[Lldb-commits] [PATCH] D33426: Introduce new command: thread backtrace unique

bgianfo added a comment. Can someone commit this as I obviously don't have a svn commit bit? https://reviews.llvm.org/D33426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D33426: Introduce new command: thread backtrace unique

bgianfo updated this revision to Diff 101664. bgianfo added a comment. Update test to user thread.StepOut() instead of thread.Resume(). https://reviews.llvm.org/D33426 Files: include/lldb/Core/Debugger.h include/lldb/Target/StackFrame.h include/lldb/Target/StackFrameList.h include/lldb/

[Lldb-commits] [PATCH] D33426: Introduce new command: thread backtrace unique

bgianfo added a comment. @jingham @labath do you have any more feedback? https://reviews.llvm.org/D33426 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D33426: Introduce new command: thread backtrace unique

bgianfo updated this revision to Diff 100830. bgianfo added a comment. Fix bug in "unique" backtrace output that Greg pointed out. Introduced a new format for unique frames and plumbed that through the stacks to be able to toggle between them both depending on the calling arguments. https://rev

[Lldb-commits] [PATCH] D33426: Introduce new command: thread backtrace unique

bgianfo updated this revision to Diff 100529. bgianfo marked 7 inline comments as done. bgianfo added a comment. Address Pavel and Greg's feedback on Diff 100365. Pavel: I took your suggestions to make the test case more readable, I really appreciate the guidance. I did have to tweak some of the

[Lldb-commits] [PATCH] D33426: Introduce new command: thread backtrace unique

bgianfo updated this revision to Diff 100365. bgianfo added a comment. Address Pavel's feedback, made the unit test more robust. This update increases the robustness of the new test I added. We ensure synchronization, and force the threads into the state we want them to be in by manually stepping

[Lldb-commits] [PATCH] D33426: Introduce new command: thread backtrace unique

bgianfo updated this revision to Diff 100047. bgianfo marked an inline comment as done. bgianfo added a comment. Address Pavel/Jim/Greg's feedback with the addition of a new test. I followed Jim's advice and extended the existing num_threads suite so that we start more thread3's. The new test_uni

[Lldb-commits] [PATCH] D33426: Introduce new command: thread unique-stacks

bgianfo updated this revision to Diff 99844. bgianfo marked 3 inline comments as done. bgianfo added a comment. This iteration addresses Jim's feedback. I've updated all of the code to match the surrounding style where I missed it originally. (branches/variable names) I also moved the command un

[Lldb-commits] [PATCH] D33426: Introduce new command: thread unique-stacks

bgianfo created this revision. This patch introduces a new thread command "unique-stacks". The command is based off of "thread backtrace all" but will instead find all threads which share matching call stacks and de-duplicate their output, listing call stack and all the threads which share it. Thi

[Lldb-commits] [PATCH] D33347: Fix incorrect Status -> Error rename in IOHandler

bgianfo updated this revision to Diff 99525. bgianfo added a comment. Fixing source path https://reviews.llvm.org/D33347 Files: lldb/trunk/source/Core/IOHandler.cpp Index: lldb/trunk/source/Core/IOHandler.cpp === --- lldb/trunk

[Lldb-commits] [PATCH] D33347: Fix incorrect Status -> Error rename in IOHandler

bgianfo created this revision. Change 302872 was a massive rename of the Error class to Status. The change included an incorrect rename of the "Status" window in the LLDB GUI from "Status to "Error". This patch undoes this incorrect rename and restores the status window's correct name. Reposit