[Lldb-commits] [PATCH] D47929: Add modulemap to lldb include directory

bruno added a comment. Very nice! > I generated a report for the remaining cyclic dependencies in the `lldb` > module here . Do you plan to fix headers at some point to break out the dependencies? Comment at: incl

[Lldb-commits] [PATCH] D47929: Add modulemap to lldb include directory

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D47929 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding a current working directory in a VFS mapping.

bruno added a comment. >> It seems conceptually a little strange to have the working directory be part >> of a serialized "FS", as it's fundamentally a property of a process and only >> transiently a property of the VFS. I tend to agree with @sammccall, it's odd that something that's usually

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory.

bruno accepted this revision. bruno added a comment. This approach looks overall much better! Unless @sammccall has any extra comments, it LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65677/new/ https://reviews.llvm.org/D65677 ___ l