[Lldb-commits] Inconsistency in cmakefile vs code

2019-07-10 Thread Carlo Kok via lldb-commits
In: lldb\source\Plugins\Process\Windows\Common\CMakeLists.txt these files are built based on the SYSTEM Architecture: if(CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64|AMD64") target_sources(lldbPluginProcessWindowsCommon PRIVATE x64/RegisterContextWindows_x64.cpp) elseif(CMAKE_SYSTEM_PROCESSOR MA

Re: [Lldb-commits] [lldb] r365295 - Change LaunchThread interface to return an Expected for non-Apple-non-Windows

2019-07-08 Thread Carlo Kok via lldb-commits
This looks to be broken on Windows: SeverityCodeDescription Project FileLineSuppression State Error C2555 'lldb_private::HostProcessWindows::StartMonitoring': overriding virtual function return type differs and is not covariant from 'lldb_private::HostNativeProcessB

Re: [Lldb-commits] [PATCH] D25681: [PseudoTerminal] Fix PseudoTerminal MSVC release crash

2016-10-18 Thread Carlo Kok via lldb-commits
fwiw this looks good to me, a much better fix than I had. but it'z zturner who objected to my approach. On 2016-10-17 17:51, Rudy Pons via lldb-commits wrote: Ilod created this revision. Ilod added reviewers: zturner, carlokok. Ilod added a subscriber: lldb-commits. Since r278177, the Posix fu

[Lldb-commits] [PATCH] D24960: Remove unreachable from apis in posix terminal compat windows and return 0

2016-09-27 Thread Carlo Kok via lldb-commits
carlokok created this revision. carlokok added a subscriber: LLDB. carlokok set the repository for this revision to rL LLVM. carlokok added a project: LLDB. These apis are called by lldb process launching but the unreachable causes them to fail on Windows. However, they don't have to do anything

[Lldb-commits] [lldb] r271876 - (Minor tweak) Make RegisterContextWindows_x86/x64::GetRegisterInfoAtIndex

2016-06-06 Thread Carlo Kok via lldb-commits
Author: carlokok Date: Mon Jun 6 04:40:27 2016 New Revision: 271876 URL: http://llvm.org/viewvc/llvm-project?rev=271876&view=rev Log: (Minor tweak) Make RegisterContextWindows_x86/x64::GetRegisterInfoAtIndex return NULL for an invalid register. The unwind logic asks for the "return address regi