charles-zablit wrote:
> LLDB reviewer here, I am not very familiar with Python typing but -
>
> > We from **future** import annotations at the start of cindex.py which lets
> > us use the PEP 585 features (among others) even in Pyhon 3.8.
>
> Can we do this in the lldb file as well? When the m
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/156868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit edited
https://github.com/llvm/llvm-project/pull/156868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/156868
>From 54f31b5cc3ec31e53e457c1879887f54ff14f14e Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 5 Sep 2025 12:01:56 +0100
Subject: [PATCH] [lldb] fix Python 3.9+ specific typing annotations
---
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/156868
>From 46503ba1ddcaae5ad7cfd283111e8e586da0855a Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Thu, 4 Sep 2025 14:18:02 +0100
Subject: [PATCH] [lldb] remove Python 3.9 specific typing annotations
---
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/156868
>From 0e9fdefffde7c679873b0907147bb153763f4ea1 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Thu, 4 Sep 2025 14:18:02 +0100
Subject: [PATCH] [lldb] remove Python 3.9 specific typing annotations
---
https://github.com/charles-zablit edited
https://github.com/llvm/llvm-project/pull/156868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit edited
https://github.com/llvm/llvm-project/pull/156868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit edited
https://github.com/llvm/llvm-project/pull/156868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
charles-zablit wrote:
Thanks for the feedback, I have made sure to keep the changes to a minimum in
the new revision.
https://github.com/llvm/llvm-project/pull/156868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/156868
This patch replaces any occurence of lower case generic type hints with its
`typing` implementation, i.e `list[str]` becomes `List[str]`.
[Type hinting generic in the standard collection were introduced
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/156474
In https://github.com/llvm/llvm-project/pull/150213 we made use of the Event
Viewer on Windows (equivalent of system logging on Darwin) rather than piping
to the standard output. This turned out to be to
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/156469
This is a relanding of https://github.com/llvm/llvm-project/pull/149493. The
tests were failing because we were interpreting a proper file descriptor as a
console file descriptor.
This patch uses the W
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/156474
>From ec308302c936c8ce4993ae27f8d5e813e4ac59c9 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Tue, 2 Sep 2025 16:13:17 +0100
Subject: [PATCH 1/2] [lldb][windows] use OutputDebugStringA instead of
Re
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/156469
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/156474
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -308,52 +306,24 @@ Environment Host::GetEnvironment() {
return env;
}
-/// Manages the lifecycle of a Windows Event's Source.
-/// The destructor will call DeregisterEventSource.
-/// This class is meant to be used with \ref llvm::ManagedStatic.
-class WindowsEventLog {
-
charles-zablit wrote:
Should this check also be added to the implementations of
GetSDKPathFromDebugInfo? They also loop over the compile units and some callers
[assume the resolved sdk won't be
empty](https://github.com/swiftlang/llvm-project/blob/f55dc0824ebcf546b1d34a5102021c15101e4d3b/lldb/
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/154396
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/154424
>From 5c7c53e53d179e7e002cbe958c12aef453afa6da Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Tue, 19 Aug 2025 22:22:38 +0100
Subject: [PATCH 1/3] [lldb][windows] remove duplicate implementation of
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/154424
>From 5c7c53e53d179e7e002cbe958c12aef453afa6da Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Tue, 19 Aug 2025 22:22:38 +0100
Subject: [PATCH 1/2] [lldb][windows] remove duplicate implementation of
charles-zablit wrote:
The `lldb-api` tests on the Swift Windows CI fail when the Python we use to
build is not the same as the one installed on the system, as can be seen on
[this
run](https://ci-external.swift.org/job/swift-PR-windows/44473/consoleText).
https://github.com/llvm/llvm-project/
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/149493
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit approved this pull request.
https://github.com/llvm/llvm-project/pull/152483
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit approved this pull request.
https://github.com/llvm/llvm-project/pull/152134
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -6,6 +6,8 @@
//
//===--===//
+#include "Plugins/Language/CPlusPlus/CPlusPlusLanguage.h"
+#include "Plugins/Language/CPlusPlus/CPlusPlusNameParser.h"
charles-zablit wrote:
I think this inc
https://github.com/charles-zablit requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/152134
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/150999
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -92,6 +92,10 @@ void TrackingOutputBuffer::finalizeStart() {
if (NameInfo.BasenameRange.second == 0)
NameInfo.BasenameRange.second = getCurrentPosition();
+ if (NameInfo.BasenameRange.second != NameInfo.ArgumentsRange.first)
+NameInfo.TemplateArgumentsRange = {Na
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/150999
>From 9b3551c6dbf8629c49f2bf3ed3f34e7b4e52e65f Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Mon, 28 Jul 2025 18:58:44 +0200
Subject: [PATCH 1/6] [lldb] add TemplateRange and NameQualifiersRange to
@@ -92,6 +92,10 @@ void TrackingOutputBuffer::finalizeStart() {
if (NameInfo.BasenameRange.second == 0)
NameInfo.BasenameRange.second = getCurrentPosition();
+ if (NameInfo.BasenameRange.second != NameInfo.ArgumentsRange.first)
+NameInfo.TemplateArgumentsRange = {Na
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/149493
>From 77bf2b7acb82ea930702c8b0587c019fd48dc0f2 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 18 Jul 2025 12:29:31 +0200
Subject: [PATCH 1/8] [windows][lldb] force the console to use a UTF-8 cod
@@ -92,6 +92,10 @@ void TrackingOutputBuffer::finalizeStart() {
if (NameInfo.BasenameRange.second == 0)
NameInfo.BasenameRange.second = getCurrentPosition();
+ if (NameInfo.BasenameRange.second != NameInfo.ArgumentsRange.first)
+NameInfo.TemplateArgumentsRange = {Na
@@ -92,6 +92,10 @@ void TrackingOutputBuffer::finalizeStart() {
if (NameInfo.BasenameRange.second == 0)
NameInfo.BasenameRange.second = getCurrentPosition();
+ if (NameInfo.BasenameRange.second != NameInfo.ArgumentsRange.first)
+NameInfo.TemplateArgumentsRange = {Na
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/151535
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit edited
https://github.com/llvm/llvm-project/pull/149493
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/151535
This is a re-landing of https://github.com/llvm/llvm-project/pull/144913, which
was reverted because of tests failing on Darwin.
The bots were failing because the x64 bots run the macOS 14.0 SDKs whereas
@@ -853,4 +853,6 @@ raw_ostream &operator<<(raw_ostream &OS, const
std::optional &O) {
} // end namespace llvm
+bool write_console_impl(int FD, llvm::StringRef Data);
charles-zablit wrote:
Fixed by using an instance of `raw_fd_ostream` instead.
https://git
@@ -853,4 +853,6 @@ raw_ostream &operator<<(raw_ostream &OS, const
std::optional &O) {
} // end namespace llvm
+bool write_console_impl(int FD, llvm::StringRef Data);
charles-zablit wrote:
Using an instance of `raw_fd_ostream` works. Thanks!
https://github
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/149493
>From 77bf2b7acb82ea930702c8b0587c019fd48dc0f2 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 18 Jul 2025 12:29:31 +0200
Subject: [PATCH 1/7] [windows][lldb] force the console to use a UTF-8 cod
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/150213
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/150999
>From 9b3551c6dbf8629c49f2bf3ed3f34e7b4e52e65f Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Mon, 28 Jul 2025 18:58:44 +0200
Subject: [PATCH 1/5] [lldb] add TemplateRange and NameQualifiersRange to
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/147768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
charles-zablit wrote:
Hi @Nerixyz, is there anything else I can add to this patch to get it merged?
https://github.com/llvm/llvm-project/pull/149493
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/150999
>From 9b3551c6dbf8629c49f2bf3ed3f34e7b4e52e65f Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Mon, 28 Jul 2025 18:58:44 +0200
Subject: [PATCH 1/4] [lldb] add TemplateRange and NameQualifiersRange to
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/150999
>From 9b3551c6dbf8629c49f2bf3ed3f34e7b4e52e65f Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Mon, 28 Jul 2025 18:58:44 +0200
Subject: [PATCH 1/3] [lldb] add TemplateRange and NameQualifiersRange to
@@ -435,142 +435,202 @@ struct DemanglingPartsTestCase {
DemanglingPartsTestCase g_demangling_parts_test_cases[] = {
// clang-format off
{
"_ZNVKO3BarIN2ns3QuxIiEEE1CIPFi3FooIS_IiES6_EEE6methodIS6_EENS5_IT_SC_E5InnerIiEESD_SD_",
- { /*.BasenameRange=*/{92, 98}, /*.S
@@ -89,6 +89,8 @@ A complete list of currently supported format string
variables is listed below:
+---+---
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/150999
>From 9b3551c6dbf8629c49f2bf3ed3f34e7b4e52e65f Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Mon, 28 Jul 2025 18:58:44 +0200
Subject: [PATCH 1/2] [lldb] add TemplateRange and NameQualifiersRange to
@@ -30,6 +30,16 @@ struct DemangledNameInfo {
/// \endcode
std::pair BasenameRange;
+ /// A [start, end) pair for the function template arguments.
+ /// The basename is the name without scope qualifiers
+ /// and without template parameters. E.g.,
+ /// \code{.cpp}
+
@@ -247,6 +248,28 @@ uint32_t File::GetPermissions(Status &error) const {
return file_stats.st_mode & (S_IRWXU | S_IRWXG | S_IRWXO);
}
+NativeFile::NativeFile()
+: m_descriptor(kInvalidDescriptor), m_stream(kInvalidStream) {}
charles-zablit wrote:
Fixed
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/149493
>From 77bf2b7acb82ea930702c8b0587c019fd48dc0f2 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 18 Jul 2025 12:29:31 +0200
Subject: [PATCH 1/6] [windows][lldb] force the console to use a UTF-8 cod
charles-zablit wrote:
> > I can't find where a `Stream` actually gets "printed" to the stdout.
>
> A `NativeFile` stream is used, which is created
> [here](https://github.com/llvm/llvm-project/blob/a676ecd83fad9b04d315c4e667742d25679cbc9f/lldb/source/Core/Debugger.cpp#L967-L970).
>
> > [2b8c69
@@ -109,6 +109,10 @@ class Host {
/// Emit the given message to the operating system log.
static void SystemLog(lldb::Severity severity, llvm::StringRef message);
+ /// Emit the given message to the stdout or stderr depending on severity.
+ static void SystemLogFallback(
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/150213
>From 7a96f44bd01d5a66f18af43d98f4b1ab8776a203 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 23 Jul 2025 12:43:38 +0100
Subject: [PATCH 1/2] [windows][lldb] implement system logging on Windows
charles-zablit wrote:
This is what it looks like for Swift:
https://github.com/user-attachments/assets/fffb34e4-b5e3-423c-9008-a5bcb10090c1";
/>
https://github.com/llvm/llvm-project/pull/150213
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/150213
This patch makes LLDB use the Event Viewer on Windows (equivalent of system
logging on Darwin) rather than piping to the standard output (which was
deactivated in ca0a5247004b6d692978d10bdbf86e338133e60c
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/149482
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
charles-zablit wrote:
> As far as I know, `WriteConsoleW` is the proper way to get Unicode on the
> console (this resolved #35615). However, that would require a new output,
> because currently, everything goes through the stdout FD and the C API.
Thanks for clarifying, I corrected the 4th opt
charles-zablit wrote:
I added `add_compile_options(/execution-charset:utf-8)` to
`llvm-project\lldb\CMakeLists.txt` however that did not fix the issue.
https://github.com/llvm/llvm-project/pull/149493
___
lldb-commits mailing list
lldb-commits@lists.l
charles-zablit wrote:
>From my understanding of the thread you linked, there are 3 ways to approach
>this:
1. Switch to ASCII characters on Windows instead of the `"╰"` character. This
is by far the easiest way to fix this specific rendering issue, but does not
address the root issue. Debuggi
charles-zablit wrote:
> Windows Terminal is the default on Windows 10 at least. I think buildbot
> launches things in conhost, but if utf-8 there was a problem for tests, we
> would have seen it before now.
I was able to reproduce this with the latest release of lldb in the Windows 11
termina
charles-zablit wrote:
> I opened an issue for this #142568.
>
> Where @Nerixyz mentions that SetConsoleOutputCP might have problems in
> cmd.exe (which probably means conhost, the original windows terminal host, as
> opposed to "windows terminal", the new one).
>From my understanding, the [or
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/149493
>From 77bf2b7acb82ea930702c8b0587c019fd48dc0f2 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 18 Jul 2025 12:29:31 +0200
Subject: [PATCH 1/2] [windows][lldb] force the console to use a UTF-8 cod
charles-zablit wrote:
# Before
https://github.com/user-attachments/assets/9b753728-5de8-4a12-9192-e0b53982bc3c";
/>
# After
https://github.com/user-attachments/assets/4d85e6dc-25d3-4fc4-b1cd-865831c46321";
/>
https://github.com/llvm/llvm-project/pull/149493
_
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/149493
This patch sets the codepage of the parent Windows console to `utf-8` and
resets it back to the original codepage once `lldb` exits.
This fixes a rendering issue where the characters defined in
`Diagnos
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/149482
Formatting patch which removes an extra line after a docstring.
>From 121daca4acec6dbcda8658db526aac86d3c3d5fb Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 18 Jul 2025 11:07:50 +0200
Subject:
https://github.com/charles-zablit approved this pull request.
https://github.com/llvm/llvm-project/pull/148235
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
charles-zablit wrote:
Is it a reasonable use case to want to not print anything? If not, then I think
this is a valid way of deactivating the plugin formatting.
https://github.com/llvm/llvm-project/pull/148235
___
lldb-commits mailing list
lldb-commit
https://github.com/charles-zablit edited
https://github.com/llvm/llvm-project/pull/147768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
charles-zablit wrote:
Deactivating these tests allows the CI to pass on the Apple bots:
https://github.com/swiftlang/llvm-project/pull/10971
https://github.com/llvm/llvm-project/pull/147768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/147768
https://github.com/llvm/llvm-project/pull/144913 was reverted because some of
the Darwin tests were failing on SDKs prior to `15.0`. This config is not
supported (having a version of lldb which is more r
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/146903
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/146903
Fix an error message which incorrectly says that we failed to handle a
`basename`. It should say `formatted-arguments` instead.
>From 0be82628756ca149de165452ba2d28d83c24b0f9 Mon Sep 17 00:00:00 2001
Fro
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/146062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/146062
>From b7700480aa7150237f73aa37b0cf39f592ac512d Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 27 Jun 2025 12:49:53 +0100
Subject: [PATCH 1/7] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in on
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/146062
>From b7700480aa7150237f73aa37b0cf39f592ac512d Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 27 Jun 2025 12:49:53 +0100
Subject: [PATCH 1/6] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in on
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/146062
>From 6ce75177264d47ffedbf0e6ee44831eac1d3ea55 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 27 Jun 2025 12:49:53 +0100
Subject: [PATCH 1/6] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in on
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/146062
>From 6ce75177264d47ffedbf0e6ee44831eac1d3ea55 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 27 Jun 2025 12:49:53 +0100
Subject: [PATCH 1/5] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in on
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/146062
>From 6ce75177264d47ffedbf0e6ee44831eac1d3ea55 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 27 Jun 2025 12:49:53 +0100
Subject: [PATCH 1/4] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in on
@@ -1128,17 +1128,8 @@ void
PlatformDarwin::AddClangModuleCompilationOptionsForSDKType(
FileSpec sysroot_spec;
- if (target) {
-if (ModuleSP exe_module_sp = target->GetExecutableModule()) {
- auto path_or_err = ResolveSDKPathFromDebugInfo(*exe_module_sp);
-
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/146062
>From 6ce75177264d47ffedbf0e6ee44831eac1d3ea55 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 27 Jun 2025 12:49:53 +0100
Subject: [PATCH 1/3] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in on
@@ -1130,13 +1130,33 @@ void
PlatformDarwin::AddClangModuleCompilationOptionsForSDKType(
if (target) {
if (ModuleSP exe_module_sp = target->GetExecutableModule()) {
- auto path_or_err = ResolveSDKPathFromDebugInfo(*exe_module_sp);
- if (path_or_err) {
-
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/146062
>From 6ce75177264d47ffedbf0e6ee44831eac1d3ea55 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Fri, 27 Jun 2025 12:49:53 +0100
Subject: [PATCH 1/2] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in on
https://github.com/charles-zablit edited
https://github.com/llvm/llvm-project/pull/146062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/146062
This patch is part of an effort to remove the ResolveSDKPathFromDebugInfo
method, and more specifically the variant which takes a Module as argument.
This PR should be merged after https://github.com/llv
charles-zablit wrote:
> Looks like this does break all the modules tests:
> https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/as-lldb-cmake/28395/execution/node/106/log/
> ...
> Could we revert for now to unblock bots?
Just opened a revert PR for this commit and a child commit.
https://
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/145864
Revert the changes made in the following PRs as they are causing bot failures:
- https://github.com/llvm/llvm-project/pull/145744
- https://github.com/llvm/llvm-project/pull/144913
>From a540d68b0a882f0f
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/145744
This patch is part of an effort to remove the `ResolveSDKPathFromDebugInfo`
method, and more specifically the variant which takes a `Module` as argument.
This PR should be merged after https://github.com
charles-zablit wrote:
Confirmed that this builds fine with the changes 👍
https://github.com/llvm/llvm-project/pull/145606
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/145744
>From e28a9e6249077c9ffca878cbf4c933b6f4f9eab8 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Thu, 19 Jun 2025 16:17:33 +0100
Subject: [PATCH 1/4] [lldb][darwin] force BuiltinHeadersInSystemModules t
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/145606
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
charles-zablit wrote:
@andrurogerz do you need us to merge this for you?
https://github.com/llvm/llvm-project/pull/145606
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1130,14 +1130,33 @@ void
PlatformDarwin::AddClangModuleCompilationOptionsForSDKType(
if (target) {
if (ModuleSP exe_module_sp = target->GetExecutableModule()) {
- auto path_or_err = ResolveSDKPathFromDebugInfo(*exe_module_sp);
- if (path_or_err) {
-
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/145744
>From e28a9e6249077c9ffca878cbf4c933b6f4f9eab8 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Thu, 19 Jun 2025 16:17:33 +0100
Subject: [PATCH 1/5] [lldb][darwin] force BuiltinHeadersInSystemModules t
https://github.com/charles-zablit approved this pull request.
https://github.com/llvm/llvm-project/pull/145606
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/144913
>From e28a9e6249077c9ffca878cbf4c933b6f4f9eab8 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Thu, 19 Jun 2025 16:17:33 +0100
Subject: [PATCH 1/2] [lldb][darwin] force BuiltinHeadersInSystemModules t
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/144731
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -74,24 +74,48 @@ struct DemangledNameInfo {
return BasenameRange.second > BasenameRange.first;
}
+ /// Returns \c true if `BasenameRange` is empty.
+ bool isBasenameEmpty() const {
+return BasenameRange.first == BasenameRange.second;
charles-zab
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/144731
>From 3c9a3e5e9af0c9d58783c11490bda473ada84ef3 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 18 Jun 2025 16:41:40 +0100
Subject: [PATCH 01/13] [lldb] upgrade HandleFrameFormatVariable callees t
1 - 100 of 192 matches
Mail list logo
