[Lldb-commits] [PATCH] D104819: [ADT] Rename StringRef case insensitive methods for clarity

lattner accepted this revision. lattner added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104819/new/ https://reviews.llvm.org/D104819 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D107528: [llvm][clang][NFC] updates inline licence info

lattner accepted this revision. lattner added a comment. Thank you for catching this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107528/new/ https://reviews.llvm.org/D107528 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D131919: Move googletest to the third-party directory

lattner accepted this revision. lattner added a comment. This revision is now accepted and ready to land. I didn't review the patch in detail, but +1 this is a great step forward to reorganize the repo! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D123957: Update the developer policy to mention release notes

lattner added a comment. This is awesome, I agree completely we should curate release notes better. That said, I think this should make it more clear that there is a "difference in kind" between user-facing tools like clang/lldb etc and other libraries in LLVM. We don't want release note burd

[Lldb-commits] [PATCH] D123957: Update the developer policy to mention release notes

lattner added a comment. Also, when this lands, we should post on the forum about it. Every change to the developer policy warrants broader visibility than just a phab discussion IMO. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957

[Lldb-commits] [PATCH] D123957: Update the developer policy to mention release notes

lattner accepted this revision. lattner added a comment. Nice, LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [PATCH] D109483: [APInt] Normalize naming on keep constructors / predicate methods.

lattner added a comment. This patch has a lot of noise, the important part is APInt.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109483/new/ https://reviews.llvm.org/D109483 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D109483: [APInt] Normalize naming on keep constructors / predicate methods.

lattner marked an inline comment as done. lattner added inline comments. Comment at: llvm/include/llvm/ADT/APInt.h:384 /// value for the APInt's bit width. bool isMaxValue() const { return isAllOnesValue(); } craig.topper wrote: > isAllOnes()? Yep, good c

[Lldb-commits] [PATCH] D109483: [APInt] Normalize naming on keep constructors / predicate methods.

lattner added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:3243 "Don't know how to expand this subtraction!"); -Tmp1 = DAG.getNode(ISD::XOR, dl, VT, Node->getOperand(1), - DAG.getConstant(APInt::getAllOnesValue(VT.getSiz

[Lldb-commits] [PATCH] D109483: [APInt] Normalize naming on keep constructors / predicate methods.

lattner added a comment. Thank you for the detailed review Craig! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109483/new/ https://reviews.llvm.org/D109483 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D109483: [APInt] Normalize naming on keep constructors / predicate methods.

lattner added a comment. I'll take care of the DAG.getAllOnesConstant change, but i'd appreciate it if you could look at the NOT cases. Running tests on the DAG.getAllOnesConstant patch now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109483/ne

[Lldb-commits] [PATCH] D109483: [APInt] Normalize naming on keep constructors / predicate methods.

lattner added a comment. > What is a "keep constructor"? Good question, I'm not sure. I think I meant to say "key constructors". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109483/new/ https://reviews.llvm.org/D109483 _

[Lldb-commits] [PATCH] D110496: [llvm] [ADT] Add a range/iterator-based split()

lattner accepted this revision. lattner added a comment. This revision is now accepted and ready to land. This is really nice! Please fix the clang-tidy casing issues, but otherwise LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110496/new/ https://reviews.llvm.org/D110496 _

[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

lattner added a comment. Do you have commit access? If not, please read the llvm developer policy and follow the instructions, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110535/new/ https://reviews.llvm.org/D110535 ___ lldb-commi