[Lldb-commits] [PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. In D126694#4470358 , @iains wrote: > In D126694#4470297 , @ChuanqiXu > wrote: > >>> Yes, that was the decision at the last time we looked - because removing >>> decls would degrade

[Lldb-commits] [PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. > Yes, that was the decision at the last time we looked - because removing > decls would degrade this - if we have new information that changes our > preferred design, then fine. I remember the major reason for the last time to not remove the decls are that the

[Lldb-commits] [PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. > That is clearly a big motivation - I will ask the folks we were talking to at > WG21 if that is their priority - or maybe they care about language isolation > etc. Yeah, I know the folks in WG21 prefer the language isolation. But you know, there are many folks who

[Lldb-commits] [PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. BTW, in my experience for talking about modules to users, they mainly/mostly care about the compilation performance. And I can't image how many people would like to use modules if they know they won't get a compilation performance win. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. In D126694#4470235 , @iains wrote: > In D126694#4470139 , @ChuanqiXu > wrote: > >> Now I think the feature may be important for the performance of modules. And >> I feel we should

[Lldb-commits] [PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. Now I think the feature may be important for the performance of modules. And I feel we should work on the ASTWriter side instead of ASTReader side. Since the size of BMIs is a problem now also it shows that it is not free to load the large BMIs. So while it is

[Lldb-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137724/new/ https://reviews.llvm.org/D137724 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. I haven't looked into the details. But I feel the feature worth a sentence in ReleaseNotes. (Maybe in the potential-breaking-change section). Also I think it'll be better to have an option `-fenable-discarding-unreachable-decls-in-gmf` to control the behavior. It'll

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. The codes look good and also the tests pass. So LGTM. Thanks! Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:1082-1094 +auto merge = [this, , FD](auto &) { + auto *Existing =

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

ChuanqiXu added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:623-626 + VisitDeclaratorDecl(D); + Record.AddDeclarationNameLoc(D->DNLoc, D->getDeclName()); + Record.push_back(D->getIdentifierNamespace()); + mizvekov wrote: > ChuanqiXu

[Lldb-commits] [PATCH] D132735: [LLDB] Recognize `std::noop_coroutine()` in `std::coroutine_handle` pretty printer

ChuanqiXu added a comment. The summary looks good to me. Comment at: lldb/source/Plugins/Language/CPlusPlus/Coroutines.cpp:70 + +static bool IsNoopResumeDestroy(Function *f) { + if (!f) Maybe `IsNoopCoro` or something else looks better? Repository: rG

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

ChuanqiXu added a comment. In D132624#3754299 , @avogelsgesang wrote: > @labath D132815 addresses your point: With > that change, the `promise` member now is typed as a pointer. > > I would prefer to land the patches

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

ChuanqiXu added a comment. In D132624#3748434 , @avogelsgesang wrote: >> The only concern is that if it would be not so easy to read if there are too >> many levels? (Consider the 30levels example in D132451 >> ). If

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

ChuanqiXu added a comment. The only concern is that if it would be not so easy to read if there is too many levels? (Consider the 30levels example in D132451 ). If it would be better to print `...` at certain level? Or this is already handled by lldb?

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

ChuanqiXu added a comment. LGTM basically. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132624/new/ https://reviews.llvm.org/D132624 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

ChuanqiXu added a reviewer: dblaikie. ChuanqiXu added a comment. LGTM. But I am not familiar with debugger internals. So I'll leave the formal acceptance for other reviewers. Comment at: lldb/source/Plugins/Language/CPlusPlus/Coroutines.cpp:138 +} \ No newline at end of file

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

ChuanqiXu added a comment. In D130689#3684333 , @thieta wrote: > In D130689#3684330 , @mehdi_amini > wrote: > >> What does it mean exactly? We can't use **anything** C++17 without writing >> it in the coding

[Lldb-commits] [PATCH] D120319: Set error message if ValueObjectRegister fails to write back to register

ChuanqiXu added a comment. In D120319#3348268 , @ilya-nozhkin wrote: > In D120319#3348267 , @ChuanqiXu > wrote: > >> What's your name and email address for this patch? > > Ilya Nozhkin > nozhkin...@gmail.com

[Lldb-commits] [PATCH] D120319: Set error message if ValueObjectRegister fails to write back to register

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd37d489cfef: Set error message if ValueObjectRegister fails to write back to register (authored by ilya-nozhkin, committed by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D120319: Set error message if ValueObjectRegister fails to write back to register

ChuanqiXu added a comment. In D120319#3348265 , @ilya-nozhkin wrote: > Could someone, please, commit these changes to the main repository? I still > don't have commit access. I'll apply for it right after merging these changes > (LLVM Developer Policy

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu added a comment. It looks like @asl isn't here and many experienced guys accepted this. So I think it might should be good to commit this one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbbce75e352be: Update Bug report URL to Github Issues (authored by

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu updated this revision to Diff 397763. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 Files: clang-tools-extra/docs/clang-doc.rst clang/docs/CommandGuide/clang.rst

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu added a comment. @asl hi, do you feel good with this revision? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu updated this revision to Diff 396737. ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. Drop the change in lld. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 Files: clang-tools-extra/docs/clang-doc.rst

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu added inline comments. Comment at: llvm/utils/gn/secondary/clang/include/clang/Config/BUILD.gn:10 output = "$target_gen_dir/config.h" values = [ +"BUG_REPORT_URL=https://github.com/llvm/llvm-project/issues/;, xbolva00 wrote: > This url should

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu marked an inline comment as done. ChuanqiXu added inline comments. Comment at: llvm/docs/CommandGuide/llvm-objcopy.rst:539 -To report bugs, please visit . +To report bugs, please visit .

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu marked 14 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/www/c_status.html:75-76 -The https://bugs.llvm.org/;>LLVM bug tracker contains a -Clang C component that tracks known bugs with Clang's language +The

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu updated this revision to Diff 396627. ChuanqiXu marked 2 inline comments as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 Files: clang-tools-extra/docs/clang-doc.rst

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu updated this revision to Diff 396589. ChuanqiXu marked 2 inline comments as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 Files: clang-tools-extra/docs/clang-doc.rst

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu marked 7 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/www/c_status.html:76 +The https://bugs.llvm.org/;>LLVM bug tracker and +https://github.com/llvm/llvm-project/issues/;>LLVM Issues contain +a Clang C component that tracks known bugs

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu updated this revision to Diff 396498. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 Files: clang-tools-extra/docs/clang-doc.rst clang/docs/CommandGuide/clang.rst

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu updated this revision to Diff 396509. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 Files: clang-tools-extra/docs/clang-doc.rst clang/docs/CommandGuide/clang.rst

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu created this revision. ChuanqiXu added reviewers: aaron.ballman, asl. Herald added subscribers: libcxx-commits, ormris, arphaman, mgorny. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: MaskRay. Herald added a project: libunwind. Herald added a reviewer: