DavidSpickett wrote:
ping!
https://github.com/llvm/llvm-project/pull/110104
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
> TEST 'lldb-api ::
> lang/c/shared_lib_stripped_symbols/TestSharedLibStrippedSymbols.py' FAILED
>
This test is flaky on Arm 32, I'll figure it out.
https://github.com/llvm/llvm-project/pull/104238
DavidSpickett wrote:
> TEST 'lldb-api ::
> lang/c/shared_lib_stripped_symbols/TestSharedLibStrippedSymbols.py' FAILED
There's something flaky about this test, I've seen it failing on unrelated
patches a few times. We'll look into it.
https://github.com/llvm/llvm-project
Author: David Spickett
Date: 2024-09-27T13:31:58+01:00
New Revision: f6e771cfeda5527b817c80e86d2352cf1f3e5e37
URL:
https://github.com/llvm/llvm-project/commit/f6e771cfeda5527b817c80e86d2352cf1f3e5e37
DIFF:
https://github.com/llvm/llvm-project/commit/f6e771cfeda5527b817c80e86d2352cf1f3e5e37.diff
https://github.com/DavidSpickett approved this pull request.
LGTM.
Maybe @labath would like to take a last look at it before it lands.
https://github.com/llvm/llvm-project/pull/95986
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://li
DavidSpickett wrote:
> Perhaps that's because I added those as special cases I don't remember the
> specifics.
I only added part of the description -
https://github.com/llvm/llvm-project/commit/85bc498826d4dac4b64f7b02659f6ec52f11c223.
Didn't add the fault address.
Happy to see improvements
DavidSpickett wrote:
So does this not need new testing or did you not add that yet?
I'm not clear on what fully decode means because at least for certain signals
like a tag check fault we do have a description for live processes and core
files. Perhaps that's because I added those as special c
@@ -235,6 +235,8 @@ if (CMAKE_SIZEOF_VOID_P EQUAL 8)
set(LLDB_IS_64_BITS 1)
endif()
+set(LLDB_SHELL_TESTS_DISABLE_REMOTE OFF CACHE BOOL "Disable remote Shell tests
execution")
DavidSpickett wrote:
Ok and that means you can still use a single `ninja check-l
@@ -60,7 +60,8 @@ something like ``target.BreakpointCreateByName`` [#]_.
A good rule of thumb is to prefer shell tests when what is being tested is
relatively simple. Expressivity is limited compared to the API tests, which
means that you have to have a well-defined test scenar
@@ -235,6 +235,8 @@ if (CMAKE_SIZEOF_VOID_P EQUAL 8)
set(LLDB_IS_64_BITS 1)
endif()
+set(LLDB_SHELL_TESTS_DISABLE_REMOTE OFF CACHE BOOL "Disable remote Shell tests
execution")
DavidSpickett wrote:
Remind me again what this does (probably the third time I'v
Author: David Spickett
Date: 2024-09-26T12:06:23Z
New Revision: 3eaaf7c4d062976901c79b523e9f3cc606943119
URL:
https://github.com/llvm/llvm-project/commit/3eaaf7c4d062976901c79b523e9f3cc606943119
DIFF:
https://github.com/llvm/llvm-project/commit/3eaaf7c4d062976901c79b523e9f3cc606943119.diff
LOG
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/109934
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Last one for FPMR. I'll push the release notes directly.
Thanks for reviewing!
https://github.com/llvm/llvm-project/pull/110104
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/110104
>From 58911927a59557aab167792f62f2c9ba9a86fa0d Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Thu, 29 Aug 2024 16:18:56 +0100
Subject: [PATCH 1/2] [lldb][AArch64] Read fpmr register from core files
-
@@ -61,3 +65,19 @@ def test_fpmr_register(self):
# 0 means the program found the new value in the sysreg as expected.
self.expect("continue", substrs=["exited with status = 0"])
+
+@skipIfLLVMTargetMissing("AArch64")
+def test_fpmr_register_core(self):
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/110104
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/110104
None
>From 58911927a59557aab167792f62f2c9ba9a86fa0d Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Thu, 29 Aug 2024 16:18:56 +0100
Subject: [PATCH] [lldb][AArch64] Read fpmr register from core files
DavidSpickett wrote:
Yes working to the standard is good, but in the minority of cases where you do
get a strange errno, `GDB_EUNKNOWN` is zero help and then you're working out
the `lldb-server gdbserver --log-channels` etc. command to get it to print the
real number.
So far that hasn't been
Author: David Spickett
Date: 2024-09-25T14:31:57Z
New Revision: 26e0b5077236064d9ab0548e049dffce4d476c06
URL:
https://github.com/llvm/llvm-project/commit/26e0b5077236064d9ab0548e049dffce4d476c06
DIFF:
https://github.com/llvm/llvm-project/commit/26e0b5077236064d9ab0548e049dffce4d476c06.diff
LOG
https://github.com/DavidSpickett approved this pull request.
Decide what to do with the remote test change but otherwise this LGTM.
https://github.com/llvm/llvm-project/pull/109961
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists
@@ -25,7 +25,6 @@ def setUp(self):
oslist=["windows"],
bugnumber="llvm.org/pr24527. Makefile.rules doesn't know how to build
static libs on Windows",
)
-@expectedFailureAll(remote=True)
DavidSpickett wrote:
Ok fair enough, maybe it's
@@ -25,7 +25,6 @@ def setUp(self):
oslist=["windows"],
bugnumber="llvm.org/pr24527. Makefile.rules doesn't know how to build
static libs on Windows",
)
-@expectedFailureAll(remote=True)
DavidSpickett wrote:
Just need a basic explanati
DavidSpickett wrote:
A better version of my question, do you have a list of tools this effects, is
it just the ones where you have modified lines in this PR?
If so we probably have nothing to worry about.
https://github.com/llvm/llvm-project/pull/109961
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/109961
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/109961
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -25,7 +25,6 @@ def setUp(self):
oslist=["windows"],
bugnumber="llvm.org/pr24527. Makefile.rules doesn't know how to build
static libs on Windows",
)
-@expectedFailureAll(remote=True)
DavidSpickett wrote:
And this works now because.
@@ -161,6 +165,11 @@ def getToolchainUtil(util_name):
}
utils = []
+# Required by API TestBSDArchives.py tests.
+# TODO don't forget to fix the test's Makefile when porting to mainline
DavidSpickett wrote:
TODO left in
https:/
@@ -149,9 +153,9 @@ def getToolchainSpec(self, compiler):
cc_dir = cc_path.parent
def getToolchainUtil(util_name):
-return cc_dir / (cc_prefix + util_name + cc_ext)
+return os.path.join(configuration.llvm_tools_dir, util_name +
exe_ext)
https://github.com/DavidSpickett commented:
My only question here is, is there some tool that every bot is going to have to
add an override for because it's not something in `/bin`?
If there is such a tool, that doesn't make this change bad, but we may want to
delay while that's accounted for.
DavidSpickett wrote:
Core files will be the next PR and a test will be added to ensure fields show
up when using a core file too.
https://github.com/llvm/llvm-project/pull/109934
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/109934
The FP8 formats have a "_" in the name so that they are:
1. Easier to read.
2. Possible to use in register expressions if/when they are supported.
Some other bits do have defined meanings but they are not
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/106695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
We're almost there for the save all / restore all anyway. We'll need special
cases for SME of course but SME is weird enough to justify that.
https://github.com/llvm/llvm-project/pull/106695
___
lldb-commits mailing list
lldb-comm
DavidSpickett wrote:
> There will be more features in future meaning more read/ write routines doing
> almost similar stuff.
IMO We may later consider refactoring the code to provide a top level interface
for feature registers read and write.
Yes I would like a "data driven" model for it. I go
DavidSpickett wrote:
Feels like we diverted you from your original problem though, which was the
remote taking the informative errno and changing it to some meaningless value.
If you've solved your problem then no obligation to do any more but if you do
want to look into the other reporting me
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/106950
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
LGTM
In theory we could test this but it'd be platform specific and error injection
is always tricky, the change is straightforward, so let's not worry about it.
https://github.com/llvm/llvm-project/pull/106950
__
Author: David Spickett
Date: 2024-09-25T10:08:10+01:00
New Revision: 706821ba8ff9db829252581dd12d8c5ee2e7b3f0
URL:
https://github.com/llvm/llvm-project/commit/706821ba8ff9db829252581dd12d8c5ee2e7b3f0
DIFF:
https://github.com/llvm/llvm-project/commit/706821ba8ff9db829252581dd12d8c5ee2e7b3f0.diff
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/109764
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Landing this, post commit comments welcome as usual.
https://github.com/llvm/llvm-project/pull/108365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/108365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/109427
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/109427
>From cc4032e58217a01ff414b8d03866a1631f492df8 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 20 Sep 2024 14:00:44 +0100
Subject: [PATCH 1/4] [lldb][docs] Resurrect the information on adding a ne
@@ -0,0 +1,94 @@
+# Adding Programming Language Support
+
+LLDB has been architected to make it straightforward to add support for a
+programming language. Only a small enum in core LLDB needs to be modified to
+make LLDB aware of a new programming language. Everything else can be
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/109427
>From cc4032e58217a01ff414b8d03866a1631f492df8 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 20 Sep 2024 14:00:44 +0100
Subject: [PATCH 1/3] [lldb][docs] Resurrect the information on adding a ne
@@ -0,0 +1,94 @@
+# Adding Programming Language Support
+
+LLDB has been architected to make it straightforward to add support for a
+programming language. Only a small enum in core LLDB needs to be modified to
+make LLDB aware of a new programming language. Everything else can be
DavidSpickett wrote:
> I think this page leaves a lot to be desired but it's a good start.
Given that language support runs from:
* Pretend it's C++ and hope (Rust) to -
* Have an entire llvm fork (Swift).
The documentation is never going to be great, this is true. Next time a
language is adde
@@ -0,0 +1,95 @@
+# Adding Programming Language Support
+
+LLDB has been architected to make it straightforward to add support for a
+programming language. Only a small enum in core LLDB needs to be modified to
+make LLDB aware of a new programming language. Everything else can be
@@ -0,0 +1,95 @@
+# Adding Programming Language Support
+
+LLDB has been architected to make it straightforward to add support for a
+programming language. Only a small enum in core LLDB needs to be modified to
+make LLDB aware of a new programming language. Everything else can be
@@ -0,0 +1,95 @@
+# Adding Programming Language Support
+
+LLDB has been architected to make it straightforward to add support for a
+programming language. Only a small enum in core LLDB needs to be modified to
+make LLDB aware of a new programming language. Everything else can be
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/109427
>From cc4032e58217a01ff414b8d03866a1631f492df8 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 20 Sep 2024 14:00:44 +0100
Subject: [PATCH 1/2] [lldb][docs] Resurrect the information on adding a ne
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/109643
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
Caused by https://github.com/llvm/llvm-project/pull/108504.
Thanks for the fix.
https://github.com/llvm/llvm-project/pull/109643
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/108996
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
ping!
https://github.com/llvm/llvm-project/pull/108365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
ping!
https://github.com/llvm/llvm-project/pull/106695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Mostly RST yes, but we have a few recent documents in Markdown which I enabled
support for in https://github.com/llvm/llvm-project/pull/89716.
https://github.com/llvm/llvm-project/pull/109427
___
lldb-commits mailing list
lldb-com
DavidSpickett wrote:
Output from the 2 failures:
```
FAIL: test_file_fail
(TestGDBRemotePlatformFile.TestGDBRemotePlatformFile.test_file_fail)
Test mocked failures of remote operations
--
Traceback (most recent call last)
DavidSpickett wrote:
I've reverted this
https://github.com/llvm/llvm-project/commit/1553714b0093a8ef907faf3b3145c224caa7364a.
I feel like the solution isn't that complicated but it's close to end of the
work day for me and I'd like to see the bot green again.
If you have a suggestion on how t
Author: David Spickett
Date: 2024-09-20T15:18:45+01:00
New Revision: 1553714b0093a8ef907faf3b3145c224caa7364a
URL:
https://github.com/llvm/llvm-project/commit/1553714b0093a8ef907faf3b3145c224caa7364a
DIFF:
https://github.com/llvm/llvm-project/commit/1553714b0093a8ef907faf3b3145c224caa7364a.diff
DavidSpickett wrote:
Found by @tschuett on https://github.com/llvm/llvm-project/issues/109119.
https://github.com/llvm/llvm-project/pull/109427
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/109427
This got deleted in e078c9507c3abb4d9bb2265c366b26557880a3e3, I presume
accidentally, because it didn't have a corresponding rst file for it.
So I've brought it back and converted it into Markdown. The co
DavidSpickett wrote:
This is failing on Windows because we use an error code that means there was no
error in one of the tests in `lldb/unittests/Utility/StatusTest.cpp`:
```
auto success = Status(NO_ERROR, ErrorType::eErrorTypeWin32);
EXPECT_STREQ(NULL, success.AsCString());
EXPECT_FALSE(
https://github.com/DavidSpickett approved this pull request.
Looks good to me.
https://github.com/llvm/llvm-project/pull/108996
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I've reverted this
(https://github.com/llvm/llvm-project/commit/801046e3303eed43bffebb84e9e505cc19cad5c0)
because it broke a stop hook test:
https://lab.llvm.org/buildbot/#/builders/162/builds/6735
It seems to add the stop hook but there's no output when it should have bee
Author: David Spickett
Date: 2024-09-20T09:57:07Z
New Revision: 801046e3303eed43bffebb84e9e505cc19cad5c0
URL:
https://github.com/llvm/llvm-project/commit/801046e3303eed43bffebb84e9e505cc19cad5c0
DIFF:
https://github.com/llvm/llvm-project/commit/801046e3303eed43bffebb84e9e505cc19cad5c0.diff
LOG
@@ -269,21 +274,7 @@ void
*lldb_private::python::SWIGBridge::LLDBSWIGPython_GetDynamicSetting(
}
python::PythonObject
-lldb_private::python::SWIGBridge::LLDBSwigPythonCreateScriptedStopHook(
-lldb::TargetSP target_sp, const char *python_class_name,
-const char *sessio
Author: David Spickett
Date: 2024-09-20T09:41:07Z
New Revision: 76b827bb4d5b4cc4d3229c4c6de2529e8b156810
URL:
https://github.com/llvm/llvm-project/commit/76b827bb4d5b4cc4d3229c4c6de2529e8b156810
DIFF:
https://github.com/llvm/llvm-project/commit/76b827bb4d5b4cc4d3229c4c6de2529e8b156810.diff
LOG
@@ -76,6 +76,79 @@
using namespace lldb;
using namespace lldb_private;
+namespace {
+
+struct ExecutableInstaller {
+
+ ExecutableInstaller(PlatformSP platform, ModuleSP module)
+ : m_platform{platform}, m_module{module},
+m_local_file{m_module->GetFileSpec()},
+
@@ -76,6 +76,79 @@
using namespace lldb;
using namespace lldb_private;
+namespace {
+
+struct ExecutableInstaller {
+
+ ExecutableInstaller(PlatformSP platform, ModuleSP module)
+ : m_platform{platform}, m_module{module},
+m_local_file{m_module->GetFileSpec()},
+
@@ -76,6 +76,79 @@
using namespace lldb;
using namespace lldb_private;
+namespace {
+
+struct ExecutableInstaller {
+
+ ExecutableInstaller(PlatformSP platform, ModuleSP module)
+ : m_platform{platform}, m_module{module},
+m_local_file{m_module->GetFileSpec()},
+
@@ -76,6 +76,79 @@
using namespace lldb;
using namespace lldb_private;
+namespace {
+
+struct ExecutableInstaller {
+
+ ExecutableInstaller(PlatformSP platform, ModuleSP module)
+ : m_platform{platform}, m_module{module},
+m_local_file{m_module->GetFileSpec()},
+
@@ -76,6 +76,79 @@
using namespace lldb;
using namespace lldb_private;
+namespace {
+
+struct ExecutableInstaller {
+
+ ExecutableInstaller(PlatformSP platform, ModuleSP module)
+ : m_platform{platform}, m_module{module},
+m_local_file{m_module->GetFileSpec()},
+
@@ -76,6 +76,79 @@
using namespace lldb;
using namespace lldb_private;
+namespace {
+
+struct ExecutableInstaller {
+
+ ExecutableInstaller(PlatformSP platform, ModuleSP module)
+ : m_platform{platform}, m_module{module},
+m_local_file{m_module->GetFileSpec()},
+
@@ -76,6 +76,79 @@
using namespace lldb;
using namespace lldb_private;
+namespace {
+
+struct ExecutableInstaller {
+
+ ExecutableInstaller(PlatformSP platform, ModuleSP module)
+ : m_platform{platform}, m_module{module},
+m_local_file{m_module->GetFileSpec()},
+
DavidSpickett wrote:
Reminder to update the PR description now that the large code model has been
implemented over in llvm.
https://github.com/llvm/llvm-project/pull/99336
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.or
https://github.com/DavidSpickett approved this pull request.
Assuming all read memory requests are generated from variables, this makes
sense. They wouldn't be split across regions.
https://github.com/llvm/llvm-project/pull/109057
___
lldb-commits mai
DavidSpickett wrote:
Will look at this properly tomorrow but just looking at the title, I'm
surprised that https://github.com/llvm/llvm-project/pull/88812 did not also fix
this. Perhaps putfile and install are different paths.
https://github.com/llvm/llvm-project/pull/108996
__
DavidSpickett wrote:
If folks could close any of their comments that have now been addressed, it
would be much easier to determine what is left to do.
We're going for the "most thorough review" record here :) Thanks for sticking
with it @dlav-sc .
https://github.com/llvm/llvm-project/pull/993
@@ -279,6 +279,9 @@ void IRExecutionUnit::GetRunnableInfo(Status &error,
lldb::addr_t &func_addr,
.setMCJITMemoryManager(std::make_unique(*this))
.setOptLevel(llvm::CodeGenOptLevel::Less);
+ if (triple.isRISCV64())
DavidSpickett wrote:
This shou
@@ -1011,6 +1011,135 @@ void RuntimeDyldELF::resolveBPFRelocation(const
SectionEntry &Section,
}
}
+static void applyUTypeImmRISCV(uint8_t *InstrAddr, uint32_t Imm) {
DavidSpickett wrote:
Does this still need to be done?
https://github.com/llvm/llvm-proje
@@ -0,0 +1,96 @@
+"""
+Test RISC-V expressions evaluation.
+"""
DavidSpickett wrote:
Are these tests going to be removed then?
On the grounds that existing tests in the test suite will cover these scenarios.
https://github.com/llvm/llvm-project/pull/99336
_
DavidSpickett wrote:
I've disabled this on Windows for now but please address the issue generally.
Testing memory region overlaps is tricky. I did it for memory tagging by hoping
that the kernel would allocate pages in the right order, which worked for at
least simulated systems. Pavel recentl
Author: David Spickett
Date: 2024-09-17T12:51:46Z
New Revision: ab38ec9ac312460e4f71c8ad3f50b9b5723469f6
URL:
https://github.com/llvm/llvm-project/commit/ab38ec9ac312460e4f71c8ad3f50b9b5723469f6
DIFF:
https://github.com/llvm/llvm-project/commit/ab38ec9ac312460e4f71c8ad3f50b9b5723469f6.diff
LOG
DavidSpickett wrote:
The test case is failing on Windows, for reasons not related to it being
Windows but due to data layout.
The const string is placed at the start of a region:
```
(lldb) p rawptr
(const char *) 0x7ff77fcb5000 "dead"
(lldb) memory region --all
<...>
[0x7ff77fc61000-0x
Author: David Spickett
Date: 2024-09-17T09:30:14Z
New Revision: b39a100ff4ec16f1f9cafcc48ea7fed920726650
URL:
https://github.com/llvm/llvm-project/commit/b39a100ff4ec16f1f9cafcc48ea7fed920726650
DIFF:
https://github.com/llvm/llvm-project/commit/b39a100ff4ec16f1f9cafcc48ea7fed920726650.diff
LOG
DavidSpickett wrote:
Thanks I understand now.
https://github.com/llvm/llvm-project/pull/108504
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
Still curious exactly how we end up with threads on a breakpoint that didn't
execute it -
https://github.com/llvm/llvm-project/pull/108504#issuecomment-2348626494
But aside from that this LGTM.
https://github.com/llvm/llvm-project/p
DavidSpickett wrote:
> "if a thread stops at a breakpoint site, we set the thread's stop reason to
> breakpoint-hit, even if the breakpoint hasn't been executed"
What does it look like for a thread to be stopped at a *breakpoint site* but
not to have executed the breakpoint?
Is this just a ti
DavidSpickett wrote:
>We have a similar concept in the downstream Swift fork and this has proven to
>be extremely valuable. This is especially true on macOS where system log
>messages are automatically captured as part of a sysdiagnose.
Does this mean someone has already been putting non-MacOS
DavidSpickett wrote:
> Unlike other, existing log channels, it is not exposed to users.
This is presumably because:
1. It contains very low level messages they likely won't be interested in.
2. If it weren't hidden, it would be printing into their sessions all the time.
Users can still list it,
@@ -31,6 +31,22 @@ class ProcessInstanceInfo;
class ProcessInstanceInfoMatch;
typedef std::vector ProcessInstanceInfoList;
+// Always on system log category and channel.
DavidSpickett wrote:
So is the log naming `system system` or for now is it just `system`
@@ -0,0 +1,3 @@
+RUN: %lldb -o 'log list' -o 'log disable system' 2>&1 | FileCheck %s
+CHECK-NOT: Logging categories for 'system'
+CHECK: Cannot disable internal log channel 'system'.
DavidSpickett wrote:
This is bikeshedding but perhaps:
```
`system` is an inter
DavidSpickett wrote:
The data order of SVE and Neon in this situation is probably wrong, but I'm not
aiming to address that here.
https://github.com/llvm/llvm-project/pull/108365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/108365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/108365
Fixes #107864
QEMU decided that when SVE is enabled it will only tell us about SVE registers
in the XML, and not include Neon registers. On the grounds that the Neon V
registers can be read from the bott
Author: David Spickett
Date: 2024-09-12T10:35:11Z
New Revision: adde85e7c3ade54b22c99d405fc9c3add869db0a
URL:
https://github.com/llvm/llvm-project/commit/adde85e7c3ade54b22c99d405fc9c3add869db0a
DIFF:
https://github.com/llvm/llvm-project/commit/adde85e7c3ade54b22c99d405fc9c3add869db0a.diff
LOG
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/108183
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/108226
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
> Yes I think there might be a Windows API launch flag that can let us do early
> detection of hardware breakpoints and watchpoints. But so far after lots of
> experimentation I have not been able to find the right set.
Is it possible this is a bug in Windows itself? Thoug
1 - 100 of 1078 matches
Mail list logo
