Author: fjricci
Date: Tue Sep 19 10:13:39 2017
New Revision: 313642
URL: http://llvm.org/viewvc/llvm-project?rev=313642&view=rev
Log:
Fix build of TaskPoolTest with xcodebuild
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http:/
Author: fjricci
Date: Tue Sep 19 08:38:30 2017
New Revision: 313637
URL: http://llvm.org/viewvc/llvm-project?rev=313637&view=rev
Log:
Use ThreadLauncher to launch TaskPool threads
Summary:
This allows for the stack size to be configured, which isn't
possible with std::thread. Prevents overflowing
Author: fjricci
Date: Mon Sep 18 08:43:59 2017
New Revision: 313539
URL: http://llvm.org/viewvc/llvm-project?rev=313539&view=rev
Log:
Revert "Use ThreadLauncher to launch TaskPool threads"
This reverts commit r313537 because it fails to link on linux buildbots
Modified:
lldb/trunk/source/Uti
Author: fjricci
Date: Mon Sep 18 08:18:48 2017
New Revision: 313537
URL: http://llvm.org/viewvc/llvm-project?rev=313537&view=rev
Log:
Use ThreadLauncher to launch TaskPool threads
Summary:
This allows for the stack size to be configured, which isn't
possible with std::thread. Prevents overflowing
Author: fjricci
Date: Fri May 5 12:18:08 2017
New Revision: 302260
URL: http://llvm.org/viewvc/llvm-project?rev=302260&view=rev
Log:
Add missing 'arch' key to valid qHostInfo keys
Summary:
'arch' is a valid qHostInfo key, but the unit
test for qHostInfo did not include it in the set of possible
Author: fjricci
Date: Wed May 3 10:00:04 2017
New Revision: 302027
URL: http://llvm.org/viewvc/llvm-project?rev=302027&view=rev
Log:
Don't attempt to use mpx registers on unsupported platforms
Summary:
The existing cpp-level checks using PR_MPX_ENABLE_MANAGEMENT aren't sufficient,
as this isn't
Author: fjricci
Date: Thu Oct 6 15:41:11 2016
New Revision: 283491
URL: http://llvm.org/viewvc/llvm-project?rev=283491&view=rev
Log:
Fix GetDisplayName when only a demangled name is available
Summary:
GetDisplayDemangledName will already return a ConstString() when
there is neither a mangled nam
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283491: Fix GetDisplayName when only a demangled name is
available (authored by fjricci).
Changed prior to commit:
https://reviews.llvm.org/D25201?vs=73307&id=73847#toc
Repository:
rL LLVM
https://r
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283238: Improvements to testing blacklist (authored by
fjricci).
Changed prior to commit:
https://reviews.llvm.org/D24988?vs=73363&id=73525#toc
Repository:
rL LLVM
https://reviews.llvm.org/D24988
F
Author: fjricci
Date: Tue Oct 4 13:48:00 2016
New Revision: 283238
URL: http://llvm.org/viewvc/llvm-project?rev=283238&view=rev
Log:
Improvements to testing blacklist
Summary:
This patch is necessary because individual test cases are not required
to have unique names. Therefore, test cases must
fjricci updated this revision to Diff 73363.
fjricci added a comment.
Fix typo
https://reviews.llvm.org/D24988
Files:
packages/Python/lldbsuite/test/configuration.py
packages/Python/lldbsuite/test/dotest.py
packages/Python/lldbsuite/test/dotest_args.py
packages/Python/lldbsuite/test/tes
fjricci updated this revision to Diff 73362.
fjricci added a comment.
Match against filename + test case + method name
https://reviews.llvm.org/D24988
Files:
packages/Python/lldbsuite/test/configuration.py
packages/Python/lldbsuite/test/dotest.py
packages/Python/lldbsuite/test/dotest_args
fjricci added a comment.
In https://reviews.llvm.org/D24988#559775, @tfiala wrote:
> In https://reviews.llvm.org/D24988#559314, @fjricci wrote:
>
> > For an example of something that couldn't be disabled with the original
> > implementation, consider a test like:
> >
> > `CreateDuringStepTestCas
fjricci added a comment.
For an example of something that couldn't be disabled with the original
implementation, consider a test like:
`CreateDuringStepTestCase.test_step_inst`
Disabling by method name (`test_step_inst`) would also disable
`CreateDuringInstructionStepTestCase.test_step_inst`.
fjricci added a comment.
The problem with the existing code is that file names are required to be
unique, but method names are not. So if the user wants to disable an individual
test method with a non-unique name, there is no way to do so. This patch still
allows the tests to be disabled by fil
fjricci added a comment.
Since this is strictly an improvement and simplification, and won't break
anyone's workflow because it's still a new feature, I'll plan on merging this
tomorrow unless I hear any objections.
https://reviews.llvm.org/D24988
___
fjricci created this revision.
fjricci added reviewers: zturner, labath, tfiala, jingham.
fjricci added subscribers: sas, lldb-commits.
This patch is necessary because individual test cases are not required
to have unique names. Therefore, test cases must now
be specified explicitly in the form ..
Author: fjricci
Date: Fri Sep 23 16:32:47 2016
New Revision: 282298
URL: http://llvm.org/viewvc/llvm-project?rev=282298&view=rev
Log:
Allow for tests to be disabled at runtime
Summary:
The current implementation of the test suite allows the user to run
a certain subset of tests using '-p', but do
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282298: Allow for tests to be disabled at runtime (authored
by fjricci).
Changed prior to commit:
https://reviews.llvm.org/D24629?vs=71651&id=72360#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
fjricci added a comment.
Ok. Barring objections from anyone else, I'll merge this later on today then,
with the understanding that if it causes issues like the ones you describe, it
should be reverted.
https://reviews.llvm.org/D24629
___
lldb-comm
fjricci added a comment.
In https://reviews.llvm.org/D24629#550823, @tfiala wrote:
> > > There is no reasonable thing we can base the expectation as the exact
> > > same device with a different cpu revision could support watchpoints just
> > > fine, so we could just define the list of these tes
fjricci added a comment.
I do understand the complexity problem, and it was one of my concerns with this
as well. For my cases, the complexity here is significantly less than the
alternatives, but I also do understand if you don't think that's generally true.
It probably comes down to how often
fjricci updated this revision to Diff 71651.
fjricci added a comment.
Refactor re
https://reviews.llvm.org/D24629
Files:
packages/Python/lldbsuite/test/configuration.py
packages/Python/lldbsuite/test/dotest.py
packages/Python/lldbsuite/test/dotest_args.py
packages/Python/lldbsuite/test/
fjricci added a comment.
The issue is that you can only commit a patch to xfail a test that fails when
you run the test suite on master with no local changes.
The problem is that if you run into test failures on other branches or in
unconventional configurations, there is no good way to disable
fjricci created this revision.
fjricci added reviewers: zturner, labath, tfiala.
fjricci added subscribers: lldb-commits, sas.
The current implementation of the test suite allows the user to run
a certain subset of tests using '-p', but does not allow the inverse,
where a user wants to run all but
Author: fjricci
Date: Wed Jul 20 14:37:31 2016
New Revision: 276166
URL: http://llvm.org/viewvc/llvm-project?rev=276166&view=rev
Log:
Fix typo in test runner
Modified:
lldb/trunk/packages/Python/lldbsuite/test/decorators.py
Modified: lldb/trunk/packages/Python/lldbsuite/test/decorators.py
UR
fjricci added a comment.
@clayborg: As you saw when running the test with debug info enabled, we might
end up calling the non-rewritten `putchar()`, which is due to the compiler
emitting debug symbols with the non-rewritten name. The `-g0` option is just a
workaround until we can fix that.
I s
fjricci updated this revision to Diff 63816.
fjricci marked an inline comment as done.
fjricci added a comment.
Fix const SP and update unit test
Will now only run the unit test as a dwarf test (with -g0),
but since we don't want to test the debug data anyway,
this shouldn't be an issue, and avoi
fjricci marked 3 inline comments as done.
Comment at:
packages/Python/lldbsuite/test/lang/c/symbol_rewriter/TestSymbolRewriter.py:28
@@ +27,3 @@
+# Clang does not rewrite dwarf debug info, so it must be stripped
+subprocess.check_call(['strip', '-g', exe])
+
-
fjricci created this revision.
fjricci added reviewers: clayborg, lattner.
fjricci added subscribers: sas, lldb-commits.
Herald added a subscriber: kubabrecka.
Clang supports symbol rewrites via the -frewrite-map-file flag,
this patch adds complementary functionality in lldb.
Re-written symbols a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274364: Skip TestDisassembleRawData when remote (authored by
fjricci).
Changed prior to commit:
http://reviews.llvm.org/D21906?vs=62406&id=62504#toc
Repository:
rL LLVM
http://reviews.llvm.org/D2190
Author: fjricci
Date: Fri Jul 1 11:47:44 2016
New Revision: 274364
URL: http://llvm.org/viewvc/llvm-project?rev=274364&view=rev
Log:
Skip TestDisassembleRawData when remote
Summary:
As this test will create a new target, it will cause all following tests
to fail when running in platform mode, if
fjricci created this revision.
fjricci added reviewers: clayborg, zturner, spyffe.
fjricci added a subscriber: lldb-commits.
As this test will create a new target, it will cause all following tests
to fail when running in platform mode, if the new target does not match
the existing architecture (f
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273720: Don't run TestImageListMultiArchitecture during
remote test suite (authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D21648?vs=61803&id=61831#toc
Repository:
rL LLVM
htt
Author: fjricci
Date: Fri Jun 24 15:44:23 2016
New Revision: 273720
URL: http://llvm.org/viewvc/llvm-project?rev=273720&view=rev
Log:
Don't run TestImageListMultiArchitecture during remote test suite
Reviewers: zturner, clayborg, tfiala
Subscribers: sas, lldb-commits
Differential Revision: http
fjricci updated this revision to Diff 61803.
fjricci added a comment.
This revision is now accepted and ready to land.
Skip test on remote platforms
http://reviews.llvm.org/D21648
Files:
packages/Python/lldbsuite/test/functionalities/object-file/TestImageListMultiArchitecture.py
Index:
pac
fjricci planned changes to this revision.
fjricci added a comment.
That's reasonable, will do.
http://reviews.llvm.org/D21648
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
fjricci added a comment.
I was wondering that as well. I thought there might be some value to testing
that the "disconnect->change platform->reconnect" path worked though. I have no
problem disabling if that doesn't seem useful though.
http://reviews.llvm.org/D21648
fjricci updated this revision to Diff 61717.
fjricci added a comment.
This revision is now accepted and ready to land.
Disconnect from existing platform connection to prevent extra hanging
connections
This is good practice on all debug servers, and required for debug servers which
can't handle m
fjricci planned changes to this revision.
fjricci added a comment.
This fix does not work without something along the lines of
http://reviews.llvm.org/D21649, I'll re-upload with a better fix.
http://reviews.llvm.org/D21648
___
lldb-commits mailing
fjricci abandoned this revision.
fjricci added a comment.
I don't think that we can assume that the user always wants to re-use an
existing platform, even of the same type. Probably the only way to resolve the
problem this tries to fix would be to add a command to display all connected
platform
fjricci added a comment.
Although, given your comments about the ios platforms, IsConnected() doesn't
seem like the right API to use anyway...
http://reviews.llvm.org/D21649
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llv
fjricci added a comment.
As I'm poking through the APIs, I found that platform_sp->IsConnected() will
return true even if the remote server has been killed since connecting (at
least on remote-linux with lldb-server in platform mode). Is this the expected
behavior of that set of functions?
ht
fjricci planned changes to this revision.
fjricci added a comment.
This will fail in the case where the remote-platform server dies, as lldb will
not cleanup its data structures. I'll investigate how to make sure the platform
is alive before connecting to it.
http://reviews.llvm.org/D21649
fjricci created this revision.
fjricci added reviewers: clayborg, jingham, vharron.
fjricci added subscribers: sas, lldb-commits.
When using 'platform select', re-use an existing platform
which matches the remote platform specs, rather than creating a new one.
Without this patch, repeating the fo
fjricci created this revision.
fjricci added reviewers: clayborg, tfiala, zturner.
fjricci added subscribers: lldb-commits, sas.
When running the test suite in platform mode, this test would
use 'platform select host', which would cause the rest of the suite to stop
running
in platform mode.
Ins
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273225: Fix typo in eOpenOptionDontFollowSymlinks (authored
by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D21422?vs=60937&id=61325#toc
Repository:
rL LLVM
http://reviews.llvm.org/D21
Author: fjricci
Date: Mon Jun 20 19:03:57 2016
New Revision: 273225
URL: http://llvm.org/viewvc/llvm-project?rev=273225&view=rev
Log:
Fix typo in eOpenOptionDontFollowSymlinks
Summary: Fix capitalization
Reviewers: labath, sas, clayborg
Subscribers: lldb-commits
Differential Revision: http://r
fjricci created this revision.
fjricci added reviewers: clayborg, labath.
fjricci added a subscriber: lldb-commits.
Fix capitalization
http://reviews.llvm.org/D21422
Files:
include/lldb/Host/File.h
source/Host/common/File.cpp
source/Target/Platform.cpp
Index: source/Target/Platform.cpp
==
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271899: Don't remove PIE executables when using svr4 packets
(authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D20990?vs=59637&id=59723#toc
Repository:
rL LLVM
http://reviews.l
Author: fjricci
Date: Mon Jun 6 10:00:50 2016
New Revision: 271899
URL: http://llvm.org/viewvc/llvm-project?rev=271899&view=rev
Log:
Don't remove PIE executables when using svr4 packets
Summary:
Because PIE executables have an e_type of llvm::ELF::ET_DYN,
they are not of type eTypeExecutable, an
fjricci updated this revision to Diff 59637.
fjricci added a comment.
Refactor to remove unnecessary object file type checking
http://reviews.llvm.org/D20990
Files:
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
Index: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
==
fjricci updated this revision to Diff 59633.
fjricci added a comment.
Fix curly-brace style
http://reviews.llvm.org/D20990
Files:
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
Index: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
=
fjricci created this revision.
fjricci added reviewers: clayborg, ADodds, tfiala.
fjricci added a subscriber: lldb-commits.
Because PIE executables have an e_type of llvm::ELF::ET_DYN,
they are not of type eTypeExecutable, and were being removed
when svr4 packets were used.
http://reviews.llvm.or
Author: fjricci
Date: Tue May 24 13:19:45 2016
New Revision: 270592
URL: http://llvm.org/viewvc/llvm-project?rev=270592&view=rev
Log:
Skip leading spaces when decoding hex values
Summary:
The StringExtractor functions using stroull will already
skip leading whitespace (ie GetU64). Make sure that
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270592: Skip leading spaces when decoding hex values
(authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D20509?vs=58041&id=58277#toc
Repository:
rL LLVM
http://reviews.llvm.org/
fjricci created this revision.
fjricci added reviewers: vharron, clayborg, jasonmolenda.
fjricci added a subscriber: lldb-commits.
The StringExtractor functions using stroull will already
skip leading whitespace (ie GetU64). Make sure that the manual
hex parsing functions also skip leading whitesp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270065: Checkout release_38 branches of llvm and clang when
building lldb 3.8 (authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D19608?vs=55274&id=57791#toc
Repository:
rL LLVM
Author: fjricci
Date: Tue May 3 11:31:36 2016
New Revision: 268397
URL: http://llvm.org/viewvc/llvm-project?rev=268397&view=rev
Log:
Split out console and file writing cases in TestCommandScriptImmediateOutput
Summary:
As these are really testing separate issues, they should be run as separate
t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268397: Split out console and file writing cases in
TestCommandScriptImmediateOutput (authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D19690?vs=55619&id=56020#toc
Repository:
r
fjricci updated this revision to Diff 55619.
fjricci added a comment.
Update timeout to 10 seconds for console case
http://reviews.llvm.org/D19690
Files:
packages/Python/lldbsuite/test/functionalities/command_script_immediate_output/TestCommandScriptImmediateOutput.py
Index:
packages/Pytho
fjricci added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/command_script_immediate_output/TestCommandScriptImmediateOutput.py:29
@@ -30,1 +28,3 @@
+"""Test that LLDB correctly allows scripted commands to set immediate
output to the console
fjricci created this revision.
fjricci added reviewers: zturner, granata.enrico, clayborg.
fjricci added a subscriber: lldb-commits.
As these are really testing separate issues, they should be run as separate
tests.
http://reviews.llvm.org/D19690
Files:
packages/Python/lldbsuite/test/function
fjricci added a comment.
I do observe the sendline() behavior on OSX, but only when I cherry-pick these
bug-fixes onto the 3.8 branch. It seems to work fine on master.
http://reviews.llvm.org/D19633
___
lldb-commits mailing list
lldb-commits@lists.
fjricci added a comment.
Oh I see. I don't think the file-writing is going to work in the PExpect mode
(for some reason, it looks like the sendline calls aren't always being
received/processed correctly by lldb, while runCmd works fine), so it's
probably better to split out into a different tes
fjricci added a comment.
Would it be acceptable to split it into two test methods inside the same test
case? Both are testing writing immediate output from a command script, just one
is immediate output to the console and the other is immediate output to a file.
http://reviews.llvm.org/D19633
fjricci abandoned this revision.
fjricci added a comment.
Ok, I'll put up a new revision to split out the test cases.
http://reviews.llvm.org/D19633
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
fjricci added a comment.
As of r264351, this test already writes to both the console and to files (since
the file writing is testing the same python file io bugs tested by the console
writing). I can make another patch to split it out if that's preferable.
However, this patch is intended to mov
fjricci updated this revision to Diff 55340.
fjricci added a comment.
Remove windows expected failure
http://reviews.llvm.org/D19633
Files:
packages/Python/lldbsuite/test/functionalities/command_script_immediate_output/TestCommandScriptImmediateOutput.py
Index:
packages/Python/lldbsuite/te
fjricci created this revision.
fjricci added reviewers: granata.enrico, zturner.
fjricci added subscribers: sas, lldb-commits.
This should make TestCommandScriptImmediateOutput more consistent
with the rest of the test suite.
http://reviews.llvm.org/D19633
Files:
packages/Python/lldbsuite/tes
fjricci created this revision.
fjricci added reviewers: clayborg, jasonmolenda.
fjricci added subscribers: hans, sas, lldb-commits.
This commit is intended only for the release_38 branch, not for master.
Fixes xcodebuild for the release_38 branch, since llvm and clang must
be on the same branch a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267741: Use absolute module path when possible if sent in
svr4 packets (authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D19557?vs=55083&id=55253#toc
Repository:
rL LLVM
http:/
Author: fjricci
Date: Wed Apr 27 12:10:15 2016
New Revision: 267741
URL: http://llvm.org/viewvc/llvm-project?rev=267741&view=rev
Log:
Use absolute module path when possible if sent in svr4 packets
Summary:
If the remote uses svr4 packets to communicate library info,
the LoadUnload tests will fail
fjricci created this revision.
fjricci added reviewers: ovyalov, ADodds, jasonmolenda, clayborg.
fjricci added subscribers: sas, lldb-commits.
If the remote uses svr4 packets to communicate library info,
the LoadUnload tests will fail, as lldb only used the basename
for modules, causing problems w
Author: fjricci
Date: Mon Apr 25 14:02:05 2016
New Revision: 267443
URL: http://llvm.org/viewvc/llvm-project?rev=267443&view=rev
Log:
test commit
Modified:
lldb/trunk/docs/lldb-for-gdb-users.txt
Modified: lldb/trunk/docs/lldb-for-gdb-users.txt
URL:
http://llvm.org/viewvc/llvm-project/lldb/t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267468: Maintain register numbering across xml include
features (authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D19303?vs=54298&id=54904#toc
Repository:
rL LLVM
http://review
Author: fjricci
Date: Mon Apr 25 16:03:55 2016
New Revision: 267468
URL: http://llvm.org/viewvc/llvm-project?rev=267468&view=rev
Log:
Maintain register numbering across xml include features
Summary:
If the remote uses include features when communicating
xml register info back to lldb, the existin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267467: Properly unload modules from target image list when
using svr4 packets (authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D19230?vs=54083&id=54902#toc
Repository:
rL LLVM
Author: fjricci
Date: Mon Apr 25 16:02:24 2016
New Revision: 267467
URL: http://llvm.org/viewvc/llvm-project?rev=267467&view=rev
Log:
Properly unload modules from target image list when using svr4 packets
Summary:
When we receive an svr4 packet from the remote, we check for new modules
and add th
fjricci added a comment.
Committed with comment added to ReadRegister declaration to specify that the
argument is an eRegisterKindProcessPlugin register number
Repository:
rL LLVM
http://reviews.llvm.org/D19305
___
lldb-commits mailing list
lldb
Author: fjricci
Date: Mon Apr 25 15:59:11 2016
New Revision: 267466
URL: http://llvm.org/viewvc/llvm-project?rev=267466&view=rev
Log:
Use Process Plugin register indices when communicating with remote
Summary:
eRegisterKindProcessPlugin is used to store the register
indices used by the remote, an
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267466: Use Process Plugin register indices when
communicating with remote (authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D19305?vs=54303&id=54900#toc
Repository:
rL LLVM
ht
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267463: Store absolute path for lldb executable in dotest.py
(authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D19082?vs=53637&id=54895#toc
Repository:
rL LLVM
http://reviews.l
Author: fjricci
Date: Mon Apr 25 15:36:22 2016
New Revision: 267463
URL: http://llvm.org/viewvc/llvm-project?rev=267463&view=rev
Log:
Store absolute path for lldb executable in dotest.py
Summary:
lldb-server tests are currently being skipped on the
check-lldb target. This is because we get the pa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267462: Create _lldb python symlink correctly when
LLVM_LIBDIR_SUFFIX is used (authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D19067?vs=54077&id=54894#toc
Repository:
rL LLVM
Author: fjricci
Date: Mon Apr 25 15:34:34 2016
New Revision: 267462
URL: http://llvm.org/viewvc/llvm-project?rev=267462&view=rev
Log:
Create _lldb python symlink correctly when LLVM_LIBDIR_SUFFIX is used
Summary:
Do not assume that liblldb.so is located in $(lldb -P)/../../../lib
when creating th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267459: Add missing qRegisterInfo option to gdbremote
testcase (authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D18807?vs=52743&id=54892#toc
Repository:
rL LLVM
http://reviews
Author: fjricci
Date: Mon Apr 25 15:24:30 2016
New Revision: 267459
URL: http://llvm.org/viewvc/llvm-project?rev=267459&view=rev
Log:
Add missing qRegisterInfo option to gdbremote testcase
Summary:
"gcc" is equivalent to "ehframe" in ProcessGDBRemote, but
only "ehframe" was a valid response in th
fjricci added a comment.
I can add a comment to the ReadRegister decl.
Alternatively, if you think it would be preferable, I could change the
parameter name from reg_num to something more descriptive, like remote_reg_num
or plugin_reg_num.
Or I could change ReadRegister to take a RegisterInfo
fjricci created this revision.
fjricci added reviewers: jasonmolenda, clayborg.
fjricci added subscribers: sas, lldb-commits.
eRegisterKindProcessPlugin is used to store the register
indices used by the remote, and eRegisterKindLLDB is used
to store the internal lldb register indices. However, we'
fjricci created this revision.
fjricci added reviewers: jingham, clayborg, jasonmolenda.
fjricci added subscribers: sas, lldb-commits.
If the remote uses include features when communicating
xml register info back to lldb, the existing code would reset the
lldb register index at the beginning of e
fjricci added inline comments.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4907
@@ -4883,2 +4906,3 @@
+m_process->GetTarget().ModulesDidUnload (removed_modules, false);
new_modules.ForEach ([&target](const lldb::ModuleSP module_sp) -> bool
fjricci created this revision.
fjricci added reviewers: ADodds, zturner, tfiala.
fjricci added subscribers: sas, lldb-commits.
When we receive an svr4 packet from the remote, we check for new modules
and add them to the list of images in the target. However, we did not
do the same for modules whic
fjricci updated this revision to Diff 54077.
fjricci added a comment.
Pass the lldb lib directory to python swig scripts
http://reviews.llvm.org/D19067
Files:
CMakeLists.txt
scripts/Python/finishSwigPythonLLDB.py
scripts/finishSwigWrapperClasses.py
Index: scripts/finishSwigWrapperClasses
fjricci added a comment.
So I looked at `finishSwigPythonLLDB.py`, and it does look like that's where
the bug is. This script sets the end of the symlink path with:
strSrc = os.path.join("lib", "liblldb" + strLibFileExtn)
Note here that "lib" is hardcoded, and doesn't use the `LLVM_LIBDIR_SUF
fjricci added a comment.
When I use LLVM_LIBDIR_SUFFIX=64, it looks like the python _lldb.so symlink
still points to build/lib/liblldb.so, instead of using the lib64 directory. So
if I do this, none of the tests will run on the check-lldb target, since
importing lldb in python fails.
Perhaps t
fjricci created this revision.
fjricci added reviewers: vharron, zturner, tfiala.
fjricci added subscribers: sas, lldb-commits.
lldb-server tests are currently being skipped on the
check-lldb target. This is because we get the path of
lldb-server by modifying the path to the lldb executable.
How
fjricci created this revision.
fjricci added reviewers: zturner, vharron, emaste.
fjricci added subscribers: sas, lldb-commits.
$(lldb -P)/../../ is assumed to be the lldb library directory
by the test suite. However, it is possible that the python
libs would be installed in build/lib64 instead of
fjricci created this revision.
fjricci added reviewers: jasonmolenda, tfiala, clayborg.
fjricci added subscribers: sas, lldb-commits.
"gcc" is equivalent to "ehframe" in ProcessGDBRemote, but
only "ehframe" was a valid response in the test suite.
I know that "gcc" was replaced by "ehframe" in the
fjricci created this revision.
fjricci added reviewers: zturner, tfiala.
fjricci added subscribers: sas, lldb-commits.
The '-p' option for dotest.py was ignored in multiprocess mode,
as the -p argument to the inferior would overwrite the -p argument
passed on the command line.
http://reviews.llvm
1 - 100 of 152 matches
Mail list logo
