[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

2022-07-08 Thread Guy Benyei via Phabricator via lldb-commits
gbenyei updated this revision to Diff 441410. gbenyei added a comment. Removed LLD and JIT related parts - JIT is out of my scope, and LLD will be in an additional patch. Fixed additional remarks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

2022-07-08 Thread Guy Benyei via Phabricator via lldb-commits
gbenyei marked 3 inline comments as done. gbenyei added inline comments. Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_riscv.cpp:554 .buildGraph(); - } else { -assert((*ELFObj)->getArch() == Triple::riscv32 && - "Invalid triple for RISCV ELF object

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

2022-07-08 Thread Guy Benyei via Phabricator via lldb-commits
gbenyei marked 3 inline comments as done. gbenyei added a comment. In D128612#3620911 , @MaskRay wrote: > In D128612#3618167 , @gbenyei wrote: > >> In D128612#3617955 ,

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

2022-07-08 Thread Guy Benyei via Phabricator via lldb-commits
gbenyei added a comment. In D128612#3617906 , @jhenderson wrote: > Objcopy aspects look good, thanks. Thanks Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_riscv.cpp:554 .buildGraph(); - } else { -

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

2022-07-08 Thread Guy Benyei via Phabricator via lldb-commits
gbenyei added a comment. In D128612#3617955 , @MaskRay wrote: > lld/ELF change should be dropped from this change. Don't use > `config->endianness`. > I feel sad that for little-endian users who don't use big-endian, every write > now is slightly

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

2022-06-28 Thread Guy Benyei via Phabricator via lldb-commits
gbenyei updated this revision to Diff 440579. gbenyei marked 7 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128612/new/ https://reviews.llvm.org/D128612 Files: clang/include/clang/Basic/Attr.td

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

2022-06-28 Thread Guy Benyei via Phabricator via lldb-commits
gbenyei updated this revision to Diff 440196. gbenyei added a comment. Thanks, Craig. Updated the patch with your remarks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128612/new/ https://reviews.llvm.org/D128612 Files:

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

2022-06-28 Thread Guy Benyei via Phabricator via lldb-commits
gbenyei created this revision. gbenyei added a reviewer: asb. gbenyei added projects: clang, LLVM, lld. Herald added subscribers: Enna1, sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, ormris, jocewei, PkmX, the_o, brucehoult,