[Lldb-commits] [PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG7aafea001282: [llvm][Support] Deprecate llvm::writeFileAtomically API (authored by hokein). Repository: r

[Lldb-commits] [PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a579db32a7a: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1543

[Lldb-commits] [PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

hokein added a comment. thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154329/new/ https://reviews.llvm.org/D154329 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

hokein added inline comments. Comment at: lldb/tools/lldb-server/lldb-platform.cpp:112 return Status("Failed to atomically write file %s", file_spec.GetPath().c_str()); return status; avl wrote: > probably, it would be better to add err

[Lldb-commits] [PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

hokein updated this revision to Diff 536735. hokein marked an inline comment as done. hokein added a comment. address a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154329/new/ https://reviews.llvm.org/D154329 Files: lldb/tools/lldb-se

[Lldb-commits] [PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

hokein marked an inline comment as done. hokein added a comment. Now this patch only contains the removal part of the API (I have cleaned all usages of `writeFileAtomically` API, except a remaining one in lldb https://reviews.llvm.org/D154329). Comment at: lldb/tools/lldb-ser

[Lldb-commits] [PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

hokein updated this revision to Diff 536698. hokein added a comment. Restrict the patch to only remove the writeFileAtomically API Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153740/new/ https://reviews.llvm.org/D153740 Files: llvm/include/llv

[Lldb-commits] [PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

hokein created this revision. hokein added reviewers: avl, JDevlieghere. Herald added a project: All. hokein requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154329 Files: l

[Lldb-commits] [PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

hokein added a comment. In D153740#4448408 , @avl wrote: > added @jkorous who originally added llvm::writeFileAtomically. > >> Let me know what you think about it -- I considered keeping the >> llvm::writeFileAtomically and migrating its underlying imple

[Lldb-commits] [PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

hokein added a comment. Herald added a subscriber: JDevlieghere. Let me know what you think about it -- I considered keeping the `llvm::writeFileAtomically` and migrating its underlying implementation to `llvm::writeToOutput`, but it doesn't seem to worth, there are only 4 in-tree usages of thi

[Lldb-commits] [PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

hokein created this revision. hokein added a reviewer: avl. Herald added subscribers: ormris, kadircet, arphaman, steven_wu, hiraditya. Herald added a project: All. hokein requested review of this revision. Herald added projects: clang, LLDB, LLVM, clang-tools-extra. Herald added subscribers: llvm-

[Lldb-commits] [PATCH] D121746: Use lit_config.substitute instead of foo % lit_config.params everywhere

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. The change looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121746/new/ https://reviews.llvm.org/D121746 _

[Lldb-commits] [PATCH] D115438: [lldb] Remove unused lldb.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rGeaf4f60507fd: [lldb] Remove unused lldb.cpp (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115438/new/ https://reviews.llvm.org/D115438

[Lldb-commits] [PATCH] D115438: [lldb] Remove unused lldb.cpp

hokein created this revision. hokein added a reviewer: labath. hokein requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lldb.cpp is unused after https://github.com/llvm/llvm-project/commit/ccf1469a4cdb03cb2bc7868f76164e85d90ebee1 Repositor