[Lldb-commits] [PATCH] D92957: ExpressionParser: Migrate to FileEntryRef in ParseInternal, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92957/new/ https://reviews.llvm.org/D92957

[Lldb-commits] [PATCH] D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types

jansvoboda11 added a comment. This breaks our build: https://green.lab.llvm.org/green/job/lldb-cmake/37529/console Can you take a look? If the fix is not obvious, please revert for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112863/new/ htt

[Lldb-commits] [PATCH] D115331: [llvm] Add null-termination capability to SmallVectorMemoryBuffer

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added subscribers: ormris, steven_wu, hiraditya. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: shafik. Herald added a reviewer: rupprecht. Herald added a reviewer: jhenderson.

[Lldb-commits] [PATCH] D115331: [llvm] Add null-termination capability to SmallVectorMemoryBuffer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0262c2394f4: [llvm] Add null-termination capability to SmallVectorMemoryBuffer (authored by jansvoboda11). Changed prior to commit: https://revie

[Lldb-commits] [PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

jansvoboda11 created this revision. jansvoboda11 added a reviewer: MaskRay. Herald added subscribers: jhenderson, ormris, ributzka, steven_wu, hiraditya, arichardson, emaste. Herald added a reviewer: JDevlieghere. Herald added a reviewer: jhenderson. Herald added a project: All. jansvoboda11 reque

[Lldb-commits] [PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

jansvoboda11 added a comment. Here's an example of a patch that changes the `OPTION` macro: D157029 . I wonder if we could have counterparts to `LLVM_MAKE_OPT_ID` and `LLVM_CONSTRUCT_OPT_INFO` that allow overriding the default `OPT_` prefix. That would make D15

[Lldb-commits] [PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

jansvoboda11 updated this revision to Diff 547018. jansvoboda11 added a comment. Herald added a reviewer: alexander-shaposhnikov. Consolidate all usages by extra `_WITH_ID_PREFIX` macros Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157028/new/ htt

[Lldb-commits] [PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

jansvoboda11 updated this revision to Diff 547090. jansvoboda11 added a comment. Herald added subscribers: pmatos, asb, aheejin, sbc100. Herald added a project: lld-macho. Herald added a reviewer: lld-macho. Convert missed LLD parts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

jansvoboda11 added inline comments. Comment at: lld/ELF/Driver.h:28 OPT_INVALID = 0, -#define OPTION(_1, _2, ID, _4, _5, _6, _7, _8, _9, _10, _11, _12) OPT_##ID, +#define OPTION(...) LLVM_MAKE_OPT_ID(__VA_ARGS__), #include "Options.inc" MaskRay wrote: > lld/w

[Lldb-commits] [PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f092f37b736: [llvm] Extract common `OptTable` bits into macros (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157028/new/ https: