[Lldb-commits] [PATCH] D70644: [DebugInfo] Support for DW_OP_implicit_pointer (llvm.dbg_derefval)

jmorse added a comment. Thanks for the patch, comments inline. A couple of things in general: As mentioned on the mailing list thread, it bothers me a little that DbgVariableIntrinsic::getVariableLocation is going to try and return something that isn't a "Real" location. In fact, wouldn't the a

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

jmorse added a comment. This is going to be excellent for linux targets and similar, In D106084#2882970 , @probinson wrote: > + @jmorse who is better placed than I am to say whether this is what Sony > would prefer. Slightly trickier -- our debugger wo

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

jmorse accepted this revision. jmorse added a comment. In D106084#2887702 , @dblaikie wrote: > It'd be preferable not to split these two cases (current "limited" versus > "ctor" homing) - because they rely on the same assumption, that the whole > progra

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

jmorse added a comment. In D106084#2890541 , @probinson wrote: > @jmorse am I remembering correctly, that we require dllimport-style > annotations, so "limited" actually includes these types even if they aren't > constructed locally? I am vague on the

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

jmorse added a comment. David wrote: > think what I'm missing here: If -fno-standalone-debug is already in use/the > default and is causing missing types because parts of the program are bulit > without debug info, then I'm not sure what the rationale is for slicing > -fstandalone-debug into a

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

jmorse added a comment. Hi, I'm experiencing reorder.py failing intermittently on a Windows system -- it seems to pick up the .lit_test_times.txt produced in the build directory for the Inputs tests after the first run, and use that for ordering. And seeing how that just contains noise, the In

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

jmorse added a comment. It turns out there's a plain old windows-has-different-slashes problem going on. In the Test object __init__ method, the call to `os.sep.join` in this patch produces the string "subdir\ccc.txt", which won't match "subdir/ccc.txt" that you load from the the .lit_test_time