[Lldb-commits] [PATCH] D122568: [lldb] correct comment in deterministic build test

2022-03-28 Thread Jez Ng via Phabricator via lldb-commits
int3 added a comment. The underlying test is still using just ld64 though. I think a proper fix be to use LLD if it's available as the host linker? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122568/new/ https://reviews.llvm.org/D122568 ___

[Lldb-commits] [PATCH] D122568: [lldb] correct comment in deterministic build test

2022-04-01 Thread Jez Ng via Phabricator via lldb-commits
int3 requested changes to this revision. int3 added a comment. This revision now requires changes to proceed. Clearing queue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122568/new/ https://reviews.llvm.org/D122568 ___

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

2023-03-23 Thread Jez Ng via Phabricator via lldb-commits
int3 added a comment. I'm trying to add similar support to lld-macho, hence the question :) Comment at: lld/COFF/LTO.cpp:183 + [&](size_t task, const Twine &moduleName) { +buf[task].first = moduleName.str(); return std::make_unique( Any re

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

2022-12-07 Thread Jez Ng via Phabricator via lldb-commits
int3 added a comment. lld/MachO changes lgtm Comment at: lld/MachO/Driver.cpp:1386 // ld64 does something really weird. It attempts to realign the value to the -// page size, but assumes the the page size is 4K. This doesn't work with +// page size, but assumes th