[Lldb-commits] [PATCH] D134245: [lldb] Actually support more than 32 logging categories

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b4db10f3492: [lldb] Actually support more than 32 logging categories (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D134245?vs=461420&id=461

[Lldb-commits] [PATCH] D134245: [lldb] Actually support more than 32 logging categories

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg. Herald added a project: All. JDevlieghere requested review of this revision. In January, Greg put up a patch (D117382 ) to support more than 32 log categories, among other things.

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Comment at: lldb/test/API/lit.cfg.py:178-179 + dotest_cmd += ['--libcxx-include-dir', config.libcxx_include_dir] + if is_configured('libcxx_include_target_dir'): +dotest_cmd += ['--libcxx-

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

JDevlieghere added a comment. Do we need both `LIBCPP_INCLUDE_DIR` and `LIBCPP_INCLUDE_TARGET_DIR`? I see we pass another `-cxx-isystem` flag, does this result in another search path or does that replace the former? If we only need one, we could set `LIBCPP_INCLUDE_DIR` to `libcxx_include_targe

[Lldb-commits] [PATCH] D133961: [lldb] Use SWIG_fail in python-typemaps.swig (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133961/new/ https://reviews.llvm.org/D133961 ___

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

JDevlieghere added a comment. In D133906#3792230 , @labath wrote: > In D133906#3791352 , @JDevlieghere > wrote: > >> In D133906#3791153 , @jingham >> wrote: >> >>> This

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

JDevlieghere added a comment. In D133906#3791153 , @jingham wrote: > This patch makes me a little sad because it breaks the "Jump to Definition" > chain in Xcode (and I bet it does in other IDE's that support this.) You > used to be able to do "Jump to

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

JDevlieghere created this revision. JDevlieghere added reviewers: mib, aprantl, labath. Herald added a project: All. JDevlieghere requested review of this revision. Generate lldb-forward with .def file. The benefit is that we don't have to keep the list of classes, and typedefs in sync. https:/

[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

JDevlieghere added inline comments. Comment at: lldb/source/Target/Process.cpp:2763-2766 +static void ResetHitCounts(Process &Proc) { + for (const auto &BP : Proc.GetTarget().GetBreakpointList().Breakpoints()) +BP->ResetHitCount(); +} Can this be a private m

[Lldb-commits] [PATCH] D133680: Add support for mach-o corefile loading of a platform binary

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133680/new/ https://reviews.llvm.org/D133680 ___

[Lldb-commits] [PATCH] D131122: [lldb] Fixed a number of typos

This revision was automatically updated to reflect the committed changes. Closed by commit rG7240436c94bd: [lldb] Fixed a number of typos (authored by GabrielRavier, committed by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D131122?vs=449806&id=459801#toc Repository: rG L

[Lldb-commits] [PATCH] D133639: [lldb] Fix detection of existing libcxx

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133639/new/ https://reviews.llvm.org/D133639 __

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Core/UserSettingsController.h:62-64 virtual void DumpAllPropertyValues(const ExecutionContext *exe_ctx, - Stream &strm, uint32_t dump_mask); +

[Lldb-commits] [PATCH] D133689: [lldb] Add SBBreakpointLocation::SetCallback

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133689/new/ https://reviews.llvm.org/D133689 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D133639: [lldb] Fix detection of existing libcxx

JDevlieghere added inline comments. Comment at: lldb/test/API/lit.cfg.py:181-184 +if is_configured_and_true('has_libcxx') and platform.system() != 'Windows': if is_configured('llvm_include_dir') and is_configured('llvm_libs_dir'): dotest_cmd += ['--libcxx-include-dir', o

[Lldb-commits] [PATCH] D133639: [lldb] Fix detection of existing libcxx

JDevlieghere added inline comments. Comment at: lldb/test/API/lit.cfg.py:94 +def is_configured_and_true(attr): + """Returns true if and only if the configuration attribute exists and it is `is_enabled` maybe? Comment at: lldb/test/API/lit.cf

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. A small comment but otherwise this LGTM. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp:924 +

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

JDevlieghere added a comment. The current patch didn't have context so I just left a bunch of nits. Comment at: lldb/include/lldb/Target/Platform.h:870-874 + virtual bool LoadSpecialBinaryAndSetDynamicLoader(Process *process, +

[Lldb-commits] [PATCH] D133519: Document some of the clang-specific DWARF extensions supported by LLDB

JDevlieghere added a comment. Content looks good to me, but I'll hold off on accepting the review until the others have had a chance to see this in their review queue. Comment at: lldb/docs/use/extensions.rst:72 + +:: + DW_TAG_compile_unit Missing newline (i

[Lldb-commits] [PATCH] D133519: Document some of the clang-specific DWARF extensions supported by LLDB

JDevlieghere added a comment. You'll need to add this to the index.rst page. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133519/new/ https://reviews.llvm.org/D133519 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D133501: [lldb] Use std::size instead of llvm::array_lengthof

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133501/new/ https://reviews.llvm.org/D133501 ___

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:396 + ifneq ($(or $(USE_LIBSTDCPP), $(USE_LIBCPP)),) + $(error Cannot use system's library and a custom library toget

[Lldb-commits] [PATCH] D133393: [test] Use either `127.0.0.1` or `[::1]` to run in ipv6-only environments.

JDevlieghere added inline comments. Comment at: lldb/unittests/TestingSupport/Host/SocketTestUtilities.h:50 +/// is detected. If neither are detected, return an error. +llvm::Expected GetLocalhostIp(); + nit Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D133259: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp:70 +static void consumeNamespace(llvm::StringRef &name) { + // Delete past an inline namespace, if any: __[a-zA-Z0-9_]+:: rupprecht wrote: > nit: this

[Lldb-commits] [PATCH] D133069: Fix inconsistent target arch when attaching to arm64 binaries on arm64e platforms.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. That test is not going to win any beauty pageants but it looks like it gets the job done. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133069/new/ https://reviews.

[Lldb-commits] [PATCH] D133130: [lldb][bindings] Fix module_access handling of regex

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133130/new/ https://reviews.llvm.org/D133130 _

[Lldb-commits] [PATCH] D133129: [lldb] Add boilerplate for debugger interrupts

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added a subscriber: mgorny. Herald added a project: All. JDevlieghere requested review of this revision. Jim is looking into adding support for interrupts to the SB API. Part of that work requires clearing the inte

[Lldb-commits] [PATCH] D133069: Fix inconsistent target arch when attaching to arm64 binaries on arm64e platforms.

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp:584 +triple.setArchName("arm64"); +target_arch.SetTriple(triple); +target.SetArchitecture(target_arch, /*set_platform=*/false, --

[Lldb-commits] [PATCH] D133069: Fix inconsistent target arch when attaching to arm64 binaries on arm64e platforms.

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp:584 +triple.setArchName("arm64"); +target_arch.SetTriple(triple); +target.SetArchitecture(target_arch, /*set_platform=*/false, --

[Lldb-commits] [PATCH] D133046: [lldb] Make the `rumtimes` target a test dependency

This revision was automatically updated to reflect the committed changes. Closed by commit rGf328922f55fe: [lldb] Make the rumtimes target a test dependency (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D133046: [lldb] Make the `rumtimes` target a test dependency

JDevlieghere created this revision. JDevlieghere added reviewers: fdeazeve, jingham. Herald added a subscriber: mgorny. Herald added a project: All. JDevlieghere requested review of this revision. Make the `rumtimes` target a test dependency https://reviews.llvm.org/D133046 Files: lldb/test/C

[Lldb-commits] [PATCH] D132973: [lldb] Fix two bugs in ObjectContainerMachOFileset when reading from memory

This revision was automatically updated to reflect the committed changes. Closed by commit rG0044cb4b2037: [lldb] Fix two bugs in ObjectContainerMachOFileset (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D132973: [lldb] Fix two bugs in ObjectContainerMachOFileset when reading from memory

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a reviewer: ributzka. Herald added a project: All. JDevlieghere requested review of this revision. Jason caught two issues in the memory part of ObjectContainerMachOFileset which I didn't hook up and the

[Lldb-commits] [PATCH] D132868: [lldb][test] Enable clang modules in API/tools/lldb-server (NFC)

JDevlieghere added a comment. In D132868#3758826 , @labath wrote: > I don't think this will work in general, as the modules feature requires all > your dependencies to be modularized, and linux systems generally don't have > that. You might be able to d

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132940/new/ https://reviews.llvm.org/D132940 ___

[Lldb-commits] [PATCH] D132868: [lldb][test] Enable clang modules in API/tools/lldb-server (NFC)

JDevlieghere added a comment. The test that's using `iostream` could be rewritten to use `printf` instead. It actually looks like most of those test can be compiled as C programs, which should speed this up even more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D132803: [lldb][test] Speed up lldb arch determination (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132803/new/ https://reviews.llvm.org/D132803 ___

[Lldb-commits] [PATCH] D117383: [lldb] Expose std::pair children for unordered_map

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117383/new/ https://reviews.llvm.org/D117383 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D132775: [lldb][docs] Fix formatting in fuzzing doc

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132775/new/ https://reviews.llvm.org/D132775 ___

[Lldb-commits] [PATCH] D117383: [lldb] Expose std::pair children for unordered_map

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp:75-76 + name.startswith("unordered_multimap<") || + name.startswith("std::__1::unordered_map<") || + name.startswith("std::__1::unordered_multimap

[Lldb-commits] [PATCH] D132148: [lldb][docs] Add documentation for LLDB fuzzers

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo inline comment. Comment at: lldb/docs/resources/fuzzing.rst:15-17 + $ -DLLVM_USE_SANITIZER='Address' + $ -DLLVM_USE_SANITIZE_COVERAGE=On + $ -DC

[Lldb-commits] [PATCH] D132642: [lldb] Fix dotest argument order

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/test/API/CMakeLists.txt:166 +set(LLDB_TEST_COMMON_ARGS ${LLDB_TEST_COMMON_ARGS_VAR} CACHE INTERNAL STRING) + fdeazeve wro

[Lldb-commits] [PATCH] D132710: [lldb] Computer and apply the slide to the fileset entry's vmaddr

This revision was automatically updated to reflect the committed changes. Closed by commit rGe360281fa710: [lldb] Computer the slide when and apply it to each fileset's vm addr (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D132710?vs

[Lldb-commits] [PATCH] D132709: [lldb][ClangExpression] Fix LLDB_LOG incorrect format specifier

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132709/new/ https://reviews.llvm.org/D132709 ___

[Lldb-commits] [PATCH] D132710: [lldb] Computer and apply the slide to the fileset entry's vmaddr

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. Computer and apply the slide to the fileset entry's vmaddr when reading a fileset from memory. https://reviews.llvm.org/D132710 Files:

[Lldb-commits] [PATCH] D132433: [lldb] Teach LLDB about filesets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG48506fbbbf27: [lldb] Teach LLDB about Mach-O filesets (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://r

[Lldb-commits] [PATCH] D132433: [lldb] Teach LLDB about filesets

JDevlieghere updated this revision to Diff 455725. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. I added the ability to call `ObjectContainer::FindPlugin` which allows you to create a Mach-O fileset from memory without actually having to know it's a fileset. I thin

[Lldb-commits] [PATCH] D132642: [lldb] Fix dotest argument order

JDevlieghere added inline comments. Comment at: lldb/test/API/CMakeLists.txt:166 +set(LLDB_TEST_COMMON_ARGS ${LLDB_TEST_COMMON_ARGS_VAR} CACHE INTERNAL STRING) + Instead of having two variables, why not move this to line 40 and make `LLDB_TEST_COMMON_ARGS` a c

[Lldb-commits] [PATCH] D132694: [lldb] Quietly source lit-lldb-init

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132694/new/ https://reviews.llvm.org/D132694 ___

[Lldb-commits] [PATCH] D132596: [lldb][nfc] Remove unused makefile test variables

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM, I meant to remove those in a previous patch. Thanks for following up on that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[Lldb-commits] [PATCH] D132433: [lldb] Teach LLDB about filesets

JDevlieghere updated this revision to Diff 455428. JDevlieghere retitled this revision from "[lldb] Teach LLDB about filesets (WIP)" to "[lldb] Teach LLDB about filesets". JDevlieghere added a comment. - Rebase - Support reading Filesets from memory CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D132433: [lldb] Teach LLDB about filesets (WIP)

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a subscriber: mgorny. Herald added a project: All. JDevlieghere requested review of this revision. https://reviews.llvm.org/D132433 Files: lldb/include/lldb/Symbol/ObjectFile.h lldb/source/Plugins/Ob

[Lldb-commits] [PATCH] D132307: [lldb] Switch RegularExpression from llvm::Regex to std::regex

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/RegularExpression.h:92 + std::regex m_regex; + std::optional m_regex_error; }; There's an ongoing discussion on the forums [1] to replace `llvm::Optional` with `std::optional`. Until th

[Lldb-commits] [PATCH] D132263: [lldb] Support specifying a custom libcxx for the API tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc0b5ebf7fc8: [lldb] Support specifying a custom libcxx for the API tests (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D132263: [lldb] Support specifying a custom libcxx for the API tests

JDevlieghere created this revision. JDevlieghere added reviewers: fdeazeve, aprantl, labath. Herald added a project: All. JDevlieghere requested review of this revision. D129166 was an attempt to ensure that by default we use the libc++ from the build dir instea

[Lldb-commits] [PATCH] D132257: [lldb] Create flag to use a custom libcxx in tests

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:338-339 +if args.custom_libcpp: +os.environ['CUSTOM_LIBCPP'] = args.custom_libcpp + aprantl wrote: > JDevlieghere wrote: > > Please don't rely on environme

[Lldb-commits] [PATCH] D132257: [lldb] Create flag to use a custom libcxx in tests

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:338-339 +if args.custom_libcpp: +os.environ['CUSTOM_LIBCPP'] = args.custom_l

[Lldb-commits] [PATCH] D132148: [lldb][docs] Add documentation for LLDB fuzzers

JDevlieghere added inline comments. Comment at: lldb/docs/resources/fuzzing.rst:28-33 +To build a fuzzer, run the desired ninja command for the fuzzer(s) you want to build: + +:: + $ ninja lldb-target-fuzzer + $ ninja lldb-commandinterpreter-fuzzer + $ ninja lldb-expressio

[Lldb-commits] [PATCH] D132148: [lldb][docs] Add documentation for LLDB fuzzers

JDevlieghere added inline comments. Comment at: lldb/docs/resources/fuzzing.rst:14-26 +:: + $ cmake \ +-G Ninja \ +-DCMAKE_BUILD_TYPE='Release' \ +-DLLVM_USE_SANITIZER='Address' \ +-DLLVM_USE_SANITIZE_COVERAGE=On \ +-DLLVM_BUILD_RUNTIME=

[Lldb-commits] [PATCH] D131998: [LLDB][NFC] Suppress spurious static inspection warnings

JDevlieghere added inline comments. Comment at: lldb/tools/lldb-vscode/FifoFiles.cpp:65-69 +// Indeed this is a leak, but it's intentional. "future" obj destructor +// will block on waiting for the worker thread to join. And the worker +// thread might be stuck in b

[Lldb-commits] [PATCH] D131996: Use a SmallPtrSet rather than a SmallVector in ClusterManager.

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/SharedCluster.h:52 ClusterManager() : m_objects() {} - - llvm::SmallVector m_objects; + llvm::SmallPtrSet m_objects; std::mutex m_mutex; labath wrote: > JDevlieghere wrote: > > I as

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/test/API/macosx/queues/TestQueues.py:131 +def check_queue_breakpoints(self, queue1, queue2, queue_breakpoint): +queue1_thread

[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb706f56133a7: [lldb] Automatically unwrap parameter packs in template argument accessors (authored by JDevlieghere). Hera

[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

JDevlieghere marked 8 inline comments as done. JDevlieghere added a comment. Thanks for the review Michael. I've addressed all your comments in the version I landed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51387/new/ https://reviews.llvm.org/D51387 __

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

JDevlieghere added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:131 +def check_queue_breakpoints(self, queue1, queue2, queue_breakpoint): +queue1_thread = queue1.GetThreadAtIndex(0) Any reason this should be a separate func

[Lldb-commits] [PATCH] D131996: Use a SmallPtrSet rather than a SmallVector in ClusterManager.

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM modulo inline comment. Comment at: lldb/include/lldb/Utility/SharedCluster.h:52 ClusterManager() : m_objects() {} - - llvm::SmallVector m_objects; + llvm::SmallPtrSet m_objects; std::mutex m_mutex;

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

This revision was automatically updated to reflect the committed changes. Closed by commit rG11f45f36dcf5: [lldb] Fetching symbols in the background with dsymForUUID (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D131328?vs=452786&id=

[Lldb-commits] [PATCH] D131407: [lldb] Flush the global thread pool in Debugger::Terminate

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d36a82d0a3d: [lldb] Flush the global thread pool in Debugger::Terminate (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

JDevlieghere added a comment. In D131900#3724366 , @fixathon wrote: > I am going to clean up the code in the entire file where **raw pointers** > should be **shared_ptr** (because they get cast to shared_ptr anyways). Also > planning to convert the **na

[Lldb-commits] [PATCH] D131821: Add test that shows the problem with D118814

JDevlieghere added a comment. Great. Thanks for closing the loop on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131821/new/ https://reviews.llvm.org/D131821 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

JDevlieghere updated this revision to Diff 452786. JDevlieghere added a comment. Rebase on top of D131303 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131328/new/ https://reviews.llvm.org/D131328 Files: lldb/include/lldb/Core/Debugger.h lldb/incl

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/test/API/macosx/queues/TestQueues.py:133 +"The breakpoint for queue %s has not been hit" % (queue_breakpoi

[Lldb-commits] [PATCH] D124314: lldb: Disable unittests if llvm_gtest target does not exist

This revision was automatically updated to reflect the committed changes. Closed by commit rG350755d94d6b: [llvm] Include utils/unittest before projects and runtimes (authored by JDevlieghere). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[Lldb-commits] [PATCH] D131850: [LLDB][NFC] Reliability Fixes for FormatEntity

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131850/new/ https://reviews.llvm.org/D131850 ___

[Lldb-commits] [PATCH] D131664: [LLDB][ARM] Remove unused LoadPseudoRegistersFromFrame function

JDevlieghere accepted this revision. JDevlieghere added a comment. In D131664#3715513 , @DavidSpickett wrote: > @JDevlieghere Unless this is still used in your downstream? Thanks for checking. It's not used downstream, so this LGTM. Repository: rG L

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/InstrumentationRuntime/TSan/InstrumentationRuntimeTSan.cpp:227 static StructuredData::Array *ConvertToStructuredArray( ValueObjectSP return_value_sp, const std::string &items_name, fixat

[Lldb-commits] [PATCH] D131901: [lldb][debugserver] Revert "Use llvm::all_of (NFC)" for debugserver

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131901/new/ https://reviews.llvm.org/D131901 ___

[Lldb-commits] [PATCH] D131821: Add test that shows the problem with D118814

JDevlieghere added a comment. I applied your patch and ran the test and for me it's passing: lldb version 16.0.0git (g...@github.com:llvm/llvm-project.git revision 0c90d5f7e967aee8ab6e5e971e25921e631a40ac) clang revision 0c90d5f7e967aee8ab6e5e971e25921e631a40ac llvm revision 0c90d5f7e9

[Lldb-commits] [PATCH] D124314: lldb: Disable unittests if llvm_gtest target does not exist

JDevlieghere added inline comments. Comment at: lldb/CMakeLists.txt:128 +set(LLDB_INCLUDE_UNITTESTS ON) +if (NOT TARGET llvm_gtest) + set(LLDB_INCLUDE_UNITTESTS OFF) mgorny wrote: > If LLDB is built through `LLVM_ENABLE_PROJECTS`, then LLDB's CMakeLists are > i

[Lldb-commits] [PATCH] D131795: [LLDB] Fix the 'default' switch case in GetCompatibleArchs()

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. As mentioned in D113155 the difference in CPU type between `qHostInfo` and `qProcessInfo` is intentional. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D131741: [lldb] Skip target variable tests on Darwin because of chained fixups

This revision was automatically updated to reflect the committed changes. Closed by commit rGabe9599f04f0: [lldb] Skip target variable tests on Darwin because of chained fixups (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D131772: [LLDB] Remove __future__ imports from examples

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131772/new/ https://reviews.llvm.org/D131772 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D131761: [LLDB] Remove __future__ imports from tests

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131761/new/ https://reviews.llvm.org/D131761 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D131741: [lldb] XFAIL target variable tests on Intel/Darwin when using Xcode 14

JDevlieghere updated this revision to Diff 452077. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131741/new/ https://reviews.llvm.org/D131741 Files: lldb/test/API/commands/target/basic/TestTargetCommand.py lldb/test/API/lang/c/global_variables/TestGlobalVariables.py lldb/test/API/l

[Lldb-commits] [PATCH] D131741: [lldb] XFAIL target variable tests on Intel/Darwin when using Xcode 14

JDevlieghere added a comment. In D131741#3717992 , @JDevlieghere wrote: > In D131741#3717974 , @jasonmolenda > wrote: > >> We already skip these tests for arm64 & arm64e because of the chained fixups >> and arm

[Lldb-commits] [PATCH] D131741: [lldb] XFAIL target variable tests on Intel/Darwin when using Xcode 14

JDevlieghere added a comment. In D131741#3717974 , @jasonmolenda wrote: > We already skip these tests for arm64 & arm64e because of the chained fixups > and arm64e fixups before that -- and now we're going to skip them on x86_64 > if the deployment tar

[Lldb-commits] [PATCH] D131741: [lldb] XFAIL target variable tests on Intel/Darwin when using Xcode 14

JDevlieghere updated this revision to Diff 452045. JDevlieghere added a comment. Check the darwin OS version as a proxy for the deployment target CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131741/new/ https://reviews.llvm.org/D131741 Files: lldb/test/API/commands/target/basic/Test

[Lldb-commits] [PATCH] D131086: [lldb/crashlog] Improve exception reporting for interactive mode

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM assuming this compiles on non-apple hosts Comment at: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:525-542 + case EXC_BAD_ACCESS: +ret

[Lldb-commits] [PATCH] D131741: [lldb] XFAIL target variable tests on Intel/Darwin when using Xcode 14

JDevlieghere added a comment. With this patch applied the test suite should be clean on an Intel mac running macOS Ventura beta + Xcode 14 beta. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131741/new/ https://reviews.llvm.org/D131741 ___ l

[Lldb-commits] [PATCH] D131741: [lldb] XFAIL target variable tests on Intel/Darwin when using Xcode 14

JDevlieghere created this revision. JDevlieghere added reviewers: davide, jasonmolenda. Herald added subscribers: pengfei, kristof.beyls. Herald added a project: All. JDevlieghere requested review of this revision. Starting with Xcode 14, ld64 is using authenticated fixups for x86_64 as well as a

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:561 + default: +LLVM_FALLTHROUGH; + case ArchSpec::eCore_arm_arm64: { clayborg wrote: > fixathon wrote: > >

[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

JDevlieghere added a comment. In D51387#1387074 , @clayborg wrote: > Do we have any callers that call GetNumTemplateArguments with false? If not, > remove the argument? Yup, there's a bunch of uses in `Language/CPlusPlus/LibCxx*.cpp` CHANGES SINCE LAST

[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

JDevlieghere updated this revision to Diff 451714. JDevlieghere added a comment. - Rebase - Address Jim's code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51387/new/ https://reviews.llvm.org/D51387 Files: lldb/include/lldb/Symbol/CompilerType.h lldb/include/lldb/S

[Lldb-commits] [PATCH] D51387: Allow Template argument accessors to automatically unwrap parameter packs

JDevlieghere commandeered this revision. JDevlieghere added a reviewer: friss. JDevlieghere added a comment. Herald added a reviewer: shafik. Herald added a project: All. Commandeering this from Fred CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51387/new/ https://reviews.llvm.org/D5138

[Lldb-commits] [PATCH] D131613: [LLDB][NFC] Clean up dead code

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131613/new/ https://reviews.llvm.org/D131613 __

[Lldb-commits] [PATCH] D131554: [LLDB][NFC] Reliability fixes for ObjectFileMachO.cpp

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:6344 segment_vmaddr seg_vmaddr; +// this is the uncommon case where strncpy is exactly +// the right one, doesn't need to be nul terminated.

[Lldb-commits] [PATCH] D131531: [lldb] Allow DataFileCache to be constructed with a different policy

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Core/DataFileCache.cpp:23-46 +llvm::CachePruningPolicy DataFileCache::GetLLDBIndexCachePolicy() { + static llvm::CachePruningPolicy

[Lldb-commits] [PATCH] D131531: [lldb] Allow DataFileCache to be constructed with a different policy

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Core/DataFileCache.h:82 private: + /// Gets the default LLDB index cache policy, which is s It's a little weird that `GetLLDBIndexCachePolicy` would be private, if only from a documentation p

[Lldb-commits] [PATCH] D131542: [lldb/crashlog] Add `-V|--version` option

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131542/new/ https://reviews.llvm.org/D131542

[Lldb-commits] [PATCH] D131407: [lldb] Flush the global thread pool in Debugger::Terminate

JDevlieghere added a comment. @labath Ping in case it got pushed down your review queue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131407/new/ https://reviews.llvm.org/D131407 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

<    3   4   5   6   7   8   9   10   11   12   >