[Lldb-commits] [lldb] [LLDB] Make internal shell the default for running LLDB lit tests. (PR #156729)

2025-09-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/156729 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Mark scripted frames as synthetic instead of artificial (PR #153117)

2025-09-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/153117 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add more command option mnemonics (PR #155705)

2025-09-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/155705 >From 6427b12a42c2064d57bc211443a5aa1e59fa81d9 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 3 Sep 2025 08:25:14 -0700 Subject: [PATCH] Add a bunch of mnemonics to the command options now that

[Lldb-commits] [lldb] [lldb] Add more command option mnemonics (PR #155705)

2025-09-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/155705 >From f56a1a836e2fbe865d8e143d021389c99ec341e6 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 27 Aug 2025 14:25:29 -0700 Subject: [PATCH] [lldb] Add more command option mnemonics Add a bunch o

[Lldb-commits] [lldb] [lldb-dap] Destroy debugger when debug session terminates (PR #156231)

2025-09-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/156231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactor variable annotation logic in Disassembler::PrintInstructions (PR #156118)

2025-08-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/156118 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix some spelling and grammatical issues in Commands/Options.td (PR #156121)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/156121 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix some spelling and grammatical issues in Commands/Options.td (PR #156121)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere auto_merge_enabled https://github.com/llvm/llvm-project/pull/156121 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix some spelling and gramatical issues in Commands/Options.td (PR #156121)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/156121 Fixes whitespace, spelling and grammatical issues in the command options. I also formatted the affected options with clang-format and reflowed the description where necessary. >From 49a76d3d7551549d243f54

[Lldb-commits] [lldb] [lldb] Fix some spelling and grammatical issues in Commands/Options.td (PR #156121)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/156121 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactor variable annotation logic in Disassembler::PrintInstructions (PR #156118)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thank you! https://github.com/llvm/llvm-project/pull/156118 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix typo in the description of the -X alias (PR #156119)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/156119 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix typo in the description of the -X alias (PR #156119)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere auto_merge_enabled https://github.com/llvm/llvm-project/pull/156119 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix typo in the description of the -X alias (PR #156119)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/156119 None >From c872dddcbd2f8e1d65357a943a65d9e4cfc0a519 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 29 Aug 2025 15:42:29 -0700 Subject: [PATCH] [lldb] Fix typo in the description of the -X alia

[Lldb-commits] [lldb] [lldb] Stop the protocol servers when terminating the plugin (PR #156101)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/156101 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix typescript issue in updated typescript code. (PR #156117)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/156117 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Format tools/driver/Options.td (NFC) (PR #156111)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/156111 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Format tools/driver/Options.td (NFC) (PR #156111)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere auto_merge_enabled https://github.com/llvm/llvm-project/pull/156111 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Format tools/driver/Options.td (NFC) (PR #156111)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/156111 Use clang-format to format the driver options tablegen file. >From d2335a68e58af0fb46b8dada94f5e3b163fc326d Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 29 Aug 2025 14:46:13 -0700 Subject: [

[Lldb-commits] [lldb] [lldb][debugserver] Max response size for qSpeedTest (PR #156099)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/156099 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add more command option mnemonics (PR #155705)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/155705 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add more command option mnemonics (PR #155705)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/155705 >From e5a8bb8a2cf2154c805ef60c0a9e34973f0a27ea Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 27 Aug 2025 14:25:29 -0700 Subject: [PATCH] [lldb] Add more command option mnemonics Add a bunch o

[Lldb-commits] [lldb] [lldb] Add more command option mnemonics (PR #155705)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/155705 >From 4563155c402f458b3229b3bde37fac2cf50405a4 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 27 Aug 2025 14:25:29 -0700 Subject: [PATCH] [lldb] Add more command option mnemonics Add a bunch o

[Lldb-commits] [lldb] [lldb] Add a simplified syntax for underlying command options (NFC) (PR #155694)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/155694 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Delay creation of ConstStrings when parsing MachO symtab (PR #155931)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. ConstStrings are fast when comparing existing ones. But creating them is expensive because the string pool is global. Here we're parsing strings, so we always have to do a create + lookup. By using a StringMap, we can do a cheaper (no

[Lldb-commits] [lldb] [lldb] Add a simplified syntax for underlying command options (NFC) (PR #155694)

2025-08-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/155694 >From 2a337e37d28a1ce2d02d8605b148213125e0fa01 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 27 Aug 2025 13:49:07 -0700 Subject: [PATCH 1/3] [lldb] Add a simplified syntax for underlying comma

[Lldb-commits] [lldb] [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBaseName() (PR #155939)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/155939 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBaseName() (PR #155939)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/155939 >From 87e6eee01196c924f4fda1093eb961f37bb6088c Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 28 Aug 2025 15:50:29 -0700 Subject: [PATCH 1/4] [lldb] Add SBFunction::GetBaseName() & SBSymbol::G

[Lldb-commits] [lldb] [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBaseName() (PR #155939)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/155939 >From 87e6eee01196c924f4fda1093eb961f37bb6088c Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 28 Aug 2025 15:50:29 -0700 Subject: [PATCH 1/4] [lldb] Add SBFunction::GetBaseName() & SBSymbol::G

[Lldb-commits] [lldb] [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBaseName() (PR #155939)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/155939 >From 87e6eee01196c924f4fda1093eb961f37bb6088c Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 28 Aug 2025 15:50:29 -0700 Subject: [PATCH 1/3] [lldb] Add SBFunction::GetBaseName() & SBSymbol::G

[Lldb-commits] [lldb] [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBaseName() (PR #155939)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/155939 >From 87e6eee01196c924f4fda1093eb961f37bb6088c Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 28 Aug 2025 15:50:29 -0700 Subject: [PATCH 1/2] [lldb] Add SBFunction::GetBaseName() & SBSymbol::G

[Lldb-commits] [lldb] [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBaseName() (PR #155939)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/155939 >From 87e6eee01196c924f4fda1093eb961f37bb6088c Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 28 Aug 2025 15:50:29 -0700 Subject: [PATCH] [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBa

[Lldb-commits] [lldb] [lldb] Add SBFunction::GetBaseName() & SBSymbol::GetBaseName() (PR #155939)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/155939 When you are trying for instance to set a breakpoint on a function by name, but the SBFunction or SBSymbol are returning demangled names with argument lists, that match can be tedious to do. Internally, t

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
@@ -376,6 +382,147 @@ void Disassembler::PrintInstructions(Debugger &debugger, const ArchSpec &arch, } } + // Add variable location annotations to the disassembly output. + // + // For each instruction, this block attempts to resolve in-scope variables + // and dete

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
@@ -376,6 +382,147 @@ void Disassembler::PrintInstructions(Debugger &debugger, const ArchSpec &arch, } } + // Add variable location annotations to the disassembly output. + // + // For each instruction, this block attempts to resolve in-scope variables + // and dete

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
@@ -376,6 +382,147 @@ void Disassembler::PrintInstructions(Debugger &debugger, const ArchSpec &arch, } } + // Add variable location annotations to the disassembly output. + // + // For each instruction, this block attempts to resolve in-scope variables + // and dete

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
@@ -376,6 +382,147 @@ void Disassembler::PrintInstructions(Debugger &debugger, const ArchSpec &arch, } } + // Add variable location annotations to the disassembly output. + // + // For each instruction, this block attempts to resolve in-scope variables + // and dete

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
@@ -376,6 +382,147 @@ void Disassembler::PrintInstructions(Debugger &debugger, const ArchSpec &arch, } } + // Add variable location annotations to the disassembly output. + // + // For each instruction, this block attempts to resolve in-scope variables + // and dete

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
@@ -376,6 +382,147 @@ void Disassembler::PrintInstructions(Debugger &debugger, const ArchSpec &arch, } } + // Add variable location annotations to the disassembly output. + // + // For each instruction, this block attempts to resolve in-scope variables + // and dete

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
@@ -376,6 +382,147 @@ void Disassembler::PrintInstructions(Debugger &debugger, const ArchSpec &arch, } } + // Add variable location annotations to the disassembly output. + // + // For each instruction, this block attempts to resolve in-scope variables + // and dete

[Lldb-commits] [lldb] [llvm] Stateful variable-location annotations in Disassembler::PrintInstructions() (follow-up to #147460) (PR #152887)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
@@ -376,6 +382,147 @@ void Disassembler::PrintInstructions(Debugger &debugger, const ArchSpec &arch, } } + // Add variable location annotations to the disassembly output. + // + // For each instruction, this block attempts to resolve in-scope variables + // and dete

[Lldb-commits] [lldb] [lldb] Adjust ProtocolServer connection defaults. (PR #155714)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
@@ -161,6 +165,27 @@ FileSpec HostInfoBase::GetSystemPluginDir() { return g_fields->m_lldb_system_plugin_dir; } +FileSpec HostInfoBase::GetUserHomeDir() { + llvm::call_once(g_fields->m_lldb_user_home_dir_once, []() { +if (!HostInfo::ComputeUserHomeDirectory(g_fields->m_

[Lldb-commits] [lldb] [lldb] Adjust ProtocolServer connection defaults. (PR #155714)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
@@ -161,6 +165,27 @@ FileSpec HostInfoBase::GetSystemPluginDir() { return g_fields->m_lldb_system_plugin_dir; } +FileSpec HostInfoBase::GetUserHomeDir() { + llvm::call_once(g_fields->m_lldb_user_home_dir_once, []() { +if (!HostInfo::ComputeUserHomeDirectory(g_fields->m_

[Lldb-commits] [lldb] [lldb] Adjust ProtocolServer connection defaults. (PR #155714)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/155714 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Adjust ProtocolServer connection defaults. (PR #155714)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
@@ -1993,23 +1994,23 @@ bool CommandInterpreter::HandleCommand(const char *command_line, // Those will be collected by the on-exit-callback. }); - helper.DispatchOnExit([&cmd_obj, &parsed_command_args, &result, - detailed_command_telemetry, comm

[Lldb-commits] [lldb] [lldb] Adjust ProtocolServer connection defaults. (PR #155714)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/155714 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a simplified syntax for underlying command options (NFC) (PR #155694)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/155694 >From 2a337e37d28a1ce2d02d8605b148213125e0fa01 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 27 Aug 2025 13:49:07 -0700 Subject: [PATCH 1/2] [lldb] Add a simplified syntax for underlying comma

[Lldb-commits] [lldb] [lldb] Add lldb-mcp scaffolding (PR #155708)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Thank you! https://github.com/llvm/llvm-project/pull/155708 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add lldbHost dependency to lldbProtocolMCP (PR #155811)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/155811 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][debugserver] Upstream to debugserver changes (PR #155733)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/155733 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a simplified syntax for underlying command options (NFC) (PR #155694)

2025-08-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere reopened https://github.com/llvm/llvm-project/pull/155694 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix use after free on ModuleList::RemoveSharedModuleIfOrphaned (PR #155331)

2025-08-27 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Can we solve this by handing down a weak pointer to the module? That way we can check if the ref count has hit zero. https://github.com/llvm/llvm-project/pull/155331 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [lldb] [lldb] Adjust ProtocolServer connection defaults. (PR #155714)

2025-08-27 Thread Jonas Devlieghere via lldb-commits
@@ -104,6 +104,43 @@ llvm::Error ProtocolServerMCP::Start(ProtocolServer::Connection connection) { if (llvm::Error error = handles.takeError()) return error; + auto listening_uris = m_listener->GetListeningConnectionURI(); + if (listening_uris.empty()) +return cre

[Lldb-commits] [lldb] [lldb] Adjust ProtocolServer connection defaults. (PR #155714)

2025-08-27 Thread Jonas Devlieghere via lldb-commits
@@ -104,6 +104,43 @@ llvm::Error ProtocolServerMCP::Start(ProtocolServer::Connection connection) { if (llvm::Error error = handles.takeError()) return error; + auto listening_uris = m_listener->GetListeningConnectionURI(); + if (listening_uris.empty()) +return cre

[Lldb-commits] [lldb] [lldb] Adjust ProtocolServer connection defaults. (PR #155714)

2025-08-27 Thread Jonas Devlieghere via lldb-commits
@@ -14,11 +14,23 @@ #include "lldb/Protocol/MCP/Resource.h" #include "lldb/Protocol/MCP/Tool.h" #include "lldb/Protocol/MCP/Transport.h" +#include "lldb/lldb-types.h" #include "llvm/ADT/StringMap.h" #include "llvm/Support/Error.h" +#include "llvm/Support/JSON.h" namespace

[Lldb-commits] [lldb] [lldb] Correct a usage after a rename was merged. (PR #155720)

2025-08-27 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Thanks! https://github.com/llvm/llvm-project/pull/155720 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add lldb-mcp scaffolding (PR #155708)

2025-08-27 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/155708 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add lldb-mcp scaffolding (PR #155708)

2025-08-27 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/155708 >From 9c2db2349ffd5fdcbbb5ceebf2a72979dd2a2e88 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 27 Aug 2025 15:15:48 -0700 Subject: [PATCH 1/2] [lldb] Add lldb-mcp scaffolding Add the scaffoldin

[Lldb-commits] [lldb] [lldb] Add lldb-mcp scaffolding (PR #155708)

2025-08-27 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,80 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] NFC Moving mcp::Transport into its own file. (PR #155711)

2025-08-27 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Nice https://github.com/llvm/llvm-project/pull/155711 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add lldb-mcp scaffolding (PR #155708)

2025-08-27 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/155708 Add the scaffolding for a new tool lldb-mcp. This utility is meant to replace netcat and acts a proxy between the LLM and one or more LLDB instances. In its current form, the utility is a trivial MCP serve

[Lldb-commits] [lldb] [lldb] Add more command option mnemonics (PR #155705)

2025-08-27 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Depends on https://github.com/llvm/llvm-project/pull/155694 https://github.com/llvm/llvm-project/pull/155705 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add more command option mnemonics (PR #155705)

2025-08-27 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/155705 Add a bunch of mnemonics to the command options now that they're highlighted in the help output. >From f4c41d2f40eb06457a7147191d88f2d32308876c Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed,

[Lldb-commits] [lldb] [lldb] Underline short option letters as mnemonics (PR #153695)

2025-08-27 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Created a PR to simplify the syntax in the tabelgen files: https://github.com/llvm/llvm-project/pull/155694 https://github.com/llvm/llvm-project/pull/153695 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [lldb] [lldb] Add a simplified syntax for underlying command options (NFC) (PR #155694)

2025-08-27 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/155694 This PR updates the tablegen emitter for command options to support a simplified syntax to underline the mnemonic. Previously, you had to write `${ansi.underline}${ansi.normal}`, where `` is the mnemonic.

[Lldb-commits] [lldb] [lldb-dap] Improving lldbdap_testcase.py error diagnosability (PR #155352)

2025-08-26 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/155352 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Corretly parse Wasm segments (PR #154727)

2025-08-26 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/154727 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Adding structured types for existing MCP calls. (PR #155460)

2025-08-26 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: 🚢 https://github.com/llvm/llvm-project/pull/155460 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Improving lldbdap_testcase.py error diagnosability (PR #155352)

2025-08-26 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: Looks good. Are there other places where this would be applicable? If so, maybe we can turn this into a little helper? If not then this is fine. https://github.com/llvm/llvm-project/pull/155352 ___ lldb-commi

[Lldb-commits] [lldb] [lldb] Underline short option letters as mnemonics (PR #153695)

2025-08-26 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/153695 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix use after free on ModuleList::RemoveSharedModuleIfOrphaned (PR #155331)

2025-08-25 Thread Jonas Devlieghere via lldb-commits
@@ -2564,9 +2564,12 @@ ModuleSP Target::GetOrCreateModule(const ModuleSpec &orig_module_spec, m_images.Append(module_sp, notify); for (ModuleSP &old_module_sp : replaced_modules) { + auto use_count = old_module_sp.use_count(); Module *old

[Lldb-commits] [lldb] [lldb] Fix use after free on ModuleList::RemoveSharedModuleIfOrphaned (PR #155331)

2025-08-25 Thread Jonas Devlieghere via lldb-commits
@@ -2564,9 +2564,12 @@ ModuleSP Target::GetOrCreateModule(const ModuleSpec &orig_module_spec, m_images.Append(module_sp, notify); for (ModuleSP &old_module_sp : replaced_modules) { + auto use_count = old_module_sp.use_count(); Module *old

[Lldb-commits] [lldb] [lldb-dap] Improving lldbdap_testcase.py error diagnosability and adding exception handling for dap server disconnect and terminations (PR #155335)

2025-08-25 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/155335 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Improving lldbdap_testcase.py error diagnosability and adding exception handling for dap server disconnect and terminations (PR #155335)

2025-08-25 Thread Jonas Devlieghere via lldb-commits
@@ -466,8 +466,15 @@ def attach( # if we throw an exception during the test case. def cleanup(): if disconnectAutomatically: -self.dap_server.request_disconnect(terminateDebuggee=True) -self.dap_server.terminate() +

[Lldb-commits] [lldb] [lldb-dap] Improving lldbdap_testcase.py error diagnosability and adding exception handling for dap server disconnect and terminations (PR #155335)

2025-08-25 Thread Jonas Devlieghere via lldb-commits
@@ -466,8 +466,15 @@ def attach( # if we throw an exception during the test case. def cleanup(): if disconnectAutomatically: -self.dap_server.request_disconnect(terminateDebuggee=True) -self.dap_server.terminate() +

[Lldb-commits] [lldb] [lldb-dap] Improving lldbdap_testcase.py error diagnosability and adding exception handling for dap server disconnect and terminations (PR #155335)

2025-08-25 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: Thanks for the contribution! We generally prefer small, self contained patches and since the two changes are orthogonal, please create a separate PR for the second change. https://github.com/llvm/llvm-project/pull/155335 __

[Lldb-commits] [lldb] Revert "[lldb] Adopt JSONTransport in the MCP Server" (PR #155280)

2025-08-25 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/155280 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Adopt JSONTransport in the MCP Server" (PR #155280)

2025-08-25 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/155280 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Adopt JSONTransport in the MCP Server" (PR #155280)

2025-08-25 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/155280 Reverts llvm/llvm-project#155034 >From 78f99109489d5eff6aa33a82ad96c4bc3c762213 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 25 Aug 2025 12:33:47 -0700 Subject: [PATCH] Revert "[lldb] Adopt

[Lldb-commits] [lldb] [lldb] Adopt JSONTransport in the MCP Server (PR #155034)

2025-08-25 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Looks like the test is flakey: it failed on the first build, then passed, then failed again. https://github.com/llvm/llvm-project/pull/155034 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[Lldb-commits] [lldb] [lldb] Adopt JSONTransport in the MCP Server (PR #155034)

2025-08-25 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: `ProtocolServerMCPTest.ToolsCallFail` failed on the Debian bot but I can't reproducice this on Darwin or Linux. https://github.com/llvm/llvm-project/pull/155034 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [lldb] [lldb] Adopt JSONTransport in the MCP Server (PR #155034)

2025-08-25 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/155034 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Adopt JSONTransport in the MCP Server (PR #155034)

2025-08-25 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/155034 >From 3020f2922fc4556b4031c412ecfde62678a5ea33 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 22 Aug 2025 14:30:08 -0700 Subject: [PATCH 1/2] [lldb] Adopt JSONTransport in the MCP Server This

[Lldb-commits] [lldb] [lldb-dap] improve symbol table style (PR #155097)

2025-08-25 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/155097 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/crashlog] Implement speculative binary lookup for target creation (PR #154975)

2025-08-22 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/154975 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/crashlog] Implement speculative binary lookup for target creation (PR #154975)

2025-08-22 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere requested changes to this pull request. I don't think it's appropriate for the crashlog script to recursive through someone's home directory. This is going to result in TCC (Transparency Consent and Control) popups when trying to access certain directories (like

[Lldb-commits] [lldb] [lldb] Add utility to create Mach-O corefile from YAML desc (PR #153911)

2025-08-22 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,223 @@ +//===-- main.cppp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Add utility to create Mach-O corefile from YAML desc (PR #153911)

2025-08-22 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,55 @@ +//===-- CoreSpec.h ===// JDevlieghere wrote: Nit: new files shouldn't use this ASCII art anymore: https://discourse.llvm.org/t/is-c-in-header-files-still-relevant/83124 ```suggestion //==

[Lldb-commits] [lldb] [lldb] Add utility to create Mach-O corefile from YAML desc (PR #153911)

2025-08-22 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,14 @@ +add_lldb_tool(yaml2macho-core +main.cpp +yaml2corespec.cpp JDevlieghere wrote: Nit: filename suggestions. ```suggestion yaml2macho.cpp CoreSpec.cpp ``` https://github.com/llvm/llvm-project/pull/153911 _

[Lldb-commits] [lldb] [lldb] Add utility to create Mach-O corefile from YAML desc (PR #153911)

2025-08-22 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,22 @@ +//===-- Utility.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add utility to create Mach-O corefile from YAML desc (PR #153911)

2025-08-22 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,55 @@ +//===-- CoreSpec.h ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add utility to create Mach-O corefile from YAML desc (PR #153911)

2025-08-22 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,55 @@ +//===-- LCNoteWriter.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add utility to create Mach-O corefile from YAML desc (PR #153911)

2025-08-22 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,55 @@ +//===-- LCNoteWriter.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add utility to create Mach-O corefile from YAML desc (PR #153911)

2025-08-22 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: I know this is a simple tool, but it seems like adding a bit of organization could go a long way. Essentially, the tool consists of 3 parts: 1. A reader that takes YAML and creates an in-memory/intermediate representation (CoreSpec). 2. A writer that

[Lldb-commits] [lldb] [lldb] Add utility to create Mach-O corefile from YAML desc (PR #153911)

2025-08-22 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/153911 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/API] Add setters to SBStructuredData (PR #154445)

2025-08-21 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/154445 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][debugserver] update --help to list all the options (PR #154853)

2025-08-21 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Nice 📚 https://github.com/llvm/llvm-project/pull/154853 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reapply "[lldb-dap] Re-land refactor of DebugCommunication. (#147787)" (PR #154832)

2025-08-21 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/154832 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Corretly parse Wasm segments (PR #154727)

2025-08-21 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/154727 >From defb8e0fe69009362537b3e2c9c05c4eac544505 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 21 Aug 2025 03:25:19 -0700 Subject: [PATCH] [lldb] Corretly parse Wasm segments My original implem

[Lldb-commits] [lldb] [lldb] Fix source line annotations for libsanitizers traces (PR #154247)

2025-08-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/154247 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   3   4   5   6   7   8   9   10   >