https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/115408
None
>From db9978e0bf8ce26a71eb73393c4951d14cdbd510 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 7 Nov 2024 17:18:50 -0800
Subject: [PATCH] [lldb] Support riscv32 corefiles
---
.../Plugins
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/115382
>From b5947cfe8fd7702f801c91f48ca050a5c839a707 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 7 Nov 2024 14:08:50 -0800
Subject: [PATCH 1/3] [lldb] Support overriding the disassembly CPU & feat
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/115382
Add the ability to override the disassembly CPU and CPU features through a
target setting (`target.disassembly-cpu` and
`target.disassembly-features`) and a `disassemble` command option (`--cpu` and
`--fea
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/115288
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM. Lua doesn't guarantee compatibility between minor versions to Lua 5.3 and
5.4 are more like Python 2 and Python 3 rather than Python 3.9 and 3.11 for
example. I might try to get it working with both at some point (mostly because
@@ -9,21 +9,27 @@
#ifndef LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
#define LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
-#include "llvm/Support/JSON.h"
#include
+#include "llvm/Support/JSON.h"
+
+#include "DAPForward.h"
JDevlieghere wrote:
This should follow LLVM's [
Author: Jonas Devlieghere
Date: 2024-11-06T15:16:20-08:00
New Revision: bd3a3959dc5b72ccbc83334132dece3f38957666
URL:
https://github.com/llvm/llvm-project/commit/bd3a3959dc5b72ccbc83334132dece3f38957666
DIFF:
https://github.com/llvm/llvm-project/commit/bd3a3959dc5b72ccbc83334132dece3f38957666.d
Author: Jonas Devlieghere
Date: 2024-11-06T09:59:35-08:00
New Revision: 4d4024e1edf354113e8d0d11661d466ae5b0bee7
URL:
https://github.com/llvm/llvm-project/commit/4d4024e1edf354113e8d0d11661d466ae5b0bee7
DIFF:
https://github.com/llvm/llvm-project/commit/4d4024e1edf354113e8d0d11661d466ae5b0bee7.d
Author: Jonas Devlieghere
Date: 2024-11-05T18:05:33-08:00
New Revision: 7c20bdf373d6cd7f35dee5c71cf94f0eb1be3200
URL:
https://github.com/llvm/llvm-project/commit/7c20bdf373d6cd7f35dee5c71cf94f0eb1be3200
DIFF:
https://github.com/llvm/llvm-project/commit/7c20bdf373d6cd7f35dee5c71cf94f0eb1be3200.d
Author: Jonas Devlieghere
Date: 2024-11-04T13:32:22-08:00
New Revision: a57296ad411a75c1376458f6b09cb75128c6e785
URL:
https://github.com/llvm/llvm-project/commit/a57296ad411a75c1376458f6b09cb75128c6e785
DIFF:
https://github.com/llvm/llvm-project/commit/a57296ad411a75c1376458f6b09cb75128c6e785.d
Author: Jonas Devlieghere
Date: 2024-11-04T11:55:09-08:00
New Revision: 8f8e2b732635f03dc646a3c98db0b58a051745b8
URL:
https://github.com/llvm/llvm-project/commit/8f8e2b732635f03dc646a3c98db0b58a051745b8
DIFF:
https://github.com/llvm/llvm-project/commit/8f8e2b732635f03dc646a3c98db0b58a051745b8.d
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/114807
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -64,3 +64,10 @@ else()
Python3_EXECUTABLE
LLDB_ENABLE_SWIG)
endif()
+
+set(LLDB_RECOMMENDED_PYTHON "3.8")
+if(Python3_LIBRARIES AND Python3_INCLUDE_DIRS AND Python3_EXECUTABLE AND
LLDB_ENABLE_SWIG
-
JDevlieghere wrote:
Seems like this might be causing GreenDragon to time out. Reverted to see if
that resolves the issue. I also had to revert #114507 as it depends on this.
https://github.com/llvm/llvm-project/pull/114576
___
lldb-commits mailing li
Author: Jonas Devlieghere
Date: 2024-11-03T12:34:47-08:00
New Revision: 4c8cc5a63b636c05f35cd8dab2c9e10686f40ea6
URL:
https://github.com/llvm/llvm-project/commit/4c8cc5a63b636c05f35cd8dab2c9e10686f40ea6
DIFF:
https://github.com/llvm/llvm-project/commit/4c8cc5a63b636c05f35cd8dab2c9e10686f40ea6.d
Author: Jonas Devlieghere
Date: 2024-11-03T12:34:52-08:00
New Revision: 74b56c7eb807e2ba54bd7a2bcfda5d0bceff1c0c
URL:
https://github.com/llvm/llvm-project/commit/74b56c7eb807e2ba54bd7a2bcfda5d0bceff1c0c
DIFF:
https://github.com/llvm/llvm-project/commit/74b56c7eb807e2ba54bd7a2bcfda5d0bceff1c0c.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/114507
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1608,9 +1612,48 @@ void Target::SetExecutableModule(ModuleSP &executable_sp,
if (image_module_sp) {
added_modules.AppendIfNeeded(image_module_sp, false);
ObjectFile *objfile = image_module_sp->GetObjectFile();
- if (objfile)
-
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/114610
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1608,9 +1612,28 @@ void Target::SetExecutableModule(ModuleSP &executable_sp,
if (image_module_sp) {
added_modules.AppendIfNeeded(image_module_sp, false);
ObjectFile *objfile = image_module_sp->GetObjectFile();
- if (objfile)
+ i
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/114507
>From 9a269fa83cea529f704c9eba339eac9987032155 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 31 Oct 2024 21:42:38 -0700
Subject: [PATCH 1/3] [lldb] Create dependent modules in parallel
MIME-Ve
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/114576
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -48,7 +48,10 @@ PathMappingList::PathMappingList(const PathMappingList &rhs)
const PathMappingList &PathMappingList::operator=(const PathMappingList &rhs) {
if (this != &rhs) {
-std::scoped_lock
locks(m_mutex, rhs.m_mutex);
+std::scoped_lock pairs_locks(m_pairs_m
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/114576
>From 9ebfdc84c46a795d35b4dd157573b97a57b232ce Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 1 Nov 2024 09:58:28 -0700
Subject: [PATCH 1/2] [lldb] Improve locking in PathMappingLists (NFC)
In
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/114610
>From ef1aaf94b52726c77e5569c84c09ecdd73811abd Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 1 Nov 2024 15:02:59 -0700
Subject: [PATCH] [lldb] Highlight "note:" in CommandReturnObject
We have
@@ -101,6 +101,10 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
// Add a hint if object description was requested, but no description
// function was implemented.
auto maybe_add_hint = [&](llvm::StringRef output) {
+static bool note_shown = false;
+
JDevlieghere wrote:
Motivated by #114608
https://github.com/llvm/llvm-project/pull/114610
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/114610
We have helpers to emit warnings and errors. Do the same thing for notes to
they stand out more.
>From 155396aa89fd418268cfcf8d054849c67bf1207e Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri,
Author: Jonas Devlieghere
Date: 2024-11-01T11:06:18-07:00
New Revision: 16a6c10bd485979ba2edf4b487d633230a9df01f
URL:
https://github.com/llvm/llvm-project/commit/16a6c10bd485979ba2edf4b487d633230a9df01f
DIFF:
https://github.com/llvm/llvm-project/commit/16a6c10bd485979ba2edf4b487d633230a9df01f.d
Author: Jonas Devlieghere
Date: 2024-11-01T11:03:19-07:00
New Revision: f33b5b79372c7a46e2e6b89a314bce0009bf4ab7
URL:
https://github.com/llvm/llvm-project/commit/f33b5b79372c7a46e2e6b89a314bce0009bf4ab7
DIFF:
https://github.com/llvm/llvm-project/commit/f33b5b79372c7a46e2e6b89a314bce0009bf4ab7.d
@@ -1608,9 +1612,28 @@ void Target::SetExecutableModule(ModuleSP &executable_sp,
if (image_module_sp) {
added_modules.AppendIfNeeded(image_module_sp, false);
ObjectFile *objfile = image_module_sp->GetObjectFile();
- if (objfile)
+ i
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/114507
>From 9a269fa83cea529f704c9eba339eac9987032155 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 31 Oct 2024 21:42:38 -0700
Subject: [PATCH 1/3] [lldb] Create dependent modules in parallel
MIME-Ve
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/114576
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
The test failures were both caused by the locking in `PathMappingList`, which
I'm addressing in #114576.
https://github.com/llvm/llvm-project/pull/114507
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/114576
In D148380 [1], Alex added locking to PathMappingLists. The current
implementation runs the callback under the lock, which I don't believe is
necessary. As far as I can tell, no users of the callback are r
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/114507
>From 9a269fa83cea529f704c9eba339eac9987032155 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 31 Oct 2024 21:42:38 -0700
Subject: [PATCH 1/2] [lldb] Create dependent modules in parallel
MIME-Ve
JDevlieghere wrote:
CC @DmT021
https://github.com/llvm/llvm-project/pull/114507
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/114507
Create dependent modules in parallel in Target::SetExecutableModule. This
change was inspired by #110646 which takes the same approach when attaching.
Jason suggested we could use the same approach when yo
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/114478
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM. Thanks!
https://github.com/llvm/llvm-project/pull/114303
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/114455
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1537,6 +1538,154 @@ static void LoadScriptingResourceForModule(const
ModuleSP &module_sp,
feedback_stream.GetData());
}
+static void ForEachFormatterInModule(
+Module &module, SectionType section_type,
+std::functi
JDevlieghere wrote:
> This might not be the right setting to ask this, but is there a plan to use
> one of the PDB parsers over the other? Would it make sense to add this as an
> option to lldb-test and the like instead of continuing to rely on an
> environment variable?
The goal is to have o
@@ -265,6 +265,7 @@ class SymbolFileNativePDB : public SymbolFileCommon {
// UID for anonymous union and anonymous struct as they don't have entities
in
// pdb debug info.
lldb::user_id_t anonymous_id = LLDB_INVALID_UID - 1;
+ std::optional m_cu_count = 0;
-
@@ -1537,6 +1538,154 @@ static void LoadScriptingResourceForModule(const
ModuleSP &module_sp,
feedback_stream.GetData());
}
+static void ForEachFormatterInModule(
JDevlieghere wrote:
Target seems like a weird
@@ -1810,7 +1813,27 @@
SymbolFileNativePDB::ParseVariablesForCompileUnit(CompileUnit &comp_unit,
VariableList &variables) {
PdbSymUid sym_uid(comp_unit.GetID());
lldbassert(sym_uid.kind() == PdbSymUidKind::Compiland);
- re
@@ -888,7 +888,8 @@ VariableSP
SymbolFileNativePDB::CreateGlobalVariable(PdbGlobalSymId var_id) {
CompUnitSP comp_unit;
std::optional modi = m_index->GetModuleIndexForVa(addr);
- if (!modi) {
+ // Some globals has modi points to the linker module, ignore them.
+ if (!m
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/114455
Lit allows you to set environment variables for all tests in a directory using
a `lit.local.cfg` file. Do this for the PDB and NativePDB tests.
>From 3788c30d90499dd9c109b258cae38eb2cb1996a3 Mon Sep 17 00:
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/114346
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/114286
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-10-31T10:39:48-07:00
New Revision: 88591aa0ca7e4d99da353d49f91ea63e43fb55e0
URL:
https://github.com/llvm/llvm-project/commit/88591aa0ca7e4d99da353d49f91ea63e43fb55e0
DIFF:
https://github.com/llvm/llvm-project/commit/88591aa0ca7e4d99da353d49f91ea63e43fb55e0.d
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/114346
>From 2d4b486202194166471ccafd97ff63c399b2e822 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 30 Oct 2024 20:34:04 -0700
Subject: [PATCH 1/2] [lldb] Use PY_VERSION_HEX to simplify conditional
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/114286
>From cb898b4f2f0cedfa7674f5b5cdcf2963dce377e4 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 30 Oct 2024 11:22:20 -0700
Subject: [PATCH 1/2] [lldb] Add a fuzzer for the DWARF Expression Evalua
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/114346
Use PY_VERSION_HEX to simplify conditional compilation depending on the Python
version.
This also adds a static_assert to lldb-python to error out with a meaningful
diagnostic when you try building LLDB w
Author: Jonas Devlieghere
Date: 2024-10-30T20:33:28-07:00
New Revision: 75aaa312ffa9aa044b84bd1b32491937795c110a
URL:
https://github.com/llvm/llvm-project/commit/75aaa312ffa9aa044b84bd1b32491937795c110a
DIFF:
https://github.com/llvm/llvm-project/commit/75aaa312ffa9aa044b84bd1b32491937795c110a.d
Author: Jonas Devlieghere
Date: 2024-10-30T18:48:43-07:00
New Revision: de7ad6b6820a265160507f8c6cf8ce5e07c4d5d8
URL:
https://github.com/llvm/llvm-project/commit/de7ad6b6820a265160507f8c6cf8ce5e07c4d5d8
DIFF:
https://github.com/llvm/llvm-project/commit/de7ad6b6820a265160507f8c6cf8ce5e07c4d5d8.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/114289
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -92,7 +92,38 @@ namespace {
struct InitializePythonRAII {
public:
InitializePythonRAII() {
-InitializePythonHome();
+#if (PY_MAJOR_VERSION == 3 && PY_MINOR_VERSION >= 8) || (PY_MAJOR_VERSION > 3)
+PyConfig config;
+PyConfig_InitPythonConfig(&config);
+#endif
+
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/112582
>From de19f43fbee9aff2a99106a23b7f264012ab5485 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon, 21 Oct 2024 13:40:02 -0700
Subject: [PATCH 1/2] [lldb] Use LLVM's helper for Unicode conversion (NF
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/114251
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/114112
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/114112
>From c58438160c016841c6a72e53cd5c4985ebd1e521 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 29 Oct 2024 11:19:33 -0700
Subject: [PATCH 1/3] [lldb] Use Py_InitializeFromConfig with Python >= 3
@@ -117,15 +148,22 @@ struct InitializePythonRAII {
PyImport_AppendInittab("_lldb", LLDBSwigPyInit);
}
+#if (PY_MAJOR_VERSION == 3 && PY_MINOR_VERSION >= 8) || (PY_MAJOR_VERSION > 3)
+config.install_signal_handlers = 0;
+Py_InitializeFromConfig(&config);
+
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/114161
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/114136
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/114136
Found by my POC DWARF expression evaluation fuzzer.
>From b4f93c43634ac4a20693da560522f3b13a516ac7 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 29 Oct 2024 15:13:19 -0700
Subject: [PATCH] [
@@ -209,7 +209,7 @@ template class PluginInstances {
Instance instance =
Instance(name, description, callback, std::forward(args)...);
m_instances.push_back(instance);
JDevlieghere wrote:
While you're here... :-) Should this use `emplace_back`
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/114120
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/114112
>From c58438160c016841c6a72e53cd5c4985ebd1e521 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 29 Oct 2024 11:19:33 -0700
Subject: [PATCH 1/2] [lldb] Use Py_InitializeFromConfig with Python >= 3
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/114112
This fixes the deprecation warning for Py_SetPythonHome, which was deprecated
in Python 3.11. With this patch, when building against Python 3.8 or later, we
now use Py_InitializeFromConfig instead.
Fixes
JDevlieghere wrote:
CC @R-Goc
https://github.com/llvm/llvm-project/pull/114112
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
🥳
https://github.com/llvm/llvm-project/pull/113980
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
Friendly ping
https://github.com/llvm/llvm-project/pull/112582
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/114087
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-10-29T09:45:29-07:00
New Revision: 2ab98dfe19ac384f0cfac1a1fafc56b9dd7ad9b7
URL:
https://github.com/llvm/llvm-project/commit/2ab98dfe19ac384f0cfac1a1fafc56b9dd7ad9b7
DIFF:
https://github.com/llvm/llvm-project/commit/2ab98dfe19ac384f0cfac1a1fafc56b9dd7ad9b7.d
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/113839
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
Interesting. Based on a conversation at the dev meeting, I was under the
impression that the DIA-based implementation was in worse shape and the native
one in better shape. I also have a memory of bug reports about PDB parsing
where originators were asked to check with `LLD
JDevlieghere wrote:
The GitHub UI made it a lot easier to spot missing libraries. I'm pretty sure
I've got them all. It doesn't lead to an error because we link everything
together anyway, but it's still the right thing to do. I also had to rebase the
PR.
https://github.com/llvm/llvm-project
JDevlieghere wrote:
@labath FYI this is ready for review.
https://github.com/llvm/llvm-project/pull/112582
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/113393
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/113593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
Given that most of these files start with 1st ValueObject` I felt like that was
the better name for the library, rather than DIL which doesn't exist yet. I'm
fine with putting the DIL implementation in the new ValueObject library
(potentially in a DIL subdirectory) or keep
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/113393
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> It appears that in all the .h files that you moved from Core to ValueObject,
> you did not update the ifdef variable at the top of the file? I would have
> expected, e.g. that "LLDB_CORE_VALUEOBJECT_H" should be changed to
> "LLDB_VALUEOBJECT_VALUEOBJECT_H". Shouldn't it?
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/111911
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -43,6 +43,10 @@ char TeeLogHandler::ID;
llvm::ManagedStatic Log::g_channel_map;
+// The error log is used by LLDB_LOG_ERROR and LLDB_LOG_ERRORV. If the given
JDevlieghere wrote:
Already fixed in the latest version of this PR :-)
https://github.com/llvm/
@@ -5066,3 +5066,17 @@ llvm::json::Value
Target::ReportStatistics(const lldb_private::StatisticsOptions &options) {
return m_stats.ToJSON(*this, options);
}
+
+bool Target::SectionLoadListIsEmpty() const {
+ return const_cast(this)->GetSectionLoadList().IsEmpty();
--
https://github.com/JDevlieghere commented:
Protecting the section load list seems reasonable. I left one inline comment +
this needs to be `clang-format`'ed.
https://github.com/llvm/llvm-project/pull/113278
___
lldb-commits mailing list
lldb-commits@
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/113278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/113248
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
Can you reference documentation about the `.native` import and explain why this
is necessary? Intuitively it makes sense but I want to make sure I fully
understand this change and having it documented will help the next person that
sees this.
https:
@@ -145,7 +145,7 @@ add_lldb_library(liblldb SHARED ${option_framework}
${option_install_prefix}
)
-# lib/pythonX.Y/dist-packages/lldb/_lldb.so is a symlink to lib/liblldb.so,
+# lib/pythonX.Y/site-packages/lldb/_lldb.so is a symlink to lib/liblldb.so,
JDevl
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/113066
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/113220
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/112582
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/112582
>From de19f43fbee9aff2a99106a23b7f264012ab5485 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon, 21 Oct 2024 13:40:02 -0700
Subject: [PATCH] [lldb] Use LLVM's helper for Unicode conversion (NFC)
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/112582
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-10-21T11:37:26-07:00
New Revision: 40ea92c859234d536553cf26650e89d6e52071c6
URL:
https://github.com/llvm/llvm-project/commit/40ea92c859234d536553cf26650e89d6e52071c6
DIFF:
https://github.com/llvm/llvm-project/commit/40ea92c859234d536553cf26650e89d6e52071c6.d
JDevlieghere wrote:
Now that the system log is a Darwin-only concept and the review comments have
been addressed, I assume nobody objects to merging this?
https://github.com/llvm/llvm-project/pull/111911
___
lldb-commits mailing list
lldb-commits@lis
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/113166
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 1220 matches
Mail list logo
