[Lldb-commits] [PATCH] D156270: [lldb][NFCI] Change logic to find clang resource dir in standalone builds

paperchalice added a comment. When I made D141907 , I want `get_clang_resource_dir` in cmake and GetResourcesPath in clang to have the same behavior and it also respects the doc string

[Lldb-commits] [PATCH] D152225: [lldb] fix dangling reference in `ClangHost.cpp`

paperchalice added a comment. If this patch fixes the CI failure , I need someone to commit this change, thanks in advance.

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice added a comment. In D141907#4398196 , @protze.joachim wrote: > The review should not be closed, since the patch was reverted and should be > recommitted (this time possibly with a reference to this review?) This is recommitted as

[Lldb-commits] [PATCH] D152225: [lldb] mark `clang_resource_path` as static

paperchalice created this revision. paperchalice added a reviewer: aprantl. Herald added a project: All. paperchalice requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The lifetime of `clang_resource_path` should be same as

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice added a comment. In D141907#4361594 , @tstellar wrote: > In D141907#4355229 , @paperchalice > wrote: > >> In D141907#4355228 , @tstellar >> wrote: >> >>>

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice added a comment. In D141907#4355228 , @tstellar wrote: > @paperchalice Do you need someone to commit this for you? Sure, I don't have the commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice added inline comments. Comment at: cmake/Modules/GetClangResourceDir.cmake:13 + if(DEFINED CLANG_RESOURCE_DIR AND NOT CLANG_RESOURCE_DIR STREQUAL "") +set(ret_dir bin/${CLANG_RESOURCE_DIR}) + else() tstellar wrote: > tstellar wrote: > >

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice added inline comments. Comment at: cmake/Modules/GetClangResourceDir.cmake:13 + if(DEFINED CLANG_RESOURCE_DIR AND NOT CLANG_RESOURCE_DIR STREQUAL "") +set(ret_dir bin/${CLANG_RESOURCE_DIR}) + else() tstellar wrote: > Why is the bin prefix

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice added a comment. Ping. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangHost.cpp:56 + const std::string clang_resource_path = + clang::driver::Driver::GetResourcesPath("bin/lldb", CLANG_RESOURCE_DIR); Should be

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice updated this revision to Diff 494223. paperchalice added a comment. - Use `clang::driver::Driver::GetResourcesPath` - Use `ARG` as prefix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141907/new/ https://reviews.llvm.org/D141907

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice added a comment. In D141907#4094748 , @MaskRay wrote: > The CMake part of this patch improves the matter. Manually constructed > resource dir (many duplicates) string is replace with a library function call. > > However, the introduced