[Lldb-commits] [PATCH] D156066: [lldb][LocateModuleCallback] Call locate module callback in Platform too

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c61c9b02b49: [lldb][LocateModuleCallback] Call locate module callback in Platform too (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D156066: [lldb][LocateModuleCallback] Call locate module callback in Platform too

splhack updated this revision to Diff 543329. splhack added a comment. Remove wrong comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156066/new/ https://reviews.llvm.org/D156066 Files: lldb/include/lldb/Target/Platform.h

[Lldb-commits] [PATCH] D156066: [lldb][LocateModuleCallback] Call locate module callback in Platform too

splhack created this revision. splhack added reviewers: clayborg, jingham, bulbazord, jasonmolenda, JDevlieghere, mib. Herald added a project: All. splhack requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is an enhancement for the

[Lldb-commits] [PATCH] D155333: [lldb][LocateModuleCallback] Fix LocateModuleCallbackTest

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG39299f0d367d: [lldb][LocateModuleCallback] Fix LocateModuleCallbackTest (authored by splhack). Repository: rG LLVM

[Lldb-commits] [PATCH] D155333: [lldb][LocateModuleCallback] Fix FileSpec compare

splhack added a comment. @jasonmolenda thank you for looking into this! I was finally able to repro the test failure on arm64 macOS with this diff (the version with `ASSERT_EQ(a_file_spec.GetPath(), b_file_spec.GetPath()`) and this CMake config. cmake \ ../llvm \ -G Ninja \

[Lldb-commits] [PATCH] D155333: [lldb][LocateModuleCallback] Fix FileSpec compare

splhack updated this revision to Diff 540648. splhack added a comment. Tear down the module cache. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155333/new/ https://reviews.llvm.org/D155333 Files:

[Lldb-commits] [PATCH] D155333: [lldb][LocateModuleCallback] Fix FileSpec compare

splhack updated this revision to Diff 540594. splhack added a comment. Use GetPath() instead of Compare(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155333/new/ https://reviews.llvm.org/D155333 Files:

[Lldb-commits] [PATCH] D155333: [lldb][LocateModuleCallback] Fix FileSpec compare

splhack added a comment. thanks @JDevlieghere @jasonmolenda, yeah `GetPath()` makes sense it could show the mismatch in human readable form. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155333/new/ https://reviews.llvm.org/D155333

[Lldb-commits] [PATCH] D153734: [lldb][LocateModuleCallback] Call locate module callback

splhack added a comment. D155333 should fix the flaky arm64 tests by replacing `ASSERT_EQ(FileSpec, FileSpec)` with `ASSERT_EQ(FileSpec::Compare(FileSpec, FileSpec, true), 0)`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D155333: [lldb][LocateModuleCallback] Fix FileSpec compare

splhack created this revision. splhack added reviewers: clayborg, jingham, bulbazord, jasonmolenda, JDevlieghere, rastogishubham. Herald added a subscriber: kristof.beyls. Herald added a project: All. splhack requested review of this revision. Herald added a project: LLDB. Herald added a

[Lldb-commits] [PATCH] D153734: [lldb][LocateModuleCallback] Call locate module callback

splhack added a comment. ok, sounds like ASSERT_EQ FileSpec does not work on Linux aarch64. will use FileSpec::Compare and double check on Linux aarch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153734/new/ https://reviews.llvm.org/D153734

[Lldb-commits] [PATCH] D155124: [lldb][Windows] Fix TestLocateModuleCallback

This revision was automatically updated to reflect the committed changes. Closed by commit rG43b9d62018fe: [lldb][Windows] Fix TestLocateModuleCallback (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155124/new/

[Lldb-commits] [PATCH] D153734: [lldb][LocateModuleCallback] Call locate module callback

splhack added a comment. @rastogishubham let me check. btw I'll commit D155124 to fix Windows tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153734/new/ https://reviews.llvm.org/D153734

[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

splhack added a comment. In D153735#4494999 , @splhack wrote: > https://lab.llvm.org/buildbot/#/builders/219/builds/4084 > > now fixing Windows tests. D155124 should fix the Windows test failures. Repository: rG

[Lldb-commits] [PATCH] D155135: [lldb][LocateModuleCallback] Fix LocateModuleCallbackTest

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb087c17c823: [lldb][LocateModuleCallback] Fix LocateModuleCallbackTest (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155135/new/

[Lldb-commits] [PATCH] D155135: [lldb][LocateModuleCallback] Fix LocateModuleCallbackTest

splhack added a comment. @jasonmolenda thanks for verifying this! and yes, I didn't realize `-DLLVM_ENABLE_ASSERTIONS=1` is missing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155135/new/ https://reviews.llvm.org/D155135

[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

splhack added a comment. @jasonmolenda D155135 should fix the `Debugger::CreateInstance` assert. (The assert does not repro locally though) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153735/new/

[Lldb-commits] [PATCH] D155135: [lldb][LocateModuleCallback] Fix LocateModuleCallbackTest

splhack created this revision. splhack added reviewers: clayborg, jingham, bulbazord, jasonmolenda, JDevlieghere, mib. Herald added a project: All. splhack requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. D153734

[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

splhack added a comment. I'm checking other `Debugger::CreateInstance` calls in unittests. Looks like it needs to call `Platform::SetHostPlatform` which is missing in LocateModuleCallbackTest.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

splhack added a comment. @jasonmolenda thanks for the report. let me check. At least `ninja check-lldb-unit check-lldb-api-python_api-sbplatform` is ok on macOS arm64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153735/new/

[Lldb-commits] [PATCH] D155124: [lldb][Windows] Fix TestLocateModuleCallback

splhack created this revision. splhack added reviewers: clayborg, jingham, bulbazord, jasonmolenda, JDevlieghere, mib. Herald added a project: All. splhack requested review of this revision. Herald added subscribers: lldb-commits, wangpc. Herald added a project: LLDB. D153735

[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

splhack added a comment. https://lab.llvm.org/buildbot/#/builders/219/builds/4084 now fixing Windows tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153735/new/ https://reviews.llvm.org/D153735

[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

This revision was automatically updated to reflect the committed changes. Closed by commit rGf03dbdb70aed: [lldb][LocateModuleCallback] Implement API, Python interface (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153735/new/

[Lldb-commits] [PATCH] D153734: [lldb][LocateModuleCallback] Call locate module callback

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f1028e9df52: [lldb][LocateModuleCallback] Call locate module callback (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153734/new/

[Lldb-commits] [PATCH] D153733: [lldb][LocateModuleCallback] Update SBFileSpec/SBModuleSpec

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4fa6fafc43a: [lldb][LocateModuleCallback] Update SBFileSpec/SBModuleSpec (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153733/new/

[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

splhack added inline comments. Comment at: lldb/source/API/SBPlatform.cpp:664-689 + if (platform_sp) { +if (callback) { + platform_sp->SetLocateModuleCallback( + [callback, callback_baton](const ModuleSpec _spec, + FileSpec

[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

splhack updated this revision to Diff 539351. splhack added a comment. update SetLocateModuleCallback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153735/new/ https://reviews.llvm.org/D153735 Files: lldb/bindings/python/python-typemaps.swig

[Lldb-commits] [PATCH] D153734: [lldb][LocateModuleCallback] Call locate module callback

splhack added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:884-887 + typedef std::function + LocateModuleCallback; clayborg wrote: > I think we still need a baton for the callback so clients can register a > callback + void *. Yes,

[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

splhack added a comment. @clayborg yes, it'd be possible to pass the baton down to Platform.h since it is just `void *`, so no dependencies required. But, first, let me explain the callback and baton flow. For Python, user will set a callable Python object as the callback. For C++ API,

[Lldb-commits] [PATCH] D153734: [lldb][LocateModuleCallback] Call locate module callback

splhack added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:944 const std::unique_ptr m_module_cache; + LocateModuleCallback m_locate_module_callback; clayborg wrote: > We probably need a baton still. In order to make this work for

[Lldb-commits] [PATCH] D153735: [lldb][TargetGetModuleCallback] Implement Python interface

splhack updated this revision to Diff 539238. splhack added a comment. - Rename 'get module callback' to 'locate module callback' - SBPlatform will do - capture callback(SBPlatformLocateModuleCallback) and baton(void *) - convert ModuleSpec/FileSpec from/to SBModuleSpec/SBFileSpec for calling

[Lldb-commits] [PATCH] D153734: [lldb][LocateModuleCallback] Call locate module callback

splhack marked 3 inline comments as done. splhack added a comment. SBPlatform API and Python will use SBPlatformLocateModuleCallback type. typedef SBError (*SBPlatformLocateModuleCallback)( void *baton, const SBModuleSpec _spec, SBFileSpec _file_spec, SBFileSpec

[Lldb-commits] [PATCH] D153734: [lldb][TargetGetModuleCallback] Call get module callback

splhack updated this revision to Diff 539213. splhack added a comment. - Rename 'get module callback' to 'locate module callback' - Enable C++ callback aside from Python callback - Introduce LocateModuleCallback typedef to use std::function in order to capture callback and baton, to convert

[Lldb-commits] [PATCH] D153733: [lldb][TargetGetModuleCallback] Update SBFileSpec/SBModuleSpec

splhack updated this revision to Diff 539207. splhack added a comment. sync with D153734 and D153735 changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153733/new/

[Lldb-commits] [PATCH] D153735: [lldb][TargetGetModuleCallback] Implement Python interface

splhack added inline comments. Comment at: lldb/include/lldb/API/SBDefines.h:129 +typedef SBError (*SBTargetGetModuleCallback)(SBDebugger debugger, + SBModuleSpec _spec, clayborg wrote: > If we are putting this into

[Lldb-commits] [PATCH] D153734: [lldb][TargetGetModuleCallback] Call get module callback

splhack added a comment. @clayborg Sure, I'll rename the type and function to `Locate` instead of `Get`. typedef SBError (*SBPlatformLocateModuleCallback)( SBDebugger debugger, SBModuleSpec _spec, SBFileSpec _file_spec, SBFileSpec _file_spec); This

[Lldb-commits] [PATCH] D153735: [lldb][TargetGetModuleCallback] Implement Python interface

splhack updated this revision to Diff 538835. splhack added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153735/new/ https://reviews.llvm.org/D153735 Files: lldb/bindings/python/python-typemaps.swig

[Lldb-commits] [PATCH] D153734: [lldb][TargetGetModuleCallback] Call get module callback

splhack updated this revision to Diff 538741. splhack added a comment. Fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153734/new/ https://reviews.llvm.org/D153734 Files: lldb/include/lldb/Core/Debugger.h

[Lldb-commits] [PATCH] D153735: [lldb][TargetGetModuleCallback] Implement Python interface

splhack updated this revision to Diff 538713. splhack added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153735/new/ https://reviews.llvm.org/D153735 Files: lldb/bindings/python/python-typemaps.swig

[Lldb-commits] [PATCH] D153734: [lldb][TargetGetModuleCallback] Call get module callback

splhack updated this revision to Diff 538696. splhack added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153734/new/ https://reviews.llvm.org/D153734 Files: lldb/include/lldb/Core/Debugger.h

[Lldb-commits] [PATCH] D153733: [lldb][TargetGetModuleCallback] Update SBFileSpec/SBModuleSpec

splhack updated this revision to Diff 538662. splhack added a comment. fix LLDB_INSTRUMENT_VA for SBModuleSpec constructor too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153733/new/ https://reviews.llvm.org/D153733 Files:

[Lldb-commits] [PATCH] D153733: [lldb][TargetGetModuleCallback] Update SBFileSpec/SBModuleSpec

splhack updated this revision to Diff 538660. splhack added a comment. Fix LLDB_INSTRUMENT_VA args Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153733/new/ https://reviews.llvm.org/D153733 Files: lldb/bindings/python/python-swigsafecast.swig

[Lldb-commits] [PATCH] D153733: [lldb][TargetGetModuleCallback] Update SBFileSpec/SBModuleSpec

splhack updated this revision to Diff 538649. splhack added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153733/new/ https://reviews.llvm.org/D153733 Files: lldb/bindings/python/python-swigsafecast.swig

[Lldb-commits] [PATCH] D153735: [lldb][TargetGetModuleCallback] Implement Python interface

splhack updated this revision to Diff 534804. splhack added a comment. Move SetTargetGetModuleCallback from SBDebugger to SBPlatform. https://discourse.llvm.org/t/rfc-python-callback-for-target-get-module/71580/4?u=splhack Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D153734: [lldb][TargetGetModuleCallback] Call get module callback

splhack updated this revision to Diff 534803. splhack added a comment. Move SetTargetGetModuleCallback from Debugger to Platform. https://discourse.llvm.org/t/rfc-python-callback-for-target-get-module/71580/4?u=splhack Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D153735: [lldb][TargetGetModuleCallback] Implement Python interface

splhack created this revision. Herald added a project: All. splhack requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. RFC https://discourse.llvm.org/t/rfc-python-callback-for-target-get-module/71580 Use SWIG for the target get module

[Lldb-commits] [PATCH] D153734: [lldb][TargetGetModuleCallback] Call get module callback

splhack created this revision. Herald added a project: All. splhack requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. RFC https://discourse.llvm.org/t/rfc-python-callback-for-target-get-module/71580 Updated Target::GetOrCreateModule to call

[Lldb-commits] [PATCH] D153733: [lldb][TargetGetModuleCallback] Update SBFileSpec/SBModuleSpec

splhack created this revision. Herald added a project: All. splhack requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. RFC https://discourse.llvm.org/t/rfc-python-callback-for-target-get-module/71580 SBFileSpec and SBModuleSpec will be used

[Lldb-commits] [PATCH] D153390: [lldb][Windows] Fix ZipFileResolver tests

splhack added a comment. verified, Windows buildbot is now green. https://lab.llvm.org/buildbot/#/builders/219 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153390/new/ https://reviews.llvm.org/D153390

[Lldb-commits] [PATCH] D153390: [lldb][Windows] Fix ZipFileResolver tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c4071d22516: [lldb][Windows] Fix ZipFileResolver tests (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153390/new/

[Lldb-commits] [PATCH] D153390: [lldb][Windows] Fix ZipFileResolver tests

splhack added a comment. Yes, in fact ZipFileResolverTest is the test what is running on Windows, and failing due to POSIX vs Windows path. This diff will fix the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153390/new/

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack added a comment. Fixed Windows test failures in D153390 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 ___

[Lldb-commits] [PATCH] D153390: [lldb][Windows] Fix ZipFileResolver tests

splhack created this revision. Herald added a project: All. splhack requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. D152759 introduced the Android .zip so file support, but it only considered POSIX path.

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack added a comment. ResolveSharedLibraryPathWithZipExisting and ResolveSharedLibraryPathWithZipMissing are failing on Windows. Looking into. https://lab.llvm.org/buildbot/#/builders/219/builds/3674 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.package-name

This revision was automatically updated to reflect the committed changes. Closed by commit rGfabd16c7460e: [lldb][Android] Add platform.plugin.remote-android.package-name (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

This revision was automatically updated to reflect the committed changes. Closed by commit rG49f55b025d81: [lldb][Android] Add PlatformAndroidTest (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152855/new/

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

This revision was automatically updated to reflect the committed changes. Closed by commit rG12dee9d3cd76: [lldb][Android] Support zip .so file (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0b9605a544d: [lldb][ObjectFileELF] Set ModuleSpec file offset and size (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152757/new/

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack added a comment. I will submit a diff to deal with how to use the AdbClient in PlatformAndroid later. Most likely we could use only one instance of AdbClient. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152855/new/

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.package-name

splhack updated this revision to Diff 532245. splhack added a comment. update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152933/new/ https://reviews.llvm.org/D152933 Files: lldb/source/Plugins/Platform/Android/CMakeLists.txt

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.run-as

splhack updated this revision to Diff 532243. splhack added a comment. Rename it to platform.plugin.remote-android.package-name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152933/new/ https://reviews.llvm.org/D152933 Files:

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack updated this revision to Diff 532196. splhack added a comment. - s/AdbClientSP/AdbClientUP/g - Updated `Status ` arg to `GetAdbClient` - Added error checks in AndroidPlatform for `GetAdbClient` - Added DownloadModuleSliceWithAdbClientError test for the GetAdbClient error Repository:

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 532165. splhack added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 Files: lldb/include/lldb/Host/common/ZipFileResolver.h

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

splhack updated this revision to Diff 532163. splhack added a comment. removed abandoned dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152757/new/ https://reviews.llvm.org/D152757 Files:

[Lldb-commits] [PATCH] D153102: [lldb][MainLoopTest] Fix assertion failure on arm Linux

splhack abandoned this revision. splhack added a comment. @DavidSpickett thanks for the heads up, and thanks @labath to the commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153102/new/ https://reviews.llvm.org/D153102

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 531992. splhack added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 Files: lldb/include/lldb/Host/common/ZipFileResolver.h

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

splhack updated this revision to Diff 531990. splhack added a comment. fixed typo and rebase onto D153102 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152757/new/ https://reviews.llvm.org/D152757 Files:

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

splhack added a comment. D153102 should fix the last test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152712/new/ https://reviews.llvm.org/D152712 ___

[Lldb-commits] [PATCH] D153102: [lldb][MainLoopTest] Fix assertion failure on arm Linux

splhack created this revision. splhack added reviewers: clayborg, labath, bulbazord, yinghuitan, JDevlieghere, leonardchan. Herald added subscribers: omjavaid, kristof.beyls. Herald added a project: All. splhack requested review of this revision. Herald added a project: LLDB. Herald added a

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

splhack added a comment. Verified D153091 fixed TerminalTest failures. from `Failed Tests (13)` https://lab.llvm.org/buildbot/#/builders/96/builds/40769 to `Failed Tests (1)` https://lab.llvm.org/buildbot/#/builders/96/builds/40781 will submit a diff to fix

[Lldb-commits] [PATCH] D153091: [lldb][TerminalTest] Fix assertion failure

This revision was automatically updated to reflect the committed changes. Closed by commit rG75e93ec72073: [lldb][TerminalTest] Fix assertion failure (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153091/new/

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 531974. splhack added a comment. Added eFileKindInvalid with assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 Files:

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:1336 + // "zip_path!/so_path". Resolve the zip file path, .so file offset and size. + ZipFileResolver::FileKind file_kind; + std::string file_path;

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 531969. splhack added a comment. Rename `ResolveBionicPath` to `ResolveSharedLibraryPath`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 Files:

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

splhack added a comment. @leonardchan I think D153091 will fix the abort (`-6` should be `SIGABRT`), therefore it should be the assertion check of re-initialization in `FileSystem::Instance`. Is there a way to run the Linux builder with D153091

[Lldb-commits] [PATCH] D153091: [lldb][TerminalTest] Fix assertion failure

splhack created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. splhack requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. D152712 replaced

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

splhack updated this revision to Diff 531954. splhack added a comment. added non zip .so file (normal file) case to the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152757/new/ https://reviews.llvm.org/D152757 Files:

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

splhack added a comment. found symbolicated stack trace in https://lab.llvm.org/buildbot/#/builders/96/builds/40769/steps/6/logs/stdio TerminalTest does not instantiate FileSystem. now preparing to submit a diff to fix it. #0 0xcc46d6d4 llvm::sys::PrintStackTrace(llvm::raw_ostream&,

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

splhack updated this revision to Diff 531950. splhack added a comment. add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152757/new/ https://reviews.llvm.org/D152757 Files: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

splhack added a comment. @leonardchan yes, I'm looking into. -6 is ENXIO? Is it using POSIX code path? Is it possible to see symbolicated stack trace of the crash? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152712/new/

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.run-as

splhack added a comment. @clayborg > platform.plugin.remote-android.package-name sure, sounds good. will update. @bulbazord > What happens if you do run-as with an empty package name? $ adb shell "run-as '' ls"; echo $? run-as: unknown package: 1 which is the same as when specify

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack added inline comments. Comment at: lldb/source/Plugins/Platform/Android/PlatformAndroid.cpp:209 - return adb.ShellToFile(cmd, minutes(1), destination); + return adb->ShellToFile(cmd, minutes(1), destination); } bulbazord wrote: > `GetAdbClient()`

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4d710e41059: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack added inline comments. Comment at: lldb/include/lldb/Host/common/ZipFileResolver.h:30 + + static bool ResolveBionicPath(const FileSpec _spec, FileKind _kind, +std::string _path, mib wrote: > mib wrote: > > This function

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

splhack added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:592 if (data_sp->GetByteSize() < length) -data_sp = MapFileData(file, -1, file_offset); +data_sp = MapFileData(file, length, file_offset);

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.run-as

splhack updated this revision to Diff 531579. splhack added a comment. Fixed diff dependencies in order to fix CI https://reviews.llvm.org/B238946 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152933/new/ https://reviews.llvm.org/D152933 Files:

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack updated this revision to Diff 531578. splhack added a comment. Fixed diff dependencies in order to fix CI https://reviews.llvm.org/B238938 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152855/new/ https://reviews.llvm.org/D152855 Files:

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 531576. splhack added a comment. Fixed diff dependencies in order to fix CI https://reviews.llvm.org/B238937 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 Files:

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.run-as

splhack updated this revision to Diff 531509. splhack added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152933/new/ https://reviews.llvm.org/D152933 Files: lldb/source/Plugins/Platform/Android/CMakeLists.txt

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack updated this revision to Diff 531500. splhack added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152855/new/ https://reviews.llvm.org/D152855 Files: lldb/source/Plugins/Platform/Android/AdbClient.h

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 531499. splhack added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 Files: lldb/include/lldb/Host/common/ZipFileResolver.h

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

splhack updated this revision to Diff 531498. splhack added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152757/new/ https://reviews.llvm.org/D152757 Files: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

splhack updated this revision to Diff 531483. splhack added a comment. Replace `llvm::sys::RetryAfterSignal(-1, ::open)` with `FileSystem::Instance().Open`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152712/new/ https://reviews.llvm.org/D152712

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

splhack added a comment. oh wait, `FileSystem::Open` is already `RetryAfterSignal::Open` in this diff. will replace `RetryAfterSignal::Open` with `FileSystem::Open`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152712/new/

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

splhack added a comment. @JDevlieghere does `FileSystem::RetryAfterSignal::Open` sound good to you? Or `FileSystem::RetryAfterSignalOpen`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152712/new/ https://reviews.llvm.org/D152712

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.run-as

splhack updated this revision to Diff 531398. splhack added a comment. remove 'Depends on' from commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152933/new/ https://reviews.llvm.org/D152933 Files:

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack updated this revision to Diff 531396. splhack added a comment. remove 'Depend on' from commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152855/new/ https://reviews.llvm.org/D152855 Files:

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 531394. splhack added a comment. remove 'Depends on' from commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 Files:

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.run-as

splhack updated this revision to Diff 531392. splhack added a comment. Herald added a subscriber: JDevlieghere. rebase onto D152855 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152933/new/

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack updated this revision to Diff 531389. splhack added a comment. rebase onto D152759 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152855/new/ https://reviews.llvm.org/D152855 Files:

  1   2   >