[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack added inline comments. Comment at: lldb/source/Plugins/Platform/Android/PlatformAndroid.cpp:261-264 + if (const char *run_as = std::getenv("ANDROID_PLATFORM_RUN_AS")) +snprintf(run_as_cmd, sizeof(run_as_cmd), "run-as '%s' ", run_as); + else +run_as_cmd[0] =

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 531384. splhack added a comment. rebase onto D152757 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 Files:

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

splhack updated this revision to Diff 531383. splhack added a comment. rebase onto D152712 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152757/new/ https://reviews.llvm.org/D152757 Files:

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

splhack updated this revision to Diff 531381. splhack added a comment. rebase onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152712/new/ https://reviews.llvm.org/D152712 Files: lldb/include/lldb/Host/common/RetryAfterSignal.h

[Lldb-commits] [PATCH] D152494: [lldb][Android] Fix adb shell cat

splhack abandoned this revision. splhack added a comment. @bulbazord thanks for the suggestion! property works well. D152933 supersedes this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152494/new/

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.run-as

splhack created this revision. Herald added a subscriber: danielkiss. Herald added a project: All. splhack added reviewers: clayborg, bulbazord, labath, lanza. splhack published this revision for review. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When LLDB fails to

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack updated this revision to Diff 531198. splhack added a comment. Herald added a subscriber: JDevlieghere. sync with D152759 new version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152855/new/

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack updated this revision to Diff 531195. splhack added a comment. - ZipFile: zip file parser in Utility - include/lldb/Utility/ZipFile.h - source/Utility/ZipFile.cpp - ZipFileResolver: bionic zip .so file resolver, depends on Host::FileSystem -

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

splhack added a comment. @yinghuitan yup, `RetryAfterSignal::Open` helper functions look better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152712/new/ https://reviews.llvm.org/D152712 ___

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

splhack updated this revision to Diff 531186. splhack added a comment. Add lldb/include/lldb/Host/common/RetryAfterSignal.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152712/new/ https://reviews.llvm.org/D152712 Files:

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

splhack updated this revision to Diff 531147. splhack added a comment. fix EXPECT_EQ warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152757/new/ https://reviews.llvm.org/D152757 Files: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack added inline comments. Comment at: lldb/source/Host/CMakeLists.txt:109-121 + +set(ANDROID_SOURCES + android/ZipFile.cpp + android/HostInfoAndroid.cpp + ) if (CMAKE_SYSTEM_NAME MATCHES "Android") + list(APPEND ANDROID_SOURCES

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

splhack updated this revision to Diff 531118. splhack added a comment. Herald added a subscriber: JDevlieghere. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152757/new/ https://reviews.llvm.org/D152757 Files:

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack added a comment. @bulbazord thanks for reviewing! will address the types, formats. Comment at: lldb/source/Host/CMakeLists.txt:109-121 + +set(ANDROID_SOURCES + android/ZipFile.cpp + android/HostInfoAndroid.cpp + ) if (CMAKE_SYSTEM_NAME MATCHES

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack created this revision. Herald added a subscriber: danielkiss. Herald added a project: All. splhack added reviewers: clayborg, labath, lanza, srhines. splhack edited the summary of this revision. splhack updated this revision to Diff 531075. splhack added a comment. splhack updated this

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack created this revision. Herald added subscribers: danielkiss, krytarowski. Herald added a project: All. splhack added reviewers: clayborg, labath, lanza, srhines. splhack published this revision for review. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In Android

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

splhack created this revision. Herald added a subscriber: emaste. Herald added a project: All. splhack added reviewers: clayborg, labath, friss, lanza. splhack published this revision for review. Herald added subscribers: lldb-commits, MaskRay. Herald added a project: LLDB. In Android API level

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

splhack created this revision. Herald added a subscriber: danielkiss. Herald added a project: All. splhack added reviewers: clayborg, hans. splhack published this revision for review. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lldb-server for Android does not build

[Lldb-commits] [PATCH] D152494: [lldb][Android] Fix adb shell cat

splhack created this revision. splhack added a reviewer: clayborg. Herald added a subscriber: danielkiss. Herald added a project: All. splhack edited the summary of this revision. splhack added reviewers: labath, lanza. splhack published this revision for review. Herald added a project: LLDB.

[Lldb-commits] [PATCH] D138164: [LLDB][Android] Fix Android serial number handling

splhack added a comment. @clayborg https://reviews.llvm.org/D139332 is the platform Android options version. I'm happy with either of this connect url version https://reviews.llvm.org/D138164 or platform options version https://reviews.llvm.org/D139332. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D139332: [LLDB][Android] Add platform options

splhack created this revision. Herald added a subscriber: danielkiss. Herald added a project: All. splhack added a reviewer: clayborg. splhack updated this revision to Diff 480112. splhack added a comment. splhack published this revision for review. Herald added a project: LLDB. Herald added a

[Lldb-commits] [PATCH] D138164: [LLDB][Android] Fix Android serial number handling

splhack added a comment. Either way works as long as we can pass the Android serial number to AdbClient.cpp. This diff just followed the current code which is actually already working for USB-connected devices and emulator. So adding TCPIP-connected device support here makes sense.

[Lldb-commits] [PATCH] D138164: [LLDB][Android] Fix Android serial number handling

splhack created this revision. Herald added a subscriber: danielkiss. Herald added a project: All. splhack added a reviewer: clayborg. splhack updated this revision to Diff 475962. splhack added a comment. splhack published this revision for review. Herald added a project: LLDB. Herald added a

<    1   2