[Lldb-commits] [PATCH] D44998: ObjectFileELF: Add support for arbitrarily named code sections

2018-05-02 Thread Konstantin Baladurin via Phabricator via lldb-commits
kbaladurin added a comment. Thank you very much! Repository: rL LLVM https://reviews.llvm.org/D44998 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44998: ObjectFileELF: Add support for arbitrarily named code sections

2018-04-27 Thread Konstantin Baladurin via Phabricator via lldb-commits
kbaladurin added a comment. Yes, as I haven't commit access. Thank you! https://reviews.llvm.org/D44998 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44998: ObjectFileELF: Add support for arbitrarily named code sections

2018-04-27 Thread Konstantin Baladurin via Phabricator via lldb-commits
kbaladurin added a comment. Herald added a reviewer: javed.absar. Is it ready to commit? https://reviews.llvm.org/D44998 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44998: ObjectFileELF: Add support for arbitrarily named code sections

2018-04-03 Thread Konstantin Baladurin via Phabricator via lldb-commits
kbaladurin added inline comments. Herald added a reviewer: espindola. Comment at: packages/Python/lldbsuite/test/arm/breakpoint-thumb-codesection/TestBreakpointThumbCodesection.py:29 + +self.runCmd("run") + labath wrote: > Do you think there's any added

[Lldb-commits] [PATCH] D44998: ObjectFileELF: Add support for arbitrarily named code sections

2018-04-02 Thread Konstantin Baladurin via Phabricator via lldb-commits
kbaladurin added inline comments. Comment at: packages/Python/lldbsuite/test/arm/breakpoint-thumb-codesection/main.c:1 +__attribute__((section("__codesection"))) +int f(int a) { clayborg wrote: > Will this work with all compilers we currently run the test suite

[Lldb-commits] [PATCH] D44998: ObjectFileELF: Add support for arbitrarily named code sections

2018-04-02 Thread Konstantin Baladurin via Phabricator via lldb-commits
kbaladurin updated this revision to Diff 140628. kbaladurin added a comment. @davide thank you! I've updated diff. Yes, I need somebody to commit this, so I haven't commit access. https://reviews.llvm.org/D44998 Files: include/lldb/Core/Section.h lit/Modules/elf-code-section.yaml package

[Lldb-commits] [PATCH] D44998: ObjectFileELF: Add support for arbitrarily named code sections

2018-04-02 Thread Konstantin Baladurin via Phabricator via lldb-commits
kbaladurin updated this revision to Diff 140609. kbaladurin added a comment. Herald added a subscriber: javed.absar. Thank you! I've extended `lldb-test` utility to dump section type: Showing 6 sections Index: 0 Type: regular Name: VM size: 0 File size: 0 Index: 1

[Lldb-commits] [PATCH] D44998: ObjectFileELF: Add support for arbitrarily named code sections

2018-03-30 Thread Konstantin Baladurin via Phabricator via lldb-commits
kbaladurin added a comment. Thank you! What is more preferable add python or lit test? Repository: rL LLVM https://reviews.llvm.org/D44998 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [PATCH] D44998: ObjectFileELF: Add support for arbitrarily named code sections

2018-03-28 Thread Konstantin Baladurin via Phabricator via lldb-commits
kbaladurin created this revision. kbaladurin added a reviewer: clayborg. kbaladurin added a project: LLDB. Herald added subscribers: llvm-commits, kristof.beyls, arichardson, emaste. ObjectFileELF assumes that code section has ".text" name. There is an exception for kalimba toolchain that can use