laszlokindrat created this revision.
laszlokindrat added reviewers: rriddle, bzcheeseman, wallace.
Herald added a project: All.
laszlokindrat requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
It seems that when trying to link the lldb library explicitly, the inlined
default constructor cannot find the vtable for the class. This patch fixes this
by explicitly declaring a default constructor in `PersistentExpressionState`,
and providing the definition in the source file.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D151501
Files:
lldb/include/lldb/Expression/ExpressionVariable.h
lldb/source/Expression/ExpressionVariable.cpp
Index: lldb/source/Expression/ExpressionVariable.cpp
===================================================================
--- lldb/source/Expression/ExpressionVariable.cpp
+++ lldb/source/Expression/ExpressionVariable.cpp
@@ -34,6 +34,8 @@
char PersistentExpressionState::ID;
+PersistentExpressionState::PersistentExpressionState() = default;
+
PersistentExpressionState::~PersistentExpressionState() = default;
lldb::addr_t PersistentExpressionState::LookupSymbol(ConstString name) {
Index: lldb/include/lldb/Expression/ExpressionVariable.h
===================================================================
--- lldb/include/lldb/Expression/ExpressionVariable.h
+++ lldb/include/lldb/Expression/ExpressionVariable.h
@@ -207,6 +207,8 @@
/// LLVM RTTI support
static char ID;
+ PersistentExpressionState();
+
virtual ~PersistentExpressionState();
virtual lldb::ExpressionVariableSP
Index: lldb/source/Expression/ExpressionVariable.cpp
===================================================================
--- lldb/source/Expression/ExpressionVariable.cpp
+++ lldb/source/Expression/ExpressionVariable.cpp
@@ -34,6 +34,8 @@
char PersistentExpressionState::ID;
+PersistentExpressionState::PersistentExpressionState() = default;
+
PersistentExpressionState::~PersistentExpressionState() = default;
lldb::addr_t PersistentExpressionState::LookupSymbol(ConstString name) {
Index: lldb/include/lldb/Expression/ExpressionVariable.h
===================================================================
--- lldb/include/lldb/Expression/ExpressionVariable.h
+++ lldb/include/lldb/Expression/ExpressionVariable.h
@@ -207,6 +207,8 @@
/// LLVM RTTI support
static char ID;
+ PersistentExpressionState();
+
virtual ~PersistentExpressionState();
virtual lldb::ExpressionVariableSP
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
