[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. In D68188#1691129 , @labath wrote: > Hmm... I like your solution of the typemap problem, but this CRTP class seems > to be way more complicated than needed. There shouldn't be any need for CRTP > as we already have regular

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna added a comment. @labath any more comments on this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D68317: factor out an abstract base class for File

lawrence_danna updated this revision to Diff 222851. lawrence_danna marked 2 inline comments as done. lawrence_danna added a comment. rm NativeFile::make_shared Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68317/new/ https://reviews.llvm.org/D6831

[Lldb-commits] [PATCH] D68317: factor out an abstract base class for File

lawrence_danna added inline comments. Comment at: lldb/include/lldb/Host/File.h:377-381 + template + static std::shared_ptr make_shared(Args... args) { +return std::static_pointer_cast( +std::make_shared(args...)); + } labath wrote: > Please delet

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 222853. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h lldb/include/lldb/Host/

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 222883. lawrence_danna added a comment. get rid of CRTP gobbledygook Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h ll

[Lldb-commits] [PATCH] D67793: new api class: SBFile

This revision was automatically updated to reflect the committed changes. Closed by commit rL373562: new api class: SBFile (authored by lawrence_danna, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D67793

[Lldb-commits] [PATCH] D68181: SBDebugger::SetInputFile, SetOutputFile, etc.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373563: SBDebugger::SetInputFile, SetOutputFile, etc. (authored by lawrence_danna, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[Lldb-commits] [PATCH] D68317: factor out an abstract base class for File

This revision was automatically updated to reflect the committed changes. Closed by commit rL373564: factor out an abstract base class for File (authored by lawrence_danna, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 222970. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h lldb/packages/Python/ll

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223049. lawrence_danna added a comment. We need to obsessively check PyErr_Occurred() before calling into the next python API, even when we'd just catch it a little later. Python APIs will generally work if you don't, but it's undefined behavior to d

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223053. lawrence_danna added a comment. no_debug_info_test -> NO_DEBUG_INFO_TESTCASE Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/A

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223056. lawrence_danna marked an inline comment as done. lawrence_danna added a comment. anonymous namespace, and a windows fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.ll

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223057. lawrence_danna added a comment. assert instead of raise Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h lldb/pa

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223069. lawrence_danna added a comment. use LLDB_LOGF and add a logging test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFil

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223071. lawrence_danna marked 2 inline comments as done. lawrence_danna added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/in

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna marked 6 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1238-1245 +// OwnedPythonFile::IsValid() chains into Base::IsValid() +// File::IsValid() is false by default, but

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223072. lawrence_danna marked 3 inline comments as done. lawrence_danna added a comment. group all the PythonFile support together in the source file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/ne

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1255-1264 + Status Close() override { +assert(m_py_obj); +GIL takeGIL; +if (m_borrowed) + retur

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223074. lawrence_danna marked 5 inline comments as done. lawrence_danna added a comment. remove unnecessary friends Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D6818

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1238-1245 +// OwnedPythonFile::IsValid() chains into Base::IsValid() +// File::IsValid() is false by default, but for the following classes +// we want the file t

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223075. lawrence_danna marked an inline comment as done. lawrence_danna added a comment. semicolons Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223080. lawrence_danna added a comment. rm class PresumptivelyValidFile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1238-1245 +// OwnedPythonFile::IsValid() chains into Base::IsValid() +// File::IsValid() is false by default, but

[Lldb-commits] [PATCH] D68433: SBFile: add a bunch of tests that should eventually work.

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. lawrence_danna added a parent revision: D68188: allow arbitrary python streams to be converted to SBFile. It's really annoying and confusing to have to keep refe

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. lawrence_danna added a parent revision: D68433: SBFile: add a bunch of tests that should eventually work.. This patch add SBFile interfaces to SBCommandReturnObj

[Lldb-commits] [PATCH] D68433: SBFile: add a bunch of tests that should eventually work.

lawrence_danna updated this revision to Diff 223139. lawrence_danna added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68433/new/ https://reviews.llvm.org/D68433 Files: lldb/packages/Python/lldbsuite/test/python_api/file_hand

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna updated this revision to Diff 223140. lawrence_danna added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68434/new/ https://reviews.llvm.org/D68434 Files: lldb/include/lldb/API/SBCommandReturnObject.h lldb/inc

[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. There a a few call sites that use FILE* which are easy to fix without disrupting anything else. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/source/Utility/ReproducerInstrumentation.cpp:38 +template <> lldb::SBFile Deserializer::Deserialize() { +//@JDevlieghere I'm pretty sure this is not the right thing to --

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna updated this revision to Diff 223143. lawrence_danna added a comment. deserializer hijinks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68434/new/ https://reviews.llvm.org/D68434 Files: lldb/include/lldb/API/SBCommandReturnObject

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna updated this revision to Diff 223146. lawrence_danna added a comment. :-/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68434/new/ https://reviews.llvm.org/D68434 Files: lldb/include/lldb/API/SBCommandReturnObject.h lldb/include

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. In D68188#1694276 , @labath wrote: > Most of your interactions seem to be about calling methods. Would it be > possible to add a PythonDataObject wrapper for this (and any other frequently > used python API)? I'm hoping th

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223234. lawrence_danna marked 4 inline comments as done. lawrence_danna added a comment. minor fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lld

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1369 +const char *utf8 = PyUnicode_AsUTF8AndSize(pystring.get(), &size); +if (!utf8 || PyErr_Occurred()) + return Status(llvm::make_error("Read")); -

[Lldb-commits] [PATCH] D68433: SBFile: add a bunch of tests that should eventually work.

lawrence_danna updated this revision to Diff 223238. lawrence_danna added a comment. use expectedFailure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68433/new/ https://reviews.llvm.org/D68433 Files: lldb/packages/Python/lldbsuite/test/python_a

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna updated this revision to Diff 223248. lawrence_danna added a comment. a different deserializer fix for SBFile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68434/new/ https://reviews.llvm.org/D68434 Files: lldb/include/lldb/API/SB

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna marked 4 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/source/Utility/ReproducerInstrumentation.cpp:38 +template <> lldb::SBFile Deserializer::Deserialize() { +//@JDevlieghere I'm pretty sure this is not the right thing to --

[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68444/new/ https://reviews.llvm.org/D68444 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

lawrence_danna updated this revision to Diff 223254. lawrence_danna marked 3 inline comments as done. lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68444/new/ https://reviews.llvm.org/D68444 Files: lldb/sour

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223350. lawrence_danna added a comment. better integration with PythonObject Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFil

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. In D68188#1695069 , @labath wrote: > I agree about the separate patch stuff, but it seems to be that this should > be done before this one. After all, all (most?) of the existing code has > already been DataObject-ized and

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223351. lawrence_danna added a comment. spelling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h lldb/packages/Python/l

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223352. lawrence_danna added a comment. comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h lldb/packages/Python/ll

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. I changed my mind about splitting this into another patch.When I first said that I had in mind a much more extensive rewrite of the PythonDataObjects. I think it's fine now as one patch -- though we should still go back later add Expected<> everywhere in Py

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223355. lawrence_danna added a comment. python2 const fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h lldb/packages

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223361. lawrence_danna added a comment. fix typemaps to deal with None correctly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/S

[Lldb-commits] [PATCH] D68545: DWIMy filterspecs for dotest.py

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. dotest.py currently requires a filterspec to be of the form `TestCase.test_method`. This patch makes it more flexible, so you can pass `TestModule.TestCase.test

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223389. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h lldb/packages/Python/ll

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna updated this revision to Diff 223391. lawrence_danna marked an inline comment as done. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68434/new/ https://reviews.llvm.org/D68434 Files: lldb/in

[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

lawrence_danna updated this revision to Diff 223392. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68444/new/ https://reviews.llvm.org/D68444 Files: lldb/source/API/SBDebugger.cpp lldb/source/Core/IOHand

[Lldb-commits] [PATCH] D68433: SBFile: add a bunch of tests that should eventually work.

lawrence_danna updated this revision to Diff 223390. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68433/new/ https://reviews.llvm.org/D68433 Files: lldb/packages/Python/lldbsuite/test/python_api/file_hand

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. This patch adds FileSP and SBFile versions of the API methods ReportEventState and HandleProcessEvent. It points the SWIG wrappers at these instead of the on

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

lawrence_danna updated this revision to Diff 223394. lawrence_danna added a comment. oops, remove unnecessary FileSP reference from interface file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68546/new/ https://reviews.llvm.org/D68546 Files: ll

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223395. lawrence_danna added a comment. add safe PythonModule functions and use them Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/A

[Lldb-commits] [PATCH] D68547: exception handling in PythonDataObjects.

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath, zturner. Herald added a project: LLDB. Python APIs nearly all can return an exception. They do this by returning NULL, or -1, or some such value and setting the exception state with PyErr_Se

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223397. lawrence_danna added a comment. split off generic exception handling stuff into a separate patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files:

[Lldb-commits] [PATCH] D68545: DWIMy filterspecs for dotest.py

lawrence_danna updated this revision to Diff 223686. lawrence_danna added a comment. updated help text Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68545/new/ https://reviews.llvm.org/D68545 Files: lldb/packages/Python/lldbsuite/test/dotest.py

[Lldb-commits] [PATCH] D68547: exception handling in PythonDataObjects.

lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:280 + template + Expected CallMethod(const char *name, const char *format, +Args... args) { labath wrote: > I

[Lldb-commits] [PATCH] D68547: exception handling in PythonDataObjects.

lawrence_danna updated this revision to Diff 223690. lawrence_danna marked 13 inline comments as done. lawrence_danna added a comment. review fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68547/new/ https://reviews.llvm.org/D68547 Files: l

[Lldb-commits] [PATCH] D68547: exception handling in PythonDataObjects.

lawrence_danna updated this revision to Diff 223691. lawrence_danna added a comment. review fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68547/new/ https://reviews.llvm.org/D68547 Files: lldb/source/Plugins/ScriptInterpreter/Python/PythonDa

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223692. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h lldb/packages/Python/ll

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna updated this revision to Diff 223693. lawrence_danna marked an inline comment as done. lawrence_danna added a comment. use is_trivially_copyable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68434/new/ https://reviews.llvm.org/D68434

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/include/lldb/Utility/ReproducerInstrumentation.h:257-259 +template <> struct serializer_tag { + typedef NotImplementedTag type; +}; labath wrote: > This still

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

lawrence_danna added a comment. In D68546#1697302 , @labath wrote: > Adding Jim for the API design aspects. > > It's unfortunate that we have to add the FileSP overload (and the associated > cruft) to every API that used to take a FILE*. I take it that is

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna updated this revision to Diff 223699. lawrence_danna marked 5 inline comments as done. lawrence_danna added a comment. get rid of dummy registrations in SBFile.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68434/new/ https://revi

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna added inline comments. Comment at: lldb/source/API/SBFile.cpp:115 + + R.Register(&dummy, "", "SBFile", "SBFile", "()"); + R.Register(&dummy, "", "SBFile", "SBFile", labath wrote: > I don't think these are right because there nothing here to conne

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

lawrence_danna added a comment. Personally, I think `%extend` is a bit ugly as it increases the difference between what's in the headers and what's actually in the python bindings, so I'd rather not do it that way.But I'm not dogmatically opposed to it. Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D68618: test fix: TestLoadUsingPaths should use realpath

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. TestLoadUsingPaths will fail if the build directory has symlinks in its path, because the real paths reported by the debu

[Lldb-commits] [PATCH] D68622: IOHandler: fall back on File::Read if a FILE* isn't available.

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath, lanza. Herald added a project: LLDB. IOHandler needs to read lines of input from a lldb::File. The way it currently does this using, FILE*, which is something we want to avoid now. I'd pr

[Lldb-commits] [PATCH] D68545: DWIMy filterspecs for dotest.py

This revision was automatically updated to reflect the committed changes. Closed by commit rL373997: DWIMy filterspecs for dotest.py (authored by lawrence_danna, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[Lldb-commits] [PATCH] D68618: test fix: TestLoadUsingPaths should use realpath

This revision was automatically updated to reflect the committed changes. Closed by commit rL374007: test fix: TestLoadUsingPaths should use realpath (authored by lawrence_danna, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. @labath anything else for this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D68547: exception handling in PythonDataObjects.

This revision was automatically updated to reflect the committed changes. Closed by commit rG085328ba: exception handling in PythonDataObjects. (authored by lawrence_danna). Changed prior to commit: https://reviews.llvm.org/D68547?vs=223900&id=223901#toc Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D68547: exception handling in PythonDataObjects.

lawrence_danna updated this revision to Diff 223900. lawrence_danna marked 2 inline comments as done. lawrence_danna added a comment. style fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68547/new/ https://reviews.llvm.org/D68547 Files: lld

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223902. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h lldb/packages/Python/ll

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

lawrence_danna added a comment. In D68546#1699397 , @labath wrote: > Yeah, the %extends are somewhat ugly, but I also find the FileSP overloads in > the "public" sections of the SB classes unnerving too, because they are not > really public -- no user ca

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

lawrence_danna added a comment. So what's the conclusion here? Should `HandleProcessEvent` get a SBStream variant as well? I say "as well", because the `FileSP` variant is required in order to remove the python binding to the `FILE*` variant, and once we have the `FileSP` it seems like

[Lldb-commits] [PATCH] D68622: IOHandler: fall back on File::Read if a FILE* isn't available.

lawrence_danna updated this revision to Diff 223958. lawrence_danna added a comment. factor out string splitting stuff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68622/new/ https://reviews.llvm.org/D68622 Files: lldb/include/lldb/Core/IOHandl

[Lldb-commits] [PATCH] D68677: protect libedit and LLDB gui from receiving null FILE* streams

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. lawrence_danna added a parent revision: D68188: allow arbitrary python streams to be converted to SBFile. We now have valid files that will return NULL from GetS

[Lldb-commits] [PATCH] D68677: protect libedit and LLDB gui from receiving null FILE* streams

lawrence_danna updated this revision to Diff 223984. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68677/new/ https://reviews.llvm.org/D68677 Files: lldb/source/Commands/CommandObjectGUI.cpp lldb/source/

[Lldb-commits] [PATCH] D68433: SBFile: add a bunch of tests that should eventually work.

lawrence_danna updated this revision to Diff 223979. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68433/new/ https://reviews.llvm.org/D68433 Files: lldb/packages/Python/lldbsuite/test/python_api/file_hand

[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

lawrence_danna updated this revision to Diff 223981. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68444/new/ https://reviews.llvm.org/D68444 Files: lldb/source/API/SBDebugger.cpp lldb/source/Core/IOHand

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223978. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h lldb/packages/Python/ll

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna updated this revision to Diff 223980. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68434/new/ https://reviews.llvm.org/D68434 Files: lldb/include/lldb/API/SBCommandReturnObject.h lldb/inc

[Lldb-commits] [PATCH] D68622: IOHandler: fall back on File::Read if a FILE* isn't available.

lawrence_danna updated this revision to Diff 223983. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68622/new/ https://reviews.llvm.org/D68622 Files: lldb/include/lldb/Core/IOHandler.h lldb/packages/Pytho

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

lawrence_danna updated this revision to Diff 223982. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68546/new/ https://reviews.llvm.org/D68546 Files: lldb/include/lldb/API/SBDebugger.h lldb/include/lldb/A

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1258-1265 + // you must check PyErr_Occurred() after calling this constructor. + PythonBuffer(PythonObject &obj

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 224114. lawrence_danna marked an inline comment as done. lawrence_danna added a comment. fixed pybuffer error handling weirdness Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.l

[Lldb-commits] [PATCH] D68677: protect libedit and LLDB gui from receiving null FILE* streams

This revision was automatically updated to reflect the committed changes. Closed by commit rG609010d0631a: protect libedit and LLDB gui from receiving null FILE* streams (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6867

[Lldb-commits] [PATCH] D68622: IOHandler: fall back on File::Read if a FILE* isn't available.

lawrence_danna updated this revision to Diff 224119. lawrence_danna marked 4 inline comments as done. lawrence_danna added a comment. review fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68622/new/ https://reviews.llvm.org/D68622 Files: ll

[Lldb-commits] [PATCH] D68622: IOHandler: fall back on File::Read if a FILE* isn't available.

lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68622/new/ https://reviews.llvm.org/D68622 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 224122. lawrence_danna added a comment. Pavel would slightly prefer if the PyObject_GetBuffer happened in the Create function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llv

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

This revision was automatically updated to reflect the committed changes. Closed by commit rG21b8a8ae27f3: allow arbitrary python streams to be converted to SBFile (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/

[Lldb-commits] [PATCH] D68734: update SBDebugger::SetInputFile() etc to work on native Files

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. lawrence_danna added a parent revision: D68433: SBFile: add a bunch of tests that should eventually work.. This patch adds FileSP versions of SetInputFile(), Set

[Lldb-commits] [PATCH] D68433: SBFile: add a bunch of tests that should eventually work.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb24022cd723f: SBFile: add a bunch of tests that should eventually work. (authored by lawrence_danna). Changed prior to commit: https://reviews.llvm.org/D68433?vs=223979&id=224178#toc Repository: rG L

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

This revision was automatically updated to reflect the committed changes. Closed by commit rG9eb137192364: SBFile support in SBCommandReturnObject (authored by lawrence_danna). Changed prior to commit: https://reviews.llvm.org/D68434?vs=223980&id=224179#toc Repository: rG LLVM Github Monorep

<    1   2   3   4   5   >