[Lldb-commits] [PATCH] D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9b8f422e711: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code (authored by ljmf00). Herald added a project: All. Changed prior to commit: https://reviews.llvm.org/D114668?vs=3918

[Lldb-commits] [PATCH] D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code

ljmf00 added a comment. Sorry for leaving this hanging for a long time. Feel free to leave feedback if I'm missing something, in the meantime. I'll try to push the other patches too. I ran the test suite again and didn't break anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D114719: [lldb][NFC] Move non-clang specific method to the generic DWARF Parser

This revision was automatically updated to reflect the committed changes. Closed by commit rG3da4f9c57b15: [lldb][NFC] Move non-clang specific method to the generic DWARF Parser (authored by ljmf00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1147

[Lldb-commits] [PATCH] D116136: [lldb] Add UTF-8 char basic type

ljmf00 updated this revision to Diff 434543. Herald added a project: All. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116136/new/ https://reviews.llvm.org/D116136 Files: lldb/bindings/python/python-extensions.swig lldb/docs/python_api_enums.rst Index: lldb/docs/python_api_enums.r

[Lldb-commits] [PATCH] D116136: [lldb] Add UTF-8 char basic type

ljmf00 added a comment. @labath In the meantime, a lot of time passed and someone patched it in D120690 , but the order on the documentation is wrong and the Python bindings need swig definitions. This patch introduces those, after rebasing with main. CHANGES

[Lldb-commits] [PATCH] D116136: [lldb] Add missing UTF-8 char basic type entries

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d5b86f851a1: [lldb] Add missing UTF-8 char basic type entries (authored by ljmf00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116136/new/ https://revie

[Lldb-commits] [PATCH] D110578: [lldb] Add support for D programming language

ljmf00 added a comment. In D110578#3027692 , @teemperor wrote: > Do you have commit access or should someone land this for you? I don't have commit access, although this is a stacked revision, so there are some dependent patches. Repository: rG LLVM

[Lldb-commits] [PATCH] D110578: [lldb] Add support for D programming language

ljmf00 updated this revision to Diff 378255. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110578/new/ https://reviews.llvm.org/D110578 Files: lldb/include/lldb/Core/Mangled.h lldb/source/Core/Mangled.cpp lldb/source/Symbol/Symtab.cpp lldb/u

[Lldb-commits] [PATCH] D112564: [lldb] Add support for custom char8_t types with different name

ljmf00 created this revision. ljmf00 added projects: LLDB, LLVM. Herald added a subscriber: JDevlieghere. ljmf00 requested review of this revision. Herald added a subscriber: lldb-commits. Currently for UTF-16 and UTF-32 types that are recognized by the DWARF encoding tags without `char16_t`

[Lldb-commits] [PATCH] D112564: [lldb] Add support for custom char8_t types with different name

ljmf00 added a comment. I can reproduce this with LDC (D LLVM-based compiler), but I don't know a way to do it with clang. Probably I need to manually write a .ll file for this. Can someone guide me on adding tests for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D112564: [lldb] Add support for custom char8_t types with different name

ljmf00 added a comment. I will also create an issue and cross-reference this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112564/new/ https://reviews.llvm.org/D112564 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D112564: [lldb] Add support for custom char8_t types with different name

ljmf00 added a comment. https://bugs.llvm.org/show_bug.cgi?id=52324 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112564/new/ https://reviews.llvm.org/D112564 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D112586: [lldb] Remove forgotten FIXME on CPlusPlus formatters

ljmf00 created this revision. ljmf00 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The patch [1] introduced this FIXME but ended up not being removed when fixed. [1]: https://github.com/llvm/llvm-project/commit/f68df12fb039d5177e3

[Lldb-commits] [PATCH] D112564: [lldb] Add support for custom char8_t types with different name

ljmf00 added a comment. In D112564#3089399 , @labath wrote: > What exactly do you need the test to do? Is printing a global variable > (`char8_t_ish foo[] = "my string"`) sufficient? > If so, you can take a look at the tests in `test/Shell/SymbolFile/DWA

[Lldb-commits] [PATCH] D112658: [lldb] Refactor C/C++ string and char summary providers

ljmf00 created this revision. ljmf00 added projects: LLDB, LLVM. Herald added a subscriber: JDevlieghere. ljmf00 requested review of this revision. Herald added a subscriber: lldb-commits. Signed-off-by: Luís Ferreira This patch refactors C/C++ formatters to avoid repetitive code. Repository

[Lldb-commits] [PATCH] D112586: [lldb] Remove forgotten FIXME on CPlusPlus formatters

ljmf00 added a comment. In D112586#3093490 , @teemperor wrote: > LGTM, thanks. Note: I can't land it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112586/new/ https://reviews.llvm.org/D112586 ___

[Lldb-commits] [PATCH] D112658: [lldb] Refactor C/C++ string and char summary providers

ljmf00 updated this revision to Diff 383121. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112658/new/ https://reviews.llvm.org/D112658 Files: lldb/source/Plugins/Language/CPlusPlus/CxxStringTypes.cpp Index: lldb/source/Plugins/Language/CPlusPlus/CxxStringTypes.cpp ===

[Lldb-commits] [PATCH] D112658: [lldb] Refactor C/C++ string and char summary providers

ljmf00 added a comment. In D112658#3092586 , @labath wrote: > Thanks for doing this. Just a couple of small remarks. Can you re-review? Comment at: lldb/source/Plugins/Language/CPlusPlus/CxxStringTypes.cpp:35 -bool lldb_private::for

[Lldb-commits] [PATCH] D113098: [lldb] (Partially) enable formatting of utf strings before the program is started

ljmf00 added a comment. In D113098#3105809 , @labath wrote: > bug reported in PR45856. Thanks for your time fixing this. So, for better understanding, does the infrastructure behind LLDB, Target and Process have similar APIs but Process is just for the

[Lldb-commits] [PATCH] D110578: [lldb] Add support for D programming language

ljmf00 added a comment. Since D111414 got merged, @teemperor can you land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110578/new/ https://reviews.llvm.org/D110578

[Lldb-commits] [PATCH] D113604: [lldb] Format lldb/include/lldb/Symbol/Type.h

ljmf00 created this revision. ljmf00 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113604 Files: lldb/include/lldb/Symbol/Type.h Index: lldb/include/lldb/Symbol/Type.h

[Lldb-commits] [PATCH] D113605: [lldb] Add documentation for eEncodingIsSyntheticUID

ljmf00 created this revision. ljmf00 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113605 Files: lldb/include/lldb/Symbol/Type.h Index: lldb/include/lldb/Symbol/Type.h

[Lldb-commits] [PATCH] D110578: [lldb] Add support for D programming language

ljmf00 added a subscriber: dblaikie. ljmf00 added a comment. @dblaikie Maybe you can land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110578/new/ https://reviews.llvm.org/D110578 ___ lldb-commits

[Lldb-commits] [PATCH] D113604: [lldb] Format lldb/include/lldb/Symbol/Type.h

ljmf00 updated this revision to Diff 386361. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113604/new/ https://reviews.llvm.org/D113604 Files: lldb/include/lldb/Symbol/Type.h Index: lldb/include/lldb/Symbol/Type.h === --

[Lldb-commits] [PATCH] D113604: [lldb] Format lldb/include/lldb/Symbol/Type.h

ljmf00 added a comment. Can you check now? If looks good, can you land it please? Comment at: lldb/include/lldb/Symbol/Type.h:86 eEncodingIsAtomicUID, ///< This type is the type whose UID is /// m_encoding_uid as an atomic type.

[Lldb-commits] [PATCH] D113605: [lldb] Fix documentation for EncodingDataType

ljmf00 updated this revision to Diff 386362. ljmf00 retitled this revision from "[lldb] Add documentation for eEncodingIsSyntheticUID" to "[lldb] Fix documentation for EncodingDataType". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113605/new/ https://reviews.llvm.org/D113605 Files:

[Lldb-commits] [PATCH] D113634: [lldb] Add support for DW_TAG_immutable_type

ljmf00 created this revision. Herald added a reviewer: shafik. ljmf00 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113634 Files: lldb/include/lldb/Symbol/Type.h lldb/s

[Lldb-commits] [PATCH] D113634: [lldb] Add support for DW_TAG_immutable_type

ljmf00 planned changes to this revision. ljmf00 added a comment. I still need to add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113634/new/ https://reviews.llvm.org/D113634 ___ lldb-commits mai

[Lldb-commits] [PATCH] D113634: [lldb] Add support for DW_TAG_immutable_type

ljmf00 added a comment. In D113634#3124042 , @teemperor wrote: > Are the DWARFASTParserClang changes meant as a step towards making it parse D? Yes, not only D but any language that currently falls here (https://github.com/llvm/llvm-project/blob/main/ll

[Lldb-commits] [PATCH] D113634: [lldb] Add support for DW_TAG_immutable_type

ljmf00 added a comment. In D113634#3124428 , @teemperor wrote: > In D113634#3124401 , @ljmf00 wrote: > >> In D113634#3124042 , @teemperor >> wrote: >> >>> Are the DWARFAS

[Lldb-commits] [PATCH] D113604: [lldb] Format lldb/include/lldb/Symbol/Type.h

ljmf00 added a comment. Friendly ping, maybe you forgot this, can you check it now @teemperor ? :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113604/new/ https://reviews.llvm.org/D113604 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D113604: [lldb] Format lldb/include/lldb/Symbol/Type.h

ljmf00 updated this revision to Diff 389836. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113604/new/ https://reviews.llvm.org/D113604 Files: lldb/include/lldb/Symbol/Type.h lldb/source/Symbol/Type.cpp Index: lldb/source/Symbol/Type.cpp =

[Lldb-commits] [PATCH] D113604: [lldb] Format lldb/include/lldb/Symbol/Type.h

ljmf00 added a comment. In D113604#3138107 , @JDevlieghere wrote: > LGTM modulo the inline comment. I addressed what you requested. Please review. If it is good to land, please do, as I don't have permissions. Repository: rG LLVM Github Monorepo C

[Lldb-commits] [PATCH] D114668: [lldb] Move generic DWARFASTParser code out of Clang-specific code

ljmf00 created this revision. ljmf00 added a project: LLDB. Herald added subscribers: JDevlieghere, mgorny. Herald added a reviewer: shafik. ljmf00 requested review of this revision. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114668 F

[Lldb-commits] [PATCH] D114668: [lldb] Move generic DWARFASTParser code out of Clang-specific code

ljmf00 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp:77 + default: + case DW_AT_abstract_origin: + case DW_AT_accessibility: Why we are including just these specific attributes? Maybe we shou

[Lldb-commits] [PATCH] D112564: [lldb] Add support for custom char8_t types with different name

ljmf00 added a comment. In D112564#3089399 , @labath wrote: > What exactly do you need the test to do? Is printing a global variable > (`char8_t_ish foo[] = "my string"`) sufficient? > If so, you can take a look at the tests in `test/Shell/SymbolFile/DWA

[Lldb-commits] [PATCH] D114719: [lldb] Move non-clang specific method to the generic DWARF Parser

ljmf00 created this revision. Herald added a reviewer: shafik. ljmf00 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch renames DW_ACCESS_to_AccessType function and move it to the abstract DWARFASTParser, since there is no cla

[Lldb-commits] [PATCH] D114719: [lldb] Move non-clang specific method to the generic DWARF Parser

ljmf00 updated this revision to Diff 390392. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114719/new/ https://reviews.llvm.org/D114719 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h lldb/source/Plugins/SymbolFil

[Lldb-commits] [PATCH] D114719: [lldb] Move non-clang specific method to the generic DWARF Parser

ljmf00 updated this revision to Diff 390412. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114719/new/ https://reviews.llvm.org/D114719 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h lldb/source/Plugins/SymbolFil

[Lldb-commits] [PATCH] D114746: [lldb] Generalize ParsedDWARFTypeAttributes

ljmf00 created this revision. Herald added a reviewer: shafik. ljmf00 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch generalizes the ParsedDWARFTypeAttributes struct to be able to share with other DWARF parsers other than clang

[Lldb-commits] [PATCH] D114746: [lldb][NFC] Generalize ParsedDWARFTypeAttributes

ljmf00 updated this revision to Diff 390487. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114746/new/ https://reviews.llvm.org/D114746 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h lldb/source/Plugins

[Lldb-commits] [PATCH] D114719: [lldb] Move non-clang specific method to the generic DWARF Parser

ljmf00 added a comment. In D114719#3159587 , @bulbazord wrote: > This makes sense to me. Out of curiosity, do you have plans to use this for > non-clang-based languages? Yes. I'm currently working on a D language plugin. You can see my fork, until I up

[Lldb-commits] [PATCH] D114746: [lldb][NFC] Generalize ParsedDWARFTypeAttributes

ljmf00 updated this revision to Diff 390489. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114746/new/ https://reviews.llvm.org/D114746 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h lldb/source/Plugins

[Lldb-commits] [PATCH] D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f99e1aa58e3: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h (authored by ljmf00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113604/new/ https://rev

[Lldb-commits] [PATCH] D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code

ljmf00 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp:1 +#include "DWARFASTParser.h" +#include "DWARFAttribute.h" bulbazord wrote: > This file will need a license header. Yes, my bad. Thanks for noticing it. =

[Lldb-commits] [PATCH] D114746: [lldb] Generalize ParsedDWARFTypeAttributes

ljmf00 added a comment. I'm not sure if this falls into NFC category since I'm changing how flags are stored. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114746/new/ https://reviews.llvm.org/D114746 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D114746: [lldb] Generalize ParsedDWARFTypeAttributes

ljmf00 planned changes to this revision. ljmf00 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFAttribute.h:86 + /// Whether it is an artificially generated symbol. + eDWARFAttributeIsArtificial = (1u << 0), + eDWARFAttributeIsExplicit = (1u << 1),

[Lldb-commits] [PATCH] D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code

ljmf00 updated this revision to Diff 391856. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114668/new/ https://reviews.llvm.org/D114668 Files: lldb/source/Plugins/SymbolFile/DWARF/CMakeLists.txt lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp lldb/source/Plugins/SymbolFile/

[Lldb-commits] [PATCH] D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code

ljmf00 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp:1 +#include "DWARFASTParser.h" +#include "DWARFAttribute.h" ljmf00 wrote: > bulbazord wrote: > > This file will need a license header. > Yes, my bad. Thanks for noti

[Lldb-commits] [PATCH] D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code

ljmf00 updated this revision to Diff 391867. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114668/new/ https://reviews.llvm.org/D114668 Files: lldb/source/Plugins/SymbolFile/DWARF/CMakeLists.txt lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp lldb/source/Plugins/SymbolFile/

[Lldb-commits] [PATCH] D114746: [lldb] Generalize ParsedDWARFTypeAttributes

ljmf00 updated this revision to Diff 392069. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114746/new/ https://reviews.llvm.org/D114746 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h lldb/source/Plugins/SymbolFil

[Lldb-commits] [PATCH] D114746: [lldb] Generalize ParsedDWARFTypeAttributes

ljmf00 accepted this revision. ljmf00 added a comment. This revision is now accepted and ready to land. In D114746#3160908 , @labath wrote: > I don't think we should be putting this into the DWARFAttribute file. It is > substantially higher-level than th

[Lldb-commits] [PATCH] D114746: [lldb] Generalize ParsedDWARFTypeAttributes

ljmf00 resigned from this revision. ljmf00 added a comment. This revision now requires review to proceed. Ops, clicked on the wrong button CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114746/new/ https://reviews.llvm.org/D114746 ___ lldb-com

[Lldb-commits] [PATCH] D114746: [lldb] Generalize ParsedDWARFTypeAttributes

ljmf00 updated this revision to Diff 392087. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114746/new/ https://reviews.llvm.org/D114746 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h lldb/source/Plugins/SymbolFil

[Lldb-commits] [PATCH] D115201: [lldb] Generalize UpdateSymbolContextScopeForType

ljmf00 created this revision. Herald added a reviewer: shafik. ljmf00 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D115201 File

[Lldb-commits] [PATCH] D115201: [lldb] Move UpdateSymbolContextScopeForType

ljmf00 added a comment. In D115201#3176955 , @shafik wrote: > Can you add a motivation for this to your summary, thank you! I added some description to it. I don't think it is worth mentioning my work on upstreaming the D lldb plugin, but I'm doing some

[Lldb-commits] [PATCH] D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h

ljmf00 updated this revision to Diff 394001. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113604/new/ https://reviews.llvm.org/D113604 Files: lldb/include/lldb/Symbol/Type.h lldb/source/Symbol/Type.cpp Index: lldb/source/Symbol/Type.cpp

[Lldb-commits] [PATCH] D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h

ljmf00 added a comment. Sorry for the delay. Can you re-review this @dblaikie ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113604/new/ https://reviews.llvm.org/D113604 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists

[Lldb-commits] [PATCH] D115662: [lldb][DWARF] Remove duplicate DIE type assignment

ljmf00 created this revision. Herald added a reviewer: shafik. ljmf00 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This assignment is already being done via UpdateSymbolContextScopeForType routine at the end of the type parsing funct

[Lldb-commits] [PATCH] D115662: [lldb][DWARF] Remove duplicate DIE type assignment

ljmf00 added a comment. In D115662#3192064 , @labath wrote: > I don't have any issues with this per se, but you may want to sync up with > @zequanwu, as his D115308 tries to delete > the second instance. Maybe he can

[Lldb-commits] [PATCH] D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGefefc4ee3b25: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h (authored by ljmf00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113604/new/ https://rev

[Lldb-commits] [PATCH] D113605: [lldb][NFC] Fix documentation for EncodingDataType

This revision was automatically updated to reflect the committed changes. Closed by commit rG1695dd175242: [lldb][NFC] Fix documentation for EncodingDataType (authored by ljmf00). Changed prior to commit: https://reviews.llvm.org/D113605?vs=386362&id=394345#toc Repository: rG LLVM Github Mon

[Lldb-commits] [PATCH] D113605: [lldb][NFC] Fix documentation for EncodingDataType

ljmf00 added inline comments. Comment at: lldb/include/lldb/Symbol/Type.h:69 enum EncodingDataType { +/// Invalid encoding eEncodingInvalid, teemperor wrote: > nit: LLVM comments end in a period. Fixed on push. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D112564: [lldb] Add support for UTF-8 unicode formatting

ljmf00 updated this revision to Diff 395777. ljmf00 retitled this revision from "[lldb] Add support for custom char8_t types with different name" to "[lldb] Add support for UTF-8 unicode formatting". ljmf00 edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D112564: [lldb] Add support for UTF-8 unicode formatting

ljmf00 added a comment. @labath I found the missing part, DumpTypeValue depends on lldb::Format and eFormatUnicode8 case should be added there too. I added tests and also changed the patch message. Can you re-review? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112564/new/ https://re

[Lldb-commits] [PATCH] D116136: [lldb] Add UTF-8 char basic type

ljmf00 created this revision. ljmf00 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A UTF-8 Basic type should be exposed the same way we have UTF-16 and UTF-32 basic types Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[Lldb-commits] [PATCH] D116136: [lldb] Add UTF-8 char basic type

ljmf00 added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:750 eBasicTypeUnsignedWChar, + eBasicTypeChar8, eBasicTypeChar16, Does the order of the enum matter here? Since this is part of the public API it might break something externa

[Lldb-commits] [PATCH] D116136: [lldb] Add UTF-8 char basic type

ljmf00 added a comment. In D116136#3206294 , @labath wrote: > I guess you'll want to use this type for your language plugin, but it seems a > bit weird to have a value with no uses. Should we maybe also make c++ > `char8_t` map to this type? Yes, that

[Lldb-commits] [PATCH] D115662: [lldb][DWARF] Remove duplicate DIE type assignment

ljmf00 added a comment. In D115662#3192735 , @labath wrote: > In D115662#3192651 , @ljmf00 wrote: > >> In D115662#3192064 , @labath wrote: >> >>> I don't have any issues w

[Lldb-commits] [PATCH] D112564: [lldb] Add support for UTF-8 unicode formatting

This revision was automatically updated to reflect the committed changes. Closed by commit rG46cdcf087300: [lldb] Add support for UTF-8 unicode formatting (authored by ljmf00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112564/new/ https://review

[Lldb-commits] [PATCH] D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code

ljmf00 added a comment. In D114668#3159640 , @bulbazord wrote: > I think breaking it out of the Clang-specific class makes sense if we want > LLDB to be more language-agnostic. Do you have an idea of what bits of > `DWARFASTParserClang` can be moved out

[Lldb-commits] [PATCH] D115662: [lldb][DWARF] Remove duplicate DIE type assignment

ljmf00 planned changes to this revision. ljmf00 added a comment. In D115662#3211312 , @labath wrote: > I don't have any issues with this, if everything still works. I hoped there > would be more of a discussion on this (I was hoping I'd maybe learn somet

[Lldb-commits] [PATCH] D116972: [lldb] Run the test suite in verbose mode

ljmf00 added inline comments. Comment at: zorg/buildbot/builders/LLDBBuilder.py:50 install_cmd = ['ninja','install'] -test_cmd = ['ninja','check-lldb'] +test_cmd = ['ninja','check-lldb', '-v'] I don't know if ninja verbosity propagates to `llvm-lit

[Lldb-commits] [PATCH] D116972: [lldb] Run the test suite in verbose mode

ljmf00 added inline comments. Comment at: zorg/buildbot/builders/LLDBBuilder.py:50 install_cmd = ['ninja','install'] -test_cmd = ['ninja','check-lldb'] +test_cmd = ['ninja','check-lldb', '-v'] ljmf00 wrote: > I don't know if ninja verbosity propaga

[Lldb-commits] [PATCH] D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code

ljmf00 added a comment. Ping @shafik @bulbazord . Can you re-review? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114668/new/ https://reviews.llvm.org/D114668 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

ljmf00 created this revision. ljmf00 added a project: LLDB. Herald added subscribers: JDevlieghere, pengfei. ljmf00 requested review of this revision. Herald added a subscriber: lldb-commits. This patch disables the following tests on non-AVX machines: - `lldb-shell :: Register/x86-64-write.test`

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

ljmf00 added inline comments. Comment at: lldb/test/Shell/Register/x86-mm-xmm-write.test:1-2 # XFAIL: system-darwin # XFAIL: system-windows + Maybe those XFAILs are related to this too. Can anyone test this on those systems, if you have a CPU with AVX extensio

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

ljmf00 added a comment. In D117928#3262656 , @JDevlieghere wrote: > Why are we disabling a lldb test because of a bug in GDB? Because GDB is used on systems that don't implement a `RegisterContext`. I added an inline comment about Darwin and Windows XF

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

ljmf00 added a comment. In D117928#3262689 , @jingham wrote: > In D117928#3262656 , @JDevlieghere > wrote: > >> Why are we disabling a lldb test because of a bug in GDB? > > Maybe somebody is running the lldb tes

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

ljmf00 added a comment. In D117928#3262710 , @jingham wrote: > I guess we're just all confused that you are mentioning GDB at all, and the > only thing I could think of is gdbserver, since that's the only way anything > GDB could get mixed with anything

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

ljmf00 added a comment. In D117928#3262874 , @jingham wrote: > Ah, I think your confusion is that you missed the “Remote” part of all the > classes in lldb that start with “GDB”. They are so called because they use > the “gdb remote serial protocol” t

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

ljmf00 added a comment. In D117928#3263319 , @mgorny wrote: > Ok, so to summarize: there's some CPU families where setting `xmm2..xmm9` via > ptrace doesn't work for some reason? That's quite weird. Could it be an > `xsave` bug perhaps? Exactly. `ptrac

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

ljmf00 added a comment. In D117928#3263992 , @mgorny wrote: > Thank you. Yes, please test on an older kernel, in case it's specifically a > kernel regression. I can confirm regression on Linux LTS 5.10.93. Probably later and introduced by the patch I m

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

ljmf00 added a comment. In D117928#3265583 , @mgorny wrote: > Could you try replacing the new function with the old one and seeing if that > helps? Or alternatively, trying to build a kernel from the commit just before > that change and with that change

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

ljmf00 added a comment. Meanwhile, a commit will land Linux stable branches soon to fix this issue: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=44cad52cc14ae10062f142ec16ede489bccf4469 . Do we have an alternative way to fix this, e.g. a custom XFAIL flag for specific

[Lldb-commits] [PATCH] D120690: [PDB] Add char8_t type

ljmf00 added a comment. Thanks for adding this, I ended up forgoting, since I don't use PDB. Comment at: lldb/include/lldb/lldb-enumerations.h:752 eBasicTypeChar32, + eBasicTypeChar8, eBasicTypeShort, You forgot to add it to the Python API. It should als