[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#3157524 , @kasper81 wrote: > Hi Luis, are you planning on adding plugin architecture support (in > `lldb/source/Plugins/Architecture`) as part of this work? I commandeered this patch from Simon Cook, the original au

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2875107 , @kasper81 wrote: > Hi, I have my fingers crossed since this request was opened in 2019. It seems > like it compiles and usable to certain degree. Can this patch be merged and > included in llvm 13 as initi

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2790028 , @luismarques wrote: > That's surprising. I'll see if I can figure out what the issue might be. > Thanks. Confirmed. Something must have broken since the last patch revision. I'll see if I can figure out /

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2789409 , @sven wrote: > I have tried the patch with llvm12, test case is provide by > jade(https://gist.github.com/e2efac2f780ed820277dbaf608805f4e), but it didn't > worked for me. > It seems that the unwind didn't

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques updated this revision to Diff 341471. luismarques added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62732/new/ https://reviews.llvm.org/D62732 Files: lldb/include/lldb/Utility/ArchSpec.h lldb/s

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2724040 , @JDevlieghere wrote: > Any update on the testing strategy yet? It seems like that this is actively > being used and worked on, so I'm generally supportive of landing this with > some elementary coverage.

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques updated this revision to Diff 341153. luismarques added a comment. Rebase and fix the unwinding issue reported by @jade. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62732/new/ https://reviews.llvm.org/D62732 Files: lldb/include/lld

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2707945 , @jade wrote: > These files are also available as a gist, which can be grabbed with: `git > clone https://gist.github.com/e2efac2f780ed820277dbaf608805f4e > lldb-riscv-repro` Thank you for the reproducer.

[Lldb-commits] [PATCH] D86292: [LLDB][RISCV] Add RISC-V ArchSpec and rv32/rv64 variant detection

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG15f597115068: [LLDB][RISCV] Add RISC-V ArchSpec and rv32/rv64 variant detection (authored by luismarques). Changed prior to commit: https://review

[Lldb-commits] [PATCH] D86292: [LLDB][RISCV] Add RISC-V ArchSpec and rv32/rv64 variant detection

luismarques updated this revision to Diff 307360. luismarques added a comment. Merge tests, using `--docnum`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86292/new/ https://reviews.llvm.org/D86292 Files: lldb/include/lldb/Utility/ArchSpec.h

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2306055 , @labath wrote: > I'm not sure what's the state of risc-v hardware these days and how much > resources do you have available, but if it's at all possible, I'd definitely > recommend adding the lldb-server b

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques updated this revision to Diff 302182. luismarques added a comment. Herald added subscribers: frasercrmck, NickHung. - Use MCBasedABI - Remove ArchSpec core bits, to be moved to D86292 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D86292: [LLDB][RISCV] Add RISC-V ArchSpec and rv32/rv64 variant detection

luismarques updated this revision to Diff 302190. luismarques retitled this revision from "[LLDB][RISCV] Distinguish between riscv32 and riscv64 based on ELF class" to "[LLDB][RISCV] Add RISC-V ArchSpec and rv32/rv64 variant detection". luismarques edited the summary of this revision. luismarques

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2288013 , @JDevlieghere wrote: > Sounds reasonable to me. Maybe it's still to early for that but have you > tried running (part of) the test suite under QEMU yet? It should give you a > pretty good idea of the stat

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2286332 , @wallace wrote: > @luismarques , what's the recommended gdb-server implementation you recommend > for me to try this on a riscv machine? I compiled mine from the mainline binutils-gdb git repository (runni

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques commandeered this revision. luismarques added a reviewer: simoncook. luismarques added a comment. Commandeering the patch, as discussed in the last RISC-V sync-up call. I'll update it with only minor changes; further development can be done in follow-up patches. Repository: rG LL

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. @labath @jrtc27 @clayborg Now that we have at least 3 open-source debug servers that we can use to test this with (OpenOCD, QEMU gdbstub, gdbserver) perhaps this can be merged? I had very good results using this patch with OpenOCD. This patch doesn't include automat

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques updated this revision to Diff 289696. luismarques added a comment. - Fix list of callee saved registers; - Fix typo; - Fix trivial clang-format issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62732/new/ https://reviews.llvm.org/D62

[Lldb-commits] [PATCH] D86292: [LLDB][RISCV] Distinguish between riscv32 and riscv64 based on ELF class

luismarques added a comment. In D86292#2237143 , @jrtc27 wrote: > Not so silly; gdb (well, the names are inherited from bfd) has `set > architecture riscv:rv32`/`set architecture riscv:rv64` :) Ha! We're in good company then. Thanks for sharing, Jessica.

[Lldb-commits] [PATCH] D86292: [LLDB][RISCV] Distinguish between riscv32 and riscv64 based on ELF class

luismarques updated this revision to Diff 286994. luismarques added a comment. Add riscv32 test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86292/new/ https://reviews.llvm.org/D86292 Files: lldb/include/lldb/Utility/ArchSpec.h lldb/source/P

[Lldb-commits] [PATCH] D86292: [LLDB][RISCV] Distinguish between riscv32 and riscv64 based on ELF class

luismarques created this revision. luismarques added reviewers: asb, lenary, clayborg, jasonmolenda, simoncook. Herald added subscribers: lldb-commits, evandro, apazos, sameer.abuasal, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edw

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2193729 , @simoncook wrote: > As for next steps, if we're happy with the state then I think this should > land (assuming qemu is sufficient given it is public), and then we can flesh > out other bits which give a be

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

luismarques added a comment. In D62732#2038309 , @jrtc27 wrote: > Yeah, I don't think we want to be merging code we can't test even in a > non-automated way. Even if this code is completely bug-free, the inability to > test it just means we risk having i