[Lldb-commits] [PATCH] D147627: [lldb][ObjectFileELF] Improve error output for unsupported arch/relocations

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM. I think this is a requirement for adding other 32bit arch support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147627/new/ https

[Lldb-commits] [PATCH] D145550: [LLDB][ObjectFileELF] Correct the return type of RelocOffset64 and RelocAddend64

This revision was automatically updated to reflect the committed changes. Closed by commit rG174a38f9c316: [LLDB][ObjectFileELF] Correct the return type of RelocOffset64 and RelocAddend64 (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D145571: [LLDB][ObjectFileELF] Correct the return type of Reloc{Offset, Addend}32

This revision was automatically updated to reflect the committed changes. Closed by commit rG27705f456a3a: [LLDB][ObjectFileELF] Correct the return type of Reloc{Offset,Addend}32 (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D145462: [LLDB][ObjectFileELF] Support LoongArch64 in ApplyReloctions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2c93873d191: [LLDB][ObjectFileELF] Support LoongArch64 in ApplyReloctions (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145462/new

[Lldb-commits] [PATCH] D145571: [LLDB][ObjectFileELF] Correct the return type of Reloc{Offset, Addend}32

SixWeining created this revision. SixWeining added a reviewer: DavidSpickett. Herald added a subscriber: emaste. Herald added a project: All. SixWeining requested review of this revision. Herald added subscribers: lldb-commits, MaskRay. Herald added a project: LLDB. This is a follow up of D145550

[Lldb-commits] [PATCH] D145550: [LLDB][ObjectFileELF] Correct the return type of RelocOffset64 and RelocAddend64

SixWeining updated this revision to Diff 503264. SixWeining added a comment. Address @DavidSpickett's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145550/new/ https://reviews.llvm.org/D145550 Files: lldb/source/Plugins/ObjectFile/ELF/

[Lldb-commits] [PATCH] D145550: [LLDB][ObjectFileELF] Correct the return type of RelocOffset64 and RelocAddend64

SixWeining added a comment. In D145550#4177291 , @DavidSpickett wrote: > Seems to me that member functions of `ELFRelocation` should use the typedefs > from `lldb/source/Plugins/ObjectFile/ELF/ELFHeader.h` where there is one. > `elf_sxword` for example

[Lldb-commits] [PATCH] D145550: [LLDB][ObjectFileELF] Correct the return type of RelocOffset64 and RelocAddend64

SixWeining created this revision. SixWeining added reviewers: DavidSpickett, labath, davide, xen0n, wangleiat, MaskRay. Herald added a subscriber: emaste. Herald added a project: All. SixWeining requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commit

[Lldb-commits] [PATCH] D145462: [LLDB][ObjectFileELF] Support LoongArch64 in ApplyReloctions

SixWeining updated this revision to Diff 503236. SixWeining added a comment. Address @DavidSpickett's comments. 1. Fix the `&&` issue. 2. Make the test more readable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145462/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D145462: [LLDB][ObjectFileELF] Support LoongArch64 in ApplyReloctions

SixWeining added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2623 +(is_signed && + ((int64_t)value > INT32_MAX && (int64_t)value < INT32_MIN))) { + Log *log = GetLog(LLDBLog::Modules); DavidSpickett wrote

[Lldb-commits] [PATCH] D145462: [LLDB][ObjectFileELF] Support LoongArch64 in ApplyReloctions

SixWeining created this revision. SixWeining added reviewers: labath, davide, DavidSpickett, xen0n, wangleiat, MaskRay. Herald added subscribers: pengfei, emaste. Herald added a project: All. SixWeining requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lld

[Lldb-commits] [PATCH] D140759: [LLDB][LoongArch] Add FP branch instructions for EmulateInstructionLoongArch

This revision was automatically updated to reflect the committed changes. Closed by commit rGb7ae5762a110: [LLDB][LoongArch] Add FP branch instructions for EmulateInstructionLoongArch (authored by lh03061238, committed by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D140615: [LLDB][LoongArch] Delete the s9 register alias definition

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1f4f06dede5: [LLDB][LoongArch] Delete the s9 register alias definition (authored by lh03061238, committed by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D140386: [LLDB][LoongArch] Add unittests for EmulateInstructionLoongArch

This revision was automatically updated to reflect the committed changes. Closed by commit rG1eaadaea5090: [LLDB][LoongArch] Add unittests for EmulateInstructionLoongArch (authored by lh03061238, committed by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D141245: [LLDB][LoongArch] ObjectFile: add a case for `EM_LOONGARCH`

This revision was automatically updated to reflect the committed changes. Closed by commit rGd52582b6b7df: [LLDB][LoongArch] ObjectFile: add a case for `EM_LOONGARCH` (authored by lh03061238, committed by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D140759: [LLDB][LoongArch] Add FP branch instructions for EmulateInstructionLoongArch

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM from the LoongArch side. Thanks. Comment at: lldb/unittests/Instruction/LoongArch/TestLoongArchEmulator.cpp:154 + opcode = opcode >> 2; + return opcode << 26 |

[Lldb-commits] [PATCH] D140759: [LLDB][LoongArch] Add FP branch instructions for EmulateInstructionLoongArch

SixWeining added inline comments. Comment at: lldb/source/Plugins/Instruction/LoongArch/EmulateInstructionLoongArch.cpp:42 "bnez rj, offs21"}, + {0xfc00, 0x4800, &EmulateInstructionLoongArch::EmulateBCXXZ, + "bceqz/bcnez cj, offs21"},

[Lldb-commits] [PATCH] D140615: [LLDB][LoongArch] Delete the s9 register alias definition

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140615/new/ https://reviews.llvm.org/D140615 __

[Lldb-commits] [PATCH] D140386: [LLDB][LoongArch] Add unittests for EmulateInstructionLoongArch

SixWeining added a comment. The tests LGTM. Comment at: lldb/unittests/Instruction/LoongArch/TestLoongArchEmulator.cpp:1-2 +//===-- TestLoongArchEmulator.cpp +//-===// +// Merge these lines into one. CHANGES SINCE L

[Lldb-commits] [PATCH] D140616: [LLDB][LoongArch] Optimize EmulateInstructionLoongArch related code

This revision was automatically updated to reflect the committed changes. Closed by commit rG3473c1093aa0: [LLDB][LoongArch] Optimize EmulateInstructionLoongArch related code (authored by lh03061238, committed by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D140616: [LLDB][LoongArch] Optimize EmulateInstructionLoongArch related code

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140616/new/ https://reviews.llvm.org/D140616 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D140616: [LLDB][LoongArch] Optimize EmulateInstructionLoongArch related code

SixWeining added inline comments. Comment at: lldb/source/Plugins/Instruction/LoongArch/EmulateInstructionLoongArch.cpp:202 bool EmulateInstructionLoongArch::EmulateBEQZ(uint32_t inst) { - if (IsLoongArch64()) -return EmulateBEQZ64(inst); - else -return false; + retu

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

This revision was automatically updated to reflect the committed changes. Closed by commit rGeafe2d4cf17b: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch (authored by lh03061238, committed by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

SixWeining accepted this revision. SixWeining added a comment. LGTM from the LoongArch side. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139833/new/ https://reviews.llvm.org/D139833 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

SixWeining added a comment. 1. Does the directory `lldb/source/Plugins/Instruction/LoongArch/` target both `LoongArch64` and `LoongArch32`? 2. Will you handle floating pointer branching instructions `bceqz` and `bcnez` in future? Comment at: lldb/source/Plugins/Instruction/L

[Lldb-commits] [PATCH] D139158: [LLDB][LoongArch] Make software single stepping work

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a9e07b1e7f4: [LLDB][LoongArch] Make software single stepping work (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139158/new/ https

[Lldb-commits] [PATCH] D139158: [LLDB][LoongArch] Make software single stepping work

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. In D139158#3974801 , @DavidSpickett wrote: > Looks mechanically fine. These classes are all a bit of a copy paste job > right now, so if you

[Lldb-commits] [PATCH] D139158: [LLDB][LoongArch] Make software single stepping work

SixWeining added a comment. I'm not sure whether lldb should follow llvm coding standard. Comment at: lldb/source/Plugins/Instruction/LoongArch/CMakeLists.txt:7-8 +lldbInterpreter +lldbSymbol +lldbPluginProcessUtility + LINK_COMPONENTS It's better

[Lldb-commits] [PATCH] D138407: [LLDB] Add LoongArch register definitions and operations

This revision was automatically updated to reflect the committed changes. Closed by commit rGed34590c1acb: [LLDB] Add LoongArch register definitions and operations (authored by seehearfeel, committed by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

SixWeining added a comment. > Regarding the public buildbot, I'm trying to set it up and maybe we can see > it in one or two weeks. FYI. D138672 is the review for adding LoongArch buildbot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D138407: [LLDB] Add LoongArch register definitions and operations

SixWeining accepted this revision. SixWeining added a comment. My comments are all addressed. LGTM from the LoongArch side. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138407/new/ https://reviews.llvm.org/D138407 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D138407: [LLDB] Add LoongArch register definitions and operations

SixWeining added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterInfos_loongarch64.h:21 +#define GPR_OFFSET(idx) ((idx)*8 + 0) +#define FPR_OFFSET(idx) ((idx)*8 + sizeof(RegisterInfoPOSIX_loongarch64::GPR)) +#define FCC_OFFSET(idx) ((idx)*1 + 32 * 8 + si

[Lldb-commits] [PATCH] D138407: [LLDB] Add LoongArch register definitions and operations

SixWeining added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_loongarch64.cpp:27 +// NT_PRSTATUS and NT_FPREGSET definition +#include + [[ https://llvm.org/docs/CodingStandards.html#include-style | Should be sorted

[Lldb-commits] [PATCH] D137519: [LLDB] Add LoongArch software breakpoint trap opcode

This revision was automatically updated to reflect the committed changes. Closed by commit rG97842fcba9e3: [LLDB] Add LoongArch software breakpoint trap opcode (authored by seehearfeel, committed by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D137519: [LLDB] Add LoongArch software breakpoint trap opcode

SixWeining accepted this revision. SixWeining added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137519/new/ https://reviews.llvm.org/D137519 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [PATCH] D137312: [LLDB] [LoongArch] Add loongarch64 case in ComputeHostArchitectureSupport()

This revision was automatically updated to reflect the committed changes. Closed by commit rGde865087f8c0: [LLDB] [LoongArch] Add loongarch64 case in ComputeHostArchitectureSupport() (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D137057: [LLDB][LoongArch] Add LoongArch ArchSpec and subtype detection

This revision was automatically updated to reflect the committed changes. Closed by commit rGe9c34618c904: [LLDB][LoongArch] Add LoongArch ArchSpec and subtype detection (authored by seehearfeel, committed by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D137057: [LLDB][LoongArch] Add LoongArch ArchSpec and subtype detection

SixWeining added inline comments. Comment at: lldb/source/Utility/ArchSpec.cpp:223 +{eByteOrderLittle, 4, 1, 4, llvm::Triple::loongarch32, + ArchSpec::eCore_loongarch32, "loongarch32"}, xen0n wrote: > `min_opcode_byte_size` should be 4 too, all LoongArc

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

SixWeining accepted this revision. SixWeining added a comment. LGTM for LoongArch related changes. Comment at: lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_loongarch64.h:26 +public: + struct GPR { +uint64_t gpr[32]; xry111 wrote: > SixWeining wro

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

SixWeining added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_loongarch64.h:26 +public: + struct GPR { +uint64_t gpr[32]; Why is this structure and below `FPR` defined like this? Do you intent to keep the layout same a

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

SixWeining added a comment. Build is OK on my local LoongArch machine with 229 failed tests and 2 timed out tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136578/new/ https://reviews.llvm.org/D136578 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

SixWeining added a comment. In D136578#3878744 , @DavidSpickett wrote: > Always good to see another architecture in lldb. > > A few points up front. > > Changes like this are fine and we can review them, but can only be landed > once we see that they'll

[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Fix build errors

SixWeining added inline comments. Comment at: lldb/source/Plugins/Process/Linux/CMakeLists.txt:11 NativeRegisterContextLinux_arm64.cpp + NativeRegisterContextLinux_loongarch64.cpp NativeRegisterContextLinux_ppc64le.cpp Had better use `git diff -U99` to