[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122974/new/ https://reviews.llvm.org/D122974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. In D122974#3586352 , @dblaikie wrote: > ^ I think it's still worthwhile/necessary to separate LLDB's use case/hashing > algorithm choice from LLVM's so LLVM's code can be changed to be more change > resilient in a way that

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. Herald added a subscriber: Michael137. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122974/new/ https://reviews.llvm.org/D122974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. In D122974#3567278 , @dblaikie wrote: >> Then I still don't know what the problem is supposed to be. If the StringMap >> hash implementation ever changes, the necessary LLDB rebuild will detect >> this, the relevant LLDB parts

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122974/new/ https://reviews.llvm.org/D122974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. In D122974#3538413 , @dblaikie wrote: > In D122974#3536342 , @llunak wrote: > >> D124704 adds a unittest that compares >> StringMap::hash() to a known

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. In D122974#3535669 , @dblaikie wrote: >> It doesn't make sense to require a stable hash algorithm for an internal >> cache file. > > It's at least a stronger stability requirement than may be provided before - > like: stable

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak updated this revision to Diff 431597. llunak added a comment. Added documentation for StringMap::hash(), including an explicit comment saying that the implementation is not guaranteed to be stable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122974/new/

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. In D122974#3532822 , @dblaikie wrote: > If we want a structure that can use a stable hash Not for D124704 . It doesn't make sense to require a stable hash algorithm for an internal cache file.

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak updated this revision to Diff 431216. llunak added a comment. - add a function for selecting a pool in ConstString - use uint32_t for hash in StringMap API CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122974/new/ https://reviews.llvm.org/D122974 Files:

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak updated this revision to Diff 427188. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122974/new/ https://reviews.llvm.org/D122974 Files: lldb/source/Utility/ConstString.cpp llvm/include/llvm/ADT/StringMap.h llvm/lib/Support/StringMap.cpp Index:

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak updated this revision to Diff 427187. llunak edited the summary of this revision. llunak added a comment. Used a temporary variable instead of repeated 'm_string_pools[h]'. Added assert that the passed-in hash value matches, guarded by EXPENSIVE_CHECKS. It will assert also hashes computed

[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

This revision was automatically updated to reflect the committed changes. Closed by commit rGb7d807dbcff0: [lldb] parallelize calling of Module::PreloadSymbols() (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122975/new/

[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

llunak added a comment. The prerequisities fo this change have been pushed, so this one is ready. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122975/new/ https://reviews.llvm.org/D122975 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

This revision was automatically updated to reflect the committed changes. Closed by commit rG20048f3150cf: [lldb] use one shared ThreadPool and task groups (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123226/new/

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

llunak updated this revision to Diff 426269. llunak added a comment. Changed to use std::call_once(). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123226/new/ https://reviews.llvm.org/D123226 Files: lldb/include/lldb/Core/Debugger.h lldb/source/Core/Debugger.cpp

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

llunak marked 2 inline comments as done. llunak added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1969 +llvm::ThreadPool ::GetThreadPool() { + static llvm::ThreadPool threadpool(llvm::optimal_concurrency()); + return threadpool; clayborg wrote:

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. In D122974#3483647 , @llunak wrote: > I can measure 10% startup time saved when everything is already cached. > Funnily enough, profiler consistently claims that saving caches got faster > too (I already use D122975

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. In D122974#3483203 , @clayborg wrote: > If the string pool caches the hash value, we could actually write out the > hash in the cache file to speed up loading. The patch doing that is D124704

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. In D122974#3482556 , @labath wrote: > Interesting. I don't know if I missed this somewhere, but could explain what > kind of a map operation can lldb perform without computing the hash at least > once? All of them :). Computing

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. In D122974#3481852 , @labath wrote: > In D122974#3481269 , @llunak wrote: > >> But what if I don't want StringMap to compute the hash at all? There's still >> that 10-15% of CPU time

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. In D122974#3480686 , @dblaikie wrote: > In D122974#3424654 , @JDevlieghere > wrote: > >> ... >> struct HashedStringRef { >> const llvm::StringRef str; >> const unsigned

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122974/new/ https://reviews.llvm.org/D122974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

llunak updated this revision to Diff 423247. llunak added a comment. Adapted to API changes from D123225 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122975/new/ https://reviews.llvm.org/D122975 Files: lldb/source/Target/Target.cpp Index:

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

llunak updated this revision to Diff 423246. llunak edited the summary of this revision. llunak added a comment. ThreadPool object is now created/destroyed by Debugger class ctor/dtor. Adapted to API changes from D123225 . CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

llunak marked an inline comment as done. llunak added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1969 +llvm::ThreadPool ::GetThreadPool() { + static llvm::ThreadPool threadpool(llvm::optimal_concurrency()); + return threadpool; clayborg wrote:

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. Ping @dblaikie ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122974/new/ https://reviews.llvm.org/D122974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D123128: don't extra notify ModulesDidLoad() from LoadModuleAtAddress()

This revision was automatically updated to reflect the committed changes. Closed by commit rG195a8b977efe: dont extra notify ModulesDidLoad() from LoadModuleAtAddress() (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123128/new/

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

llunak added a comment. In D123020#3442434 , @labath wrote: > In D123020#3437246 , @llunak wrote: > >> In D123020#3426867 , @JDevlieghere >> wrote: >> >>> FWIW the

[Lldb-commits] [PATCH] D123128: don't extra notify ModulesDidLoad() from LoadModuleAtAddress()

llunak updated this revision to Diff 421782. llunak edited the summary of this revision. llunak added a comment. Changed to always disable notify and added a comment about that to LoadModuleAtAddress(). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123128/new/

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

llunak abandoned this revision. llunak added a comment. In D123020#3426867 , @JDevlieghere wrote: > FWIW the official policy is outlined here: > https://llvm.org/docs/CodeReview.html I'm aware of it, but as far as I can judge I was following it. Even

[Lldb-commits] [PATCH] D123008: remove the "expand" diamond for variables where expanding fails

This revision was automatically updated to reflect the committed changes. Closed by commit rGc29a51b3a257: [lldb][gui] remove the expand diamond for variables where expanding fails (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D123015: handle Ctrl+C to stop a running process

This revision was automatically updated to reflect the committed changes. Closed by commit rGf42f21746cb8: [lldb][gui] handle Ctrl+C to stop a running process (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123015/new/

[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

llunak updated this revision to Diff 420885. llunak added a comment. Rebased on ThreadPool groups (D123225 ) and adding such thread pool to LLDB (D123226 ). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122975/new/

[Lldb-commits] [PATCH] D123226: [lldb] use one shared ThreadPool and task groups

llunak created this revision. llunak added reviewers: clayborg, labath. llunak added a project: LLDB. Herald added subscribers: JDevlieghere, arphaman. Herald added a project: All. llunak requested review of this revision. Herald added a subscriber: lldb-commits. As a preparation for

[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

llunak added a comment. In D122975#3430613 , @JDevlieghere wrote: > After applying this patch I started seeing data races reported by TSan when > running the shell tests (`check-lldb-shell`). It seems to happen to different > tests on different runs

[Lldb-commits] [PATCH] D122975: parallelize calling of Module::PreloadSymbols()

llunak updated this revision to Diff 420492. llunak retitled this revision from "parallelize module loading in DynamicLoaderPOSIXDYLD()" to "parallelize calling of Module::PreloadSymbols()". llunak edited the summary of this revision. llunak added a reviewer: jingham. llunak added a comment.

[Lldb-commits] [PATCH] D123128: don't extra notify ModulesDidLoad() from LoadModuleAtAddress()

llunak created this revision. llunak added a reviewer: jasonmolenda. llunak added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. llunak requested review of this revision. Herald added a subscriber: lldb-commits. Places calling LoadModuleAddress() already

[Lldb-commits] [PATCH] D122975: parallelize module loading in DynamicLoaderPOSIXDYLD()

llunak added a comment. In D122975#3428876 , @labath wrote: > OK, got it. So, for this case, I think the best approach would be to extract > and paralelize the `PreloadSymbols` calls. They are not deep (=> relatively > easy to extract), optional (they

[Lldb-commits] [PATCH] D123001: make 'step out' step out of the selected frame

This revision was automatically updated to reflect the committed changes. Closed by commit rG76bc77292089: [lldb][gui] make step out step out of the selected frame (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123001/new/

[Lldb-commits] [PATCH] D122998: use just '#' instead of 'frame #2' in the threads/frame view

This revision was automatically updated to reflect the committed changes. Closed by commit rGf90fa55569fc: [lldb][gui] use just #2 instead of frame #2 in the threads/frame view (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D122997: do not show the help window on first gui startup

This revision was automatically updated to reflect the committed changes. Closed by commit rGaaca2acd5f34: [lldb][gui] do not show the help window on first gui startup (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122997/new/

[Lldb-commits] [PATCH] D123001: make 'step out' step out of the selected frame

llunak updated this revision to Diff 420295. llunak added a comment. Added a test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123001/new/ https://reviews.llvm.org/D123001 Files: lldb/include/lldb/Target/Thread.h lldb/source/Core/IOHandlerCursesGUI.cpp

[Lldb-commits] [PATCH] D122975: parallelize module loading in DynamicLoaderPOSIXDYLD()

llunak added a comment. In D122975#3427008 , @clayborg wrote: > I had tried something similar with the thread pools when trying to > parallelize similar stuff. The solution I made was to have a global thread > pool for the entire LLDB process, but then

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

llunak added a comment. In D123020#3426252 , @labath wrote: >> BTW, does it make sense to get even things like this reviewed, or is it ok >> if I push these directly if I'm reasonably certain I know what I'm doing? I >> feel like I'm spamming you by

[Lldb-commits] [PATCH] D122980: make ConstStringTable use DenseMap rather than std::map

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a6a0dfa06a5: [lldb] make ConstStringTable use DenseMap rather than std::map (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122980/new/

[Lldb-commits] [PATCH] D122975: parallelize module loading in DynamicLoaderPOSIXDYLD()

llunak added a comment. In D122975#3426575 , @labath wrote: > I'd like to understand what is the precise thing that you're trying to > optimise. If there is like a single hot piece of code that we want to > optimise, then we might be able to come up

[Lldb-commits] [PATCH] D123020: increase timeouts if running on valgrind

llunak created this revision. llunak added a reviewer: clayborg. llunak added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. llunak requested review of this revision. Herald added a subscriber: lldb-commits. Valgrind makes everything run much slower, so

[Lldb-commits] [PATCH] D123015: handle Ctrl+C to stop a running process

llunak created this revision. llunak added a reviewer: clayborg. llunak added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. llunak requested review of this revision. Herald added a subscriber: lldb-commits. This is essentially the same as

[Lldb-commits] [PATCH] D123008: remove the "expand" diamond for variables where expanding fails

llunak created this revision. llunak added a reviewer: clayborg. llunak added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. llunak requested review of this revision. Herald added a subscriber: lldb-commits. If the variables view shows a variable that is a

[Lldb-commits] [PATCH] D123001: make 'step out' step out of the selected frame

llunak created this revision. llunak added a reviewer: clayborg. llunak added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. llunak requested review of this revision. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D122998: use just '#' instead of 'frame #2' in the threads/frame view

llunak created this revision. llunak added a reviewer: clayborg. llunak added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. llunak requested review of this revision. Herald added a subscriber: lldb-commits. Since the threads/frame view is taking only a

[Lldb-commits] [PATCH] D122997: do not show the help window on first gui startup

llunak created this revision. llunak added a reviewer: clayborg. llunak added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. llunak requested review of this revision. Herald added a subscriber: lldb-commits. It's rather annoying if it's there after every

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. In D122974#3424654 , @JDevlieghere wrote: > I'm slightly concerned about the two hash values (the "full" hash vs the > single byte one). That's not something that was introduced in this patch, but > passing it around adds an

[Lldb-commits] [PATCH] D122980: make ConstStringTable use DenseMap rather than std::map

llunak updated this revision to Diff 419996. llunak retitled this revision from "make ConstStringTable use std::unordered_map rather than std::map" to "make ConstStringTable use DenseMap rather than std::map". llunak edited the summary of this revision. llunak added a comment. In

[Lldb-commits] [PATCH] D122980: make ConstStringTable use std::unordered_map rather than std::map

llunak created this revision. llunak added a reviewer: clayborg. llunak added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. llunak requested review of this revision. Herald added a subscriber: lldb-commits. The ordering is not needed, and

[Lldb-commits] [PATCH] D122975: parallelize module loading in DynamicLoaderPOSIXDYLD()

llunak created this revision. llunak added reviewers: clayborg, labath. llunak added a project: LLDB. Herald added subscribers: usaxena95, JDevlieghere, kadircet. Herald added a project: All. llunak requested review of this revision. Herald added subscribers: lldb-commits, ilya-biryukov. If LLDB

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak created this revision. llunak added reviewers: clayborg, chandlerc. Herald added subscribers: dexonsmith, hiraditya. Herald added a project: All. llunak requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits.

[Lldb-commits] [PATCH] D86416: [lldb] -stdlib=libc++ for linking with lldb lib also if LLVM_ENABLE_LIBCXX

llunak added a comment. In D86416#2286333 , @JDevlieghere wrote: > Which tests are affected by this? I don't know. There are 5 hits for 'buildDriver' and 8 for '%include_SB_APIs%' under tests/, so at least 13, but I don't know if that's all. > How

[Lldb-commits] [PATCH] D86416: [lldb] -stdlib=libc++ for linking with lldb lib also if LLVM_ENABLE_LIBCXX

llunak added a comment. Ping. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86416/new/ https://reviews.llvm.org/D86416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D86416: [lldb] -stdlib=libc++ for linking with lldb lib also if LLVM_ENABLE_LIBCXX

llunak added a comment. Ping. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86416/new/ https://reviews.llvm.org/D86416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D86417: [lldb] do not propagate eTrapHandlerFrame repeatedly

llunak abandoned this revision. llunak added a comment. Funny coincidence, the ctor has been broken for 5 years and that commit introducing my problem has been there for a year. Ok, closing, thank you for your help. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D86417: [lldb] do not propagate eTrapHandlerFrame repeatedly

llunak added a comment. No, everything's fine :). See the updated patch. The UnwindPlan object already enters x86AssemblyInspectionEngine::AugmentUnwindPlanFromCallSite() with the lazybool uninitialized and fixing that fixes everything: (lldb) bt * thread #1, name = 'a.out', stop reason =

[Lldb-commits] [PATCH] D86417: [lldb] do not propagate eTrapHandlerFrame repeatedly

llunak updated this revision to Diff 288780. llunak edited the summary of this revision. llunak added a comment. And it indeed was suspicious. 3fd917d8860e9bdcabc14c536da4377307906be0 didn't update the UnwindPlan copy ctor to copy the field. This patch fixes the problem even without your

[Lldb-commits] [PATCH] D86417: [lldb] do not propagate eTrapHandlerFrame repeatedly

llunak added a comment. In D86417#2239062 , @JosephTremoulet wrote: > and let me know how that goes? I don't have a linux system here to try it > on, but I have a feeling this may fix the problem you're seeing. Yes, it fixes my problem. However (if

[Lldb-commits] [PATCH] D86417: [lldb] do not propagate eTrapHandlerFrame repeatedly

llunak added a comment. In D86417#2237602 , @jasonmolenda wrote: > lldb thinks that both frames 1 & 2 are trap handler frames. They have full > register context available for the frame above them on the stack (that is, > frames 2 & 3) and frames 2 & 3

[Lldb-commits] [PATCH] D86417: [lldb] do not propagate eTrapHandlerFrame repeatedly

llunak added a comment. In D86417#2236337 , @JosephTremoulet wrote: >> And its parent 'raise' is set so as well because of >> 'GetNextFrame()->m_frame_type == eTrapHandlerFrame '. > > Sorry, can you clarify what code path you're referring to here? I

[Lldb-commits] [PATCH] D86416: [lldb] -stdlib=libc++ for linking with lldb lib also if LLVM_ENABLE_LIBCXX

llunak marked an inline comment as done. llunak added a comment. In D86416#2232966 , @teemperor wrote: > Out of curiosity, will this also fix the TestPluginCommands.py ? Yes. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D86416: [lldb] -stdlib=libc++ for linking with lldb lib also if LLVM_ENABLE_LIBCXX

llunak updated this revision to Diff 287451. llunak added a comment. Updated to not use environment variable. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86416/new/ https://reviews.llvm.org/D86416 Files:

[Lldb-commits] [PATCH] D86417: [lldb] do not propagate eTrapHandlerFrame repeatedly

llunak created this revision. llunak added reviewers: JosephTremoulet, jasonmolenda. llunak added a project: LLDB. Herald added a subscriber: JDevlieghere. llunak requested review of this revision. This fixes handle-abrt test on my x86_64 openSUSE 15.2. The regression was introduced by

[Lldb-commits] [PATCH] D86416: [lldb] -stdlib=libc++ for linking with lldb lib also if LLVM_ENABLE_LIBCXX

llunak created this revision. llunak added reviewers: labath, zturner. llunak added a project: LLDB. Herald added a subscriber: JDevlieghere. llunak requested review of this revision. Otherwise on Linux e.g. the api/command-return-object test uses libstdc++ for the test app and libc++ is used

[Lldb-commits] [PATCH] D85290: [lldb][gui] use left/right in the source view to scroll

This revision was automatically updated to reflect the committed changes. Closed by commit rGdcd4589a0d68: [lldb][gui] use left/right in the source view to scroll (authored by llunak). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D85290?vs=283192=286246#toc

[Lldb-commits] [PATCH] D85290: [lldb][gui] use left/right in the source view to scroll

llunak added a comment. Ping. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85290/new/ https://reviews.llvm.org/D85290 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D85286: [lldb][gui] use names for color pairs, instead of magic numbers

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a8e4b5c7447: [lldb][gui] use names for color pairs, instead of magic numbers (authored by llunak). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG14406ca01fd3: [lldb][gui] use syntax highlighting also in gui mode (authored by llunak). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D85145?vs=282865=283498#toc

[Lldb-commits] [PATCH] D85123: Truncate long lines/names if needed in lldb gui

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc0e8fb7874a: [lldb][gui] truncate long lines/names if needed (authored by llunak). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D85290: [lldb][gui] use left/right in the source view to scroll

llunak created this revision. llunak added a reviewer: clayborg. llunak requested review of this revision. I intentionally decided not to reset the column automatically anywhere, because I don't know where and if at all that should happen. There should be always an indication of being scrolled

[Lldb-commits] [PATCH] D85286: [lldb][gui] use names for color pairs, instead of magic numbers

llunak updated this revision to Diff 283175. llunak added a comment. Change also SetBackground() calls. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85286/new/ https://reviews.llvm.org/D85286 Files: lldb/source/Core/IOHandlerCursesGUI.cpp Index:

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

llunak added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:486 + if (!string.consume_front("[")) { +llvm::errs() << "Missing '[' in color escape sequence.\n"; +continue; clayborg wrote: > So what will happen if we

[Lldb-commits] [PATCH] D85286: [lldb][gui] use names for color pairs, instead of magic numbers

llunak created this revision. llunak added a reviewer: clayborg. llunak requested review of this revision. Repository: rLLDB LLDB https://reviews.llvm.org/D85286 Files: lldb/source/Core/IOHandlerCursesGUI.cpp Index: lldb/source/Core/IOHandlerCursesGUI.cpp

[Lldb-commits] [PATCH] D85123: Truncate long lines/names if needed in lldb gui

llunak updated this revision to Diff 283155. llunak added a comment. Use SteamString. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85123/new/ https://reviews.llvm.org/D85123 Files: lldb/source/Core/IOHandlerCursesGUI.cpp

[Lldb-commits] [PATCH] D85088: Implement TerminalSizeChanged() for lldb ncurses GUI

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f1b24b70c6c: [lldb][gui] implement TerminalSizeChanged() (authored by llunak). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D85106: Move TestGuiBasicDebug.py to lldb/test and update it

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7be982c836c: [lldb][gui] move TestGuiBasicDebug.py to lldb/test and update it (authored by llunak). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D85219: [lldb] fix building with panel.h being in /usr/include/ncurses/

This revision was automatically updated to reflect the committed changes. Closed by commit rGc952ec15d388: [lldb] fix building with panel.h being in /usr/include/ncurses/ (authored by llunak). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D85098: Implement breakpoint removal on breakpoint toggling in lldb gui

This revision was automatically updated to reflect the committed changes. Closed by commit rGd6868d9ca1db: [lldb][gui] implement breakpoint removal on breakpoint toggling (authored by llunak). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D85107: Add a test for 'b' (toggle breakpoint)

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb828aba55ac: [lldb][gui] add a test for b (toggle breakpoint) (authored by llunak). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D85089: Implement shift+tab for going back in lldb gui views

This revision was automatically updated to reflect the committed changes. llunak marked 2 inline comments as done. Closed by commit rG7a63dc534eb8: [lldb][gui] implement shift+tab for going back in views (authored by llunak). Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D85106: Move TestGuiBasicDebug.py to lldb/test and update it

llunak added a comment. I personally don't particularly care where the tests are, I just wanted all the gui tests to be together to make it simpler to run them all. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85106/new/ https://reviews.llvm.org/D85106

[Lldb-commits] [PATCH] D85219: [lldb] fix building with panel.h being in /usr/include/ncurses/

llunak created this revision. llunak added a reviewer: clayborg. Herald added a subscriber: mgorny. llunak requested review of this revision. My openSUSE 15.2 has /usr/include/curses.h as a symlink to /usr/include/ncurses/curses.h , but there's no such symlink for panel.h . Prefer using

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

llunak updated this revision to Diff 282865. llunak added a comment. Updated according to comments. I find some of the StringRef APIs flawed though: consume_front() returns true on success, but consumeInteger() returns false; consume_front() modifies the object, but drop_front() doesn't.

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

llunak added a comment. In D85145#2192716 , @teemperor wrote: > I wonder if there is a reasonable way to test this. From what I understand > these attributes aren't in any output buffer that we could expect (e.g., with > a pexpect test). I'm not sure.

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

llunak added a comment. In D85145#2191421 , @teemperor wrote: > Btw, the highlighter supports any kind of delimiter string when > 'highlighting' source. So you could add a parameter for a custom highlighter > too and then pass a more convenient

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

llunak created this revision. llunak added a reviewer: clayborg. llunak requested review of this revision. Use the same functionality as the non-gui mode, the colors just need translating to curses colors. Repository: rLLDB LLDB https://reviews.llvm.org/D85145 Files:

[Lldb-commits] [PATCH] D85123: Truncate long lines/names if needed in lldb gui

llunak updated this revision to Diff 282607. llunak added a comment. Handle properly also the "<<< Thread 1: breakpoint 1.1" marker. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85123/new/ https://reviews.llvm.org/D85123 Files:

[Lldb-commits] [PATCH] D85123: Truncate long lines/names if needed in lldb gui

llunak created this revision. llunak added a reviewer: clayborg. llunak requested review of this revision. Without this, sources with long lines or variable names may overwrite panel frames, or even overrun to the following line. There's currently no way to scroll left/right in the views, so

[Lldb-commits] [PATCH] D85107: Add a test for 'b' (toggle breakpoint)

llunak updated this revision to Diff 282543. llunak edited the summary of this revision. llunak added a comment. Removed use of curses python module, lldbexpect hardcodes TERM=vt100, so the escape sequence should be actually hardcoded too. The previous version didn't work e.g. in Linux console.

[Lldb-commits] [PATCH] D85096: Fix lldb test on lib64 systems

This revision was automatically updated to reflect the committed changes. Closed by commit rG18d4069503e7: fix lldb test on lib64 systems (authored by llunak). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D85107: Add a test for 'b' (toggle breakpoint)

llunak created this revision. llunak added a reviewer: clayborg. llunak requested review of this revision. The test needs the python curses module, to get the proper escape sequence to send the down key event. I'm not sure if it's ok to just use the module, or if some check for it should be

[Lldb-commits] [PATCH] D85106: Move TestGuiBasicDebug.py to lldb/test and update it

llunak created this revision. llunak added a reviewer: clayborg. llunak requested review of this revision. Between the time it was created and it was pushed upstream, 99451b4453688a94c6014cac233d371ab4cc342d has moved the

[Lldb-commits] [PATCH] D85098: Implement breakpoint removal on breakpoint toggling in lldb gui

llunak created this revision. llunak added a reviewer: clayborg. llunak requested review of this revision. It says it toggles breakpoints, so if one already exists on the selected location, remove it instead of adding. Repository: rLLDB LLDB https://reviews.llvm.org/D85098 Files:

  1   2   >