[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

mark2185 added a comment. In D136465#3884755 , @DavidSpickett wrote: >> Great! I'd just like to note that I do not have commit access, per the >> guide's instructions. > > What name/email address do you want on the commit? Luka Markušić

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

mark2185 added a comment. In D136465#3884047 , @clayborg wrote: > Looks ok to me. I don't do Android stuff on a daily basis. As long as the old > way of connecting still works I think this is ok. Great! I'd just like to note that I do not have commit

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

mark2185 updated this revision to Diff 470421. mark2185 added a comment. Make remote-android local ports configurable The local ports for `platform connect` and `attach` were always random, this allows the user to configure them. This is useful for debugging a truly remote android (when the

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

mark2185 marked 2 inline comments as done. mark2185 added a comment. Did I just overwrite the initial commit with a new one, instead of just creating a diff based on the two comments? I'm terribly sorry, should I just squash my two commits and run `arc diff --update=D136465` again?

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

mark2185 updated this revision to Diff 470381. mark2185 added a comment. Remove {} for single line if statements per LLVM coding guidelines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136465/new/ https://reviews.llvm.org/D136465 Files:

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

mark2185 added a comment. In D136465#3880809 , @clayborg wrote: > Is there any way to test this? Through the test suite? I couldn't find //any// `android platform` related tests, and this would require `adb` to be running in the background, so I'm not

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

mark2185 added a comment. In D136465#3878640 , @DavidSpickett wrote: > Ok, so this change means that the randomisation still happens, unless you > override it with these environment variables? This seems like a good way to > do it. Exactly, this is

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

mark2185 added a comment. In D136465#3878581 , @DavidSpickett wrote: > Does this account for the situation where you spawn many gdbserver from the > platform and therefore need more ports? Does it even need to? (just guessing > that that could have

[Lldb-commits] [PATCH] D136465: Make remote-android local ports configurable

mark2185 created this revision. Herald added a subscriber: danielkiss. Herald added a project: All. mark2185 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The local ports for `platform connect` and `attach` were always random, this