[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs abandoned this revision. codemzs added a comment. Closing this as it has been resolved by D150913 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150291/new/ https://reviews.llvm.org/D150291 ___

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs added a comment. In D150291#4338118 , @tahonermann wrote: >> I do wonder if we need two bfloat implementations, but for that I'll leave a >> comment on D149573 . > > Given the discussions occurring in D149573

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs added a comment. In D150291#4335352 , @tahonermann wrote: > Thanks for all the updates @codemzs! I'm going to go ahead and accept. But > please wait a few days for recently subscribed folks to have a chance to > comment before landing this.

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs updated this revision to Diff 521363. codemzs marked an inline comment as done. codemzs added a comment. Addressing feedback from @barannikov88 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150291/new/ https://reviews.llvm.org/D150291 Files: clang/include/clang-c/Index.h

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs marked an inline comment as done. codemzs added a comment. In D150291#4335360 , @barannikov88 wrote: > The summary as it is will be hard to read in git log. Please split it into > multiple lines 72~80 chars each. >

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs updated this revision to Diff 521353. codemzs marked 2 inline comments as done. codemzs set the repository for this revision to rG LLVM Github Monorepo. codemzs added a comment. Update comments as per feedback from @tahonermann Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs added a comment. Thank you for pointing that out and for reviewing my code. I appreciate your guidance. I was following the LLVM contribution guidelines to use git clang-format, but I understand the importance of maintaining existing code styles that may be altered by git-clang format.

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs updated this revision to Diff 521163. codemzs marked 4 inline comments as done. codemzs retitled this revision from "[Clang] Rename internal type identifier(s) for `__bf16` to `BF16Ty`" to "[Clang] Rename internal type identifier(s) for __bf16 to BF16Ty". codemzs added a comment. PR

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for `__bf16` to `BF16Ty`

codemzs created this revision. codemzs added reviewers: tahonermann, erichkeane, stuij. Herald added subscribers: mattd, gchakrabarti, asavonic, ctetreau, kerbowa, arphaman, kristof.beyls, jvesely. Herald added a project: All. codemzs requested review of this revision. Herald added subscribers:

[Lldb-commits] [PATCH] D117637: Fix build break on CentOS due to gcc 7.3.1

codemzs added a comment. In D117637#3254195 , @labath wrote: > I needed to dust off my old-deps build for another patch, so I also fixed > this in the process. @labath Have you already committed your change? I need this for our builds that are broken.

[Lldb-commits] [PATCH] D117637: Fix build break on CentOS due to gcc 7.3.1

codemzs added a comment. In D117637#3254195 , @labath wrote: > I needed to dust off my old-deps build for another patch, so I also fixed > this in the process. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D117637: Fix build break on CentOS due to gcc 7.3.1

codemzs created this revision. codemzs added reviewers: mgorny, labath, emaste, krytarowski, stella.stamenova. codemzs requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Pursuant to discussion here https://reviews.llvm.org/D117113