[Lldb-commits] [PATCH] D70772: I implemented the features listed in this document: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0616r0.pdf and built libc++ using ninja without any errors/w

mclow.lists requested changes to this revision. mclow.lists added a comment. This revision now requires changes to proceed. This is a mess. The changes in `libcxx/CMakeLists.txt` are unrelated to P0616. The changes in `algorithm` are also unrelated to P0616. The changes in `forward_list` are also

[Lldb-commits] [PATCH] D62034: compiler-rt/lib/builtins: s/#include /#include /g to match proper case.

mclow.lists added a comment. I have no objection to this; but I'm not really confident that this won't break more than it solves. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62034/new/ https://reviews.llvm.org/D62034 _

[Lldb-commits] [PATCH] D47384: Remove dependency from Host to clang

mclow.lists added inline comments. Herald added a project: LLVM. Comment at: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangHost.cpp:77 + const char *swift_clang_resource_dir = "usr/lib/swift/clang"; + auto parent = std::next(rev_it); + if (parent != r_end && *parent ==

[Lldb-commits] [PATCH] D62654: [Docs] Modernize references to macOS

mclow.lists added a comment. I'm fine with the libc++ changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62654/new/ https://reviews.llvm.org/D62654 ___ lldb-commits mailing list lldb-commits@lists.