https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/158811
None
>From 8ccfc58fd99356e88a16337f1fee21f104c49aa5 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Tue, 16 Sep 2025 01:10:16 -0700
Subject: [PATCH] [lldb] Make LineEntry class and make AddressRang
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/158811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/158811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
Thanks, feel free to merge whenever
https://github.com/llvm/llvm-project/pull/157364
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/158759
>From b204ad16b8584a796585fb376b5258e3240fa71b Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Mon, 15 Sep 2025 18:09:34 -0700
Subject: [PATCH] [lldb/API] Mark SBValue with error as invalid
This pa
medismailben wrote:
I fixed the formatting most of the failures. I only need to find the right way
to return the errors through DAP: prior to this change, errors were returned as
part of the value object string, since the object was still considered valid
but now that it's marked invalid, the
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/158759
>From 9744d606c8ddc03aeba105c89647af4c009dac28 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Mon, 15 Sep 2025 18:04:48 -0700
Subject: [PATCH] [lldb/API] Mark SBValue with error as invalid
This pa
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/158756
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
> > The one downside to this is that any links that we've handed out to the
> > documentation in the past will get broken. Is there any way that we can
> > keep the links that used to be in python-reference.rst, but have them
> > redirected to the new files?
> > Other than
@@ -0,0 +1,45 @@
+import lldb
+
+class FacadeExample:
+def __init__(self, bkpt, extra_args, dict):
+self.bkpt = bkpt
+self.extra_args = extra_args
+self.base_sym = None
+self.facade_locs = []
+self.facade_locs_desc = []
+self.cur
@@ -0,0 +1,45 @@
+import lldb
+
+class FacadeExample:
+def __init__(self, bkpt, extra_args, dict):
+self.bkpt = bkpt
+self.extra_args = extra_args
+self.base_sym = None
+self.facade_locs = []
+self.facade_locs_desc = []
+self.cur
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/158331
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/158128
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -529,6 +561,20 @@ class Breakpoint : public
std::enable_shared_from_this,
m_name_list.erase(name_to_remove);
}
+ enum TypeDisplay {
medismailben wrote:
Can we add a comment for this ?
https://github.com/llvm/llvm-project/pull/158128
@@ -0,0 +1,420 @@
+# Writing Custom Commands
+
+### Create a new command using a Python function
+
+Python functions can be used to create new LLDB command interpreter commands,
+which will work like all the natively defined lldb commands. This provides a
+very flexible and easy w
@@ -0,0 +1,420 @@
+# Writing Custom Commands
+
+### Create a new command using a Python function
+
+Python functions can be used to create new LLDB command interpreter commands,
+which will work like all the natively defined lldb commands. This provides a
+very flexible and easy w
@@ -0,0 +1,45 @@
+import lldb
+
+class FacadeExample:
+def __init__(self, bkpt, extra_args, dict):
+self.bkpt = bkpt
+self.extra_args = extra_args
+self.base_sym = None
+self.facade_locs = []
+self.facade_locs_desc = []
+self.cur
medismailben wrote:
> The one downside to this is that any links that we've handed out to the
> documentation in the past will get broken. Is there any way that we can keep
> the links that used to be in python-reference.rst, but have them redirected
> to the new files?
>
> Other than that it
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/158331
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,45 @@
+import lldb
+
+class FacadeExample:
+def __init__(self, bkpt, extra_args, dict):
+self.bkpt = bkpt
+self.extra_args = extra_args
+self.base_sym = None
+self.facade_locs = []
+self.facade_locs_desc = []
+self.cur
@@ -0,0 +1,45 @@
+import lldb
+
+class FacadeExample:
+def __init__(self, bkpt, extra_args, dict):
+self.bkpt = bkpt
+self.extra_args = extra_args
+self.base_sym = None
+self.facade_locs = []
+self.facade_locs_desc = []
+self.cur
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/149622
>From d5d9e01134e0cf78974cd5f50f028bd71756c24f Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Thu, 4 Sep 2025 14:59:44 -0700
Subject: [PATCH] [lldb] Introduce ScriptedFrame affordance
This patch i
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/149622
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
Great! May be we should do this for:
- `Status::Status(std::string err_str)`
- `static Status FromErrorString(const char *str)`
- `static Status FromErrorStringWithFormat(const char *format, ...)`
- ` template static Status FromErrorStringWithFormatv(const
char *format, Arg
medismailben wrote:
Also, it would be great if we had a clang-tidy checker as part of the CI
testing to catching this inconsistencies earlier 👀
https://github.com/llvm/llvm-project/pull/156774
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/149622
>From 440e6ce8e00130621ec57160ffd80e54e179a5d2 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Thu, 4 Sep 2025 10:52:00 -0700
Subject: [PATCH] [lldb] Introduce ScriptedFrame affordance
This patch i
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/149622
>From a38ed4d99315224889c503d2ce31362be28b28eb Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Wed, 3 Sep 2025 18:32:22 -0700
Subject: [PATCH] [lldb] Introduce ScriptedFrame affordance
This patch i
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/149622
>From df4c41ddc529dce9aac96a698199cb6ed4506000 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Thu, 4 Sep 2025 10:21:46 -0700
Subject: [PATCH] [lldb] Introduce ScriptedFrame affordance
This patch i
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/149622
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/149622
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/149622
>From 583a83e1001a824fcfbc9a0811af3fbaf446e5ca Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Tue, 2 Sep 2025 17:36:27 -0700
Subject: [PATCH 1/2] [lldb] Mark scripted frames as synthetic instead of
https://github.com/medismailben ready_for_review
https://github.com/llvm/llvm-project/pull/149622
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
@Anthony-Eid Almost there! Looks like all the tests are passing now you just
need to fix the formatting for the python changes (you can run `pip3 install
darker && darker -r HEAD~ $LLVM/lldb`) and mark the PR ready for review. Once
you do that I'll add some reviewer to this
medismailben wrote:
Looking at the logs:
- `TestDAP_variables.py` fails on [line
290](https://github.com/llvm/llvm-project/blob/47f0fb9057c0c3c3d0c294dd608df0702706d990/lldb/test/API/tools/lldb-dap/variables/TestDAP_variables.py#L290).
It looks like we call `self.set_local("argc", 123)`. I went
medismailben wrote:
> @medismailben lldb-dap is usable from Zed with my most recent commit now! Do
> you have time this week to pair on getting this mergable? I'm pretty sure
> using new variable ids is going to break some tests and idk if there's
> formatters or anything else I have to fix to
medismailben wrote:
Sounds good, let me know when you're ready 🙂
https://github.com/llvm/llvm-project/pull/124232
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
@Anthony-Eid could you rebase this PR, that'd be better to look at it
https://github.com/llvm/llvm-project/pull/124232
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
https://github.com/medismailben approved this pull request.
Very cool! LGTM!
https://github.com/llvm/llvm-project/pull/155061
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/154975
>From 97d05a3a6ab2d8c9d61f20383dbabe84891e17a2 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Fri, 22 Aug 2025 14:18:01 -0700
Subject: [PATCH] [lldb/crashlog] Implement speculative binary lookup fo
@@ -340,11 +341,101 @@ def find_matching_slice(self):
print(
(
"error\nerror: unable to locate '%s' with UUID
%s"
-% (self.path, self.get_normalized_uuid_string())
+
@@ -340,11 +341,101 @@ def find_matching_slice(self):
print(
(
"error\nerror: unable to locate '%s' with UUID
%s"
-% (self.path, self.get_normalized_uuid_string())
+
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/154975
This patch changes the way the main executable gets looked up when creating the
target in the crashlog script.
On macOS, when a process crashes while being built from a user home directory,
the path to th
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/154651
>From 04db318bbd6b3c4e9245a11a711960cd016dcb19 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Thu, 21 Aug 2025 22:55:59 -0700
Subject: [PATCH] [lldb/crashlog] Avoid StopAtEntry when launch crashlog
https://github.com/medismailben ready_for_review
https://github.com/llvm/llvm-project/pull/154651
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/154651
>From 5bd75225a9a934be76ce7b337c1defb1e25e9153 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Wed, 20 Aug 2025 17:07:33 -0700
Subject: [PATCH] [lldb/crashlog] Avoid StopAtEntry when launch crashlog
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/154445
>From 65b7e3a056f7b3c76217364d700e577f029e4190 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Wed, 20 Aug 2025 16:59:25 -0700
Subject: [PATCH] [lldb/API] Add setters to SBStructuredData
This patch
@@ -109,6 +109,22 @@ class SBStructuredData {
/// Return the generic pointer if this data structure is a generic type.
lldb::SBScriptObject GetGenericValue() const;
+ void SetValueForKey(const char *key, SBStructuredData &value) const;
medismailben wrote:
medismailben wrote:
I'm with @DavidSpickett here: I think we should just show the original value
next to the modified value:
```
(lldb) settings set use-color false
(lldb) settings show use-color
use-color (boolean) = false (default: true)
```
It makes discovery easier. We could also change th
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/152599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -134,9 +115,30 @@ struct InitializePythonRAII {
PyImport_AppendInittab("_lldb", LLDBSwigPyInit);
}
+#if LLDB_EMBED_PYTHON_HOME
medismailben wrote:
Was moving the initialization past the `if (!Py_IsInitialized()) {` needed ?
https://github.com/ll
@@ -204,9 +209,64 @@ bool ScriptedThread::LoadArtificialStackFrames() {
SymbolContext sc;
symbol_addr.CalculateSymbolContext(&sc);
-StackFrameSP synth_frame_sp = std::make_shared(
+return std::make_shared(
this->shared_from_this(), idx, idx, cfa, cfa_i
@@ -0,0 +1,192 @@
+//===-- ScriptedFrame.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,192 @@
+//===-- ScriptedFrame.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,192 @@
+//===-- ScriptedFrame.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,192 @@
+//===-- ScriptedFrame.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/152055
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -131,23 +132,30 @@ void
StructuredPythonObject::Serialize(llvm::json::OStream &s) const {
// PythonObject
void PythonObject::Dump(Stream &strm) const {
- if (m_py_obj) {
-FILE *file = llvm::sys::RetryAfterSignal(nullptr, ::tmpfile);
-if (file) {
- ::PyObject_
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/152031
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -131,23 +132,30 @@ void
StructuredPythonObject::Serialize(llvm::json::OStream &s) const {
// PythonObject
void PythonObject::Dump(Stream &strm) const {
- if (m_py_obj) {
-FILE *file = llvm::sys::RetryAfterSignal(nullptr, ::tmpfile);
-if (file) {
- ::PyObject_
@@ -10,10 +10,12 @@ touch_shared();
// Create some TLS storage within the static executable.
__thread int var_static = 44;
+__thread int var_static2 = 22;
void *fn_static(void *param)
{
var_static *= 2;
+ var_static2 *= 3;
medismailben wrote:
ind
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/152006
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -137,7 +137,16 @@ struct InitializePythonRAII {
config.install_signal_handlers = 0;
Py_InitializeFromConfig(&config);
PyConfig_Clear(&config);
-InitializeThreadsPrivate();
+
+// The only case we should go further and acquire the GIL: it is unlocked.
+
https://github.com/medismailben approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/151777
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
I have some reservations about the effectiveness of this new approach: Instead
of having a list in lldb-rpc with your ptr + length exceptions, now we need to
mark manually every single method at the SBAPI level. If a new method gets
added the SBAPI and the contributor doesn
https://github.com/medismailben approved this pull request.
Beautiful! LGTM with comments!
https://github.com/llvm/llvm-project/pull/150720
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
@@ -0,0 +1,100 @@
+//===-- ScriptedBreakpointPythonInterface.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,100 @@
+//===-- ScriptedBreakpointPythonInterface.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -50,8 +50,28 @@ void
BreakpointResolverScripted::CreateImplementationIfNeeded(
if (!script_interp)
return;
- m_implementation_sp = script_interp->CreateScriptedBreakpointResolver(
- m_class_name.c_str(), m_args, breakpoint_sp);
+ m_interface_sp = script_interp
https://github.com/medismailben approved this pull request.
Overall, LGTM with comments and linking failure addressed.
https://github.com/llvm/llvm-project/pull/147655
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi
medismailben wrote:
Looks like there is a linking issue on Linux:
```
2025-07-24T23:47:48.0834355Z [6326/6332] Linking CXX executable bin/lldb-rpc-gen
2025-07-24T23:47:48.0834814Z FAILED: bin/lldb-rpc-gen
2025-07-24T23:47:48.0852723Z : && /opt/llvm/bin/clang++ -gmlt -fPIC
-fno-semantic-interpo
@@ -306,6 +348,28 @@ bool EmitAmalgamatedServerHeader(const
std::vector &Files) {
return true;
}
+bool EmitAmalgamatedLibraryHeader(const std::vector &Files) {
medismailben wrote:
Not sure what "Amalgamated" means here, I'd like a more self-explaining name
@@ -46,6 +48,12 @@ static std::string GetServerOutputDirectory() {
return std::string(Path);
}
+static std::string GetLibraryOutputDirectory() {
+ llvm::SmallString<128> Path(OutputDir.getValue());
medismailben wrote:
nit: I was wondering if we should make
@@ -0,0 +1,20 @@
+#ifndef LLDB_API_SBRPC_CHECKARRAYPTR_H
+#define LLDB_API_SBRPC_CHECKARRAYPTR_H
+
+#include
+#include
medismailben wrote:
Make sure to remove this from every test
https://github.com/llvm/llvm-project/pull/147655
__
@@ -0,0 +1,20 @@
+#ifndef LLDB_API_SBRPC_CHECKARRAYPTR_H
+#define LLDB_API_SBRPC_CHECKARRAYPTR_H
+
+#include
+#include
+
+#include "lldb/API/SBDefines.h"
+
+namespace lldb {
+class LLDB_API SBRPC_CHECKARRAYPTR {
medismailben wrote:
+1
https://github.com/llvm/l
@@ -153,70 +249,221 @@ class LLDB_API SBDebugger {
/// lldb::SBStructuredData settings = debugger.GetSetting("target.arg0");
/// lldb::SBStructuredData settings = debugger.GetSetting("target");
///
- /// \param[out] setting
+ /// \param[in] setting
/// Property set
@@ -106,44 +124,122 @@ class LLDB_API SBDebugger {
bool &is_debugger_specific);
#endif
+ /// Get structured progress data from an event.
+ ///
+ /// \param [in] event
+ /// The event to extract the progress information from.
+ /
@@ -106,44 +124,122 @@ class LLDB_API SBDebugger {
bool &is_debugger_specific);
#endif
+ /// Get structured progress data from an event.
+ ///
+ /// \param [in] event
+ /// The event to extract the progress information from.
+ /
@@ -106,44 +124,122 @@ class LLDB_API SBDebugger {
bool &is_debugger_specific);
#endif
+ /// Get structured progress data from an event.
medismailben wrote:
nit:
```suggestion
/// Get progress structured data from
medismailben wrote:
> We definitely need more documentation, but I do sometimes get annoyed by it
> when it obscures browsing through the source code by stretching out the class
> definition. If that includes important information about the API, then I
> think it's worth it, but some of these
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/138031
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/145104
>From c83fa6be0c41102d4c0df424574b215d4f83f5f2 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Fri, 20 Jun 2025 14:45:11 -0700
Subject: [PATCH 1/2] [lldb/crashlog] Fix register parsing for arm64 usi
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/145104
This patch addresses 2 issues:
1. It makes registers available on non-crashed threads all the time
2. It fixes arm64 registers parsing for registers that don't use the `x` prefix
(`fp` -> `x29` / `lr` -> `x
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/145099
This patch adds support to the haswell sub-architecture (x86_64h) to scripted
processes.
rdar://147208252
>From bf21c2e9c59939956230d3093d5705e3e8fde12e Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
medismailben wrote:
Cool stuff!
https://github.com/llvm/llvm-project/pull/144543
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/144839
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
This is just fixing the test failure introduced by #94575
https://github.com/llvm/llvm-project/pull/144839
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/144839
This patch makes interactive mode as the default when using the crashlog
command. It replaces the existing `-i|--interactive` flag with a new
`-m|--mode` option, that can either be `interactive` or `batch`
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/144768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3546,6 +3546,8 @@ llvm::Expected Target::GetTraceOrCreate() {
}
Status Target::Attach(ProcessAttachInfo &attach_info, Stream *stream) {
+ std::unique_ptr attach_progress;
+ attach_progress = std::make_unique("Waiting to attach to process");
medismailben
https://github.com/medismailben approved this pull request.
Cool! LGTM with comment addressed.
https://github.com/llvm/llvm-project/pull/144768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/144768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
> Hey @clayborg, this is pretty cool. I'm glad you were able to use and extend
> the ScriptedPythonInterface to implement this, hopefully it wasn't too
> complicated. LGTM!
I meant LGTM on the scripting side of things. I still thing we should address
Jim's comments:
> For
https://github.com/medismailben approved this pull request.
Hey @clayborg, this is pretty cool. I'm glad you were able to use and extend
the ScriptedPythonInterface to implement this, hopefully it wasn't too
complicated. LGTM!
https://github.com/llvm/llvm-project/pull/142514
__
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/142215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
Cool! Would be nice to change some of the existing tests to make sure these
work as expected.
https://github.com/llvm/llvm-project/pull/142215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
medismailben wrote:
That doesn't solve the issue:
```
File
"/Users/mib/Developer/open-source/llvm.org/lldb/test/API/tools/lldb-dap/disassemble/TestDAP_disassemble.py",
line 28, in test_disassemble
self.assertIn("location", pc_assembly, "Source location missing.")
AssertionError: 'locatio
medismailben wrote:
Hey @eronnen, I think this change broke the macOS lldb incremental bot:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/26259/execution/node/106/log/?consoleFull
Let me know if you need help to investigate it or if we should revert it if you
don't have t
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/140958
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/139567
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
> @felipepiovezan I don't have a machine to run ObjC tests on, could you apply
> this patch and see if it fixes the issue in #135843 ?
The test pass after applying this patch. Feel free to land this whenever :)
https://github.com/llvm/llvm-project/pull/139567
_
1 - 100 of 1233 matches
Mail list logo
