[Lldb-commits] [PATCH] D157497: feat: Migrate isArch16Bit

nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. Herald added a subscriber: StephenFan. This change looks strictly worse in isolation, the proposal on discourse did not reach consensus, and looking at the diagram in

[Lldb-commits] [PATCH] D149641: [docs] Hide collaboration and include graphs in doxygen docs

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. LGTM, only the inheritance graph is useful, which this preserves if I understand correctly (CLASS_GRAPH is still YES). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D140800: [OptTable] Precompute OptTable prefixes union table through tablegen

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM In D140800#4044983 , @serge-sans-paille wrote: > In D140800#4043723 , @nikic wrote: > >> Just to check,

[Lldb-commits] [PATCH] D140800: [OptTable] Precompute OptTable prefixes union table through tablegen

nikic added a comment. Just to check, this isn't going to cause some warning spew about all those OptTable implementations being non-final? Comment at: llvm/include/llvm/Option/OptTable.h:256 +/// Specialization of +class GenericOptTable : public OptTable {

[Lldb-commits] [PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139881/new/ https://reviews.llvm.org/D139881 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

nikic added a comment. @TimNN Do you have an IR sample for this? DAE is supposed to strip UB-implying attributes when converting arguments to poison here:

[Lldb-commits] [PATCH] D136144: [lldb] Fix m_hwp_regs size for ppc64le

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f59f302e435: [lldb] Fix m_hwp_regs size for ppc64le (PR54520) (authored by nikic). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. The default switch has happened, so unblocking this. Comment at: clang/test/CodeGenOpenCL/overload.cl:23 generic int *local *genloc; generic int *global *genglob; + //

[Lldb-commits] [PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. I'd like to block this on `-fsanitize-memory-param-retval` (aka msan eager checks) being enabled by default. It seems pretty clear that there is a *lot* of UB due to uninitialized

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

nikic added a comment. In D130689#3690258 , @thieta wrote: > In D130689#3689157 , @thakis wrote: > >> Is it expected and intentional that this increases the mac deployment target >> to 10.12? > > I wasn't aware

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

nikic added a comment. Given that LLVM 15 branches off in one week, maybe it would be better to wait for that before relanding the change, as it seems to have significant impact on plugins? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

nikic added a comment. FYI this change had a noticeable compile-time impact (http://llvm-compile-time-tracker.com/compare.php?from=ee88c0cf09969ba44307068797e12533b94768a6=bdc6974f92304f4ed542241b9b89ba58ba6b20aa=instructions), is that expected? Largest regressions are in kimwitu++, where

[Lldb-commits] [PATCH] D123957: Update the developer policy to mention release notes

nikic accepted this revision. nikic added inline comments. This revision is now accepted and ready to land. Comment at: llvm/docs/DeveloperPolicy.rst:195 +* Adding, removing, or regrouping a diagnostic. +* Fixing a bug (please link to the issue fixed in the bug database). +*

[Lldb-commits] [PATCH] D123957: Update the developer policy to mention release notes

nikic requested changes to this revision. nikic added inline comments. This revision now requires changes to proceed. Comment at: llvm/docs/DeveloperPolicy.rst:195 +* Adding, removing, or regrouping a diagnostic. +* Fixing a bug (please link to the issue fixed in the bug