[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG874217f99b99: [clang] Enable C++11-style attributes in all language modes (authored by philnik). Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik updated this revision to Diff 542743. philnik added a comment. - Address comments - Try to fix CI - Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151683/new/ https://reviews.llvm.org/D151683 Files: clang/docs/LanguageExtensions.r

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik added a comment. In D151683#4508209 , @MaskRay wrote: > Reverse ping @philnik :) > > The `release/17.x` branch will be created soon > (https://discourse.llvm.org/t/llvm-17-0-0-release-planning-and-update/71762). I know. I just didn't have the ti

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik updated this revision to Diff 536623. philnik edited the summary of this revision. philnik added a comment. Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151683/new/ https://reviews.llvm.org/D151683 Files: clang/docs/Langua

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik updated this revision to Diff 536620. philnik marked 16 inline comments as done. philnik added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151683/new/ https://reviews.llvm.org/D151683 Files: clang/docs/Langu

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik added inline comments. Comment at: clang/test/Parser/cxx-decl.cpp:316 #if __cplusplus >= 201103L -// expected-error@+3 {{expected}} +// expected-error@+2 {{expected}} // expected-error@-3 {{expected ';' after top level declarator}} aaron.ballman wrote:

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik added a comment. In D151683#4380877 , @erichkeane wrote: > What is the justification for this? What exactly are you asking for? Why I'd like to back port it? This would make quite a bit of code in libc++ simpler and avoids pit-falls where an at

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik added inline comments. Herald added subscribers: Michael137, JDevlieghere. Comment at: clang/test/ParserHLSL/group_shared.hlsl:14 -// expected-error@+1 {{expected expression}} float groupshared [[]] i = 12; Should this also get an extension warning/sho

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik created this revision. philnik added reviewers: aaron.ballman, erichkeane. Herald added subscribers: wlei, wenlei, jdoerfert, dmgreen. Herald added a project: All. philnik requested review of this revision. Herald added subscribers: lldb-commits, cfe-commits, jplehr, sstefan1, MaskRay. Hera

[Lldb-commits] [PATCH] D130822: Fixed loads of typos

philnik added a comment. Could you split this up per project? Large patches like this are really hard to review, since there is no single person/small group that can approve everything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130822/new/ htt

[Lldb-commits] [PATCH] D127684: [NFC] Use `https` instead of `http` in the urls

philnik added a comment. Could you do this on a per-project basis? More than 1000 files is way to much to sift through. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127684/new/ https://reviews.llvm.org/D127684 ___

[Lldb-commits] [PATCH] D123580: [libc++] Use bit field for checking if string is in long or short mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29c8c070a177: [libc++] Use bit field for checking if string is in long or short mode (authored by philnik). Repository: rG LLVM Github Monorepo C

[Lldb-commits] [PATCH] D124113: [lldb] Adjust libc++ string formatter for changes in D123580

philnik accepted this revision. philnik added a comment. This revision is now accepted and ready to land. LGTM assuming you checked that it actually works with my patch applied. Do you want to land your patch first, or should we do it the other way around? Comment at: lldb/sou

[Lldb-commits] [PATCH] D124155: [lldb] Add tests which simulate the various std::string layouts

philnik accepted this revision. philnik added a comment. This revision is now accepted and ready to land. LGTM, but you probably want to wait for someone from the LLDB team to approve too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124155/new/

[Lldb-commits] [PATCH] D124113: [lldb] Adjust libc++ string formatter for changes in D123580

philnik added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:658 + if (!using_bitmasks) +capacity *= 2; if (size == LLDB_INVALID_OFFSET || capacity == LLDB_INVALID_OFFSET || This should only be done if the string is in the

[Lldb-commits] [PATCH] D123580: [libc++] Use bit field for checking if string is in long or short mode

philnik added inline comments. Comment at: libcxx/utils/gdb/libcxx/printers.py:192 class StdStringPrinter(object): """Print a std::string.""" labath wrote: > philnik wrote: > > dblaikie wrote: > > > philnik wrote: > > > > jgorbe wrote: > > > > > Mordante

[Lldb-commits] [PATCH] D123580: [libc++] Use bit field for checking if string is in long or short mode

philnik updated this revision to Diff 423841. philnik added a comment. - Try to fix Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123580/new/ https://reviews.llvm.org/D123580 Files: libcxx/include/string libcxx/test/libcxx/strings/basi

[Lldb-commits] [PATCH] D123580: [libc++] Use bit field for checking if string is in long or short mode

philnik added inline comments. Comment at: libcxx/utils/gdb/libcxx/printers.py:192 class StdStringPrinter(object): """Print a std::string.""" dblaikie wrote: > philnik wrote: > > jgorbe wrote: > > > Mordante wrote: > > > > philnik wrote: > > > > > Mordant

[Lldb-commits] [PATCH] D123580: [libc++] Use bit field for checking if string is in long or short mode

philnik updated this revision to Diff 423316. philnik added a comment. - Add Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123580/new/ https://reviews.llvm.org/D123580 Files: libcxx/include/string libcxx/test/libcxx/strings/basic.strin

[Lldb-commits] [PATCH] D123580: [libc++] Use bit field for checking if string is in long or short mode

philnik added a reviewer: LLDB. philnik added inline comments. Comment at: libcxx/utils/gdb/libcxx/printers.py:192 class StdStringPrinter(object): """Print a std::string.""" jgorbe wrote: > Mordante wrote: > > philnik wrote: > > > Mordante wrote: > > > >

[Lldb-commits] [PATCH] D123580: [libc++] Use bit field for checking if string is in long or short mode

philnik updated this revision to Diff 423266. philnik added a comment. - Fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123580/new/ https://reviews.llvm.org/D123580 Files: libcxx/include/string libcxx/test/libcxx/strings/basic.string/str

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

philnik added a comment. In D121078#3373081 , @SimplyDanny wrote: > I'm happy that you found a reasonable compromise. I like it too. ;) > > Now, I ask you to help me a little bit with the workflow and the test > failures. The review comments are all tak