[Lldb-commits] [PATCH] D74951: [lldb] Remove all the 'current_id' logging counters from the lookup code.

grandinj added a comment. Just a drive-by suggestion: Logging the pointer value of the relevant root object in the callees would provide similar benefit to anyone needing to do log tracing Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74951/new/ https://revie

[Lldb-commits] [PATCH] D67376: [DWARF] Evaluate DW_OP_entry_value

grandinj added inline comments. Comment at: lldb/include/lldb/Symbol/Function.h:258 + +using CallSiteParameterArray = std::unique_ptr>; + the way this is being used seems to indicate it can be std::vector no need for unique_ptr CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D65025: [Symbol] Improve TypeSystemMap mutex safety

grandinj added a comment. Maybe make AddMap take a lock_guard parameter as recommended here https://stackoverflow.com/questions/28825749/ensuring-that-current-thread-holds-a-lock-on-a-c11-mutex ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65025/new/ https://reviews.llvm.org/D650