Re: [Lldb-commits] [PATCH] D17521: Update website for building and testing on Windows

2016-02-22 Thread Petr Hons via lldb-commits
Honsik added a comment. Hello, newcomer here. Thanks zturner for you support. Shouldn't best workflow for VS also be mentioned? Like one solution for code editing generated by CMake -G "Visual Studio 14" that lacks directory structure (mostly CMake + VS issue) and another with custom project co

Re: [Lldb-commits] [PATCH] D17492: Case sensitive path compare on Windows breaks breakpoints

2016-02-23 Thread Petr Hons via lldb-commits
Honsik updated the summary for this revision. Honsik updated this revision to Diff 48871. Honsik added a comment. I added requested changes. http://reviews.llvm.org/D17492 Files: include/lldb/Core/ConstString.h include/lldb/Host/FileSpec.h packages/Python/lldbsuite/test/functionalities/b

Re: [Lldb-commits] [PATCH] D17492: Case sensitive path compare on Windows breaks breakpoints

2016-02-23 Thread Petr Hons via lldb-commits
Honsik added inline comments. Comment at: packages/Python/lldbsuite/test/dotest.py:288-294 @@ -288,1 +287,9 @@ + +if sys.platform.startswith('win32'): +import ctypes, time +while not ctypes.windll.kernel32.IsDebuggerPresent(): +

Re: [Lldb-commits] [PATCH] D17492: Case sensitive path compare on Windows breaks breakpoints

2016-02-24 Thread Petr Hons via lldb-commits
Honsik added a comment. The testsuite passed the same way as master, but no UNEXPECTED SUCCESS. Please fix the miss spelling directly. Thanks. Comment at: source/Host/common/FileSpec.cpp:517 @@ -511,2 +516,2 @@ // If full is false, then if either directory is empty, then

Re: [Lldb-commits] [PATCH] D17492: Case sensitive path compare on Windows breaks breakpoints

2016-02-24 Thread Petr Hons via lldb-commits
Honsik added a comment. I have generated it against master branch. I used git reset HEAD~1, modified, commited and created patch. Maybe the problem was I used the Arcanist for the first diff and then I used web interface, as you have suggested. http://reviews.llvm.org/D17492 __

[Lldb-commits] [PATCH] D17635: Continue after process exit

2016-02-25 Thread Petr Hons via lldb-commits
Honsik created this revision. Honsik added a reviewer: zturner. Honsik added a subscriber: lldb-commits. When process exits, and SBProcess.Continue() is executed, timeout occurs (5secs). Instead error message "Process is not alive" is returned. Added test for this message. Fix of breakpoint cas

Re: [Lldb-commits] [PATCH] D17635: Continue after process exit

2016-02-26 Thread Petr Hons via lldb-commits
Honsik added a comment. I tried to put this check in PrivateResume, but its not that simple because of the public RUN lock. I am not that sure if it is safe to always unclock the lock inside PrivateResume. http://reviews.llvm.org/D17635 ___ lldb-c

Re: [Lldb-commits] [PATCH] D17635: Continue after process exit

2016-02-26 Thread Petr Hons via lldb-commits
Honsik updated this revision to Diff 49258. Honsik added a comment. OK I have modified the PrivateResume to add the check and release the public running lock. http://reviews.llvm.org/D17635 Files: packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_case_sensitivity/TestBrea

Re: [Lldb-commits] [PATCH] D17635: Continue after process exit

2016-03-10 Thread Petr Hons via lldb-commits
Honsik updated this revision to Diff 50373. Honsik added a comment. Sorry for the delay, I have been on holiday. I have modified the patch as jingham requested. The public run lock is reset back on error in both Resume and ResumeSynchronous methods. http://reviews.llvm.org/D17635 Files: pa

Re: [Lldb-commits] [PATCH] D17635: Continue after process exit

2016-03-19 Thread Petr Hons via lldb-commits
Honsik added a comment. Yes please, with that comment change jingham has mentioned. Do you want me to create new diff? http://reviews.llvm.org/D17635 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li