[Lldb-commits] [PATCH] D110578: [lldb] Add support for D programming language

teemperor accepted this revision. teemperor added a comment. Do you have commit access or should someone land this for you? Comment at: lldb/include/lldb/Core/Mangled.h:48 +eManglingSchemeRustV0, +eManglingSchemeD }; Nit which can be fixed when

[Lldb-commits] [PATCH] D110472: [lldb] [gdb-remote] Use llvm::StringRef.split() and llvm::to_integer()

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. All the `llvm::StringRef &` iteration variables can just be `llvm::StringRef` without the reference. Also some `base` values got lost here (see inline comments). Beside that this LGTM,

[Lldb-commits] [PATCH] D110478: [lldb] Move StringConvert inside debugserver

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110478/new/ https://reviews.llvm.org/D110478 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D110447: [lldb] Convert misc. StringConvert uses

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. This patch makes me very happy. I have one comment regarding one small change in behaviour, but otherwise this LGTM. If you have the time, it would be nice to drop FIXME's above the few

[Lldb-commits] [PATCH] D87281: [lldb] Add a C language REPL to test LLDB's REPL infrastructure

This revision was automatically updated to reflect the committed changes. Closed by commit rGc22329972f02: [lldb] Add a C language REPL to test LLDBs REPL infrastructure (authored by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D109908: [lldb] Show fix-it applied even if expression didn't evaluate succesfully

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. My bad, I thought you wanted to print the fix-its if the 'fixed' expression failed to *parse* again, but this is about non-parsing errors. Ignore my other points, they were suggestions

[Lldb-commits] [PATCH] D109908: [lldb] Show fix-it applied even if expression didn't evaluate succesfully

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Herald added a subscriber: JDevlieghere. Could you add a test for that? The usual test fixit in Clang is `.`/`->` mixup, e.g. (lldb) expr struct Foo { int i; }; Foo *f; f.i

[Lldb-commits] [PATCH] D109508: [lldb] Fix format string in Communication::Write

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4f1c90a6d4dd: [lldb] Fix format string in Communication::Write (authored by rmansfield, committed by teemperor). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D109185: [gn build] Add build files for LLDB

teemperor added a comment. Thanks! Out of curiosity, is there a public GN bot that is testing this? > LLDB has many dependency cycles, something GN doesn't allow. For that reason, I've omitted some dependency edges. Hopefully we can clean up the cycles one day. No idea about GN, but I would

[Lldb-commits] [PATCH] D109508: [lldb] Fix format string in Communication::Write

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109508/new/ https://reviews.llvm.org/D109508

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

teemperor reopened this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks, reverted the commit. @saschwartz Can you take a look at the failure? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108351/new/

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe387c8c413e2: [lldb server] Tidy up LLDB server return codes and associated tests (authored by saschwartz, committed by teemperor). Repository:

[Lldb-commits] [PATCH] D109013: [lldb] Tighten lock in Language::ForEach

teemperor accepted this revision. teemperor added a comment. Yay! It's probably worth adding comment that `callback` might end up calling back into ForEach :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109013/new/

[Lldb-commits] [PATCH] D109004: [lldb] Catch all exceptions when checking if simulator exists

teemperor added a comment. Weird, in the test log it seems xcodebuild fails, but that would just raise a `CalledProcessError` (which we already catch here and cause the test to skip). And this would also not print anything to stderr as we set the stderr output in the `check_output` call to

[Lldb-commits] [PATCH] D109004: [lldb] Catch all exceptions when checking if simulator exists

teemperor added a comment. Herald added a subscriber: JDevlieghere. Do we know what the exception that is being thrown here? FWIW, `except Exception` will catch everything, even completely bogus things such as type errors, calling functions with the wrong arguments and things that should

[Lldb-commits] [PATCH] D108983: [lldb] Don't save empty expressions in the multiline editor history

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4f7fb13f87e1: [lldb] Dont save empty expressions in the multiline editor history (authored by teemperor). Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D108817: [LLDB] Fix 'std::out_of_range' crashing bug when file name completion using file path.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGffcf57110759: [LLDB] Fix std::out_of_range crashing bug when file name completion using… (authored by HirokiImai, committed by teemperor).

[Lldb-commits] [PATCH] D108817: [LLDB] Fix 'std::out_of_range' crashing bug when file name completion using file path.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. In D108817#2972047 , @HirokiImai wrote: > Thanks for the review! > I didn't know how to write tests very well, so the review was very helpful

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Move best-practices.txt contain to resources/test.rst

teemperor accepted this revision. teemperor added a comment. Thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D108817: [LLDB] Fix 'std::out_of_range' crashing bug when file name completion using file path.

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Thanks for the patch! As Jonas pointed out, tests are usually expected for these kind of patches. But the IOHandler logic has some really quirky way to write tests, so just

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Renew best-practices.txt

teemperor added inline comments. Comment at: lldb/docs/testsuite/best-practices.rst:53 + +Cleanup after yourself +-- This section here seems very outdated, can we just delete it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

teemperor requested changes to this revision. teemperor added inline comments. This revision now requires changes to proceed. Comment at: lldb/test/API/functionalities/dyld-launch-linux/TestDyldLaunchLinux.py:13 + +def test(self): +self.build()

[Lldb-commits] [PATCH] D108717: Fix Reference case for TypeSystemClang::GetChildCompilerTypeAtIndex(...) to avoid possible invalid cast

teemperor added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:6505 if (idx_is_valid) { - const clang::ReferenceType *reference_type = - llvm::cast(GetQualType(type).getTypePtr()); - CompilerType pointee_clang_type =

[Lldb-commits] [PATCH] D108717: Fix Reference case for TypeSystemClang::GetChildCompilerTypeAtIndex(...) to avoid possible invalid cast

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Thanks for the patch! So IIUC correctly this fixes a crash when calling `Dereference` on an SBValue that is of type `SomeTypedef` with `typedef int& SomeTypedef`? If yes, then

[Lldb-commits] [PATCH] D107079: [lldb] Add an option for emitting LLDB logs as JSON

teemperor added a comment. Friendly ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107079/new/ https://reviews.llvm.org/D107079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! I'll merge this on Monday when I have time to watch the bots (unless ofc someone else merges this before then). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D108395: [lldb] Delete IRExecutionUnit::CollectCandidateCPlusPlusNames

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I'm very supportive of the idea that we delete everything that isn't tested :) (and I'm only partly joking here). However removing this should cause a bunch of test failures

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

teemperor requested changes to this revision. teemperor added inline comments. This revision now requires changes to proceed. Comment at: lldb/tools/lldb-server/lldb-platform.cpp:289 fprintf(stderr, "failed to create acceptor: %s", error.AsCString()); -

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

teemperor added inline comments. Comment at: lldb/tools/lldb-server/lldb-platform.cpp:289 fprintf(stderr, "failed to create acceptor: %s", error.AsCString()); -exit(socket_error); +return -1; } clayborg wrote: > Should we return error.GetError()

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Eh, I didn't want to accept this now. Just marking this as 'request changes' so it goes back to you for the last few things. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Some nits but this LGTM, thanks! I'll accept & land this for you once the last few things are addressed :) Comment at: lldb/tools/lldb-server/lldb-server.cpp:59

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Sorry for the delay on this! Feel free to ping sooner if this gets stuck again. I think just passing a string here seems fine, but maybe we could let the function just take a

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Thanks for the patch (and tests!), this LGTM for the most part. I'm maybe being nitpicky here, but could we replace all the `ret = ...` stuff and `exit(...)` with just `return

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

teemperor added a comment. In D104413#2952057 , @PatriosTheGreat wrote: > Should I send this somehow back to review? Nope, this is (as it should be) in the review queue but I just didn't get around to this yet. Sorry for the delay, I'll try to take a

[Lldb-commits] [PATCH] D108228: Fix error handling in the libcxx std::string formatter

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. You could land all the formatting changes as its own commit just to make it clear that this is adding one `if (error)` and the other line changes are formatting updates. But I

[Lldb-commits] [PATCH] D108145: [lldb] Make TestAArch64AdrpAdd depend on the AArch64 target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc5495c351a1: [lldb] Make TestAArch64AdrpAdd depend on the AArch64 target (authored by teemperor). Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D108121: [lldb] Add tests for TypeSystemMap::GetTypeSystemForLanguage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf521e78dfd2: [lldb] Add tests for TypeSystemMap::GetTypeSystemForLanguage (authored by teemperor). Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D108088: [lldb] Avoid unhandled Error in TypeSystemMap::GetTypeSystemForLanguage

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks for fixing this (and cleaning up the code), LGTM. I wrote some regression tests for this in D108121 that I'll land as a follow-up.

[Lldb-commits] [PATCH] D107079: [lldb] Add an option for emitting LLDB logs as JSON

teemperor updated this revision to Diff 365944. teemperor added a comment. - Fix double printing and formatting of the old plain text format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107079/new/ https://reviews.llvm.org/D107079 Files: lldb/docs/design/logging.rst

[Lldb-commits] [PATCH] D106743: [lldb][NFC] Define DWARFDIE::children out-of-line instead of using template magic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb2c262cfb12f: [lldb][NFC] Define DWARFDIE::children out-of-line instead of using template… (authored by teemperor). Herald added a subscriber:

[Lldb-commits] [PATCH] D107079: [lldb] Add an option for emitting LLDB logs as JSON

teemperor added a comment. In D107079#2914111 , @aprantl wrote: > More a comment than anything else: One thing I always wanted to explore was > to implement LLDB's logging on Darwin on top of os_log >

[Lldb-commits] [PATCH] D107079: [lldb] Add an option for emitting LLDB logs as JSON

teemperor added a comment. In D107079#2918185 , @jasonmolenda wrote: > Sorry for not commenting on this on earlier, I wanted to think about it a bit. > > I think the usefulness of this can depend on the type of logging. l often > turn on gdb-remote

[Lldb-commits] [PATCH] D107079: [lldb] Add an option for emitting LLDB logs as JSON

teemperor updated this revision to Diff 365737. teemperor retitled this revision from "[lldb] Change the log format to JSON instead of plain text" to "[lldb] Add an option for emitting LLDB logs as JSON". teemperor edited the summary of this revision. teemperor added a comment. Herald added

[Lldb-commits] [PATCH] D107778: [lldb] Add a test for user-defined objc_copyRealizedClassList_nolock

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57bf5c86591a: [lldb] Add a test for user-defined objc_copyRealizedClassList_nolock (authored by teemperor). Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D107776: [lldb] Add a test for potentially conflicting names for the Objective-C class update utility expression

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG499489064b7a: [lldb] Add a test for potentially conflicting names for the Objective-C class… (authored by teemperor). Herald added a project: LLDB.

[Lldb-commits] [PATCH] D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Thanks for the patch! I think we can actually simplify that code even more by just removing the `!got_line` checks in both ifs? There is really no reason to have them from

[Lldb-commits] [PATCH] D107767: Fix break introduced in 14735ca

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG875a16bcfc28: [lldb] Fix break introduced in 14735ca (authored by rgiese, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D107767: Fix break introduced in 14735ca

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I'm landing this to unbreak Green Dragon. @mgorny Just a heads up, I think this also broke one test with debugserver:

[Lldb-commits] [PATCH] D107767: Fix break introduced in 14735ca

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks. I assume you don't have commit access so I'll land this for you in a minute :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

teemperor added a comment. I ran it a few times and I'm sure it's an actual '"the output didn't show up" timeout and not a random failure. I also checked and my node doesn't have an `.editrc` file or something like that on the node. It's failing on a different Arch Linux bot so I think it's

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

teemperor added a comment. I fear I might also have to congratulate you on your first revert (sorry, couldn't resist that joke). TestUnicode is failing for me with this patch on Arch Linux: Command Output (stdout): -- lldb version 14.0.0 (g...@github.com:Teemperor/llvm-project revision

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

teemperor added a comment. In D106035#2927714 , @nealsid wrote: > In D106035#2927660 , @teemperor > wrote: > >> The release branch was recently made, so we can land this right now. Just >> give me a ping when I

[Lldb-commits] [PATCH] D107446: [lldb] Stop referencing "host_lib" in cmake files

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. lgtm, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107446/new/ https://reviews.llvm.org/D107446 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

teemperor added a comment. The release branch was recently made, so we can land this right now. Just give me a ping when I should merge this :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106035/new/ https://reviews.llvm.org/D106035

[Lldb-commits] [PATCH] D73191: Only match mangled name in full-name function lookup (with accelerators)

teemperor added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:43 + // In case of a full match, we insert functions with a matching mangled name. + if (name_type_mask & eFunctionNameTypeFull && die.GetMangledName() == name) {

[Lldb-commits] [PATCH] D73191: Only match mangled name in full-name function lookup (with accelerators)

This revision was automatically updated to reflect the committed changes. Closed by commit rGf968bd77bbcf: Reland [lldb/DWARF] Only match mangled name in full-name function lookup (with… (authored by jarin, committed by teemperor). Changed prior to commit:

[Lldb-commits] [PATCH] D73191: Only match mangled name in full-name function lookup (with accelerators)

teemperor accepted this revision. teemperor added a comment. Herald added a subscriber: JDevlieghere. From what I can see the underlying problem with the import-std-module tests has been fixed at some point in the past (at least it doesn't reproduce anymore). I don't recall seeing a fix for the

[Lldb-commits] [PATCH] D107434: fix D103172

teemperor added a comment. I think this part of the patch can just be reverted. Thanks for tracking this down! Reverted the respective changes in e4977f9cb58ff7820d0287ba309490af57787749 Feel free to close this. I'll see

[Lldb-commits] [PATCH] D107341: [lldb] Move comment about noindex next to line it refers to

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks, lgtm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107341/new/ https://reviews.llvm.org/D107341 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D107338: [lldb] Get rid of HAVE_SYS_TYPES_H

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks! This LGTM itself, but I would prefer if we could remove that define in this commit and remove the redundant Config.h includes in another (so, the first version of this patch

[Lldb-commits] [PATCH] D107079: [lldb] Change the log format to JSON instead of plain text

teemperor added a comment. Actually forgot this one: Having the ability to log the current channel in each message is also planned. This originally came up when I kept telling people to do 'log enable lldb all' and people were tired of filtering through the very verbose logs (and Jim suggested

[Lldb-commits] [PATCH] D107079: [lldb] Change the log format to JSON instead of plain text

teemperor added a comment. I hacked together a quick example log viewer in HTML here: https://teemperor.de/pub/logviewer.html (I already loaded in a log from my machine, so you can just hit "parse log"). Note that you can search the log messages and you can click each one of them to reveal

[Lldb-commits] [PATCH] D107079: [lldb] Change the log format to JSON instead of plain text

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. LLDB has a quite extensive logging framework that is mostly used to help with bug reporting where users are

[Lldb-commits] [PATCH] D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization

teemperor added inline comments. Comment at: lldb/source/Plugins/TraceExporter/ctf/CommandObjectThreadTraceExportCTF.cpp:78 + : LLDB_INVALID_THREAD_ID; +result.AppendErrorWithFormat( +"Thread index %lu is out of range (valid

[Lldb-commits] [PATCH] D105788: [LLDB] Silence warnings from ScriptedProcessPythonInterface.cpp

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I think this is the last round of review so I'll just accept this modulo a few nits. Comment at:

[Lldb-commits] [PATCH] D105788: [LLDB] Silence warnings from ScriptedProcessPythonInterface.cpp

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Some nits but otherwise this seems like the right direction. Thanks! Comment at:

[Lldb-commits] [PATCH] D105471: [lldb] Generalize empty record size computation to avoid giving empty C++ structs a size of 0

teemperor added a comment. In D105471#2896544 , @stella.stamenova wrote: > In D105471#2896533 , > @stella.stamenova wrote: > >> I think this change broke the Windows LLDB bot. More specifically the >>

[Lldb-commits] [PATCH] D103172: [lldb][NFC] Allow range-based for loops over DWARFDIE's children

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77440d644b3b: [lldb][NFC] Allow range-based for loops over DWARFDIEs children (authored by teemperor). Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D105028: [lldb] Fix that `process signal` completion always returns all signals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG078003482e90: [lldb] Fix that `process signal` completion always returns all signals (authored by teemperor). Herald added a subscriber:

[Lldb-commits] [PATCH] D105463: [lldb][NFC] Remove redundant accessibility heuristic in the DWARF parser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12a89e14b83a: [lldb][NFCI] Remove redundant accessibility heuristic in the DWARF parser (authored by teemperor). Herald added a subscriber:

[Lldb-commits] [PATCH] D105471: [lldb] Generalize empty record size computation to avoid giving empty C++ structs a size of 0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67c588c481bb: [lldb] Generalize empty record size computation to avoid giving empty C++… (authored by teemperor). Herald added a subscriber:

[Lldb-commits] [PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

teemperor added a comment. Quick note to prevent some confusion: I saw this patch and realized that the LLDB change was only necessary because some Clang code got copy pasted into LLDB. I removed that copy in https://reviews.llvm.org/D106537 so if you see merge conflicts while merging this,

[Lldb-commits] [PATCH] D106226: [lldb] Improve error message when "lldb attach" fails

teemperor added a comment. Congrats on getting started on your first patch! I improving this error message really seems like a good idea. From what I can see the error message here is identical to GDB's which is a different project with an incompatible license. No idea if this is large enough

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. In D106035#2885174 , @nealsid wrote: > In D106035#2879939 , @teemperor > wrote: > >> I actually

[Lldb-commits] [PATCH] D105389: [lldb] Add AllocateMemory/DeallocateMemory to the SBProcess API

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e7ec447cc7e: [lldb] Add AllocateMemory/DeallocateMemory to the SBProcess API (authored by housel, committed by teemperor). Repository: rG LLVM

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

teemperor added a comment. I actually expected after the RFC that we would remove all the non-wchar code, but this seems also fine. I think this LGTM in general, but I feel a bit nervous about touching stuff that depends so much on OS/environment. What OS/environment did you test this patch

[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I'm really sorry, I don't understand what kind of review is expected here given the state of this patch. - The patch **still** doesn't include the tests that I asked for in my

[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I guess Phabricator just sent this back to review automatically when you updated the diff? Just mark this as 'needs review' again when this is ready for review. I'll send this

[Lldb-commits] [PATCH] D105779: RFC: [lldb] Fix editline unicode on Linux

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: lldb/tools/driver/Driver.cpp:872 + ::setlocale(LC_ALL, ""); + ::setlocale(LC_CTYPE, ""); + jankratochvil wrote: >

[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I think this looks good, thanks for fixing this! I believe there should be a few more tests for all the corner cases we can run into here (those tests can all be just Python

[Lldb-commits] [PATCH] D105779: RFC: [lldb] Fix editline unicode on Linux

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. In retrospective that's a rather obvious fix. Thanks! This LGTM, but I think this deserves a comment about why we are setting this. Usually LLVM avoids the locale-dependent

[Lldb-commits] [PATCH] D105480: [lldb][docs] Force documentation emission of special Python class members

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ebfeb258698: [lldb][docs] Force documentation emission of special Python class members (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29cc50e17a68: [LLDB][GUI] Add initial forms support (authored by OmarEmaraDev, committed by teemperor). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D105327: [lldb] Add the ability to silently import scripted commands

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:512 virtual bool - LoadScriptingModule(const char *filename, bool init_session, +

[Lldb-commits] [PATCH] D105470: [lldb] Clear children of ValueObject on value update

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. So IIUC we can do things here: 1. We disallow giving `ValueObjectConstResult` a new value via `SetData`/`SetValueFromCString`. Both functions have a way of signaling error to the user,

[Lldb-commits] [PATCH] D103172: [lldb][NFC] Allow range-based for loops over DWARFDIE's children

teemperor added a comment. ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103172/new/ https://reviews.llvm.org/D103172 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D104653: [lldb] Avoid using any shell when calling xcrun.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG355541a1b7a5: [lldb] Avoid using any shell when calling xcrun. (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [PATCH] D104882: makes extension contribute breakpoints using new package.json schema:https://code.visualstudio.com/updates/v1_42#_implement-a-debug-adapter-inside-an-extension

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d8156ef87f8: [lldb-vscode] Make extension contribute breakpoints use new package.json schema (authored by chrisbond, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D104856: [NFC] Remove unreferenced function ResolveIPV4HostName

teemperor accepted this revision. teemperor added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104856/new/ https://reviews.llvm.org/D104856 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

teemperor added a comment. In D95602#2839419 , @fhahn wrote: > It looks like this is breaking building LLDB on Green Dragon: > https://smooshbase.apple.com/ci/job/am_github_build_tester/63476/console > > please take a look and consider reverting if it

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

teemperor added a comment. In D104856#2839256 , @jankratochvil wrote: > On OSX with `-DLLDB_USE_SYSTEM_DEBUGSERVER=OFF` I have built: > -rwxr-xr-x 1 macbook staff 689200 Jun 24 19:10 bin/debugserver > It uses

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

teemperor added a comment. In D104856#2838600 , @jankratochvil wrote: > In D104856#2838571 , @teemperor > wrote: > >> The file is part of `debugserver` which is Darwin exclusive and is also only >>

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

teemperor added a comment. In D104856#2838526 , @jankratochvil wrote: > In D104856#2838515 , @teemperor > wrote: > >> (Nit: this is from the Linux manpage but this code is only compiled on >> Darwin). > > Why

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

teemperor edited reviewers, added: jasonmolenda; removed: k8stone, beanz. teemperor added a comment. (Nit: this is from the Linux manpage but this code is only compiled on Darwin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104856/new/

[Lldb-commits] [PATCH] D104778: [lldb] Remove asserts in CommandReturnObject SetError and AppendError

teemperor added a comment. In D104778#2835701 , @DavidSpickett wrote: >> LGTM, I'll add them in my patch. Thanks for the quick turnaround! > > To clarify, is there still a regression with the API? No regression anymore from what I can see. My point was

[Lldb-commits] [PATCH] D104778: [lldb] Remove asserts in CommandReturnObject SetError and AppendError

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, I'll add them in my patch. Thanks for the quick turnaround! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104778/new/

[Lldb-commits] [PATCH] D104768: [lldb] Remove CommandReturnObject's SetError(StringRef)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104768/new/ https://reviews.llvm.org/D104768

[Lldb-commits] [PATCH] D104768: [lldb] Remove CommandReturnObject's SetError(StringRef)

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. We should never assert unless we have to within SB API calls as that takes down the whole debugging session and all this is directly available to users via the script

[Lldb-commits] [PATCH] D104697: [lldb] Remove more redundant SetStatus(eReturnStatusFailed)

teemperor accepted this revision. teemperor added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Commands/CommandObjectReproducer.cpp:141 static void SetError(CommandReturnObject , Error err) { - result.GetErrorStream().Printf("error:

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104067/new/ https://reviews.llvm.org/D104067

<    1   2   3   4   5   6   7   8   9   10   >