[Lldb-commits] [PATCH] D80556: [lldb] Don't complete ObjCInterfaceDecls in ClangExternalASTSourceCallbacks::FindExternalVisibleDeclsByName

This revision was automatically updated to reflect the committed changes. Closed by commit rG019bd6485c52: [lldb] Dont complete ObjCInterfaceDecls in ClangExternalASTSourceCallbacks… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [PATCH] D80543: [lldb] Manual remove of DISALLOW_COPY_AND_ASSIGN def and one expansion

teemperor added a comment. In D80543#2054405 , @labath wrote: > I am all for this, because makes lldb code more consistent with llvm (llvm > used to have a LLVM_DELETED_FUNCTION macro, but it was removed as soon as > c++11 came into being). > > But

[Lldb-commits] [PATCH] D80254: Prevent GetNumChildren from transitively walking pointer chains

This revision was automatically updated to reflect the committed changes. Closed by commit rG83bd2c4a0680: Prevent GetNumChildren from transitively walking pointer chains (authored by jarin, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D80308: [lldb] Enable C++14 when evaluating expressions in a C++14 frame

teemperor marked an inline comment as done. teemperor added a comment. In D80308#2051624 , @aprantl wrote: > > It seems C++17 and so on isn't yet in any of the language enums (and the > > DWARF standard it seems), so C++17 support will be a follow up

[Lldb-commits] [PATCH] D80254: Prevent GetNumChildren from transitively walking pointer chains

teemperor accepted this revision. teemperor added a comment. I think the refactoring is a good idea, but IMHO this patch can go in as-is. It's not adding any more debt to the existing approach (it even deletes code) and it adds tests, so I don't see a drawback of merging this. Also having this

[Lldb-commits] [PATCH] D80308: [lldb] Enable C++14 when evaluating expressions in a C++14 frame

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f88f39ab815: [lldb] Enable C++14 when evaluating expressions in a C++14 frame (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D80310: [lldb][NFC] Overload raw_ostream operator << for ConstString

This revision was automatically updated to reflect the committed changes. Closed by commit rGbca378f68a7d: [lldb][NFC] Overload raw_ostream operator for ConstString (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D80254: Prevent GetNumChildren from transitively walking pointer chains

teemperor accepted this revision. teemperor added subscribers: labath, clayborg. teemperor added a comment. This revision is now accepted and ready to land. I think this looks good beside some minor nit-picks. Maybe @labath should take a second look too. Comment at:

[Lldb-commits] [PATCH] D79947: [lldb] Print full Clang diagnostics when the ClangModulesDeclVendor fails to compile a module

This revision was automatically updated to reflect the committed changes. Closed by commit rGd48ef7cab558: [lldb] Print full Clang diagnostics when the ClangModulesDeclVendor fails to… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior

[Lldb-commits] [PATCH] D79722: Correct the argument list of command `breakpoint read`

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c89297cf7ee: Correct the argument list of command `breakpoint read` (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. IMHO this looks good now. Maybe add a comment to the commit that this adds support for incomplete types in ValueObjects. I think @jingham should also take a look at this to make sure

[Lldb-commits] [PATCH] D78798: [lldb] Add missing nullptr checks to AppleObjCRuntime::GetBacktraceThreadFromException

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8af9f5fca7d: [lldb] Add missing nullptr checks to AppleObjCRuntime… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D79686: Tab completion for breakpoint write and breakpoint name add/delete

This revision was automatically updated to reflect the committed changes. Closed by commit rGe87362e6894e: Tab completion for breakpoint write and breakpoint name add/delete (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D79666: Complete breakpoint enable/disable/delete/modify with a list of breakpoint IDs

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e50b9a43bf6: Complete breakpoint enable/disable/delete/modify with a list of breakpoint IDs (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [PATCH] D79568: [lldb] Remove 'use_synthetic' parameters in ValueObject code

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b1f1cf1cf71: [lldb] Remove use_synthetic parameters in ValueObject code (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D79632: [lldb][modules] Disable Clang Modules in source/Host directory on macOS

This revision was automatically updated to reflect the committed changes. Closed by commit rG7cf4ab13af8a: [lldb][modules] Disable Clang Modules in source/Host directory on macOS (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I don't see a huge problem with things like `__lldb_autogen_nspair` as it's a single obviously generated type hardcoded into LLDB. But this really generic approach here can

[Lldb-commits] [PATCH] D79490: tab completion for register read/write

This revision was automatically updated to reflect the committed changes. Closed by commit rGa14f4a7531f0: tab completion for register read/write (authored by Gongyu Deng gy_d...@icloud.com, committed by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

teemperor added a comment. I don't really know that ValueObject code, but I wish we could just pretend that the dereferenced type of X is a type named Y or something like that and then just map *Ref classes to their non-opaque bridged types when dereferenced. No idea if that's possible though.

[Lldb-commits] [PATCH] D79563: [lldb/test] Make "inline" tests handle multiple statements at the same location

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Will this also fix these problems? int i = 0; //% code_that_is_executed //% that that isn't executed as it's behind an empty line :( I think disabling the check is fine. You

[Lldb-commits] [PATCH] D79563: [lldb/test] Make "inline" tests handle multiple statements at the same location

teemperor added a comment. Changing might actually be a better idea as this way we at least know this isn't crashing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79563/new/ https://reviews.llvm.org/D79563

[Lldb-commits] [PATCH] D78809: [lldb] Warn the user about starting the --func-regex parameter with an asterisk

This revision was automatically updated to reflect the committed changes. Closed by commit rGaaf68cd9ce2f: [lldb] Warn the user about starting the --func-regex parameter with an asterisk (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [PATCH] D79404: Fix error handling after [] in 'frame variable'

teemperor accepted this revision. teemperor added a comment. I don't think I know this code better than Pavel, but this also LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79404/new/ https://reviews.llvm.org/D79404

[Lldb-commits] [PATCH] D79273: Add an explicit API to read the Xcode SDK DWARF attribute from compile units

teemperor added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:786 + module_sp->RegisterXcodeSDK(sdk, sysroot); + return {sdk}; +} I think we can early-exit here? CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D79251: Fix overloaded operator new cases in TestCppOperators.py which currently work by accident

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: lldb/test/API/lang/cpp/operators/main.cpp:12 bool custom_new = false; B b; This can also go as it's now unused.

[Lldb-commits] [PATCH] D79168: [lldb] Also set owning module for template specializations

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e9fb845fcc4: [lldb] Also set owning module for template specializations (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D74892: [lldb][cmake] Also use local submodule visibility on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rG8baa0b9439b5: [lldb][cmake] Also use local submodule visibility on Darwin (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74892/new/

[Lldb-commits] [PATCH] D75241: [lldb] Adjust TestExec code to be closer to real world code

This revision was automatically updated to reflect the committed changes. Closed by commit rGd00eaa082b7c: [lldb] Adjust TestExec code to be closer to real world code (authored by teemperor). Changed prior to commit: https://reviews.llvm.org/D75241?vs=246911=260303#toc Repository: rG LLVM

[Lldb-commits] [PATCH] D78808: [lldb] Improve error message when --func-regex parameter for the breakpoint command is invalid

This revision was automatically updated to reflect the committed changes. Closed by commit rGb58af8d254ee: [lldb] Improve error message when --func-regex parameter for the breakpoint… (authored by teemperor). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D78333: Add Objective-C property accessors loaded from Clang module DWARF to lookup

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. So it seems there aren't any alternative solutions that are less invasive, so I think this can go in. Comment at:

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. In D78697#2001751 , @aleksandr.urakov wrote: > The problem here is that in the case of success `GetCString()` returns > `nullptr`, and we fail

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

teemperor added a comment. In D78697#2001682 , @aleksandr.urakov wrote: > Thanks! Fixed. The only thing is that `GetCString()` can return `nullptr`, > which leads to `None` in Python, so I made a simple wrapper for that. I think GetCString should

[Lldb-commits] [PATCH] D78697: [lldb][TypeSystemClang] Desugar an elaborated type before checking if it's a typedef or getting a typedefed type

teemperor added a comment. LGTM now beside some minor request for the test. Thanks for the patch! Comment at: lldb/test/API/lang/cpp/typedef/TestCppTypedef.py:33 +expr_result = frame.EvaluateExpression("(SF)s") +self.assertTrue(expr_result.IsValid(), "Can't

[Lldb-commits] [PATCH] D76906: [lldb] Fixing the bug that the "log timer" has no tab completion

teemperor added a comment. In D76906#1972413 , @gedatsu217 wrote: > [39/575] Linking CXX shared library lib/libc++abi.1.0.dylib > FAILED: lib/libc++abi.1.0.dylib > : && /Library/Developer/CommandLineTools/usr/bin/c++ -fPIC >

[Lldb-commits] [PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

teemperor added a comment. Beside Gabors comment I think I'm happy with this. Thanks! Comment at: clang/unittests/AST/ASTImporterTest.cpp:5939 + +/// An ExternalASTSource that keeps track of the tags is completed. +struct SourceWithCompletedTagList : clang::ExternalASTSource {

[Lldb-commits] [PATCH] D78333: Add Objective-C property accessors loaded from Clang module DWARF to lookup

teemperor added a comment. I'm not sure I understand why are we not adding the property to the lookup ptr? I would assume we would call addDecl to it which should make it visible and I don't see any ObjCPropertyDecl (?) check in that code? Comment at:

[Lldb-commits] [PATCH] D77968: [lldb][NFC] Remove FormatterChoiceCriterion

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e3701f8a0bf: [lldb][NFC] Remove FormatterChoiceCriterion (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D78094: [lldb/test] Fix TestLoadUnload

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0be92ebcd8d: [lldb/test] Fix TestLoadUnload (authored by mib, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78094/new/

[Lldb-commits] [PATCH] D77842: Fix setting Python3_ROOT_DIR on Windows

teemperor added a comment. @isuruf Do you have commit access or do you need this committed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77842/new/ https://reviews.llvm.org/D77842 ___ lldb-commits

[Lldb-commits] [PATCH] D76697: [lldb] Replace debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType with lldbassert

teemperor added a subscriber: kkleine. teemperor added a comment. @kkleine yes, that's correct. So what should happen with this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76697/new/ https://reviews.llvm.org/D76697 ___ lldb-commits

[Lldb-commits] [PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. From what I understand the whole idea here is to just ask the external AST source to complete the record before we import them? If yes, then this seems like the right idea to

[Lldb-commits] [PATCH] D77214: [lldb] Add option to retry Fix-Its multiple times to failed expressions

teemperor closed this revision. teemperor added a comment. Somehow Phab forget to close this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77214/new/ https://reviews.llvm.org/D77214 ___

[Lldb-commits] [PATCH] D77842: Fix setting Python3_ROOT_DIR on Windows

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, PYTHON_HOME is apparently the Windows way we allow people to specify the python root when finding the package. Please update the review description though with why this change was

[Lldb-commits] [PATCH] D76906: [lldb] Fixing the bug that the "log timer" has no tab completion

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d3b7370c466: [lldb] Fixing the bug that the log timer has no tab completion (authored by gedatsu217, committed by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

teemperor added a comment. I think the part of the patch that adds documentation to the existing method should go in (In general all patches that just add documentation have my blanket approval, so please just commit those). For the additional function: If you just change that CommandExists

[Lldb-commits] [PATCH] D77214: [lldb] Add option to retry Fix-Its multiple times to failed expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG203a8adb6542: [lldb] Add option to retry Fix-Its multiple times to failed expressions (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [PATCH] D77055: [lldb] Also apply Fix-Its in "note:" diagnostics that belong to an error diagnostic

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c2dc28d812c: [lldb] Also apply Fix-Its in note: diagnostics that belong to an error… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [PATCH] D61548: Fix use of 'is' operator for comparison

teemperor added a comment. I rewrote this test in acb0b99c8e4f1dc65a7f1e26da9db77239a67da7 so this isn't necessary anymore. Thanks for the patch though! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76729: Convert for loops to entry-based iteration

This revision was automatically updated to reflect the committed changes. Closed by commit rG51b38746295f: Convert for loops to entry-based iteration (authored by shivammittal99, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Ok, no more complaints from my side. LGTM Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:1256 + name, + parent_desc ?

[Lldb-commits] [PATCH] D77197: [lldb] Allow expect_expr without a running target

This revision was automatically updated to reflect the committed changes. Closed by commit rG15f34ff2d897: [lldb] Allow expect_expr without a running target (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D76964: Fix an issue where the IgnoreName function was not allowing "Class" to be looked up inside a namespace or other class.

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. LGTM minus some stylistic changes. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp:582 +static const ConstString

[Lldb-commits] [PATCH] D75562: Add an opque payload field to lldb::Type (NFC).

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Could you make the `uint32_t` a typedef? I'm fine with this not being type-safe, but a typedef would at least allow me to search for where this information is used. Grepping/searching

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Sorry for resetting this back from accepted :) Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:1260 + + module->Name = name.str(); +

[Lldb-commits] [PATCH] D77096: Correct the duplicate pragma marks in CommandObjectTarget.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rGd30e9ad34519: Correct the duplicate pragma marks in CommandObjectTarget.cpp (authored by shivammittal99, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D77096: Correct the duplicate pragma marks in CommandObjectTarget.cpp

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77096/new/ https://reviews.llvm.org/D77096

[Lldb-commits] [PATCH] D77042: [lldb] Make Fix-Its also apply to top-level expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG83c81c0a4694: [lldb] Make Fix-Its also apply to top-level expressions (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D76840: [lldb] Fix another crash in covariant type handling

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. To summarize IRC: I think the underlying cause here is that we get the Imported callback from the ASTImporter and then recursively start a completely new import process from that. I

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

This revision was automatically updated to reflect the committed changes. Closed by commit rGdaed98e5b5d1: Convert CommandObjectCommands functions to return StringRefs (authored by shivammittal99, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76697: [lldb] Replace debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType with lldbassert

teemperor updated this revision to Diff 252517. teemperor retitled this revision from "[lldb] Remove Debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType" to "[lldb] Replace debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType with lldbassert".

[Lldb-commits] [PATCH] D76698: [lldb] Always log if acquiring packet sequence mutex fails

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ccc4de42eae: [lldb] Always log if acquiring packet sequence mutex fails (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D76685: [lldb] Don't dump the frame in SBTarget::EvaluateExpression in LLDB_CONFIGURATION_DEBUG

This revision was automatically updated to reflect the committed changes. Closed by commit rGaef982e35acd: [lldb] Dont dump the frame in SBTarget::EvaluateExpression in… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D76687: [lldb][NFC] Always update m_cache_{hits/misses} in FormatCache

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b6a779ca8ce: [lldb][NFC] Always update m_cache_{hits/misses} in FormatCache (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D76699: [lldb] Remove some debugging printfs from ITSession code

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8dab9b3d5b9: [lldb] Remove some debugging printfs from ITSession code (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D76650: Data formatters: fix detection of C strings

This revision was automatically updated to reflect the committed changes. Closed by commit rG177dd63c8d74: Data formatters: fix detection of C strings (authored by jarin, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76699: [lldb] Remove some debugging printfs from ITSession code

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added a subscriber: JDevlieghere. This seems only useful for debugging and it's just plainly printf'ing to the console instead of some log, so let's remove this. Repository: rLLDB LLDB https://reviews.llvm.org/D76699

[Lldb-commits] [PATCH] D76698: [lldb] Always log if acquiring packet sequence mutex fails

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added a subscriber: JDevlieghere. Currently we only log in debug builds but I don't see why we would do this as this is neither expensive and seems useful. I looked into the git history of this code and it seems

[Lldb-commits] [PATCH] D76697: [lldb] Remove Debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added a subscriber: JDevlieghere. teemperor updated this revision to Diff 252289. teemperor added a comment. - Upload correct diff. This assert only triggers in Debug builds (and not in Rel+Assert builds). Let's always

[Lldb-commits] [PATCH] D76697: [lldb] Remove Debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType

teemperor updated this revision to Diff 252289. teemperor added a comment. - Upload correct diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76697/new/ https://reviews.llvm.org/D76697 Files:

[Lldb-commits] [PATCH] D76650: Data formatters: fix detection of C strings

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks for tracking this down! I only have a minor comment about the test character. Comment at:

[Lldb-commits] [PATCH] D76280: [lldb] Mark expressions that couldn't be parsed or executed as failed expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a4905ae2d65: [lldb] Mark expressions that couldnt be parsed or executed as failed… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h:318 + /// Synthesize a clang::Module and return its ID or a default-constructed ID. +

[Lldb-commits] [PATCH] D68010: [lldb] Fix string summary of an empty NSPathStore2

This revision was automatically updated to reflect the committed changes. Closed by commit rG939ca455e72e: [lldb] Fix string summary of an empty NSPathStore2 (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68010/new/

[Lldb-commits] [PATCH] D68010: [lldb] Fix string summary of an empty NSPathStore2

teemperor updated this revision to Diff 251184. teemperor added a comment. - Rebased the patch. This has been (really) delayed because of the whole unit test I wanted to write, but I'll just land this as-is (as having this broken even longer just because I haven't written that new unit test

[Lldb-commits] [PATCH] D75761: [lldb] Fix to get the AST we generate for function templates to be closer to what clang generates and expects

teemperor accepted this revision. teemperor added a comment. LGTM Comment at: lldb/test/API/lang/cpp/template-function/TestTemplateFunctions.py:37 + self.expect_expr("var(1)", result_type="int", result_value="10") + self.expect_expr("var(1,2)",

[Lldb-commits] [PATCH] D75761: [lldb] Fix to get the AST we generate for function templates to be closer to what clang generates and expects

teemperor added a comment. (Also my nit pick about the revision title is still stands) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75761/new/ https://reviews.llvm.org/D75761 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D76011: Add a verification mechanism to CompilerType.

teemperor added a comment. I think this change is slightly orthogonal to the way we are supposed to construct types in LLDB. After the quirky bugs we had with Decl * and DeclContext * pointers in the CompilerDeclContext, I moved all the `Compiler*(TypeSystem *, opaque_ptr*)` constructors calls

[Lldb-commits] [PATCH] D75761: [lldb] Fix to get the AST we generate for function templates to be closer to what clang generates and expects

teemperor added a comment. FWIW, I don't think the error cases should use expect_expr as it currently doesn't have a reasonable way to handle errors (the error_msg thing is really too strict and didn't land on purpose. That was more of a side effect of all the refactoring that went into the

[Lldb-commits] [PATCH] D76080: Adjust error_msg handling for expect_expr in lldbtest.py

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. - All of the asserts should print a useful error when failing (i.e., one that allows us to directly write a fix). You could do assertIn which is clearer than `find(...)` and

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

teemperor added a comment. Fixed in 352f16db87f583ec7f55f8028647b5fd8616111f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75537/new/ https://reviews.llvm.org/D75537

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

teemperor added a comment. Sure, I can take care of it. It seems `OptionValueRegex::Clear` is always resetting to an empty regex. I guess the same goes for the other option values that are failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

teemperor added a comment. I guess now all the shady hacks are coming out. The following settings change their value after calling settings clear after startup in the test: target.process.thread.step-avoid-regexp (regex) -> from '^std::' to empty string platform.module-cache-directory

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

teemperor added a comment. Somehow this broke the macOS LLDB bot: Failing Tests (2): lldb-api :: functionalities/inline-stepping/TestInlineStepping.py lldb-api :: lang/cpp/std-function-step-into-callable/TestStdFunctionStepIntoCallable.py Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D75761: [lldb] Fix to get the AST we generate for function templates to be closer to what clang generates and expects

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I only have some minor comments but otherwise I think this can land. The title could use some updating as "Fix to get the AST we generate for function templates to be closer to what

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

teemperor added inline comments. Comment at: lldb/include/lldb/Symbol/Type.h:198 uint32_t GetEncodingMask(); - - bool IsCompleteObjCClass() { return m_is_complete_objc_class; } - - void SetIsCompleteObjCClass(bool is_complete_objc_class) { -m_is_complete_objc_class =

[Lldb-commits] [PATCH] D75626: Add support for owning module information to TypeSystemClang.

teemperor added a comment. I'm not a big fan of storing data in the `ClangExternalASTSourceCallbacks`. The main reason is that this external source only exists when the ASTContext in the TypeSystemClang is created by the TypeSystemClang. When the TypeSystem adopts an ASTContext there can be

[Lldb-commits] [PATCH] D75761: Fix to get the AST we generate for function templates to be closer to what clang generates and expects

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Small nit pick: Use `expect_expr(` over `expect("expr ...` if you do a Python test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75761/new/

[Lldb-commits] [PATCH] D75715: Switch TypeSystemClang over to CreateDeserialized() (NFC)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. The changes that remove the non-existent module parameter slipped in by mistake I think and the rest LGTM. I didn't verify if all the `setX` calls are 100% identical to what the

[Lldb-commits] [PATCH] D74891: [lldb] Never compile the debugserver with Clang module flags

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e7c686e46c3: [lldb] Never compile the debugserver with Clang module flags (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74891/new/

[Lldb-commits] [PATCH] D75164: [lldb][cmake] Move remove_module_flags macro to AddLLDB.cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rGce1bc00f37d7: [lldb][cmake] Move remove_module_flags macro to AddLLDB.cmake (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D75418: tab completion for process signal

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bba1c22e77a: tab completion for process signal (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75418/new/

[Lldb-commits] [PATCH] D75418: tab completion for process signal

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75418/new/ https://reviews.llvm.org/D75418 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D75497: [lldb][NFC] Refactor TestSafeFuncCalls.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG53b135eeb491: [lldb][NFC] Refactor TestSafeFuncCalls.py (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75497/new/

[Lldb-commits] [PATCH] D75493: [lldb] Remove some #ifdef LLDB_CONFIGURATION_DEBUG around asserts

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b2c4e7178c3: [lldb] Remove some #ifdef LLDB_CONFIGURATION_DEBUG around asserts (authored by teemperor). Changed prior to commit: https://reviews.llvm.org/D75493?vs=247761=248800#toc Repository: rG

[Lldb-commits] [PATCH] D75597: Update the current execution context at the beginning of tab completions

This revision was automatically updated to reflect the committed changes. Closed by commit rGec31255c0080: [lldb] Update the current execution context at the beginning of tab completions (authored by Gongyu Deng gy_d...@icloud.com, committed by teemperor). Herald added a subscriber:

[Lldb-commits] [PATCH] D75418: tab completion for process signal

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I would like to have a test for this without a running process but otherwise this LGTM. Thanks a lot! Comment at:

[Lldb-commits] [PATCH] D75294: [lldb][NFC] Minor code cleanup in Editline.cpp

teemperor added a comment. Actually this LGTM (Jonas already caught the thing I wanted to complain about) but the commit message needs some improvements: - The title should contain "[NFC]" (which is short for "No functional change" and just means that you didn't change any functionality here.

[Lldb-commits] [PATCH] D75496: [lldb][NFC] Remove some commented out code in TypeSystemClang

This revision was automatically updated to reflect the committed changes. Closed by commit rG531515198e47: [lldb][NFC] Remove some commented out code in TypeSystemClang (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D75497: [lldb][NFC] Refactor TestSafeFuncCalls.py

teemperor created this revision. teemperor added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch inlines all the single-line functions that we only use once in the test and replaces the assertTrue with an assertEquals to improve the

[Lldb-commits] [PATCH] D75496: [lldb][NFC] Remove some commented out code in TypeSystemClang

teemperor created this revision. teemperor added a reviewer: LLDB. I don't see why we want to keep that code around. https://reviews.llvm.org/D75496 Files: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp Index: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp

<    3   4   5   6   7   8   9   10   11   12   >