[Lldb-commits] [PATCH] D75493: [lldb] Remove some #ifdef LLDB_CONFIGURATION_DEBUG around asserts

teemperor created this revision. teemperor added a reviewer: aprantl. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Otherwise this code won't run on the Release+Asserts builds we have on the CI. Fixes rdar://problem/59867885 (partly) Repository: rLLDB

[Lldb-commits] [PATCH] D75481: [lldb] Don't iterate over a std::set in SymbolFileDWARF::GetTypes to make it deterministic

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6b3fcdcb8cd: [lldb] Dont iterate over a std::setType* in SymbolFileDWARF::GetTypes to… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D75481: [lldb] Don't iterate over a std::set in SymbolFileDWARF::GetTypes to make it deterministic

teemperor updated this revision to Diff 247733. teemperor added a comment. This revision is now accepted and ready to land. - Use SetVector instead. - Remove now unused include to CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75481/new/ https://reviews.llvm.org/D75481 Files:

[Lldb-commits] [PATCH] D75481: [lldb] Don't iterate over a std::set in SymbolFileDWARF::GetTypes to make it deterministic

teemperor planned changes to this revision. teemperor added a comment. Just realized that this should be `llvm::SetVector` not `UniqueVector` ... Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75481/new/ https://reviews.llvm.org/D75481

[Lldb-commits] [PATCH] D75481: [lldb] Don't iterate over a std::set in SymbolFileDWARF::GetTypes to make it deterministic

teemperor created this revision. teemperor added reviewers: JDevlieghere, aprantl. Herald added subscribers: lldb-commits, abidh, mgrang. Herald added a project: LLDB. JDevlieghere accepted this revision. This revision is now accepted and ready to land. teemperor planned changes to this revision.

[Lldb-commits] [PATCH] D75330: [lldb] Remove checks behind LLDB_CONFIGURATION_DEBUG from TypeSystemClang

This revision was automatically updated to reflect the committed changes. Closed by commit rG69d2b675562c: [lldb] Remove checks behind LLDB_CONFIGURATION_DEBUG from TypeSystemClang (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D75330: [lldb] Remove checks behind LLDB_CONFIGURATION_DEBUG from TypeSystemClang

teemperor created this revision. teemperor added a reviewer: aprantl. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. This function is (supposed) to be a list of asserts that just do a generic sanity check on declarations we return. Right now this

[Lldb-commits] [PATCH] D75241: [lldb] Adjust TestExec code to be closer to real world code

teemperor created this revision. teemperor added reviewers: labath, JDevlieghere. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. For some reason the TestExec test on the macOS bots randomly fails with this error: output: * thread #2, stop reason = EXC_BAD_ACCESS

[Lldb-commits] [PATCH] D75200: AddressSanitizer failure in MemoryCache

teemperor added a comment. This fixes the asan failures for me, so LGTM. Don't really know that code so someone else should approve this. I skipped the test on the sanitizer build for now ( 56b03c35ddecf7d096a513b0633ddf6c49286784

[Lldb-commits] [PATCH] D73018: [lldb] Add SystemInitializerAllPlugins and delete copy-pasted Init code in SystemInitializerFull and SystemInitializerTest

teemperor abandoned this revision. teemperor added a comment. This is no longer needed after Jonas' patches. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73018/new/ https://reviews.llvm.org/D73018 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D74891: [lldb] Never compile the debugserver with Clang module flags

teemperor updated this revision to Diff 246673. teemperor added a comment. - rebased on top of D75164 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74891/new/ https://reviews.llvm.org/D74891 Files:

[Lldb-commits] [PATCH] D75164: [lldb][cmake] Move remove_modue_flags macro to AddLLDB.cmake

teemperor created this revision. teemperor added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. This is currently hidden in the Host CMakeLists but we should also use this macro in other parts of LLDB where we have ObjC++ sources.

[Lldb-commits] [PATCH] D65872: [lldb][NFC] Check in test case for testing virtual function calls in pointers and references.

teemperor abandoned this revision. teemperor added a comment. Herald added a subscriber: JDevlieghere. This was fixed/tested in D73024 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65872/new/ https://reviews.llvm.org/D65872

[Lldb-commits] [PATCH] D75031: [lldb] Fix that a crashing test is marked as unsupported when it prints UNSUPPORTED before crashing

This revision was automatically updated to reflect the committed changes. Closed by commit rG55d4b0d7dd70: [lldb] Fix that a crashing test is marked as unsupported when it prints… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D75073: [lldb] Color the current PC marker

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. This is the best patch I have seen since I started working on LLVM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75073/new/

[Lldb-commits] [PATCH] D75031: [lldb] Fix that a crashing test is marked as unsupported when it prints UNSUPPORTED before crashing

teemperor created this revision. teemperor added reviewers: labath, JDevlieghere. Herald added subscribers: lldb-commits, aprantl. Herald added a project: LLDB. teemperor retitled this revision from "[lldb] Fx that a crashing test is marked as passed as passing/unsupported when it prints

[Lldb-commits] [PATCH] D74957: [lldb] Disable auto fix-its when evaluating expressions in the test suite

This revision was automatically updated to reflect the committed changes. teemperor marked an inline comment as done. Closed by commit rGc131dfefe2b4: [lldb] Disable auto fix-its when evaluating expressions in the test suite (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D74951: [lldb] Remove all the 'current_id' logging counters from the lookup code.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe657a1eb23f8: [lldb] Remove all the current_id logging counters from the lookup code. (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74957: [lldb] Disable auto fix-its when evaluating expressions in the test suite

teemperor marked 3 inline comments as done. teemperor added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2404 +# Disable fix-its that tests don't pass by accident. +options.SetAutoApplyFixIts(True) + shafik wrote:

[Lldb-commits] [PATCH] D74957: [lldb] Disable auto fix-its when evaluating expressions in the test suite

teemperor updated this revision to Diff 245846. teemperor added a comment. - Revert dummy change that set auto-apply fixits to true (thanks Shafik!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74957/new/ https://reviews.llvm.org/D74957 Files:

[Lldb-commits] [PATCH] D74957: [lldb] Disable auto fix-its when evaluating expressions in the test suite

teemperor created this revision. teemperor added reviewers: jingham, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently the test suite runs with enabled automatically applied Clang fix-its for expressions. This is causing that sometimes incorrect

[Lldb-commits] [PATCH] D74951: [lldb] Remove all the 'current_id' logging counters from the lookup code.

teemperor created this revision. teemperor added reviewers: labath, shafik, JDevlieghere. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. teemperor retitled this revision from "[lldb] Remove all the`current_id` logging counters from the lookup code." to "[lldb]

[Lldb-commits] [PATCH] D74903: [lldb][test] Add two wrapper functions to manage settings in test-suite

teemperor added a comment. I'm kinda curious how much we actually support this? I know we do a lot of random fiddling with settings and what not, but I feel if we anyway say that each test needs to have a clean setup, can't we just create like a new SBDebugger instance or something like that

[Lldb-commits] [PATCH] D74891: [lldb] Never compile the debugserver with Clang module flags

teemperor created this revision. Herald added subscribers: lldb-commits, JDevlieghere, mgorny. Herald added a project: LLDB. Compiling ObjC++ with Clang modules is usually not working well and compiling the small debugserver with modules is not worth the trouble. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

teemperor added a comment. If we get away with this approach them I'm completely fine with it. But I would feel better if we first have some more unit tests for RangeDataVector first. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74759/new/

[Lldb-commits] [PATCH] D74478: [lldb] Let TypeSystemClang::GetDisplayTypeName remove anonymous and inline namespaces.

This revision was automatically updated to reflect the committed changes. Closed by commit rG785df616807f: [lldb] Let TypeSystemClang::GetDisplayTypeName remove anonymous and inline… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74816: [lldb/Core] Remove more duplicate code in PluginManager (NFCI)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, let’s send that code to the shadow realm. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74816/new/ https://reviews.llvm.org/D74816

[Lldb-commits] [PATCH] D73946: [lldb] Fix another instance where we pass a nullptr as TypeSourceInfo to NonTypeTemplateParmDecl::Create

This revision was automatically updated to reflect the committed changes. Closed by commit rG40b2c7f29b44: [lldb] Fix another instance where we pass a nullptr as TypeSourceInfo to… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74478: [lldb] Let TypeSystemClang::GetDisplayTypeName remove anonymous and inline namespaces.

teemperor added a comment. In D74478#1874746 , @jingham wrote: > The only hesitation I have about this is if we are still printing this noise > in demangled names, then the name of the type you see for a variable will be > different from what you see

[Lldb-commits] [PATCH] D74310: [lldb] Don't model std::atomic as a transparent data structure in the data formatter

This revision was automatically updated to reflect the committed changes. Closed by commit rG51d8c598331b: [lldb] Dont model std::atomic as a transparent data structure in the data… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74310: [lldb] Don't model std::atomic as a transparent data structure in the data formatter

teemperor updated this revision to Diff 245109. teemperor added a comment. - Expand tests as suggested by Shafik (thanks!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74310/new/ https://reviews.llvm.org/D74310 Files: lldb/source/Plugins/Language/CPlusPlus/LibCxxAtomic.cpp

[Lldb-commits] [PATCH] D74607: [lldb][NFC] Make all CompilerDeclContext parameters references instead of pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9568a95493a: [lldb][NFC] Make all CompilerDeclContext parameters references instead of… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74743: [lldb] Make header guards consistent across LLDB

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Herald added a subscriber: wuzish. Yeah, let's do what LLVM is doing. Thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74743/new/

[Lldb-commits] [PATCH] D74607: [lldb][NFC] Make all CompilerDeclContext parameters references instead of pointers

teemperor updated this revision to Diff 244921. teemperor added a comment. - Readded some `parent_decl_context.IsValid()` checks to SymbolFilePDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74607/new/ https://reviews.llvm.org/D74607 Files: lldb/include/lldb/Core/Module.h

[Lldb-commits] [PATCH] D74657: [lldb/Target] Add process crash-info command

teemperor added a comment. I have some comments (beside my usual documentation spam). But otherwise looks good to me. Comment at: lldb/bindings/interface/SBProcess.i:196 +SBStructuredData +GetCrashInfo (); + documentation. Comment

[Lldb-commits] [PATCH] D74607: [lldb][NFC] Make all CompilerDeclContext parameters references instead of pointers

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:1133 -if (parent_decl_ctx && GetDeclContextContainingUID( - result->getSymIndexId()) !=

[Lldb-commits] [PATCH] D74607: [lldb][NFC] Make all CompilerDeclContext parameters references instead of pointers

teemperor created this revision. teemperor added reviewers: labath, mib. Herald added subscribers: lldb-commits, JDevlieghere, abidh, arphaman. Herald added a project: LLDB. All of our lookup APIs either use `CompilerDeclContext &` or `CompilerDeclContext *` semi-randomly it seems. This leads to

[Lldb-commits] [PATCH] D74478: [lldb] Let TypeSystemClang::GetDisplayTypeName remove anonymous and inline namespaces.

teemperor added a comment. In D74478#1873581 , @shafik wrote: > I can see how stripping `__1` would be nice but I seeing `(anonymous > namespace)` may be useful to know especially b/c it effects visibility and > linkage. It would be nicer if could make

[Lldb-commits] [PATCH] D73860: [lldb/StringPrinter] Avoid reading garbage in uninitialized strings

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. In D73860#1872746 , @vsk wrote: > Ping, @teemperor do you have any concerns about this one? Didn't see Jonas comment when he accepted, sorry.

[Lldb-commits] [PATCH] D74478: [lldb] Let TypeSystemClang::GetDisplayTypeName remove anonymous and inline namespaces.

teemperor created this revision. teemperor added reviewers: shafik, jingham. Herald added subscribers: lldb-commits, JDevlieghere, christof. Herald added a project: LLDB. Currently when printing data types we include implicit scopes such as inline namespaces or anonymous namespaces. This leads

[Lldb-commits] [PATCH] D74252: Fix+re-enable Assert StackFrame Recognizer on Linux

teemperor added inline comments. Comment at: lldb/source/Target/AssertFrameRecognizer.cpp:152 +ConstString func_name = sym_ctx.GetFunctionName(); +if (func_name == ConstString(function_name) || +alternate_function_name.empty() || JDevlieghere

[Lldb-commits] [PATCH] D73938: [Host.mm] Check for the right macro instead of inlining it

teemperor added a comment. I think this is now causing a warning: 1600⧐952 ( 37%) Building CXX object tools/lldb/source/Host/macosx/objcxx/CMakeFiles/lldbHostMacOSXObjCXX.dir/Host.mm.o /Users/teemperor/2llvm/llvm-project/lldb/source/Host/macosx/objcxx/Host.mm:139:14: warning: unused

[Lldb-commits] [PATCH] D74310: [lldb] Don't model std::atomic as a transparent data structure in the data formatter

teemperor created this revision. teemperor added reviewers: JDevlieghere, jingham. Herald added subscribers: lldb-commits, abidh, jfb, christof. Herald added a project: LLDB. Currently the data formatter is treating `std::atomic` variables as transparent wrappers around their underlying value

[Lldb-commits] [PATCH] D74126: [lldb] Remove all 'clean' targets from test Makefiles

This revision was automatically updated to reflect the committed changes. Closed by commit rG68cc9f80a6bf: [lldb] Remove all clean targets from test Makefiles (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74126/new/

[Lldb-commits] [PATCH] D74126: [lldb] Remove all 'clean' targets from test Makefiles

teemperor updated this revision to Diff 243106. teemperor added a comment. - Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74126/new/ https://reviews.llvm.org/D74126 Files: lldb/packages/Python/lldbsuite/test/api/multithreaded/Makefile

[Lldb-commits] [PATCH] D74126: [lldb] Remove all 'clean' targets from test Makefiles

teemperor updated this revision to Diff 242899. teemperor added a comment. - Reverted some removal for bundle tests that somehow use this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74126/new/ https://reviews.llvm.org/D74126 Files:

[Lldb-commits] [PATCH] D74126: [lldb] Remove all 'clean' targets from test Makefiles

teemperor created this revision. teemperor added reviewers: labath, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. To my knowledge we don't actually use or need these rules. And if we need them then there is probably a better way to implement this than

[Lldb-commits] [PATCH] D74038: [lldb] Make TestDataFormatterObjCCF.py pass outside California

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d8bd0d6548e: [lldb] Make TestDataFormatterObjCCF.py pass outside California (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74038: [lldb] Make TestDataFormatterObjCCF.py pass outside California

teemperor created this revision. teemperor added a reviewer: mib. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! This test creates its dates with `NSDate

[Lldb-commits] [PATCH] D73952: [lldb] Ignore type sugar in TypeSystemClang::GetPointerType

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ff4f881a777: [lldb] Ignore type sugar in TypeSystemClang::GetPointerType (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73952/new/

[Lldb-commits] [PATCH] D73946: [lldb] Fix another instance where we pass a nullptr as TypeSourceInfo to NonTypeTemplateParmDecl::Create

teemperor added a comment. In D73946#1857244 , @vsk wrote: > We have test coverage for this already, not sure why the sanitizer bot hasn't > flagged this already: >

[Lldb-commits] [PATCH] D73946: [lldb] Fix another instance where we pass a nullptr as TypeSourceInfo to NonTypeTemplateParmDecl::Create

teemperor updated this revision to Diff 242339. teemperor edited the summary of this revision. teemperor added a comment. - Fix a typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73946/new/ https://reviews.llvm.org/D73946 Files:

[Lldb-commits] [PATCH] D73952: [lldb] Ignore type sugar in TypeSystemClang::GetPointerType

teemperor created this revision. teemperor added a reviewer: shafik. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Currently having a typedef for ObjC types is breaking member access in LLDB: typedef NSString Str; NSString *s; s.length; // OK Str *s;

[Lldb-commits] [PATCH] D73860: [lldb/StringPrinter] Avoid reading garbage in uninitialized strings

teemperor requested changes to this revision. teemperor added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/string/main.cpp:8 +// A corrupt libcxx string which points to garbage and has a crazy length.

[Lldb-commits] [PATCH] D73808: [lldb/TypeSystemClang] Supply trivial TypeSourceInfo to NonTypeTemplateParmDecl::Create

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks for looking into this. I didn't get around to fix that myself yet. Out of curiosity, how did you get this test to fail? When I apply just your changes to the test (without the

[Lldb-commits] [PATCH] D73946: [lldb] Fix another instance where we pass a nullptr as TypeSourceInfo to NonTypeTemplateParmDecl::Create

teemperor created this revision. teemperor added reviewers: shafik, vsk. Herald added subscribers: lldb-commits, JDevlieghere, kristof.beyls. Herald added a project: LLDB. Follow up to an issue pointed out in the review of D73808 . Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D73871: [lldb] Make the order in which ClusterManager calls destructors deterministic

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f4cb2e7b67a: [lldb] Make the order in which ClusterManager calls destructors deterministic (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D73839: [LLDB] Add missing declarations for linking to psapi

teemperor added a comment. Seems like this was nondeterministic? http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13321 Maybe a dependency issue on the tblgen.exe... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73839/new/

[Lldb-commits] [PATCH] D73871: [lldb] Make the order in which ClusterManager calls destructors deterministic

teemperor created this revision. teemperor added reviewers: labath, JDevlieghere. Herald added subscribers: lldb-commits, abidh, mgrang. Herald added a project: LLDB. ClusterManager is using a SmallPtrSet to store the objects in it. We always only add every object once so using a set is not

[Lldb-commits] [PATCH] D73839: [LLDB] Add missing declarations for linking to psapi

teemperor added a comment. I guess this is causing the windows failure on the bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13320 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73839/new/ https://reviews.llvm.org/D73839

[Lldb-commits] [PATCH] D71699: [lldb] Increase the rate at which ConstString's memory allocator scales the memory chunks it allocates

This revision was automatically updated to reflect the committed changes. Closed by commit rG500c324fa13e: [lldb] Increase the rate at which ConstStrings memory allocator scales the… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D73766: [RFC] Make substrs argument to self.expect ordered by default.

teemperor added a comment. FWIW I'm currently going over the failing tests and fixing them, so unless I find a test that actually needs unordered subsets I don't think having the parameter makes sense. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73766/new/

[Lldb-commits] [PATCH] D73766: [RFC] Make substrs argument to self.expect ordered by default.

teemperor added a comment. I'm very much in favor of making this more strict by default. My only problem is that the current error message is really cryptic: AssertionError: False is not True : 'expr --show-types -- *(StgClosure*)$r14' returns expected result, got '(StgClosure) $3 = {

[Lldb-commits] [PATCH] D73661: [lldb] Move clang-based files out of Symbol

teemperor added a comment. Also this doesn't compile on Linux: FAILED: tools/lldb/source/Plugins/ABI/SysV-ppc64/CMakeFiles/lldbPluginABISysV_ppc64.dir/ABISysV_ppc64.cpp.o

[Lldb-commits] [PATCH] D73661: [lldb] Move clang-based files out of Symbol

teemperor added a comment. Pretty much what Pavel said, otherwise this LGTM. Maybe also rename/move the unit test files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73661/new/ https://reviews.llvm.org/D73661

[Lldb-commits] [PATCH] D73345: [lldb] Don't create duplicate declarations when completing a forward declaration with a definition from another source

This revision was automatically updated to reflect the committed changes. Closed by commit rGab8b22d1c2d9: [lldb] Dont create duplicate declarations when completing a forward… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D73024: [lldb] Complete return types of CXXMethodDecls to prevent crashing due to covariant return types

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5fb2e371ec2: [lldb] Complete return types of CXXMethodDecls to prevent crashing due to… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D73506: Auto-completion bug fix for dot operator

teemperor added a comment. I don't really know the vscode plugin code but I pointed out when this was implemented that the whole token replacement mechanism that LLDB's completion API uses is really hard to get right. If you're at it, you might

[Lldb-commits] [PATCH] D73345: [lldb] Don't create duplicate declarations when completing a forward declaration with a definition from another source

teemperor created this revision. teemperor added reviewers: shafik, labath. Herald added subscribers: lldb-commits, JDevlieghere, abidh, aprantl. Herald added a project: LLDB. I noticed this strange line in `ASTImporterDelegate::ImportDefinitionTo` which doesn't make a lot of sense:

[Lldb-commits] [PATCH] D73024: [lldb] Complete return types of CXXMethodDecls to prevent crashing due to covariant return types

teemperor updated this revision to Diff 240156. teemperor added a comment. - Made test stricter. - Moved code to ASTImporterDelegate. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73024/new/ https://reviews.llvm.org/D73024 Files:

[Lldb-commits] [PATCH] D72946: [lldb] Remove ClangASTImporter reference from Target

teemperor added inline comments. Comment at: lldb/include/lldb/Symbol/TypeSystemClang.h:38 +#include "Plugins/ExpressionParser/Clang/ClangPersistentVariables.h" + I would also just let this be part of the normal include list without the empty line (or

[Lldb-commits] [PATCH] D72946: [lldb] Remove ClangASTImporter reference from Target

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. In D72946#1827372 , @clayborg wrote: > Is an AST importer specific to a target? Can we just put it into the Clang > AST type system subclass and

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Abort StackFrame Recognizer

teemperor added inline comments. Comment at: lldb/include/lldb/Target/AbortRecognizer.h:29 + GetAbortLocation(Process *process_sp); + static llvm::Optional> + GetAssertLocation(Process *process_sp); This function (especially the return types) deserve some

[Lldb-commits] [PATCH] D72953: Fix the handling of unnamed bit-fields when parsing DWARF

teemperor added a comment. LGTM modulo some minor points regarding the test. The refactoring of the parsing code and using `expect_expr` can be done as NFC follow-ups. Thanks for the patch, great work! Comment at:

[Lldb-commits] [PATCH] D72953: Fix the handling of unnamed bit-fields when parsing DWARF

teemperor added a comment. I just went back to the radar we had about the CG crash and this *does* fix that issue (rdar://53932023). I could also not reproduce the CG crash again so I assume that was something else that fiddled around in that area. So LGTM minus the thing with the

[Lldb-commits] [PATCH] D72391: [lldb] Add a display name to ClangASTContext instances

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9a39a896c95: [lldb] Add a display name to ClangASTContext instances (authored by teemperor). Changed prior to commit: https://reviews.llvm.org/D72391?vs=236786=239495#toc Repository: rG LLVM Github

[Lldb-commits] [PATCH] D69933: [ASTImporter] Limit imports of structs

teemperor added a comment. I really don't think the ASTImporter should ever manipulate records in the source context (effectively the source context should be considered immutable). It also seems *very* wrong that what we import depends in any way on a previous expression so I agree we should

[Lldb-commits] [PATCH] D73018: [lldb] Add SystemInitializerAllPlugins and delete copy-pasted Init code in SystemInitializerFull and SystemInitializerTest

teemperor added a comment. > This still leaves the question of the script interpreter plugins, which are > suspiciously *not* included in "all plugins". The script interpreters are > quite special, so I think it's fine to handle them separately -- the question > is just how to convey that

[Lldb-commits] [PATCH] D73018: [lldb] Add SystemInitializerAllPlugins and delete copy-pasted Init code in SystemInitializerFull and SystemInitializerTest

teemperor updated this revision to Diff 239251. teemperor added a comment. - Removed all the duplicated linking flags too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73018/new/ https://reviews.llvm.org/D73018 Files: lldb/include/lldb/Initialization/SystemInitializerAllPlugins.h

[Lldb-commits] [PATCH] D73018: [lldb] Add SystemInitializerAllPlugins and delete copy-pasted Init code in SystemInitializerFull and SystemInitializerTest

teemperor marked an inline comment as done. teemperor added a comment. I moved the single non-plugin call back to the original Full/Test subclasses so the name is now correct. Also I removed all the duplicated linking flags that I forgot to remove before. I also don't think we should make this

[Lldb-commits] [PATCH] D72909: Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort

teemperor added inline comments. Comment at: lldb/source/Symbol/LineTable.cpp:27 + LineTable::Entry::LessThanBinaryPredicate less_than_bp(this); + std::sort(sequences.begin(), sequences.end(), less_than_bp); + for (auto *sequence : sequences) { grimar wrote:

[Lldb-commits] [PATCH] D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided.

This revision was automatically updated to reflect the committed changes. Closed by commit rG22447a61d405: [lldb] Mark the implicit copy constructor as deleted when a move constructor is… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided.

teemperor updated this revision to Diff 239084. teemperor added a comment. - Added a simple expr evaluation as an additional way to trigger the error. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72694/new/ https://reviews.llvm.org/D72694 Files:

[Lldb-commits] [PATCH] D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided.

teemperor marked 2 inline comments as done. teemperor added a comment. Thanks for the review! Comment at: lldb/packages/Python/lldbsuite/test/commands/expression/deleting-implicit-copy-constructor/main.cpp:14 + // should have propagated to this record and Clang won't crash.

[Lldb-commits] [PATCH] D73024: [lldb] Complete return types of CXXMethodDecls to prevent crashing due to covariant return types

teemperor planned changes to this revision. teemperor added a comment. Actually that seems to be more complicated in case we get the method decl by asking the ASTImporter for a definition (which will skip this code). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72953: Fix the handling of unnamed bit-fields when parsing DWARF

teemperor added a comment. (Jim pointed out that we land this without expect_expr to make back porting easier but somehow Phabricator didn't add his comment to the review here. `expect_expr` is not yet in the downstream Github branch but it is in the 10 release branch, so that makes sense to

[Lldb-commits] [PATCH] D73024: [lldb] Complete return types of CXXMethodDecls to prevent crashing due to covariant return types

teemperor created this revision. teemperor added reviewers: lhames, shafik. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. Currently we crash in Clang's CodeGen when we call functions with covariant return types with this assert: Assertion failed:

[Lldb-commits] [PATCH] D73018: [lldb] Add SystemInitializerAllPlugins and delete copy-pasted Init code in SystemInitializerFull and SystemInitializerTest

teemperor created this revision. teemperor added reviewers: labath, JDevlieghere. Herald added subscribers: lldb-commits, s.egerton, abidh, simoncook, fedor.sergeev, aheejin, krytarowski, mgorny, dschuff. Herald added a project: LLDB. teemperor edited the summary of this revision.

[Lldb-commits] [PATCH] D73016: [lldb/CMake] Make it possible to disable plugins at configuration time

teemperor added a comment. How does this deal with linking flags etc.? Your cmake cache disabled `LLDB_PLUGIN_SYMBOLFILE_NATIVEPDB_BUILD` (well, it would without the LDB typo) but that just gives me a build that fails to link with `ld: error: unable to find library

[Lldb-commits] [PATCH] D72953: Fix the handling of unnamed bit-fields when parsing DWARF

teemperor added a comment. (Just some quick comments, will review this properly during normal working hours) Without this fix debugging Clang with LLDB is essentially impossible, so I'm in favour of landing this with as few pre-commit refactorings as possible to make backporting easier and

[Lldb-commits] [PATCH] D72946: [lldb] Remove ClangASTImporter reference from Target

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I wish we could do this without a global map. Also the ClangASTImporter shouldn't have a dependency on Target (I'm actually surprised this compiles without an additional

[Lldb-commits] [PATCH] D72909: Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort

teemperor added inline comments. Comment at: lldb/source/Symbol/LineTable.cpp:172 + LineSequenceImpl *seq_b = reinterpret_cast(sequence_b); + return (*this)(seq_a->m_entries.front(), seq_b->m_entries.front()); +} Nit pick, this would also work without the

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang

teemperor added a comment. Herald added a subscriber: wuzish. Are there any objections against this? Otherwise I'll land this tomorrow. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72684/new/ https://reviews.llvm.org/D72684 ___

[Lldb-commits] [PATCH] D70314: [lldb] Add expect_expr function for testing expression evaluation in dotests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG13f22f5d5958: [lldb] Add expect_expr function for testing expression evaluation in dotests. (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D70314: [lldb] Add better test commands for expression evaluation

teemperor updated this revision to Diff 238209. teemperor added a comment. - Removed substr functionality. - Using `frame()` now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70314/new/ https://reviews.llvm.org/D70314 Files:

[Lldb-commits] [PATCH] D70314: [lldb] Add better test commands for expression evaluation

teemperor updated this revision to Diff 238205. teemperor added a comment. - Removed everything that is not summary or value. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70314/new/ https://reviews.llvm.org/D70314 Files:

[Lldb-commits] [PATCH] D70314: [lldb] Add better test commands for expression evaluation

teemperor added a comment. I also got rid of the expr->frame var->expr flow and it's not just expr->frame var. I don't want to remove them as we found two formatter bugs by testing both but once these thing don't break constantly then we can remove the 'expr' variant from the simple expression

[Lldb-commits] [PATCH] D70314: [lldb] Add better test commands for expression evaluation

teemperor updated this revision to Diff 238189. teemperor added a comment. - Moved to using the SBAPI. We can't get fully rid of parsing some output as GetDescription of SBValue returns `(type) $0 = VALUE\n` but there seems to be no way to get rid of the stuff around the value we want. But we

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang

teemperor added a comment. In D72684#1820486 , @clayborg wrote: > We might also want to move these into lldb/source/Plugins/TypeSystem as well > to complete this refactor? I fully agree but I prefer if we could do this as it's own change. This patch

[Lldb-commits] [PATCH] D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided.

teemperor updated this revision to Diff 237981. teemperor added a comment. - Readd test files. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72694/new/ https://reviews.llvm.org/D72694 Files:

<    4   5   6   7   8   9   10   11   12   13   >