[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang

teemperor updated this revision to Diff 237959. teemperor retitled this revision from "[lldb][NFC] Rename ClangASTContext to ClangTypeSystem" to "[lldb][NFC] Rename ClangASTContext to TypeSystemClang". teemperor added a comment. - Revert to original dummy patch. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided.

teemperor updated this revision to Diff 237960. teemperor added a comment. - Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72694/new/ https://reviews.llvm.org/D72694 Files: lldb/packages/Python/lldbsuite/test/commands/expression/completion-crash1/TestCompletionCrash1.py

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to ClangTypeSystem

teemperor added a comment. Huh, seems I uploaded to the wrong review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72684/new/ https://reviews.llvm.org/D72684 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to ClangTypeSystem

teemperor updated this revision to Diff 237953. teemperor added a comment. - Rebased to get rid of shady StringRef -> C-String conversion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72684/new/ https://reviews.llvm.org/D72684 Files:

[Lldb-commits] [PATCH] D72698: [lldb] Add method decls to a CXXRecordDecl only after all their properties are defined

teemperor created this revision. teemperor added a reviewer: shafik. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Calling `addDecl` on a CXXRecordDecl is not a trivial method but is actually inspecting the added declarations to infer properties about the

[Lldb-commits] [PATCH] D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided.

teemperor added a comment. FWIW this patch makes me realise that we really should have a Sema around when we create the module AST as this would prevent issues like this and saves us from simulating Sema behavior. That's probably yet another large refactoring so I don't have time for that

[Lldb-commits] [PATCH] D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided.

teemperor updated this revision to Diff 237948. teemperor added a comment. - Upload correct revision of the test file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72694/new/ https://reviews.llvm.org/D72694 Files:

[Lldb-commits] [PATCH] D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided.

teemperor created this revision. teemperor added a reviewer: shafik. Herald added subscribers: lldb-commits, JDevlieghere, aprantl. Herald added a project: LLDB. CXXRecordDecls that have a move constructor but no copy constructor need to have their implicit copy constructor marked as deleted (see

[Lldb-commits] [PATCH] D72510: [lldb/Expression] Improve interpreter error message with a non-running target

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72510/new/ https://reviews.llvm.org/D72510

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to ClangTypeSystem

teemperor added a comment. Both TypeSystemClang and ClangTypeSystem works for me. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72684/new/ https://reviews.llvm.org/D72684 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D72593: [lldb][NFC] Rewrite python_api/rdar-12481949 test

This revision was automatically updated to reflect the committed changes. Closed by commit rGd8ffd601d523: [lldb][NFC] Rewrite python_api/rdar-12481949 test (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72593/new/

[Lldb-commits] [PATCH] D72596: [lldb] Don't defend against internal LLVM errors in IRInterpreter

This revision was automatically updated to reflect the committed changes. Closed by commit rGf18370fe0e75: [lldb] Dont defend against internal LLVM errors in IRInterpreter (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to ClangTypeSystem

teemperor added a comment. We are currently after a fresh rebranch downstream so now is a good time to rename this without causing merge-conflict hell later on. It would be useful if could get consensus if and to what we should rename this class soon-ish so that I can make this move as

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to ClangTypeSystem

teemperor created this revision. teemperor added reviewers: LLDB, aprantl, shafik, clayborg. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. This commit renames ClangASTContext to ClangTypeSystem to better reflect what this class is actually supposed to

[Lldb-commits] [PATCH] D72086: [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end.

This revision was automatically updated to reflect the committed changes. Closed by commit rG61b6a4e82653: [lldb] Fix that SBThread.GetStopDescription is returning strings with… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72447: [lldb] Mark several tests as not dependent on debug info

teemperor added a comment. In D72447#1817559 , @stella.stamenova wrote: > This introduced a failure on the Windows LLDB bot (there were already other > failing tests though, so maybe you missed it): > >

[Lldb-commits] [PATCH] D72596: [lldb] Don't defend against internal LLVM errors in IRInterpreter

teemperor created this revision. teemperor added reviewers: labath, mib. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. teemperor edited the summary of this revision. Whenever we cast an LLVM instruction to one of its subclasses, we do a double check

[Lldb-commits] [PATCH] D72593: [lldb][NFC] Rewrite python_api/rdar-12481949 test

teemperor created this revision. teemperor added reviewers: labath, aprantl. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. This renames the test `rdar-12481949` to `get-value-32bit-int` as it just tests that we return the correct result get calling

[Lldb-commits] [PATCH] D72447: [lldb] Mark several tests as not dependent on debug info

This revision was automatically updated to reflect the committed changes. Closed by commit rGddf044290ede: [lldb] Mark several tests as not dependent on debug info (authored by teemperor). Changed prior to commit: https://reviews.llvm.org/D72447?vs=237047=237594#toc Repository: rG LLVM

[Lldb-commits] [PATCH] D72086: [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end.

teemperor added a comment. I made a new typemap now that is only for GetStopDescription and it's snprintf semantics. This keeps all the other functions working. I kept the old behavior of requiring a >0 buffer size etc. in tact for now. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72086: [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end.

teemperor updated this revision to Diff 237590. teemperor added a comment. - Move to use a new typemap for GetStopDescription. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72086/new/ https://reviews.llvm.org/D72086 Files: lldb/bindings/interface/SBThread.i

[Lldb-commits] [PATCH] D72510: [lldb/Expression] Improve interpreter error message with a non-running target

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. To give this more context: The IRInterpreter can interpret function calls but only on Hexagon (see D9404 ). The reason why we essentially

[Lldb-commits] [PATCH] D72359: [lldb] Fix TestClangASTContext.TestFunctionTemplateInRecordConstruction in Debug builds

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e13cff44d6b: [lldb] Fix TestClangASTContext.TestFunctionTemplateInRecordConstruction in… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72495: [lldb] Make CompleteTagDeclsScope completion order deterministic

This revision was automatically updated to reflect the committed changes. Closed by commit rG77da826edad0: [lldb] Make CompleteTagDeclsScope completion order deterministic (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72507: [lldb] Remove FieldDecl stealing hack by rerouting indirect imports to the original AST

This revision was automatically updated to reflect the committed changes. Closed by commit rGef239972614c: [lldb] Remove FieldDecl stealing hack by rerouting indirect imports to the… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72507: [lldb] Remove FieldDecl stealing hack by rerouting indirect imports to the original AST

teemperor added a comment. FWIW, this isn't really a finished patch yet as I actually wanted to write several unit tests for this, but as it fixes the gmodules failures on master I thought I might as well put it up now. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72507: [lldb] Remove FieldDecl stealing hack by rerouting indirect imports to the original AST

teemperor created this revision. teemperor added reviewers: shafik, aprantl. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. teemperor added a comment. FWIW, this isn't really a finished patch yet as I actually wanted to write several unit tests for this, but

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

This revision was automatically updated to reflect the committed changes. Closed by commit rG902974277d50: Data formatters: Look through array element typedefs (authored by jarin, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

teemperor added a comment. Actually the failures are gmodules only so I'll land this now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72133/new/ https://reviews.llvm.org/D72133 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

teemperor added a comment. In D72133#1813724 , @jarin wrote: > Raphael, could you possibly land the patch for me? Thanks! It's in my queue, but the green dragon bot (and my own CI) are currently dead due to a libc++ change that breaks the data

[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. In D72413#1811038 , @aprantl wrote: > In D72413#1810969 , @jingham wrote: > > > If we can't make a

[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

teemperor added a comment. The C++ expression parser will probably behave incredibly incorrectly without a persistent state but before this patch it just crashed, so I think this is good to go. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72413/new/ https://reviews.llvm.org/D72413

[Lldb-commits] [PATCH] D72086: [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end.

teemperor added a comment. Ah, seems like we match in the type map by function signature and GetSTDOUT matches the signature by accident CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72086/new/ https://reviews.llvm.org/D72086 ___

[Lldb-commits] [PATCH] D72447: [lldb] Mark several tests as not dependent on debug info

teemperor added a comment. Herald added a subscriber: dexonsmith. Some of the tests technically touch debug information but don't test features specific to it. If anyone thinks some of these tests are worthwhile to run with all debug information variants then let me know. Repository: rLLDB

[Lldb-commits] [PATCH] D72447: [lldb] Mark several tests as not dependent on debug info

teemperor created this revision. teemperor added reviewers: labath, jingham, aprantl, mib. Herald added a reviewer: jfb. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. This just adds `NO_DEBUG_INFO_TESTCASE` to tests that don't really exercise anything debug

[Lldb-commits] [PATCH] D72086: [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end.

teemperor added a comment. For reasons that are beyond my understanding this change seems to break `SBProcess.GetSTDOUT` in random tests like this: == ERROR: test_change_value_dwarf

[Lldb-commits] [PATCH] D72086: [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end.

teemperor updated this revision to Diff 236986. teemperor added a comment. - Just removed the result parameter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72086/new/ https://reviews.llvm.org/D72086 Files: lldb/packages/Python/lldbsuite/test/python_api/thread/TestThreadAPI.py

[Lldb-commits] [PATCH] D72190: Removing C-style casts in favor of explict C++ style casts

teemperor added inline comments. Comment at: lldb/include/lldb/Expression/IRExecutionUnit.h:330 - static const unsigned eSectionIDInvalid = (unsigned)-1; Do we even need this cast? Neither Clang nor GCC complain about `unsigned X = -1` for me. CHANGES

[Lldb-commits] [PATCH] D72086: [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end.

teemperor updated this revision to Diff 236793. teemperor added a comment. - Remove unintended empty line change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72086/new/ https://reviews.llvm.org/D72086 Files: lldb/packages/Python/lldbsuite/test/python_api/thread/TestThreadAPI.py

[Lldb-commits] [PATCH] D72086: [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end.

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/scripts/Python/python-typemaps.swig:124-125 } else { - llvm::StringRef ref(static_cast($1), result); + const char *cstr = static_cast($1); + llvm::StringRef ref(cstr,

[Lldb-commits] [PATCH] D72086: [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end.

teemperor updated this revision to Diff 236790. teemperor marked an inline comment as done. teemperor added a comment. - Simplify swig type map code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72086/new/ https://reviews.llvm.org/D72086 Files:

[Lldb-commits] [PATCH] D72391: [lldb] Add a display name to ClangASTContext instances

teemperor created this revision. teemperor added reviewers: shafik, labath, JDevlieghere, mib. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. teemperor added a comment. I don't know if this needs a unit test where we call the constructor and explicitly check the name is

[Lldb-commits] [PATCH] D72391: [lldb] Add a display name to ClangASTContext instances

teemperor added a comment. I don't know if this needs a unit test where we call the constructor and explicitly check the name is the one we passed in. Let me know if you think this would make sense. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72391/new/

[Lldb-commits] [PATCH] D72359: [lldb] Fix TestClangASTContext.TestFunctionTemplateInRecordConstruction in Debug builds

teemperor created this revision. teemperor added a reviewer: shafik. Herald added subscribers: lldb-commits, JDevlieghere, aprantl. Herald added a project: LLDB. In Debug builds we call VerifyDecl in ClangASTContext::CreateFunctionDeclaration which in turn calls `getAccess` on the created

[Lldb-commits] [PATCH] D72161: [lldb][NFC] Use static_cast instead of reinterpret_cast where possible

This revision was automatically updated to reflect the committed changes. Closed by commit rG65fdb34219f3: [lldb][NFC] Use static_cast instead of reinterpret_cast where possible (authored by teemperor). Changed prior to commit: https://reviews.llvm.org/D72161?vs=236066=236552#toc Repository:

[Lldb-commits] [PATCH] D72161: [lldb][NFC] Use static_cast instead of reinterpret_cast where possible

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/tools/debugserver/source/MacOSX/MachProcess.mm:1745 + "0x%8.8llx, length = %llu) => %p", + (uint64_t)addr, (uint64_t)length, static_cast(bp));

[Lldb-commits] [PATCH] D72086: [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end.

teemperor updated this revision to Diff 236542. teemperor edited the summary of this revision. teemperor added a comment. - Move change to SWIG type map. - Fixed some type in the test. The API never emulated the snprintf behavior as it includes a NULL byte when we pass a nullptr buffer (and

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

teemperor added a comment. In D72133#1806822 , @clayborg wrote: > So as long as the following are true from this patch I am ok: > > - if I ask for the array element type of "str" in the test that was added, it > should return "MCHAR". We shouldn't be

[Lldb-commits] [PATCH] D72161: [lldb][NFC] Use static_cast instead of reinterpret_cast where possible

teemperor created this revision. teemperor added reviewers: shafik, JDevlieghere, labath. Herald added subscribers: lldb-commits, usaxena95, arphaman. Herald added a project: LLDB. There are a few places in LLDB where we do a `reinterpret_cast` for conversions that we could also do with

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

teemperor added a comment. Interesting, I actually can't reproduce those failures on any of my machines. Can you post the error output you get? But I agree that we can figure this out in a separate patch, so I'll give this another test run and then land it. Thanks for the patch! CHANGES

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

teemperor added a comment. Just FYI, I meant that `lldb/source/API/SBType.cpp` shouldn't be changed with this patch. I think it's fine that this patch will change the behavior (as the old behavior seems broken). Also do you need someone to commit this for you? CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D71909: [lldb] Fix crash in AccessDeclContextSanity when copying FunctionTemplateDecl inside a record.

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/source/Symbol/ClangASTContext.cpp:1347 + if (decl_ctx->isRecord()) +func_tmpl_decl->setAccess(clang::AccessSpecifier::AS_public); shafik wrote: > Where is the

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I have some comments but otherwise this patch looks good to me. Thanks! Comment at:

[Lldb-commits] [PATCH] D72086: [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end.

teemperor created this revision. teemperor added a reviewer: labath. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. `SBThread.GetStopDescription` is a curious API as it takes a buffer length as a parameter that specifies how many bytes the buffer we

[Lldb-commits] [PATCH] D71909: [lldb] Fix crash in AccessDeclContextSanity when copying FunctionTemplateDecl inside a record.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ead00872929: [lldb] Fix crash in AccessDeclContextSanity when copying FunctionTemplateDecl… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D71909: [lldb] Fix crash in AccessDeclContextSanity when copying FunctionTemplateDecl inside a record.

teemperor added a comment. I'll land this now as its a pretty straightforward fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71909/new/ https://reviews.llvm.org/D71909 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D71906: [lldb][tests] Make it possible to expect failure for a whole category

teemperor added a comment. This LGTM but I'm not the right person to sign this off. I guess Pavel and Jonas know this code better. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71906/new/ https://reviews.llvm.org/D71906

[Lldb-commits] [PATCH] D71909: [lldb] Fix crash in AccessDeclContextSanity when copying FunctionTemplateDecl inside a record.

teemperor updated this revision to Diff 235369. teemperor added a comment. - Add unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71909/new/ https://reviews.llvm.org/D71909 Files:

[Lldb-commits] [PATCH] D71909: [lldb] Fix crash in AccessDeclContextSanity when copying FunctionTemplateDecl inside a record.

teemperor created this revision. teemperor added a reviewer: shafik. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. teemperor retitled this revision from "[lldb] Fixcrash in AccessDeclContextSanity when copying FunctionTemplateDecl inside a record." to

[Lldb-commits] [PATCH] D71630: [lldb] Add a SubsystemRAII that takes care of calling Initialize and Terminate in the unit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG5dca0596a959: [lldb] Add a SubsystemRAII that takes care of calling Initialize and Terminate… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D71630: [lldb] Add a SubsystemRAII that takes care of calling Initialize and Terminate in the unit tests

teemperor updated this revision to Diff 235109. teemperor added a comment. - Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71630/new/ https://reviews.llvm.org/D71630 Files: lldb/unittests/Core/MangledTest.cpp lldb/unittests/Editline/EditlineTest.cpp

[Lldb-commits] [PATCH] D71630: [lldb] Add a SubsystemRAII that takes care of calling Initialize and Terminate in the unit tests

teemperor updated this revision to Diff 234860. teemperor added a comment. - Migrated more tests to SubsystemRAII CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71630/new/ https://reviews.llvm.org/D71630 Files: lldb/unittests/Core/MangledTest.cpp

[Lldb-commits] [PATCH] D71748: [lldb] Make that we can call HostInfo::Initialize and HostInfo::Terminate multiple times

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2371791fc74: [lldb] Make that we can call HostInfo::Initialize and HostInfo::Terminate… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68464: [lldb][modern-type-lookup] Ask the ExternalASTMerger to lookup namespaces instead of using the old mechanism

teemperor abandoned this revision. teemperor added a comment. modern-type-lookup has been removed, closing this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68464/new/ https://reviews.llvm.org/D68464 ___

[Lldb-commits] [PATCH] D71699: [lldb] Increase the rate at which ConstString's memory allocator scales the memory chunks it allocates

teemperor added a comment. (This patch is otherwise ready to land) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71699/new/ https://reviews.llvm.org/D71699 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D71699: [lldb] Increase the rate at which ConstString's memory allocator scales the memory chunks it allocates

teemperor added a comment. @llunak can you test how this affects your runtime for the use case you wanted this for? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71699/new/ https://reviews.llvm.org/D71699 ___

[Lldb-commits] [PATCH] D71748: [lldb] Make that we can call HostInfo::Initialize and HostInfo::Terminate multiple times

teemperor created this revision. teemperor added a reviewer: labath. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. HostInfo's state isn't actually fully rested after calling ::Terminate. Currently we only reset the values of all the

[Lldb-commits] [PATCH] D71630: [lldb] Add a SubsystemRAII that takes care of calling Initialize and Terminate in the unit tests

teemperor updated this revision to Diff 234839. teemperor added a comment. Herald added a subscriber: mgorny. - Add test - Move SubsystemRAIICase to ::detail I'll wait with landing this until HostInfo's Initialize/Terminate are fixed (calling Terminate and Initialize is currently breaking the

[Lldb-commits] [PATCH] D71630: [lldb] Add a SubsystemRAII that takes care of calling Initialize and Terminate in the unit tests

teemperor updated this revision to Diff 234711. teemperor added a comment. - Added SFINAE spaghetti to handle llvm::Error return types. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71630/new/ https://reviews.llvm.org/D71630 Files: lldb/unittests/Core/MangledTest.cpp

[Lldb-commits] [PATCH] D71699: [lldb] Increase the rate at which ConstString's memory allocator scales the memory chunks it allocates

teemperor created this revision. teemperor added a reviewer: llunak. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. teemperor added a parent revision: D71654: [llvm] Add a way to speed up the speed in which BumpPtrAllocator increases slab sizes. We

[Lldb-commits] [PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

teemperor added a comment. Another bug report for this: https://bugs.llvm.org/show_bug.cgi?id=44331 Please close when landing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71378/new/ https://reviews.llvm.org/D71378 ___ lldb-commits

[Lldb-commits] [PATCH] D71575: [LLDB] Add initial support for WebAssembly debugging

teemperor added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/WASM-DYLD/DynamicLoaderWasmDYLD.cpp:1 +//===-- DynamicLoaderWasmDYLD.cpp *- C++ +//-*-===// paolosev wrote: > aprantl wrote: > > 1. This hangs over

[Lldb-commits] [PATCH] D71630: [lldb] Add a SubsystemRAII that takes care of calling Initialize and Terminate in the unit tests

teemperor created this revision. teemperor added reviewers: labath, JDevlieghere. Herald added subscribers: lldb-commits, abidh, MaskRay, emaste. Herald added a reviewer: martong. Herald added a reviewer: espindola. Herald added a reviewer: shafik. Herald added a project: LLDB. teemperor added a

[Lldb-commits] [PATCH] D71630: [lldb] Add a SubsystemRAII that takes care of calling Initialize and Terminate in the unit tests

teemperor added a comment. Herald added a subscriber: rnkovacs. I only converted like 40% of our tests to the new system as I first wanted to get some feedback before I do all the refactoring. Also I'm open to ideas how to name the member (currently I just use `subsystems` without the `m_`

[Lldb-commits] [PATCH] D71603: [lldb] Make ClangASTImporter::LayoutRecordType always return the same layout

teemperor created this revision. teemperor added a reviewer: shafik. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. teemperor removed reviewers: martong, a.sidorin. Herald added a reviewer:

[Lldb-commits] [PATCH] D71562: [lldb] Remove modern-type-lookup

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGff0102b32cfe: [lldb] Remove modern-type-lookup (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D71562: [lldb] Remove modern-type-lookup

teemperor added a comment. I'm landing this now as I started the cleanup work for the current lookup code and the modern-type-lookup code is blocking that refactoring. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71562/new/ https://reviews.llvm.org/D71562

[Lldb-commits] [PATCH] D71196: [lldb] Add support for calling objc_direct methods from LLDB's expression evaluator.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd5b54bbfaf19: [lldb] Add support for calling objc_direct methods from LLDBs expression… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D71575: [LLDB] Add initial support for WebAssembly debugging

teemperor added a comment. I think this is really nice. I have some minor remarks here and there but otherwise this LGTM. Comment at: lldb/source/Plugins/DynamicLoader/WASM-DYLD/DynamicLoaderWasmDYLD.cpp:88 + + if ((module_sp = modules.FindFirstModule(module_spec))) { +

[Lldb-commits] [PATCH] D71562: [lldb] Remove modern-type-lookup

teemperor added a comment. @martong I added you as a reviewer because I assume you were interested in that development. I'm curious what you think should happen to the clang-import-test. We could either rewrite the tests as unit tests in the ASTImporterTest you guys are already using or we

[Lldb-commits] [PATCH] D71562: [lldb] Remove modern-type-lookup

teemperor created this revision. teemperor added reviewers: shafik, martong. Herald added subscribers: lldb-commits, usaxena95, JDevlieghere, arphaman, christof, rnkovacs. Herald added a project: LLDB. teemperor added a comment. @martong I added you as a reviewer because I assume you were

[Lldb-commits] [PATCH] D71489: [lldb][NFC] Remove unnecessary includes in source/Commands

This revision was automatically updated to reflect the committed changes. Closed by commit rG068325012796: [lldb][NFC] Remove unnecessary includes in source/Commands (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71489/new/

[Lldb-commits] [PATCH] D71398: [lldb] Remove RTTI in ClangExternalASTSourceCommon based on a global map of known instances

This revision was automatically updated to reflect the committed changes. Closed by commit rG8280896bd1b0: [lldb] Remove RTTI in ClangExternalASTSourceCommon based on a global map of… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D71398: [lldb] Remove RTTI in ClangExternalASTSourceCommon based on a global map of known instances

teemperor updated this revision to Diff 233984. teemperor added a comment. - Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71398/new/ https://reviews.llvm.org/D71398 Files: lldb/include/lldb/Symbol/ClangExternalASTSourceCommon.h lldb/source/Symbol/ClangASTContext.cpp

[Lldb-commits] [PATCH] D71405: [lldb] Centralize desugaring of decltype-like types in ClangASTContext

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. The change LGTM but the test could just be a unit test instead of doing the whole compile->start->attach->expr command cycle. You can just add this to the `TestClangASTContext.cpp` to

[Lldb-commits] [PATCH] D71489: [lldb][NFC] Remove unnecessary includes in source/Commands

teemperor created this revision. teemperor added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, krytarowski. Herald added a project: LLDB. teemperor marked an inline comment as done. teemperor added inline comments. Comment at:

[Lldb-commits] [PATCH] D71489: [lldb][NFC] Remove unnecessary includes in source/Commands

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/source/Commands/CommandCompletions.cpp:12 -#include -#endif - I did this change by hand as both includes are not used at all and the #if can then also go.

[Lldb-commits] [PATCH] D71482: [lldb/CMake] Rename LLDB_DISABLE_PYTHON to LLDB_ENABLE_PYTHON

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. That seems like a simple mechanical change and the move from DISABLE to ENABLE was IIRC already consensus, so LGTM. Comment at:

[Lldb-commits] [PATCH] D71454: [lldb][NFC] Remove all `setUp` overrides that only call the parent implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rG9bace26a690a: [lldb][NFC] Remove all `setUp` overrides that only call the parent… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D71409: [lldb][NFC] Make metadata tracking type safe

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ab9fa44cd60: [lldb][NFC] Make metadata tracking type safe (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71409/new/

[Lldb-commits] [PATCH] D71409: [lldb][NFC] Make metadata tracking type safe

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/source/Symbol/ClangExternalASTSourceCommon.cpp:64 +ClangExternalASTSourceCommon::GetMetadata(const clang::Type *object) { + auto It = m_type_metadata.find(object); + if (It !=

[Lldb-commits] [PATCH] D71454: [lldb][NFC] Remove all `setUp` overrides that only call the parent implementation

teemperor created this revision. teemperor added reviewers: labath, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A lot of our tests copied the setUp code from our TestSampleTest.py: def setUp(self): # Call super's setUp().

[Lldb-commits] [PATCH] D71452: [lldb][NFC] Remove 'from __future__ import print_function' from all tests that don't actually call 'print()'

teemperor added a comment. Herald added subscribers: wuzish, dexonsmith. I tested this on python2 (macOS) and python3 (Arch Linux) so this shouldn't break any test. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71452/new/ https://reviews.llvm.org/D71452

[Lldb-commits] [PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

teemperor added a comment. I wonder if we have a way to fix this from with LLDB. Having Clang code that is only tested in LLDB is always a bit weird. Otherwise the idea itself LGTM, thanks for working on this (and reducing the test case to that!) Comment at:

[Lldb-commits] [PATCH] D71409: [lldb][NFC] Make metadata tracking type safe

teemperor added a comment. (I'm aware that a lot of the touched code here could be improved, but I would prefer that I at least can trust my compiler before I refactor the remaining Metadata stuff...) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71409/new/

[Lldb-commits] [PATCH] D71409: [lldb][NFC] Make metadata tracking type safe

teemperor created this revision. teemperor added reviewers: labath, shafik, aprantl. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. teemperor added a comment. teemperor edited the summary of this revision. (I'm aware that a lot of the touched code here could

[Lldb-commits] [PATCH] D71336: [lldb] Remove ClangASTMetrics

This revision was automatically updated to reflect the committed changes. Closed by commit rGe39cb48cd0bd: [lldb] Remove ClangASTMetrics (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71336/new/

[Lldb-commits] [PATCH] D71398: [lldb] Remove RTTI in ClangExternalASTSourceCommon based on a global map of known instances

teemperor created this revision. teemperor added reviewers: labath, aprantl. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Currently we do our RTTI check for ClangExternalASTSourceCommon by using this global map of ClangExternalASTSourceCommon where every

[Lldb-commits] [PATCH] D71336: [lldb] Remove ClangASTMetrics

teemperor created this revision. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Not once have I looked at these numbers in a log and considered them useful for anything. Also we should not

[Lldb-commits] [PATCH] D71299: [FormatManager] Add a unittest for GetCandidateLanguages()

teemperor added inline comments. Comment at: lldb/unittests/DataFormatter/FormatManagerTests.cpp:9-24 +#include "TestingSupport/TestUtilities.h" + +#include "lldb/Core/Mangled.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include

<    5   6   7   8   9   10   11   12   13   14   >