[Lldb-commits] [PATCH] D146041: Fix weirdly apologetic diagnostic messages

rsmith added a comment. I have no strong opinions on the merits of this patch in either direction; I think the "sorry"s in the Sema diagnostics for regrettable non-conformance make Clang marginally friendlier, but they do nothing to actually help people who encounter the diagnostic. FWIW, the

[Lldb-commits] [PATCH] D142733: Add _Optional as fast qualifier

rsmith added a comment. Including a link to the RFC (https://discourse.llvm.org/t/rfc-optional-a-type-qualifier-to-indicate-pointer-nullability/68004/2) in each of the patches in this series would be helpful. Assuming that we want to go in this direction, it seems quite expensive to model this

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

rsmith added a comment. In D131858#3957630 , @arphaman wrote: > This change has caused a failure in Clang's stage 2 CI on the green dragon > Darwin CI: > https://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/6390/console. > > Assertion failed: (l

[Lldb-commits] [PATCH] D133069: Fix inconsistent target arch when attaching to arm64 binaries on arm64e platforms.

rsmith added a comment. Hi, the newly-added test, `TestDynamicLoaderDarwin.py`, fails under asan: https://gist.github.com/zygoloid/bf7b21f03d7db966e456b6c365c4635d Please can you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133069/ne

[Lldb-commits] [PATCH] D117383: [lldb] Expose std::pair children for unordered_map

rsmith added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp:74 + if (name.consume_front("std::")) +name.consume_front("__1::"); + return name.consume_front(type) && name.startswith("<"); This is not right -- libc+

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

rsmith accepted this revision. rsmith added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

rsmith accepted this revision. rsmith added a comment. Looks good to me. Comment at: clang/lib/Sema/SemaExprCXX.cpp:6504-6516 // If we have function pointer types, unify them anyway to unify their // exception specifications, if any. if (LTy->isFunctionPointerTyp

[Lldb-commits] [PATCH] D95164: Make SBDebugger::CreateTargetWithFileAndArch accept lldb.LLDB_DEFAULT_ARCH

rsmith added a comment. I reverted this and the follow-up fix in rG8b1171488575bd0b5ccb23bc1a3d22e2aaccb244 , because it's introduced several test failures. Example: http://lab.llvm.org:8011/#/builders/96/builds/3777 It appe

[Lldb-commits] [PATCH] D39307: Fix global data symbol resolution

rsmith added a comment. In https://reviews.llvm.org/D39307#907358, @xiaobai wrote: > It seems like clang shouldn't even be asking us about this in the first > place, but I don't fully understand why it's trying to do what it's trying to > do. It looks like there are two issues here: clang is