[Lldb-commits] [PATCH] D108510: [lldb] Allow to register frame recognizers applied beyond the first instruction

2021-08-21 Thread Roman Podoliaka via Phabricator via lldb-commits
malor created this revision. malor added reviewers: jingham, mib. malor added a project: LLDB. Herald added subscribers: dang, JDevlieghere. malor requested review of this revision. Herald added a subscriber: lldb-commits. It is currently possible to register a frame recognizer, but it will be app

[Lldb-commits] [PATCH] D108510: [lldb] Allow to register frame recognizers applied beyond the first instruction

2021-08-24 Thread Roman Podoliaka via Phabricator via lldb-commits
malor added a comment. In D108510#2961332 , @jingham wrote: > One of the key reasons to use "frame recognizers" is to provide argument > values to functions that don't have debug information. That generally only > works when stopped at the first instru

[Lldb-commits] [PATCH] D108510: [lldb] Allow to register frame recognizers applied beyond the first instruction

2021-08-25 Thread Roman Podoliaka via Phabricator via lldb-commits
malor updated this revision to Diff 368565. malor added a comment. Updated the description of the flag to incorporate Jim's feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108510/new/ https://reviews.llvm.org/D108510 Files: lldb/source/Commands/CommandObjectFrame.cpp lldb/s

[Lldb-commits] [PATCH] D108510: [lldb] Allow to register frame recognizers applied beyond the first instruction

2021-08-29 Thread Roman Podoliaka via Phabricator via lldb-commits
malor added a comment. Thank you, Jim! Would you be able to submit this change? The clang-tidy premerge check has failed, but I don't think it's actionable: it's complaining about an #include in the file that I'm not modifying -- I saw it failing in the same way (although, on different files)

[Lldb-commits] [PATCH] D108510: [lldb] Allow to register frame recognizers applied beyond the first instruction

2021-08-29 Thread Roman Podoliaka via Phabricator via lldb-commits
malor added a comment. In D108510#2971249 , @mib wrote: > Hi Roman, thanks for your patch. It also looks good to me, so I'll land it > for you. Thank you, Med! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or