[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-06 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/156803 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-06 Thread Roy Shi via lldb-commits
royitaqi wrote: @JDevlieghere: Thank you for your reply. I appreciate it a lot. I will: 1. Learn about the memory monitor in DAP. * Context: It's not failing - We are just starting to experiment with the server mode. This connection timeout feature is a precaution before we can do large sc

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-05 Thread Roy Shi via lldb-commits
@@ -327,6 +366,11 @@ serveConnection(const Socket::SocketProtocol &protocol, const std::string &name, std::unique_lock lock(dap_sessions_mutex); dap_sessions.erase(&loop); std::notify_all_at_thread_exit(dap_sessions_condition, std::move(lock)); + + // St

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread Roy Shi via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/156803 >From 9af1b0029e3e19b521d472d8c94596709f990166 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Wed, 3 Sep 2025 22:23:20 -0700 Subject: [PATCH 1/2] [lldb-dap] Add optional TTL argument when using --connection ---

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-04 Thread Roy Shi via lldb-commits
royitaqi wrote: @JDevlieghere Thanks for the good questions. I appreciate all of them. Below are my thoughts for discussion. > proliferation of new options > motivation Main motivation is memory pressure. Other ways to counter memory pressure is either to monitor from lldb-dap VS Code extensi

[Lldb-commits] [lldb] [lldb-dap] Add new optional argument `time-to-live` when using `--connection` (PR #156803)

2025-09-03 Thread Roy Shi via lldb-commits
https://github.com/royitaqi created https://github.com/llvm/llvm-project/pull/156803 # Usage ``` --time-to-live When using --connection, the number of milliseconds to wait for new connections at the beginning and after all clients have disconnected. Not specifying

[Lldb-commits] [lldb] [lldb-dap] Destroy debugger when debug session terminates (PR #156231)

2025-09-02 Thread Roy Shi via lldb-commits
royitaqi wrote: > do you know if destroying the debugger will free the module cache? @walter-erquinigo: I assume, by "module cache", you meant the global module list accessible by `ModuleList::GetSharedModule()` and `ModuleList::GetSharedModuleList()`. I think destroying the debugger will NOT

[Lldb-commits] [lldb] [lldb-dap] Destroy debugger when debug session terminates (PR #156231)

2025-08-31 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/156231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Destroy debugger when debug session terminates (PR #156231)

2025-08-31 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/156231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Destroy debugger when debug session terminates (PR #156231)

2025-08-31 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/156231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Destroy debugger when debug session terminates (PR #156231)

2025-08-31 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/156231 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Destroy debugger at disconnect request (PR #156231)

2025-08-31 Thread Roy Shi via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/156231 >From c35a97fb54dfc046be3bdcde2a6297603aa9b297 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Sun, 31 Aug 2025 01:45:23 -0700 Subject: [PATCH] [lldb-dap] Destroy debugger when debug session terminates --- lldb/

[Lldb-commits] [lldb] [lldb-dap] Destroy debugger at disconnect request (PR #156231)

2025-08-31 Thread Roy Shi via lldb-commits
https://github.com/royitaqi created https://github.com/llvm/llvm-project/pull/156231 Currently, in Server Mode (i.e. `--connection`), the destroy callbacks of all debuggers are called at the lldb-dap process's termination. This causes delayed logging and release of resources. This can also cau

[Lldb-commits] [lldb] [vscode-lldb] Support lldb-dap environment in debug configuration (PR #153536)

2025-08-28 Thread Roy Shi via lldb-commits
https://github.com/royitaqi closed https://github.com/llvm/llvm-project/pull/153536 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Support lldb-dap environment in debug configuration (PR #153536)

2025-08-26 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/153536 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Support lldb-dap environment in debug configuration (PR #153536)

2025-08-26 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/153536 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Support lldb-dap environment in debug configuration (PR #153536)

2025-08-26 Thread Roy Shi via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/153536 >From a8b0d3ebb8e3b5519ecda14699346123781abc2b Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Wed, 13 Aug 2025 22:47:58 -0700 Subject: [PATCH 1/5] [vscode-lldb] Support lldb-dap environment in debug configuratio

[Lldb-commits] [lldb] [vscode-lldb] Support lldb-dap environment in debug configuration (PR #153536)

2025-08-26 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/153536 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Support lldb-dap environment in debug configuration (PR #153536)

2025-08-26 Thread Roy Shi via lldb-commits
@@ -157,6 +157,61 @@ async function getDAPArguments( .get("arguments", []); } +/** + * Retrieves the environment that will be provided to lldb-dap either from settings or the provided + * {@link vscode.DebugConfiguration}. + * + * @param workspaceFolder The {@link vscode.

[Lldb-commits] [lldb] [vscode-lldb] Support lldb-dap environment in debug configuration (PR #153536)

2025-08-26 Thread Roy Shi via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/153536 >From a8b0d3ebb8e3b5519ecda14699346123781abc2b Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Wed, 13 Aug 2025 22:47:58 -0700 Subject: [PATCH 1/4] [vscode-lldb] Support lldb-dap environment in debug configuratio

[Lldb-commits] [lldb] [vscode-lldb] Support lldb-dap environment in debug configuration (PR #153536)

2025-08-26 Thread Roy Shi via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/153536 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Support lldb-dap environment in debug configuration (PR #153536)

2025-08-26 Thread Roy Shi via lldb-commits
@@ -157,6 +157,61 @@ async function getDAPArguments( .get("arguments", []); } +/** + * Retrieves the environment that will be provided to lldb-dap either from settings or the provided + * {@link vscode.DebugConfiguration}. + * + * @param workspaceFolder The {@link vscode.

[Lldb-commits] [lldb] [vscode-lldb] Support lldb-dap environment in debug configuration (PR #153536)

2025-08-16 Thread Roy Shi via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/153536 >From a8b0d3ebb8e3b5519ecda14699346123781abc2b Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Wed, 13 Aug 2025 22:47:58 -0700 Subject: [PATCH 1/3] [vscode-lldb] Support lldb-dap environment in debug configuratio

[Lldb-commits] [lldb] [vscode-lldb] Support lldb-dap environment in debug configuration (PR #153536)

2025-08-15 Thread Roy Shi via lldb-commits
royitaqi wrote: @JDevlieghere / @walter-erquinigo: Gentle ping: Do you guys want to review before I merge, or later? (I know I can already merge with one approval. Just want to be a good citizen and check with you guys.) https://github.com/llvm/llvm-project/pull/153536 ___