Re: [Lldb-commits] [PATCH] D19273: Update Go OS Plugin for newer runtimes

This revision was automatically updated to reflect the committed changes. Closed by commit rL267048: Update Go OS Plugin for newer runtimes. (authored by ribrdb). Changed prior to commit: http://reviews.llvm.org/D19273?vs=54427=54572#toc Repository: rL LLVM http://reviews.llvm.org/D19273

[Lldb-commits] [lldb] r267048 - Update Go OS Plugin for newer runtimes.

Author: ribrdb Date: Thu Apr 21 15:57:28 2016 New Revision: 267048 URL: http://llvm.org/viewvc/llvm-project?rev=267048=rev Log: Update Go OS Plugin for newer runtimes. Differential Revision: http://reviews.llvm.org/D19273 Modified:

Re: [Lldb-commits] [PATCH] D19273: Update Go OS Plugin for newer runtimes

ribrdb removed rL LLVM as the repository for this revision. ribrdb updated this revision to Diff 54427. http://reviews.llvm.org/D19273 Files: source/Plugins/OperatingSystem/Go/OperatingSystemGo.cpp Index: source/Plugins/OperatingSystem/Go/OperatingSystemGo.cpp

Re: [Lldb-commits] [PATCH] D19273: Update Go OS Plugin for newer runtimes

ribrdb marked an inline comment as done. ribrdb added a comment. I'm not sure how else we could identify the runtime version. I'm hoping to eventually add a producer string that has the version, but this would just be a git commit for development compilers. Repository: rL LLVM

[Lldb-commits] [PATCH] D19273: Update Go OS Plugin for newer runtimes

ribrdb created this revision. ribrdb added a subscriber: lldb-commits. ribrdb set the repository for this revision to rL LLVM. Repository: rL LLVM http://reviews.llvm.org/D19273 Files: source/Plugins/OperatingSystem/Go/OperatingSystemGo.cpp Index:

[Lldb-commits] [PATCH] D16234: Implement missing GoASTContext methods

ribrdb created this revision. ribrdb added a reviewer: clayborg. ribrdb added a subscriber: lldb-commits. ribrdb set the repository for this revision to rL LLVM. Repository: rL LLVM http://reviews.llvm.org/D16234 Files: source/Symbol/GoASTContext.cpp Index: source/Symbol/GoASTContext.cpp

[Lldb-commits] [lldb] r257926 - Implement missing GoASTContext methods

Author: ribrdb Date: Fri Jan 15 13:35:48 2016 New Revision: 257926 URL: http://llvm.org/viewvc/llvm-project?rev=257926=rev Log: Implement missing GoASTContext methods Modified: lldb/trunk/source/Symbol/GoASTContext.cpp Modified: lldb/trunk/source/Symbol/GoASTContext.cpp URL:

Re: [Lldb-commits] [lldb] r257926 - Implement missing GoASTContext methods

It would be nice if we could get this into 3.8 to get rid of these asserts. -- Ryan Brown On Fri, Jan 15, 2016 at 11:35 AM, Ryan Brown via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: ribrdb > Date: Fri Jan 15 13:35:48 2016 > New Revision: 257926 > > URL: h

[Lldb-commits] [lldb] r252109 - Add go data formatters.

Author: ribrdb Date: Wed Nov 4 18:24:36 2015 New Revision: 252109 URL: http://llvm.org/viewvc/llvm-project?rev=252109=rev Log: Add go data formatters. Differential Revision: http://reviews.llvm.org/D13878 Added: lldb/trunk/packages/Python/lldbsuite/test/lang/go/formatters/

[Lldb-commits] [lldb] r252007 - Fix build for go parser unittest.

Author: ribrdb Date: Tue Nov 3 16:46:37 2015 New Revision: 252007 URL: http://llvm.org/viewvc/llvm-project?rev=252007=rev Log: Fix build for go parser unittest. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj lldb/trunk/unittests/Expression/GoParserTest.cpp Modified:

[Lldb-commits] [lldb] r251835 - Move go expression tests to the new location.

Author: ribrdb Date: Mon Nov 2 15:28:18 2015 New Revision: 251835 URL: http://llvm.org/viewvc/llvm-project?rev=251835=rev Log: Move go expression tests to the new location. Added: lldb/trunk/packages/Python/lldbsuite/test/lang/go/expressions/

Re: [Lldb-commits] [PATCH] D13073: Add an expression parser for Go

ribrdb added a comment. Is this ready to submit? Comment at: source/Expression/LLVMUserExpression.cpp:43-60 @@ +42,20 @@ + +LLVMUserExpression::LLVMUserExpression(ExecutionContextScope _scope, const char *expr, const char *expr_prefix, +

Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

ribrdb added a comment. Is this ready to submit? http://reviews.llvm.org/D13878 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

ribrdb added inline comments. Comment at: source/Plugins/Language/Go/GoFormatterFunctions.cpp:10 @@ +9,3 @@ + +#include + Eugene.Zelenko wrote: > Please add include section comments. Same for other sections. Which sections? I've seen a couple types of section

Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

ribrdb removed rL LLVM as the repository for this revision. ribrdb updated this revision to Diff 37900. ribrdb added a comment. Oops, I ran clang-format with the wrong arguments. Ran it again. http://reviews.llvm.org/D13878 Files: cmake/LLDBDependencies.cmake lldb.xcodeproj/project.pbxproj

Re: [Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

ribrdb updated this revision to Diff 37898. Repository: rL LLVM http://reviews.llvm.org/D13878 Files: cmake/LLDBDependencies.cmake lldb.xcodeproj/project.pbxproj source/API/SystemInitializerFull.cpp source/Plugins/Language/CMakeLists.txt source/Plugins/Language/Go/CMakeLists.txt

[Lldb-commits] [PATCH] D13878: Add data formatters for go strings and slices.

ribrdb created this revision. ribrdb added a reviewer: clayborg. ribrdb added a subscriber: lldb-commits. ribrdb set the repository for this revision to rL LLVM. Repository: rL LLVM http://reviews.llvm.org/D13878 Files: cmake/LLDBDependencies.cmake lldb.xcodeproj/project.pbxproj

Re: [Lldb-commits] [PATCH] D13149: Create GoLanguageRuntime

ribrdb closed this revision. ribrdb added a comment. Submitted in revisions 249456 and 249459. Repository: rL LLVM http://reviews.llvm.org/D13149 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13268: Simple readline functionality for interactive python on linux.

ribrdb updated this revision to Diff 36637. Repository: rL LLVM http://reviews.llvm.org/D13268 Files: CMakeLists.txt scripts/Python/modules/readline/CMakeLists.txt scripts/Python/modules/readline/readline.cpp source/CMakeLists.txt Index: source/CMakeLists.txt

Re: [Lldb-commits] [lldb] r248934 - Now persistent expression data no longer lives with the Target, but rather with

Shouldn't Target::GetPersistentVariable take a language parameter instead of assuming clang? On Wed, Sep 30, 2015 at 12:59 PM Sean Callanan via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: spyffe > Date: Wed Sep 30 14:57:57 2015 > New Revision: 248934 > > URL:

Re: [Lldb-commits] [lldb] r248934 - Now persistent expression data no longer lives with the Target, but rather with

Oh, now I see the search in 249027. But how does this work with multiple type systems? Target no longer manages persistent variable names so won't each type system generate conflicting names? e.g. (lldb) expr -l c -- 1 $1 = 1 (lldb) expr -l go -- 2 $1 = 2 (lldb) expr -l go -- $1 Which $1 do you

Re: [Lldb-commits] [PATCH] D13268: Simple readline functionality for interactive python on linux.

ribrdb updated this revision to Diff 36295. ribrdb marked an inline comment as done. ribrdb added a comment. Updated comments. Repository: rL LLVM http://reviews.llvm.org/D13268 Files: scripts/Python/modules/readline/CMakeLists.txt scripts/Python/modules/readline/readline.cpp Index:

[Lldb-commits] [PATCH] D13268: Simple readline functionality for interactive python on linux.

ribrdb created this revision. ribrdb added a reviewer: tfiala. ribrdb added a subscriber: lldb-commits. ribrdb set the repository for this revision to rL LLVM. This implements basic line editing for the interactive python interpreter on linux. No tab completion, but at least backspace works.

[Lldb-commits] [PATCH] D13149: Create GoLanguageRuntime

ribrdb created this revision. ribrdb added a reviewer: clayborg. ribrdb added a subscriber: lldb-commits. ribrdb set the repository for this revision to rL LLVM. GoLanguageRuntime supports finding the runtime type for Go interfaces. Repository: rL LLVM http://reviews.llvm.org/D13149 Files:

Re: [Lldb-commits] [PATCH] D13073: Add an expression parser for Go

ribrdb added a comment. Hmm. I assumed you're using clang to generate llvm IR, is that not the case? I don't really want to write a whole go compiler. Right now I'm interpreting the AST using the ValueObject API. This also lets me reuse the error checking and things implemented in the type

Re: [Lldb-commits] [PATCH] D5871: Add an OperatingSystem plugin to support goroutines

ribrdb updated this revision to Diff 34914. ribrdb added a comment. > I am confused as to why we need to do this. If you have a memory thread, it > might be backed by a real thread, or it might not. If it is backed by a > real thread, we should be asking the real thread why it really

Re: [Lldb-commits] [PATCH] D5871: Add an OperatingSystem plugin to support goroutines

ribrdb updated the summary for this revision. ribrdb set the repository for this revision to rL LLVM. ribrdb updated this revision to Diff 34806. ribrdb added a comment. I've updated this to load the plugin when modules are loaded, added a setting to enable/disable the goroutine plugin, and

Re: [Lldb-commits] [PATCH] D5871: Add an OperatingSystem plugin to support goroutines

ribrdb updated this revision to Diff 34839. ribrdb added a comment. Fix cmake build. Repository: rL LLVM http://reviews.llvm.org/D5871 Files: cmake/LLDBDependencies.cmake include/lldb/Core/PluginManager.h lib/Makefile lldb.xcodeproj/project.pbxproj source/Core/PluginManager.cpp

[Lldb-commits] [lldb] r247647 - Fix error on windows:

Author: ribrdb Date: Mon Sep 14 19:50:43 2015 New Revision: 247647 URL: http://llvm.org/viewvc/llvm-project?rev=247647=rev Log: Fix error on windows: c:\buildbot\lldb-windows-x86\lldb-windows-x86\llvm\tools\lldb\source\symbol\goastcontext.cpp(906) : warning C4715:

Re: [Lldb-commits] [lldb] r247082 - Implement a Target::GetTypeSystemForLanguage API, as well as provide helpers on the TypeSystem to get numeric types of specific sizes and signedness

On Wed, Sep 9, 2015 at 2:57 PM Enrico Granata wrote: > On Sep 9, 2015, at 2:47 PM, Ryan Brown wrote: > > > On Tue, Sep 8, 2015 at 3:10 PM Enrico Granata via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > >> Author: enrico >> Date: Tue Sep 8

Re: [Lldb-commits] [lldb] r247082 - Implement a Target::GetTypeSystemForLanguage API, as well as provide helpers on the TypeSystem to get numeric types of specific sizes and signedness

On Tue, Sep 8, 2015 at 3:10 PM Enrico Granata via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: enrico > Date: Tue Sep 8 17:09:19 2015 > New Revision: 247082 > > URL: http://llvm.org/viewvc/llvm-project?rev=247082=rev > Log: > Implement a Target::GetTypeSystemForLanguage API, as