serhiy.redko updated this revision to Diff 390182.
serhiy.redko edited the summary of this revision.
serhiy.redko added a comment.
As requested DAP now reports an error in case debug configuration contains
unused target related keys
("program", "coreFile" etc) along with "launchCommands" or
serhiy.redko updated this revision to Diff 380298.
serhiy.redko added a comment.
- return error in case debug configuration contains incompatible fields with
'launchCommands'/'attachCommands'
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94997/new/
https://reviews.llvm.org/D94997
serhiy.redko updated this revision to Diff 378575.
serhiy.redko added a comment.
- added printing of unused target related fields from launch.json in case
launchCommands/attachCommands fields are provided.
- updated help info in for launch/attach fields according to review request.
CHANGES
serhiy.redko planned changes to this revision.
serhiy.redko added a comment.
Thanks for review and your input, @clayborg
> So I agree we need to fix the "settings set" issue as it surfaces a quirk in
> the order and number of targets we create. The main questions is if we care
> that we don't
serhiy.redko created this revision.
serhiy.redko requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
launch.json's fields have ambiguity with how final target is created:
1. There are dedicated fields to specify target like "program", "pid",
