Author: sas
Date: Wed Aug 22 15:25:45 2018
New Revision: 340460
URL: http://llvm.org/viewvc/llvm-project?rev=340460&view=rev
Log:
Add include directory for libxml on macOS
Summary:
Builds fail because libxml/xmlreader.h isn't found. Adding the include
directory to the include list fixes the issue
Author: sas
Date: Thu Aug 16 17:35:47 2018
New Revision: 339974
URL: http://llvm.org/viewvc/llvm-project?rev=339974&view=rev
Log:
Add a relocation for R_AARCH64_ABS32 in ObjectFileELF
Summary:
.rela.debug_info relocations are being done via
ObjectFileELF::ApplyRelocations for aarch64. Currently,
Author: sas
Date: Mon Aug 6 15:21:28 2018
New Revision: 339071
URL: http://llvm.org/viewvc/llvm-project?rev=339071&view=rev
Log:
Revert "Add a relocation for R_AARCH64_ABS32 in ObjectFileELF"
This reverts commit f055ce7eb893cd0d17ebcfd4125018f46f983aff.
Modified:
lldb/trunk/source/Plugins/O
Author: sas
Date: Mon Aug 6 15:04:08 2018
New Revision: 339068
URL: http://llvm.org/viewvc/llvm-project?rev=339068&view=rev
Log:
Add a relocation for R_AARCH64_ABS32 in ObjectFileELF
Summary:
.rela.debug_info relocations are being done via
ObjectFileELF::ApplyRelocations for aarch64. Currently,
Yeah, just a quick note about ds2, this is the current status of supported
platforms:
* Linux (x86/x86_64/arm/aarch64), used for debugging processes on "classic"
linux (Ubuntu, centOS, etc), Android, as well as Tizen.
* Windows (x86/x86_64/arm), used to debug processes on Windows Desktop,
Windows P
Author: sas
Date: Tue Nov 28 09:50:31 2017
New Revision: 319191
URL: http://llvm.org/viewvc/llvm-project?rev=319191&view=rev
Log:
Simplify UUID constructors
Summary: This remove a small amount of duplicated code.
Reviewers: clayborg, zturner, davide
Subscribers: lldb-commits
Differential Revis
Author: sas
Date: Mon Nov 27 17:26:07 2017
New Revision: 319132
URL: http://llvm.org/viewvc/llvm-project?rev=319132&view=rev
Log:
Remove some duplicated code in UUID.cpp
Summary: Formatting needs to be done only once. Ran check-lldb and nothing
changes.
Reviewers: clayborg, davide
Reviewed By:
Author: sas
Date: Mon Nov 27 13:16:37 2017
New Revision: 319095
URL: http://llvm.org/viewvc/llvm-project?rev=319095&view=rev
Log:
Mark UUID::GetByteSize() const
Summary:
This method doesn't modify anything in the object it's called on so we
can mark it const to make it usable in a const context.
Author: sas
Date: Wed Nov 22 15:56:32 2017
New Revision: 318886
URL: http://llvm.org/viewvc/llvm-project?rev=318886&view=rev
Log:
Run clang-format on source/Host/common/Symbols.cpp
I saw a bunch of style errors so this fixes them.
Modified:
lldb/trunk/source/Host/common/Symbols.cpp
Modified
Author: sas
Date: Mon Nov 13 12:13:25 2017
New Revision: 318079
URL: http://llvm.org/viewvc/llvm-project?rev=318079&view=rev
Log:
Reformat a comment. NFC.
Modified:
lldb/trunk/include/lldb/lldb-private-defines.h
Modified: lldb/trunk/include/lldb/lldb-private-defines.h
URL:
http://llvm.org/v
Author: sas
Date: Mon Nov 6 16:14:40 2017
New Revision: 317529
URL: http://llvm.org/viewvc/llvm-project?rev=317529&view=rev
Log:
Disable tests in lang/c/shared_lib on Windows
Summary: These fail because `-fPIC` is not supported on Windows.
Reviewers: zturner, jingham, clayborg
Reviewed By: cla
I think @zturner is correct. Shared libraries do work with lldb on Windows,
just just that these tests are not buildable for Windows.
On Mon, Nov 6, 2017 at 1:56 PM Zachary Turner wrote:
> It’s been a long time since I looked at this but I remember it just being
> a problem in the Makefiles, not
Author: sas
Date: Mon Nov 6 11:25:33 2017
New Revision: 317501
URL: http://llvm.org/viewvc/llvm-project?rev=317501&view=rev
Log:
Add a dependency from check-lldb on lld
Summary:
This is required when using the in-tree clang for building tests,
because -fuse-ld=lld is used by default.
Subscriber
Makes sense. I'll update the diff.
On Mon, Nov 6, 2017 at 9:28 AM Zachary Turner wrote:
> This is definitely required, but only on windows. I’d put it behind a
> check for Windows, and I’d also add a check to print a warning/error if
> (TARGET lld) returns false on windows
> On Mon, Nov 6, 2017
Author: sas
Date: Thu Nov 2 09:56:52 2017
New Revision: 317219
URL: http://llvm.org/viewvc/llvm-project?rev=317219&view=rev
Log:
Run clang-format on lldb.cpp
Modified:
lldb/trunk/source/lldb.cpp
Modified: lldb/trunk/source/lldb.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source
Author: sas
Date: Thu Nov 2 09:56:19 2017
New Revision: 317218
URL: http://llvm.org/viewvc/llvm-project?rev=317218&view=rev
Log:
Use LLVM version string
Summary:
macOS builds of LLDB use the bundle version from
`tools/driver/lldb-Info.plist`. That file hasn't been updated since the 4.0
release s
This changes nothing except for 32bit Windows, which used to not be able to
benefit from ABISysV_i386 but can use it now. The ABI support is tested
independently from Windows itself.
On Thu, Oct 26, 2017 at 10:25 AM Davide Italiano
wrote:
> On Thu, Oct 26, 2017 at 10:04 AM, Stephane Sezer
Author: sas
Date: Thu Oct 26 10:04:20 2017
New Revision: 316673
URL: http://llvm.org/viewvc/llvm-project?rev=316673&view=rev
Log:
Allow SysV-i386 ABI on everything other than Apple targets
Summary:
This matches other SysV ABIs that are different on Apple and non-Apple targets,
like `ABISysV_arm.c
Author: sas
Date: Tue Oct 24 16:46:00 2017
New Revision: 316533
URL: http://llvm.org/viewvc/llvm-project?rev=316533&view=rev
Log:
Fix a compile warning on linux
Can't cast directly between a pointer to function and a pointer to
object.
Modified:
lldb/trunk/source/API/SBDebugger.cpp
Modified
Author: sas
Date: Tue Oct 24 16:40:59 2017
New Revision: 316532
URL: http://llvm.org/viewvc/llvm-project?rev=316532&view=rev
Log:
Allow ObjectFilePECOFF to initialize with ARM binaries.
Summary: This is required to start debugging WinPhone ARM targets.
Reviewers: compnerd, zturner, omjavaid
Rev
Author: sas
Date: Tue Oct 24 16:01:33 2017
New Revision: 316527
URL: http://llvm.org/viewvc/llvm-project?rev=316527&view=rev
Log:
Remove some unused function calls from ClangUserExpression.cpp
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
Modified:
lldb/
Author: sas
Date: Tue Oct 24 15:56:05 2017
New Revision: 316526
URL: http://llvm.org/viewvc/llvm-project?rev=316526&view=rev
Log:
Remove some dead code from ClangExpressionDeclMap.cpp
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
Modified:
lldb/trunk/
Author: sas
Date: Mon Oct 9 10:49:32 2017
New Revision: 315221
URL: http://llvm.org/viewvc/llvm-project?rev=315221&view=rev
Log:
Update ABISysV_arm64::RegisterIsVolatile to accept registers prefixed with r
Summary:
While the specification says that the 64bit registers are prefixed with
`x`, it s
I do. We still use this but always in a remote debugging scenario so I
never had issues with this diff and I haven't gotten around to looking at
windows unit tests at all.
On Mon, Oct 2, 2017 at 9:43 AM Zachary Turner via Phabricator <
revi...@reviews.llvm.org> wrote:
> zturner added a comment.
>
Author: sas
Date: Thu Sep 28 12:49:00 2017
New Revision: 314455
URL: http://llvm.org/viewvc/llvm-project?rev=314455&view=rev
Log:
Add a few missing newlines in lldb-server messages
Reviewers: fjricci, clayborg
Subscribers: lldb-commits
Differential Revision: https://reviews.llvm.org/D38373
Mod
Author: sas
Date: Fri Sep 22 16:41:41 2017
New Revision: 314045
URL: http://llvm.org/viewvc/llvm-project?rev=314045&view=rev
Log:
Implement trampoline step-through for Windows-x86.
Summary:
This is required to be able to step through calls to external functions
that are not properly marked with _
What difference does this make?
On Fri, Sep 15, 2017 at 8:00 PM Eugene Zemtsov via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: eugene
> Date: Fri Sep 15 19:58:49 2017
> New Revision: 313437
>
> URL: http://llvm.org/viewvc/llvm-project?rev=313437&view=rev
> Log:
> Check availabili
Author: sas
Date: Mon Jun 5 12:44:04 2017
New Revision: 304725
URL: http://llvm.org/viewvc/llvm-project?rev=304725&view=rev
Log:
Avoid invalid string access in ObjCLanguage::MethodName::SetName
Summary:
Don't access `name[1] if the string is only of length 1. Avoids a
crash/assertion failure w
Author: sas
Date: Tue May 23 14:22:31 2017
New Revision: 303677
URL: http://llvm.org/viewvc/llvm-project?rev=303677&view=rev
Log:
Fix bad change in RenderScriptx86ABIFixups.cpp, forgot to change everything
necessary
Summary: I didn't change all instances of i to I in this loop. I am a bad
perso
Author: sas
Date: Tue May 23 13:54:03 2017
New Revision: 303674
URL: http://llvm.org/viewvc/llvm-project?rev=303674&view=rev
Log:
hange RenderScriptx86ABIFixups.cpp to use llvm::AttributeList iterator
LLVM::AttributeList recently had getNumSlots() removed, which broke the
build. This fixes the bu
Author: sas
Date: Fri Mar 31 13:00:48 2017
New Revision: 299239
URL: http://llvm.org/viewvc/llvm-project?rev=299239&view=rev
Log:
Verify memory address range validity in GDBRemoteCommunicationClient
Summary:
This aims to verify the validity of the response from the debugging
server in GDBRemoteCo
I'm currently busy with other stuff but I'll get back to this soon. I
think we have a different version of this internally which seems to
work properly, so I'll make sure everything is clean and re-upload a
better version.
On Tue, Dec 20, 2016 at 11:34 AM, Greg Clayton via Phabricator
wrote:
> cl
sas added a comment.
Just a couple nits inline. Also, did you run `clang-format` on your change? I
see some issues with `if`s and the associated parentheses.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:215
+ }
+ if (siginfo_signal_found == false) {
+//
sas accepted this revision.
sas added a reviewer: sas.
sas added a comment.
Cool stuff.
Are you planning on doing a similar change for other architectures?
https://reviews.llvm.org/D25947
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
Author: sas
Date: Mon Oct 31 19:21:57 2016
New Revision: 285658
URL: http://llvm.org/viewvc/llvm-project?rev=285658&view=rev
Log:
Remove executable bit on a source file
Modified:
lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp
(contents, props changed)
Modif
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277060: Remove a duplicated block in cmake. (authored by
sas).
Changed prior to commit:
https://reviews.llvm.org/D22891?vs=65839&id=66038#toc
Repository:
rL LLVM
https://reviews.llvm.org/D22891
Fil
Author: sas
Date: Thu Jul 28 17:11:54 2016
New Revision: 277060
URL: http://llvm.org/viewvc/llvm-project?rev=277060&view=rev
Log:
Remove a duplicated block in cmake.
Summary:
This is supposed to find the python lib dir and seems like it's just
been copied twice by mistake.
Reviewers: tfiala
Sub
sas created this revision.
sas added a reviewer: tfiala.
sas added a subscriber: lldb-commits.
This is supposed to find the python lib dir and seems like it's just
been copied twice by mistake.
https://reviews.llvm.org/D22891
Files:
source/Host/CMakeLists.txt
Index: source/Host/CMakeLists.txt
Yeah I can do this today.
> On Jul 19, 2016, at 1:58 AM, Zachary Turner wrote:
>
> I can't test this on Windows until Friday because I'm traveling and my laptop
> isn't set up to build lldb. Could Stephane maybe help?
>
>
> On Tue, Jul 19, 2016 at 1:51 AM Saleem Abdulrasool
> wrote:
> compn
sas added a comment.
In http://reviews.llvm.org/D22294#483264, @clayborg wrote:
> Note that during function lookup, we can find **both** "putchar" and
> "__my_putchar" in the debug info, so you will be able to call both.
Correct, unless as you pointed out both symbols are in libraries, and not
sas added a comment.
In http://reviews.llvm.org/D22294#483250, @clayborg wrote:
> In http://reviews.llvm.org/D22294#483213, @sas wrote:
>
> > @jingham, @clayborg, this is indeed a bit fragile as having to specify your
> > rewrite maps manually when debugging is very error-prone. I have a patch
sas added a comment.
@jingham, @clayborg, this is indeed a bit fragile as having to specify your
rewrite maps manually when debugging is very error-prone. I have a patch that
fetches the path to the rewrite map from the debug info, I'm waiting for this
one to go in to upload that other diff (tr
Author: sas
Date: Wed Jul 13 12:34:26 2016
New Revision: 275287
URL: http://llvm.org/viewvc/llvm-project?rev=275287&view=rev
Log:
Fix a check in the objc trampoline handler
Summary:
The function FunctionCaller::WriteFunctionArguments returns false on
errors, so they should check for the false ret
sas created this revision.
sas added reviewers: jingham, clayborg.
sas added a subscriber: lldb-commits.
The function FunctionCaller::WriteFunctionArguments returns false on
errors, so they should check for the false return value.
Change by Walter Erquinigo
http://reviews.llvm.org/D22278
Files
sas abandoned this revision.
sas added a comment.
Ah, makes sense, I had missed the `DebugClang` build configuration. Thanks for
pointing this out.
http://reviews.llvm.org/D22235
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://list
Author: sas
Date: Mon Jul 11 20:44:58 2016
New Revision: 275140
URL: http://llvm.org/viewvc/llvm-project?rev=275140&view=rev
Log:
Add LLVM build config for BuildAndIntegration.
Reviewers: tfiala, clayborg
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D22234
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275140: Add LLVM build config for BuildAndIntegration.
(authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D22234?vs=63548&id=63628#toc
Repository:
rL LLVM
http://reviews.llvm.org/D2
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275139: Make ThreadPlanStepInstruction's constructor public.
(authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D22230?vs=63625&id=63627#toc
Repository:
rL LLVM
http://reviews.llvm.
Author: sas
Date: Mon Jul 11 20:43:46 2016
New Revision: 275139
URL: http://llvm.org/viewvc/llvm-project?rev=275139&view=rev
Log:
Make ThreadPlanStepInstruction's constructor public.
Summary:
Some thread plans have public contructors, some others have protected
constructors with friend classes. N
sas updated this revision to Diff 63625.
sas added a comment.
Rebase.
http://reviews.llvm.org/D22230
Files:
include/lldb/Target/ThreadPlanStepInstruction.h
Index: include/lldb/Target/ThreadPlanStepInstruction.h
===
--- include/l
Author: sas
Date: Mon Jul 11 20:28:59 2016
New Revision: 275134
URL: http://llvm.org/viewvc/llvm-project?rev=275134&view=rev
Log:
Apply local patches when building llvm on Mac.
Summary:
This is already done when building for linux with the CMake build
system. This functionality disappeared recent
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275134: Apply local patches when building llvm on Mac.
(authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D22233?vs=63547&id=63619#toc
Repository:
rL LLVM
http://reviews.llvm.org/D2
Sounds good. I can make a separate patch to make all the constructors
public if you think that's better. See http://reviews.llvm.org/D22230
for a patch that makes one of the constructors public.
Is this patch good to go in its current form then?
On Mon, Jul 11, 2016 at 12:21 PM, Jim Ingham wrote
sas added a subscriber: sas.
sas added a comment.
Sounds good. I can make a separate patch to make all the constructors
public if you think that's better. See http://reviews.llvm.org/D22230
for a patch that makes one of the constructors public.
Is this patch good to go in its current form then?
sas updated this revision to Diff 63550.
sas added a comment.
Remove leftover comment.
http://reviews.llvm.org/D22235
Files:
lldb.xcodeproj/project.pbxproj
scripts/Xcode/build-llvm.py
Index: scripts/Xcode/build-llvm.py
===
---
sas created this revision.
sas added reviewers: tfiala, clayborg.
sas added a subscriber: lldb-commits.
When we build Debug, we might be tracking down bugs in clang/llvm as
well, so building it Debug with assertions helps debug the debugger.
http://reviews.llvm.org/D22235
Files:
lldb.xcodeproj
sas created this revision.
sas added reviewers: tfiala, clayborg.
sas added a subscriber: lldb-commits.
http://reviews.llvm.org/D22234
Files:
scripts/Xcode/build-llvm.py
Index: scripts/Xcode/build-llvm.py
===
--- scripts/Xcode/bui
sas created this revision.
sas added reviewers: tfiala, clayborg.
sas added a subscriber: lldb-commits.
This is already done when building for linux with the CMake build
system. This functionality disappeared recently when some of the build
scripts used by the xcode build system changed.
http://r
sas requested a review of this revision.
sas added a comment.
@jingham, it looks like the `GetStepThroughTrampolinePlan` functions do not
queue the thread plan themselves. See
`DynamicLoaderPOSIXDYLD::GetStepThroughTrampolinePlan` for instance that just
does `new ThreadPlanRunToAddress(...)`.
sas updated this revision to Diff 63542.
sas added a comment.
Use arm-pc-windows intead of armv7-pc-windows.
http://reviews.llvm.org/D19604
Files:
source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
==
sas created this revision.
sas added reviewers: clayborg, zturner.
sas added a subscriber: lldb-commits.
This is required to be able to step through calls to external functions
that are not properly marked with __declspec(dllimport). When a call
like this is emitted, the linker will inject a tramp
sas created this revision.
sas added reviewers: clayborg, zturner.
sas added a subscriber: lldb-commits.
Some thread plans have public contructors, some others have protected
constructors with friend classes. Not sure how these were determined,
but this thread plan is going to be required to imple
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271863: Fix function name lookup in IRExecutionEngine.cpp.
(authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D20312?vs=57854&id=59685#toc
Repository:
rL LLVM
http://reviews.llvm.or
Author: sas
Date: Sun Jun 5 21:50:46 2016
New Revision: 271863
URL: http://llvm.org/viewvc/llvm-project?rev=271863&view=rev
Log:
Fix function name lookup in IRExecutionEngine.cpp.
Summary:
Without this commit, when `log enable lldb expr` is enabled, the
disassembly of JIT'ed code is never displa
sas added a comment.
Nit: Adding a comment explaining why we special-case the main executable (i.e.:
because it is never included in `libraries-svr4` packets) might be useful here.
http://reviews.llvm.org/D20990
___
lldb-commits mailing list
lldb-c
sas accepted this revision.
sas added a comment.
This is really useful.
http://reviews.llvm.org/D20623
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sas updated this revision to Diff 57854.
sas added a comment.
No need to use `.AsCString()` on these.
http://reviews.llvm.org/D20312
Files:
source/Expression/IRExecutionUnit.cpp
Index: source/Expression/IRExecutionUnit.cpp
===
-
sas added a comment.
Ah yes, good idea not to use `AsCString()` here.
I think changing the `!=` to `==` is the right thing to do here because the bug
was introduced in r263995:
@@ -122,7 +125,7 @@ IRExecutionUnit::DisassembleFunction (Stream &stream,
for (JittedFunction &function :
sas created this revision.
sas added a reviewer: spyffe.
sas added a subscriber: lldb-commits.
Without this commit, when `log enable lldb expr` is enabled, the
disassembly of JIT'ed code is never displayed.
http://reviews.llvm.org/D20312
Files:
source/Expression/IRExecutionUnit.cpp
Index: sou
sas accepted this revision.
sas added a reviewer: sas.
sas added a comment.
This revision is now accepted and ready to land.
I did the same thing back when 3.7 was the current release branch and I think
@clayborg reviewed it at that point.
Without this, we simply can't build the release branch.
sas added a comment.
@compnerd:
- We don't use thumb-* triples in lldb as far as I can see. Thumb is handled
just fine regardless of the triple.
- `pc` vs `unknown` doesn't seem to matter either, and other code in this file
uses `pc` (see a few lines above).
- `msvc` vs `itanium` is also handle
sas added a comment.
@zturner, you might be right, I might have to change the code I have to load
the initial executable's `Module` and use an offset different than 0 there.
I'll wait to see what @clayborg says.
http://reviews.llvm.org/D19603
___
sas created this revision.
sas added a reviewer: zturner.
sas added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
This is required to start debugging WinPhone ARM targets.
http://reviews.llvm.org/D19604
Files:
source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
I
sas created this revision.
sas added a reviewer: zturner.
sas added a subscriber: lldb-commits.
http://reviews.llvm.org/D19603
Files:
source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
=
sas closed this revision.
sas added a comment.
Committed as r265422.
http://reviews.llvm.org/D18779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: sas
Date: Tue Apr 5 12:34:38 2016
New Revision: 265422
URL: http://llvm.org/viewvc/llvm-project?rev=265422&view=rev
Log:
Fix dotest.py '-p' option for multi-process mode
Summary:
The '-p' option for dotest.py was ignored in multiprocess mode,
as the -p argument to the inferior would over
sas closed this revision.
sas added a comment.
Committed as r265421.
http://reviews.llvm.org/D18660
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sas closed this revision.
sas added a comment.
Committed as r265420.
http://reviews.llvm.org/D18620
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: sas
Date: Tue Apr 5 12:30:31 2016
New Revision: 265421
URL: http://llvm.org/viewvc/llvm-project?rev=265421&view=rev
Log:
Update watchpoint help to use new -s flag
Summary: Flag updated in D233237
Reviewers: spyffe, jingham, Eugene.Zelenko
Subscribers: lldb-commits, sas
Differential Re
sas closed this revision.
sas added a comment.
Committed as r265419.
http://reviews.llvm.org/D18631
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: sas
Date: Tue Apr 5 12:29:19 2016
New Revision: 265420
URL: http://llvm.org/viewvc/llvm-project?rev=265420&view=rev
Log:
Print environment when dumping arch triple
Summary: Print environment from triple if it exists.
Reviewers: tfiala, clayborg
Subscribers: lldb-commits, sas
Different
Author: sas
Date: Tue Apr 5 12:27:52 2016
New Revision: 265419
URL: http://llvm.org/viewvc/llvm-project?rev=265419&view=rev
Log:
Make sure to update Target arch if environment changed
Summary: Fixes "target list" for non-android linux platforms (ie gnu, gnueabi)
Reviewers: jasonmolenda, tfiala,
sas closed this revision.
sas added a comment.
Committed as r265418.
http://reviews.llvm.org/D18531
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: sas
Date: Tue Apr 5 12:25:32 2016
New Revision: 265418
URL: http://llvm.org/viewvc/llvm-project?rev=265418&view=rev
Log:
Allow gdbremote process to read modules from memory
Summary:
The logic to read modules from memory was added to LoadModuleAtAddress
in the dynamic loader, but not in p
sas added a comment.
Committed as r264476.
http://reviews.llvm.org/D18459
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: sas
Date: Fri Mar 25 18:40:32 2016
New Revision: 264476
URL: http://llvm.org/viewvc/llvm-project?rev=264476&view=rev
Log:
Fix FILE * leak in Python API
Summary:
This fixes a leak introduced by some of these changes:
r257644
r250530
r250525
The changes made in these patches result in leak
sas closed this revision.
sas added a comment.
Committed as r264351.
http://reviews.llvm.org/D18228
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: sas
Date: Thu Mar 24 17:22:20 2016
New Revision: 264351
URL: http://llvm.org/viewvc/llvm-project?rev=264351&view=rev
Log:
Make File option flags consistent for Python API
Summary:
Fixes SBCommandReturnObject::SetImmediateOutputFile() and
SBCommandReturnObject::SetImmediateOutputFile() for
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264173: Implement ObjectFilePECOFF::GetEntryPointAddress.
(authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D17970?vs=50978&id=51449#toc
Repository:
rL LLVM
http://reviews.llvm.org
Author: sas
Date: Wed Mar 23 13:00:13 2016
New Revision: 264173
URL: http://llvm.org/viewvc/llvm-project?rev=264173&view=rev
Log:
Implement ObjectFilePECOFF::GetEntryPointAddress.
Reviewers: zturner, clayborg
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D17970
Modif
Author: sas
Date: Thu Mar 17 13:52:41 2016
New Revision: 263735
URL: http://llvm.org/viewvc/llvm-project?rev=263735&view=rev
Log:
Fix deadlock due to thread list locking in 'bt all' with obj-c
Summary:
The gdb-remote async thread cannot modify thread state while the main thread
holds a lock on th
sas updated this revision to Diff 50978.
sas added a comment.
Change implementation according to @clayborg's comments.
http://reviews.llvm.org/D17970
Files:
source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h
Index: source/Plugins/Objec
sas added a comment.
Yep, @jingham is right, I need this for expression evaluation. I'll do the
change @clayborg requested.
http://reviews.llvm.org/D17970
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
sas added a comment.
FWIW, I didn't cache this value because in the current form it is just
returning some data that is already cached by `ParseHeader()`. If I split it in
section/offset address, it might be required.
http://reviews.llvm.org/D17970
__
sas closed this revision.
sas added a comment.
Committed as r263735.
http://reviews.llvm.org/D18075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sas created this revision.
sas added reviewers: zturner, clayborg.
sas added a subscriber: lldb-commits.
http://reviews.llvm.org/D17970
Files:
source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h
Index: source/Plugins/ObjectFile/PECOFF/Obj
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262513: Use shallow clones in build-llvm.py. (authored by
sas).
Changed prior to commit:
http://reviews.llvm.org/D17425?vs=48427&id=49663#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17425
File
Author: sas
Date: Wed Mar 2 14:53:19 2016
New Revision: 262513
URL: http://llvm.org/viewvc/llvm-project?rev=262513&view=rev
Log:
Use shallow clones in build-llvm.py.
Summary:
This makes cloning (and therefore the whole build) faster.
The checkout step goes from ~4m to ~30s on my host.
Reviewers
sas added a subscriber: sas.
sas added a comment.
Ah, sounds like a cool change. Should we wait until your stuff goes in or
are you still ok with submitting my patch in the meantime?
http://reviews.llvm.org/D17425
___
lldb-commits mailing list
lldb-
sas created this revision.
sas added a reviewer: tfiala.
sas added a subscriber: lldb-commits.
This makes cloning (and therefore the whole build) faster.
The checkout step goes from ~4m to ~30s on my host.
http://reviews.llvm.org/D17425
Files:
scripts/Xcode/lldbbuild.py
Index: scripts/Xcode/l
1 - 100 of 191 matches
Mail list logo
