[Lldb-commits] [PATCH] D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp

srhines added a comment. In D142309#4107170 , @xgupta wrote: > In D142309#4102284 , @labath wrote: > >> In D142309#4075745 , @JDevlieghere >> wrote: >> >>> LGTM, but I wo

[Lldb-commits] [PATCH] D132514: [lldb] Remove obsolete Android-specific definitions

srhines accepted this revision. srhines added a comment. Thanks for cleaning this up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132514/new/ https://reviews.llvm.org/D132514 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64

srhines added a comment. We had some internal Google folks hit this exact issue recently. I don't think that the same "default" CPU should be used for debugging tools like `llvm-objdump`, and that is the crux of the matter here. Perhaps updating the test to specify "generic" as the CPU when pas

[Lldb-commits] [PATCH] D128453: Automate checking for "command that takes no arguments" being passed arguments in CommandObjectParsed

srhines added a comment. In D128453#3607129 , @labath wrote: > In D128453#3606296 , @JDevlieghere > wrote: > >> This is great, it both guarantees consistently and enforces command objects >> registering their ar

[Lldb-commits] [PATCH] D114111: Remove a useless temporary of a base class type.

srhines accepted this revision. srhines added a comment. Per https://developer.android.com/guide/topics/renderscript/migrate, we are starting to turn things down as part of the deprecation. I reached out internally to the folks helping with that to make sure that we don't cause problems by dele

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

srhines added inline comments. Comment at: lldb/include/lldb/Host/windows/PosixApi.h:56 #endif #endif // __MINGW32__ Update comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65822/new/ https://reviews.llv

[Lldb-commits] [PATCH] D64118: [lldb_test_suite] Fix lldb test suite targeting remote Android

srhines added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/make/Android.rules:93 -L$(NDK_ROOT)/sources/cxx-stl/llvm-libc++/libs/$(STL_ARCH) \ - $(NDK_ROOT)/sources/cxx-stl/llvm-libc++/libs/$(STL_ARCH)/libc++.a + $(