Author: tberghammer
Date: Tue Oct 13 11:48:04 2015
New Revision: 250180
URL: http://llvm.org/viewvc/llvm-project?rev=250180&view=rev
Log:
Fix cast in arm watchpoint handling code
We had an incorrect sign extension when castion from a pointer to an
lldb::addr_t what broke the watchpoint hit detect
tberghammer updated this revision to Diff 37258.
tberghammer added a comment.
Use llvm::sys::RWMutex
Using it have a minor performance hit for debug info parsing because of the
intensive write operations, but should have a positive impact on all reads
(most access after debug info parsing). If
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Look good
http://reviews.llvm.org/D13695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
tberghammer added inline comments.
Comment at: source/Core/ConstString.cpp:147-152
@@ -165,7 +146,8 @@
protected:
-//--
-// Typedefs
-//--
-
tberghammer added a comment.
It is depending on the implementation of std::async what AFAIK isn't defined by
the standard, but I would expect that a decent stl implementation will create a
reasonable number of threads (in some sense).
While developing/testing the code (with ~3000 CU in a Symbol
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Make dwarf parsing multi-threaded
Loading the debug info from a large application is the slowest task
LLDB do. This CL makes most of the dwarf parsing code multi-threade
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Change ConstString to support massive multi-threaded access
Previously ConstString had a single mutex guarding the global string
pool for each access what become a bottl
Author: tberghammer
Date: Mon Oct 12 05:33:04 2015
New Revision: 250024
URL: http://llvm.org/viewvc/llvm-project?rev=250024&view=rev
Log:
Improve TestValueOfVectorVariable
* XFAIL it for android arm/aarch64 as watchpoints aren't supported there
* Remove the dwarf/dsym test separation as they will
Author: tberghammer
Date: Fri Oct 9 07:43:08 2015
New Revision: 249827
URL: http://llvm.org/viewvc/llvm-project?rev=249827&view=rev
Log:
Fix a crash, an UB and add some assert to dwo symbol file handling
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
lldb/tr
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D13588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
tberghammer added a comment.
In general I like the approach you are taking and creating
IsAlwaysThumbInstructions sounds like a good idea, but I would implement it a
bit differently.
llvm::Triple already contains a SubArch field what is filled in from the first
part of the triple in case of ar
Author: tberghammer
Date: Fri Oct 9 07:06:10 2015
New Revision: 249826
URL: http://llvm.org/viewvc/llvm-project?rev=249826&view=rev
Log:
Fix the windows build after r249747
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp
URL:
ht
Author: tberghammer
Date: Fri Oct 9 07:06:07 2015
New Revision: 249825
URL: http://llvm.org/viewvc/llvm-project?rev=249825&view=rev
Log:
Fix the way dwo tests are skipped on darwin
We want to skip these tests when the target platform is darwin, not
when the host because they have to be enabled i
Author: tberghammer
Date: Fri Oct 9 06:01:56 2015
New Revision: 249821
URL: http://llvm.org/viewvc/llvm-project?rev=249821&view=rev
Log:
Fix regression caused by r249769
* Change TestSettings to test qith go instead of pascal as ToT pascal
support isn't complete
* Fix crash inside PluginManage
Author: tberghammer
Date: Wed Oct 7 09:52:16 2015
New Revision: 249549
URL: http://llvm.org/viewvc/llvm-project?rev=249549&view=rev
Log:
Fix race condition in the working directory cleanup code
Modified:
lldb/trunk/test/lldbtest.py
Modified: lldb/trunk/test/lldbtest.py
URL:
http://llvm.org
Author: tberghammer
Date: Wed Oct 7 07:38:29 2015
New Revision: 249541
URL: http://llvm.org/viewvc/llvm-project?rev=249541&view=rev
Log:
Remove working directory from remote platform in the test suite
Previously we haven't cleaned up the working directory we created on
the remote platform and be
Author: tberghammer
Date: Wed Oct 7 06:40:10 2015
New Revision: 249539
URL: http://llvm.org/viewvc/llvm-project?rev=249539&view=rev
Log:
XFAIL new dwo test failing with totclang on linux i386
Modified:
lldb/trunk/test/functionalities/breakpoint/breakpoint_locations/TestBreakpointLocations.p
tberghammer added a comment.
I committed in this CL in its current state (with fixing the issues raised by
Pavel).
If you see any of the newly added dwo test failing on your platform then please
skip/xfail them accordingly or let me know so I can take a look.
If you have to disable the running
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249530: Run tests with dwo symbol files (authored by
tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D13300?vs=36114&id=36723#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13300
F
Author: tberghammer
Date: Wed Oct 7 05:02:17 2015
New Revision: 249530
URL: http://llvm.org/viewvc/llvm-project?rev=249530&view=rev
Log:
Run tests with dwo symbol files
dwo symbol files are generated when code compiled with the "-gsplit-dwarf"
command option (https://gcc.gnu.org/wiki/DebugFissio
Author: tberghammer
Date: Tue Oct 6 09:39:05 2015
New Revision: 249407
URL: http://llvm.org/viewvc/llvm-project?rev=249407&view=rev
Log:
Rename a test case to avoid name conflict
Rename the python source file for DataFormatterOSTypeTestCase to match
the purpose of the test and to avoid a name co
tberghammer accepted this revision.
tberghammer added a comment.
I agree with Pavel, that you don't have to send these trivial changes for core
review
http://reviews.llvm.org/D13462
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://l
Author: tberghammer
Date: Fri Oct 2 07:00:04 2015
New Revision: 249120
URL: http://llvm.org/viewvc/llvm-project?rev=249120&view=rev
Log:
Change expected stop reason in TestInferiorAssert for Android API <= 16
Modified:
lldb/trunk/test/functionalities/inferior-assert/TestInferiorAssert.py
Mo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249119: Fix several issues around .ARM.exidx section
handling (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D13380?vs=36338&id=36343#toc
Repository:
rL LLVM
http://revi
Author: tberghammer
Date: Fri Oct 2 06:58:26 2015
New Revision: 249119
URL: http://llvm.org/viewvc/llvm-project?rev=249119&view=rev
Log:
Fix several issues around .ARM.exidx section handling
* Use .ARM.exidx as a fallback unwind plan for non-call site when the
instruction emulation based unwin
tberghammer created this revision.
tberghammer added a reviewer: labath.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
Fix several issues around .ARM.exidx section handling
* Use .ARM.exidx as a fallback unwind plan for non-call site when the
instru
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249012: Restrict the scope of a hack in DYLDRendezvous
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D13288?vs=36097&id=36240#toc
Repository:
rL LLVM
http://reviews.llv
Author: tberghammer
Date: Thu Oct 1 08:57:57 2015
New Revision: 249013
URL: http://llvm.org/viewvc/llvm-project?rev=249013&view=rev
Log:
Fix breakpoint opcode calculation on Linux
Change the way we detect if we have to place a thumb breakpoint instead
of an arm breakpoint in the case when no sym
Author: tberghammer
Date: Thu Oct 1 08:58:01 2015
New Revision: 249014
URL: http://llvm.org/viewvc/llvm-project?rev=249014&view=rev
Log:
Fix Android-SDK detection on API 10 device
Run the getprop command with AdbClient::Shell instead of
Platform::RunShellCommand because getting the output from g
Author: tberghammer
Date: Thu Oct 1 08:57:54 2015
New Revision: 249012
URL: http://llvm.org/viewvc/llvm-project?rev=249012&view=rev
Log:
Restrict the scope of a hack in DYLDRendezvous
The hack is there to work around an incorrect load address reported
by the android linker on API 21 and 22 devic
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248998: Trim the output of mktem in
PlatformAndroid::DownloadSymbolFile (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D13293?vs=36111&id=36209#toc
Repository:
rL LLVM
h
Author: tberghammer
Date: Thu Oct 1 04:42:23 2015
New Revision: 248998
URL: http://llvm.org/viewvc/llvm-project?rev=248998&view=rev
Log:
Trim the output of mktem in PlatformAndroid::DownloadSymbolFile
Differential revision: http://reviews.llvm.org/D13293
Modified:
lldb/trunk/source/Plugins/
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D13323
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
tberghammer created this revision.
tberghammer added reviewers: clayborg, tfiala, zturner, emaste, labath.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
Run tests with dwo symbol file
dwo symbol files are generated when code compiled with
I haven't managed to reproduce the issue you reported (what OS and Android
version do you use?), but based on the description this change (not
committed in yet) might fix the issue: http://reviews.llvm.org/D13293. Can
you take a look?
Thanks,
Tamas
On Wed, Sep 30, 2015 at 12:49 AM Oleksiy Vyalov
tberghammer created this revision.
tberghammer added a reviewer: ovyalov.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Trim the output of mktem in PlatformAndroid::DownloadSymbolFile
http://reviews.llvm.org/D13293
Files:
source/Plugins/Platfor
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp:683
@@ +682,3 @@
+
+if (m_use_alt_disaasm == true)
+decode_status = m_alt_dis
Author: tberghammer
Date: Wed Sep 30 10:17:06 2015
New Revision: 248910
URL: http://llvm.org/viewvc/llvm-project?rev=248910&view=rev
Log:
Make the ArmUnwindInfo parsing code endian independent
Differential revision: http://reviews.llvm.org/D13291
Modified:
lldb/trunk/include/lldb/Symbol/ArmU
This revision was automatically updated to reflect the committed changes.
tberghammer marked 2 inline comments as done.
Closed by commit rL248910: Make the ArmUnwindInfo parsing code endian
independent (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D13291?vs=36103&i
Author: tberghammer
Date: Wed Sep 30 09:55:08 2015
New Revision: 248908
URL: http://llvm.org/viewvc/llvm-project?rev=248908&view=rev
Log:
Fix xcode build after rL248903
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.o
tberghammer created this revision.
tberghammer added a reviewer: labath.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
Make the ArmUnwindInfo parsing code endian independent
http://reviews.llvm.org/D13291
Files:
include/lldb/Symbol/ArmUnwindInfo.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248903: Add support for .ARM.exidx unwind information
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D13245?vs=35970&id=36101#toc
Repository:
rL LLVM
http://reviews.llvm
Author: tberghammer
Date: Wed Sep 30 08:50:14 2015
New Revision: 248903
URL: http://llvm.org/viewvc/llvm-project?rev=248903&view=rev
Log:
Add support for .ARM.exidx unwind information
.ARM.exidx/.ARM.extab sections contain unwind information used on ARM
architecture from unwinding from an excepti
tberghammer marked an inline comment as done.
Comment at: source/Symbol/ArmUnwindInfo.cpp:62
@@ +61,3 @@
+static uint64_t
+GetULEB128(const uint32_t* data, uint16_t& offset, uint16_t max_offset)
+{
labath wrote:
> Is there a reason DataExtractor::GetULEB128 could
Author: tberghammer
Date: Wed Sep 30 08:42:06 2015
New Revision: 248901
URL: http://llvm.org/viewvc/llvm-project?rev=248901&view=rev
Log:
XFAIL 2 test in TestTargetCommands on android-aarch64
The 2 test just get enabled with the recemt test system refactor.
Modified:
lldb/trunk/test/function
tberghammer created this revision.
tberghammer added a reviewer: labath.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
Restrict the scope of a hack in DYLDRendezvous
The hack is there to work around an incorrect load address reported
by t
tberghammer created this revision.
tberghammer added a reviewer: jasonmolenda.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
.ARM.exidx/.ARM.extab sections contain unwind information used on ARM
architecture from unwinding from an exception.
http://r
This revision was automatically updated to reflect the committed changes.
tberghammer marked an inline comment as done.
Closed by commit rL248788: Change oat symbolization code for android to work on
non-rooted devices (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/
Author: tberghammer
Date: Tue Sep 29 06:04:18 2015
New Revision: 248788
URL: http://llvm.org/viewvc/llvm-project?rev=248788&view=rev
Log:
Change oat symbolization code for android to work on non-rooted devices
On android when debugging an apk we run lldb-server as application user
because the sel
tberghammer marked 3 inline comments as done.
Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:340
@@ -346,1 +339,3 @@
[this](std::string* s) {
+AdbClient adb(m_device_id);
+
ovyalov wrote:
> Could you reuse adb variable defined
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248571: Eliminate a potential crash in the struct layout
code with a gracefull fallback (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12963?vs=35084&id=35717#toc
Reposito
Author: tberghammer
Date: Fri Sep 25 07:50:51 2015
New Revision: 248571
URL: http://llvm.org/viewvc/llvm-project?rev=248571&view=rev
Log:
Eliminate a potential crash in the struct layout code with a gracefull fallback
Differential revision: http://reviews.llvm.org/D12963
Modified:
lldb/trunk
tberghammer created this revision.
tberghammer added a reviewer: ovyalov.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Change oat symbolization code for android to work on non-rooted devices
On android when debugging an apk we run lldb-server as
Author: tberghammer
Date: Wed Sep 23 06:00:35 2015
New Revision: 248373
URL: http://llvm.org/viewvc/llvm-project?rev=248373&view=rev
Log:
Fix xcode build after r248366
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.or
tberghammer added a comment.
In http://reviews.llvm.org/D13028#250822, @clayborg wrote:
> Looks good. For the failing test cases, just check this stuff in and we
> should take care or marking any needed tests and expected fail. Is there a
> way to mark a test such that the "dwarf in .o files" w
tberghammer resigned from this audit.
tberghammer added a comment.
I committed in a build fix as http://reviews.llvm.org/rL248281
Users:
tberghammer (Auditor)
http://reviews.llvm.org/rL248277
___
lldb-commits mailing list
lldb-commits@lists.llvm.
Author: tberghammer
Date: Tue Sep 22 10:04:39 2015
New Revision: 248281
URL: http://llvm.org/viewvc/llvm-project?rev=248281&view=rev
Log:
Fix register names in EmulateInstructionMIPS.cpp
Modified:
lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp
Modified: lldb/trunk/sour
tberghammer added a subscriber: tberghammer.
tberghammer raised a concern with this commit.
tberghammer added a comment.
Hi Sagar,
This change break the Linux build
(http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/6568)
because the register enums have been renamed recent
tberghammer added a subscriber: lldb-commits.
http://reviews.llvm.org/rL248277
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tberghammer added a comment.
I decided to make it an opt-out feature as most of the test case will use some
debug info and this way you don't have to specify it explicitly (mutating a
test what don't have any debug info only have performance hit because it will
run the same test multiple times)
Author: tberghammer
Date: Mon Sep 21 05:24:59 2015
New Revision: 248148
URL: http://llvm.org/viewvc/llvm-project?rev=248148&view=rev
Log:
Fix MSVC warings in DWARFExpression.cpp
Modified:
lldb/trunk/source/Expression/DWARFExpression.cpp
Modified: lldb/trunk/source/Expression/DWARFExpression.
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
Possibly we can try to run IWYU
(https://github.com/include-what-you-use/include-what-you-use). I haven't tried
it but it sounds like a tool what is suitable for the task.
Repository:
rL LLVM
http://reviews.llvm.org/D
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
I committed in the fix mentioned by Pavel as http://reviews.llvm.org/rL248146
http://reviews.llvm.org/D12976
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://l
Author: tberghammer
Date: Mon Sep 21 05:08:49 2015
New Revision: 248146
URL: http://llvm.org/viewvc/llvm-project?rev=248146&view=rev
Log:
Use ClangASTContext for compile units with language eLanguageTypeMipsAssembler
Both GNU AS and LLVM emits language type DW_LANG_Mips_Assembler for
all assembly
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248146: Use ClangASTContext for compile units with language
eLanguageTypeMipsAssembler (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12962?vs=35083&id=35218#toc
Repositor
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
In http://reviews.llvm.org/D12899#248654, @ki.stfu wrote:
> In http://reviews.llvm.org/D12899#248648, @zturner wrote:
>
> > One possible solution is to make an lldb-all target.
>
>
> As I said, it would much better rather t
tberghammer created this revision.
tberghammer added a reviewer: spyffe.
tberghammer added a subscriber: lldb-commits.
Eliminate a potential crash in the struct layout code with a gracefull fallback
http://reviews.llvm.org/D12963
Files:
source/Expression/ClangASTSource.cpp
Index: source/Expre
tberghammer created this revision.
tberghammer added reviewers: jingham, dawn.
tberghammer added a subscriber: lldb-commits.
Use ClangASTContext for compile units with language eLanguageTypeMipsAssembler
Both GNU AS and LLVM emits language type DW_LANG_Mips_Assembler for all
assembly code.
http
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good with minor comment inline
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3228-3230
@@ -3227,3 +3227,5 @@
-if (die.GetReferenced
tberghammer added subscribers: lldb-commits, sivachandra.
tberghammer added a comment.
Hi Greg,
This change introduced a regression in expression evaluation. When I try to
evaluate any expression in some specific context then lldb prints out the
following error:
error: out-of-line definition
tberghammer added a comment.
I see. Thank you for the clarification
Repository:
rL LLVM
http://reviews.llvm.org/D12757
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: tberghammer
Date: Thu Sep 17 05:05:21 2015
New Revision: 247879
URL: http://llvm.org/viewvc/llvm-project?rev=247879&view=rev
Log:
XFAIL step after crash tests on android-aarch64 API 21
Android-aarch64 for API21 uses sa_restore to return from a signal handler
what have no eh_frame specifie
This revision was automatically updated to reflect the committed changes.
tberghammer marked an inline comment as done.
Closed by commit rL247789: Add support for the DWARFLocationList used by
split-dwarf (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12880?vs=3480
Author: tberghammer
Date: Wed Sep 16 07:37:06 2015
New Revision: 247789
URL: http://llvm.org/viewvc/llvm-project?rev=247789&view=rev
Log:
Add support for the DWARFLocationList used by split-dwarf
Split-dwarf uses a different header format to specify the address range
for the elements of the locat
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247788: Fix prologue end handling when code compiled by gcc
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12757?vs=34435&id=34886#toc
Repository:
rL LLVM
http://review
Author: tberghammer
Date: Wed Sep 16 07:36:37 2015
New Revision: 247788
URL: http://llvm.org/viewvc/llvm-project?rev=247788&view=rev
Log:
Fix prologue end handling when code compiled by gcc
GCC don't use the is_prologue_end flag to mark the first instruction
after the prologue. Instead of it it i
tberghammer marked an inline comment as done.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:36-228
@@ -37,1 +35,195 @@
+static int
+print_dwarf_exp_op (Stream &s,
+const DWARFDataExtractor& data,
+lldb::offset_t *offs
tberghammer added a comment.
The line number is not always the same for the 2 entry (the first one points to
the open '{' and the second one to the first instruction of the function). I
added the check for the file name, but I would be quite surprised if we find a
scenario when the file names d
tberghammer added a comment.
In http://reviews.llvm.org/D12757#246497, @clayborg wrote:
> Maybe we can try still removing duplicates, but remembering the first index
> where we had a duplicate line entry. If we don't get a prologue end, then we
> got back to the index we remembered for the firs
tberghammer added a subscriber: tberghammer.
tberghammer requested changes to this revision.
tberghammer added a reviewer: tberghammer.
tberghammer added a comment.
This revision now requires changes to proceed.
If I understand this change correctly then OperatingSystemGo::CreateInstance
will be
tberghammer created this revision.
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: lldb-commits.
Add support for the DWARFLocationList used by split-dwarf
Split-dwarf uses a different header format to specify the address range for the
elements of the location lists.
http
tberghammer added a comment.
Hi Greg, what do you think about my inline suggestion? Are you fine with
removing the original hack about removing duplicate entries from the line table
end then solve the problem around duplicate line entries with always returning
the last entry if we have multiple
Author: tberghammer
Date: Tue Sep 15 09:04:52 2015
New Revision: 247690
URL: http://llvm.org/viewvc/llvm-project?rev=247690&view=rev
Log:
Skip TestGoASTContext on remote targets as it it not remote compatible
Modified:
lldb/trunk/test/lang/go/types/TestGoASTContext.py
Modified: lldb/trunk/te
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247672: Add support for DW_OP_GNU_const_index to dwarf
expression (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12849?vs=34697&id=34794#toc
Repository:
rL LLVM
http://
Author: tberghammer
Date: Tue Sep 15 05:33:54 2015
New Revision: 247672
URL: http://llvm.org/viewvc/llvm-project?rev=247672&view=rev
Log:
Add support for DW_OP_GNU_const_index to dwarf expression
DW_OP_GNU_const_index is a new opcode used when split dwarf is enabled
Differential revision: http:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247671: Fix several issues arount dwo symbol file handling
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12804?vs=34550&id=34793#toc
Repository:
rL LLVM
http://reviews
Author: tberghammer
Date: Tue Sep 15 05:33:41 2015
New Revision: 247671
URL: http://llvm.org/viewvc/llvm-project?rev=247671&view=rev
Log:
Fix several issues arount dwo symbol file handling
Differential revision: http://reviews.llvm.org/D12804
Modified:
lldb/trunk/source/Plugins/SymbolFile/DW
tberghammer added a comment.
Thank you for the clarification. I will commit in this patch without the change
we discussed (ignoring 0 file address) and I will address that issue later.
http://reviews.llvm.org/D12804
___
lldb-commits mailing list
ll
tberghammer added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3892-3893
@@ +3891,4 @@
+{
+lldb::user_id_t spec_uid = form_value.Reference();
+if (UserIDMatches(spec_uid))
+
tberghammer added a comment.
Those tests are communicating on the gdb remote protocol directly and do a
pattern matching on the response. I think they have the register set names hard
coded in one of those patters, but haven't looked into it (I expect that they
will fail on OSX too).
http://r
tberghammer created this revision.
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: lldb-commits.
Add support for DW_OP_GNU_const_index to dwarf expression
DW_OP_GNU_const_index is a new opcode used when split dwarf is enabled
http://reviews.llvm.org/D12849
Files:
inclu
tberghammer added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2242-2248
@@ -2241,2 +2241,9 @@
lldb::addr_t highest_func_addr = func_ranges.GetMaxRangeEnd (0);
+
+// lowest_func_addr is a file address what can't be 0 because
tberghammer added a comment.
I tried out this change and it compiles both on Linux and on arm, but it causes
2 test failure:
TestLldbGdbServer.LldbGdbServerTestCase.test_qRegisterInfo_returns_all_valid_results_llgs_dwarf
TestLldbGdbServer.LldbGdbServerTestCase.test_qRegisterInfo_returns_one_valid
Author: tberghammer
Date: Mon Sep 14 10:44:29 2015
New Revision: 247571
URL: http://llvm.org/viewvc/llvm-project?rev=247571&view=rev
Log:
Fix a possible SEGV in SymbolFileDWARF
The iterator pointing to an element of a dense map was used after
the element from was removed from the map what isn't g
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
Generally looks good to me with a few minor comments, but please wait for a
review from Greg or Jim.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3201
@@ +3200,3 @@
+
tberghammer created this revision.
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: lldb-commits.
Fix several issues around dwo symbol file handling
This change all dwo related test failure on Linux x86_64
http://reviews.llvm.org/D12804
Files:
source/Plugins/SymbolFile/
This revision was automatically updated to reflect the committed changes.
tberghammer marked an inline comment as done.
Closed by commit rL247400: Improve the arm/aarch64 mapping symbol handling
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12755?vs=34432&id=34536
Author: tberghammer
Date: Fri Sep 11 05:04:00 2015
New Revision: 247400
URL: http://llvm.org/viewvc/llvm-project?rev=247400&view=rev
Log:
Improve the arm/aarch64 mapping symbol handling
Change the mapping symbol handling to handle the case when the mapping
symbols are prefixed with an arbitrary p
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
I tried to apply your patch but couldn't manage to do it because
source/Utility/ARM_ehframe_Registers.[h,cpp] is not available in TOT. I think
you uploaded only a part of your patch.
Repository:
rL LLVM
http://reviews
tberghammer created this revision.
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: lldb-commits.
Fix prologue end handling when code compiled by gcc
GCC don't use the is_prologue_end flag to mark the first instruction
after the prologue. Instead of it it is issuing a line
501 - 600 of 725 matches
Mail list logo
