[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

tatyana-krasnukha updated this revision to Diff 320548. tatyana-krasnukha edited the summary of this revision. tatyana-krasnukha added a comment. It turns out that the Debugger recalculated the selected stack frame without taking the Process's run lock. I replaced the whole context evaluation wit

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

tatyana-krasnukha updated this revision to Diff 320560. tatyana-krasnukha added a comment. Removed test since the same case was added by D95761 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92164/new/ https://reviews.llvm.org/D92164 Files: lldb/inc

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

tatyana-krasnukha added a comment. In D92164#2536036 , @werat wrote: > I think your test case is even better, the one in D95761 > doesn't try to run commands. Ok, then I'll replace it if you don't mind. CHANGES SINCE L

[Lldb-commits] [PATCH] D96817: Fix deep copying for OptionValue classes

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: clayborg, JDevlieghere, labath, teemperor. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: mgorny. tatyana-krasnukha requested review of this revision. Herald added a subscriber: lldb-commits. Some impl

[Lldb-commits] [PATCH] D96817: Fix deep copying for OptionValue classes

tatyana-krasnukha added a comment. CRTP was my first implementation, however, I discarded it as more bug-prone. Virtual Clone function at the interface is so common that, I believe, everyone knows it must be overridden by a new derived class. The necessity of inheriting from base_clone_helper i

[Lldb-commits] [PATCH] D96817: Fix deep copying for OptionValue classes

tatyana-krasnukha updated this revision to Diff 324435. tatyana-krasnukha added a comment. Removed explicit conversions to StringRef from the test with respect to D96861 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96817/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D96817: Fix deep copying for OptionValue classes

tatyana-krasnukha added a comment. I created D96817 - a demonstrative example of the CRTP-based version of this patch. Please, take a look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96817/new/ https://reviews.llvm.org/D96817 __

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support

tatyana-krasnukha added a comment. clang-tidy would not be happy;) Comment at: lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp:665 +return SetHardwareBreakpoint(addr, size); else return SetSoftwareBreakpoint(addr, size); Redundant `else

[Lldb-commits] [PATCH] D96952: CRTP-based version of D96817

This revision was automatically updated to reflect the committed changes. tatyana-krasnukha marked 2 inline comments as done. Closed by commit rGf0f183ee4ad9: [lldb/Interpreter] Fix deep copying for OptionValue classes (authored by tatyana-krasnukha). Herald added a project: LLDB. Herald added a s

[Lldb-commits] [PATCH] D96952: CRTP-based version of D96817

tatyana-krasnukha added inline comments. Comment at: lldb/source/Interpreter/OptionValueFileSpecList.cpp:169 std::lock_guard lock(m_mutex); - return OptionValueSP(new OptionValueFileSpecList(m_current_value)); + return std::make_shared(*this); } JDevliegher

[Lldb-commits] [PATCH] D96817: Fix deep copying for OptionValue classes

tatyana-krasnukha abandoned this revision. tatyana-krasnukha added a comment. D96952 is landed instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96817/new/ https://reviews.llvm.org/D96817 ___ lldb-commit

[Lldb-commits] [PATCH] D88906: [lldb/docs] Clarify python/swig version incompatibility

tatyana-krasnukha accepted this revision. tatyana-krasnukha added a comment. This revision is now accepted and ready to land. I used Swig 3.0.12 + cherry-picked commit that fixes that bug (https://github.com/swig/swig/issues/1321) on Windows. It worked well with both Python 3.7 and 3.8. The on

[Lldb-commits] [PATCH] D88769: [trace] Scaffold "thread trace dump instructions"

tatyana-krasnukha added inline comments. Comment at: lldb/source/Plugins/Process/Trace/ProcessTrace.h:18 + +class ProcessTrace : public lldb_private::Process { +public: clayborg wrote: > So one issue is how do we eventually deal with debugging a live process that

[Lldb-commits] [PATCH] D92164: Make SBDebugger internal variable getter and setter not use CommandInterpreter's context

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: jingham, JDevlieghere, labath. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: lldb-commits. tatyana-krasnukha requested review of this revision. SBDebugger asks CommandInterpreter for execution context

[Lldb-commits] [PATCH] D92164: Make SBDebugger internal variable getter and setter not use CommandInterpreter's context

tatyana-krasnukha updated this revision to Diff 308325. tatyana-krasnukha added a comment. Removed refactoring to make the changes clearer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92164/new/ https://reviews.llvm.org/D92164 Files: lldb/packages/Python/lldbsuite/test/python_api/d

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

tatyana-krasnukha updated this revision to Diff 310927. tatyana-krasnukha retitled this revision from "Make SBDebugger internal variable getter and setter not use CommandInterpreter's context" to "Make CommandInterpreter's execution context the same as debugger's one.". tatyana-krasnukha edited t

[Lldb-commits] [PATCH] D93052: "target create" shouldn't save target if the command failed

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: clayborg, JDevlieghere, jingham, teemperor. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: emaste. tatyana-krasnukha requested review of this revision. Herald added a subscriber: lldb-commits. TargetLi

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

tatyana-krasnukha updated this revision to Diff 31. tatyana-krasnukha added a comment. Thanks for pointing to the nested command problem! Replaced pointer to the execution context with the stack of contexts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92164/new/ https://reviews.l

[Lldb-commits] [PATCH] D93052: "target create" shouldn't save target if the command failed

tatyana-krasnukha updated this revision to Diff 311128. tatyana-krasnukha added a comment. Removed `do_select`'s default value. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93052/new/ https://reviews.llvm.org/D93052 Files: lldb/include/lldb/Target/TargetList.h lldb/source/API/SBDe

[Lldb-commits] [PATCH] D93052: "target create" shouldn't save target if the command failed

This revision was automatically updated to reflect the committed changes. Closed by commit rG2634ec6ce900: [lldb] "target create" shouldn't save target if the command failed (authored by tatyana-krasnukha). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa01b26fb51c7: [lldb] Make CommandInterpreter's execution context the same as debugger's one. (authored by tatyana-krasnukha). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

tatyana-krasnukha updated this revision to Diff 312770. tatyana-krasnukha added a comment. Fixed CommandInterpreter::GetProcessOutput to avoid deadlock in Windows process plugin. This should also fix the problem @labath described above. Pavel, could you please check whether it works for you? C

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

tatyana-krasnukha added a comment. In D92164#2463734 , @labath wrote: > With this version of the patch, I am unable to reproduce the issue using the > approach I described in the previous comment. However, it still reproduces > when issuing the equivalen

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

tatyana-krasnukha added a comment. D92164 was intended for fixing the "settings set" issue, however, it revealed some deadlocks and data races, and had to be reverted temporarily. Currently, I'm working on those multithreading issues and will submit a patch as

[Lldb-commits] [PATCH] D76351: [lldb-vscode] Don't use SBLaunchInfo in request_attach

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b18b568e91a: [lldb-vscode] Don't use SBLaunchInfo in request_attach (authored by anton.kolesov, committed by tatyana-krasnukha). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D76593: [lldb-vscode] Convert launch_info and attach_info to local variables

This revision was automatically updated to reflect the committed changes. Closed by commit rGa92673fe9a08: [lldb-vscode] Convert launch_info and attach_info to local variables (authored by anton.kolesov, committed by tatyana-krasnukha). Changed prior to commit: https://reviews.llvm.org/D76593?

[Lldb-commits] [PATCH] D84254: [lldb] Skip overlapping hardware and external breakpoints when writing memory

tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: clayborg. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes the assertion `assert(intersects);` in the Process::WriteMemory function. Repository: rG LLVM Github Monorepo ht

[Lldb-commits] [PATCH] D84255: [lldb] Make process plugins check whether a hardware breakpoint is required

tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: clayborg. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, emaste. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84255 Files: lldb/source/Plugins/Process/FreeBSD/Proce

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: clayborg, labath, JDevlieghere. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, arphaman. Most process plugins (if not all) don't set hardware index for breakpoints. They even are not able

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

tatyana-krasnukha added a comment. Probably fixes llvm.org/PR44659, though I cannot check on arm/aarch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84257/new/ https://reviews.llvm.org/D84257 ___ ll

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

tatyana-krasnukha added a comment. Comment at: lldb/source/Breakpoint/BreakpointLocation.cpp:73 + if (m_bp_site_sp) +return m_bp_site_sp->IsHardware(); + JDevlieghere wrote: > Should we sanity check that this is true when `m_hardware_index != > LLDB_INVA

[Lldb-commits] [PATCH] D84254: [lldb] Skip overlapping hardware and external breakpoints when writing memory

tatyana-krasnukha updated this revision to Diff 279777. tatyana-krasnukha added a comment. `BreakpointSite::IntersectsRange` returns `false` for hardware breakpoints, that's why the assertion fails. Since my bare-metal target loads process's memory via Process::WriteMemory, I have 200+ unresolv

[Lldb-commits] [PATCH] D84311: [lldb/test] Put hardware breakpoint tests together, NFC

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: JDevlieghere, labath. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: lldb-commits. Create a common base class for them to re-use supports_hw_breakpoints function in decorators. This is a preparatory

[Lldb-commits] [PATCH] D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation

tatyana-krasnukha created this revision. Herald added subscribers: lldb-commits, yaxunl, mgorny. Herald added a project: LLDB. Working on the patch D84257 I noticed that both BreakpointLocation and BreakpointSite were inherited from StoppointLocation. Also, I n

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

tatyana-krasnukha updated this revision to Diff 280448. tatyana-krasnukha added a comment. @omjavaid, thank you for verifying this! Added the checks that IsHardware is consistent with m_hardware_index. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

tatyana-krasnukha added a comment. I went further than just moving m_hardware_index from StoppointLocation. Please, take a look at D84527 and let me know what you think about that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D84255: [lldb] Make process plugins check whether a hardware breakpoint is required

tatyana-krasnukha updated this revision to Diff 281598. tatyana-krasnukha added reviewers: labath, JDevlieghere. tatyana-krasnukha added a comment. Un-skip TestRequireHWBreakpoints.py on Windows, now it works as expected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation

tatyana-krasnukha updated this revision to Diff 281600. tatyana-krasnukha added reviewers: JDevlieghere, jingham. tatyana-krasnukha added a comment. Addressed comments. > It's also a little weird that we're clearing watchpoint hit counts when a > process dies, but not breakpoint hit counts. If w

[Lldb-commits] [PATCH] D84311: [lldb/test] Put hardware breakpoint tests together, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc114352edfe0: [lldb/test] Put hardware breakpoint tests together, NFC (authored by tatyana-krasnukha). Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D84254: [lldb] Skip overlapping hardware and external breakpoints when writing memory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7ec3e3be70d: [lldb] Skip overlapping hardware and external breakpoints when writing memory (authored by tatyana-krasnukha). Repository: rG LLVM G

[Lldb-commits] [PATCH] D84255: [lldb] Make process plugins check whether a hardware breakpoint is required

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb352e62feadd: [lldb] Make process plugins check whether a hardware breakpoint is required (authored by tatyana-krasnukha). Repository: rG LLVM Git

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGebaa8b1c6074: [lldb] Don't use hardware index to determine whether

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

tatyana-krasnukha added a comment. Ups... Pushed it occationaly with the other patchs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84257/new/ https://reviews.llvm.org/D84257 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda0bba5c9abb: [lldb/Breakpoint] Rename StoppointLocation to StoppointSite and drop its… (authored by tatyana-krasnukha). Changed prior to commit:

[Lldb-commits] [PATCH] D84954: [lldb] Make Target::CleanupProcess consistent for breakpoints and watchpoints

tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: jingham. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. tatyana-krasnukha requested review of this revision. Target clears watchpoints hit count but doesn't do the same for

[Lldb-commits] [PATCH] D84957: [lldb/Process/Windows] Trying to kill exited/detached process in not error

tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: asmith. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. tatyana-krasnukha requested review of this revision. Don't report an error, just log this happened. This fixes a lot o

[Lldb-commits] [PATCH] D84954: [lldb] Make Target::CleanupProcess consistent for breakpoints and watchpoints

tatyana-krasnukha updated this revision to Diff 282030. tatyana-krasnukha added a comment. TestAddressBreakpoints.py fails on the last check - it expects hit count to be saved after re-launching the process. Removed that check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D84957: [lldb/Process/Windows] Attempt to kill exited/detached process in not error

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe97c693bb0ec: [lldb/Process/Windows] Attempting to kill exited/detached process in not an… (authored by tatyana-krasnukha). Changed prior to commit:

[Lldb-commits] [PATCH] D84957: [lldb/Process/Windows] Attempt to kill exited/detached process in not error

tatyana-krasnukha added a comment. Thank you! I fixed the commit title and description as you suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84957/new/ https://reviews.llvm.org/D84957 ___ lldb-

[Lldb-commits] [PATCH] D111209: Don't push null ExecutionContext on CommandInterpreter exectx stack

tatyana-krasnukha added a comment. Added inline comment Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2842 - OverrideExecutionContext(m_debugger.GetSelectedExecutionContext()); - auto finalize = llvm::make_scope_exit([this]() { -RestoreExecutionContext(); +

[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

tatyana-krasnukha added inline comments. Comment at: lldb/test/API/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py:269 self.expect(side_effect.bp_loc, exe=False, -patterns=["1.* where = .*main .* resolved, hit count = 1"]) +

[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

tatyana-krasnukha accepted this revision. tatyana-krasnukha added a comment. This revision is now accepted and ready to land. LGTM, but I would wait for one more approve. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111899/new/ https://reviews.llvm.org/D111899

[Lldb-commits] [PATCH] D114861: Don't consider frames with different PCs as a loop

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: labath, jasonmolenda. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: JDevlieghere. tatyana-krasnukha requested review of this revision. Herald added a subscriber: lldb-commits. A compiler can produce F

[Lldb-commits] [PATCH] D114862: Replace StackID's operator "<" with a function returning FrameComparison

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: labath, jasonmolenda. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: JDevlieghere. tatyana-krasnukha requested review of this revision. Herald added a subscriber: lldb-commits. "false" result of the op

[Lldb-commits] [PATCH] D51569: Hold GIL while allocating memory for PythonString.

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: clayborg, granata.enrico. Herald added a subscriber: lldb-commits. Swig wraps C++ code into `SWIG_PYTHON_THREAD_BEGIN_ALLOW; ... SWIG_PYTHON_THREAD_END_ALLOW;` Thus, lldb crashs with "Fatal Python error: Python memory a

[Lldb-commits] [PATCH] D51569: Hold GIL while allocating memory for PythonString.

tatyana-krasnukha updated this revision to Diff 163646. tatyana-krasnukha added a comment. %feature("nothreadallow") looks more appropriate in this case. GetDescription method is quite cheap, no need to handle the GIL. Repository: rLLDB LLDB https://reviews.llvm.org/D51569 Files: scripts/

[Lldb-commits] [PATCH] D51594: [ARC] Make char unsigned by default

tatyana-krasnukha accepted this revision. tatyana-krasnukha added a subscriber: clayborg. tatyana-krasnukha added a comment. This revision is now accepted and ready to land. Good to me, if no one is confused about absent general support of ARC target. Please, add @clayborg to reviewers. Reposit

[Lldb-commits] [PATCH] D51569: Hold GIL while allocating memory for PythonString.

tatyana-krasnukha added a comment. Yes, and `%feature("nothreadallow")` doesn't allow to release GIL before calling these functions - it prevents Swig from wrapping them into SWIG_PYTHON_THREAD_BEGIN_ALLOW .. SWIG_PYTHON_THREAD_END_ALLOW block. Repository: rLLDB LLDB https://reviews.llvm.o

[Lldb-commits] [PATCH] D51569: Hold GIL while allocating memory for PythonString.

tatyana-krasnukha added a comment. I have a third party module which implements a custom command for LLDB. The command calls `str(target)`, `str(process)`, etc. for logging. Anyway, every call to these functions will cause this crash to happen, because PythonString is allocated after releasing

[Lldb-commits] [PATCH] D51569: Hold GIL while allocating memory for PythonString.

tatyana-krasnukha updated this revision to Diff 164008. tatyana-krasnukha added a comment. Use more readable aliases to set end clear the feature. Repository: rLLDB LLDB https://reviews.llvm.org/D51569 Files: scripts/Python/python-extensions.swig Index: scripts/Python/python-extensions.sw

[Lldb-commits] [PATCH] D51999: build: add libedit to include paths

tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: compnerd. Herald added subscribers: lldb-commits, mgorny. Without that build of Host, Core and Interpreter with custom libedit fails. Repository: rLLDB LLDB https://reviews.llvm.org/D51999 Files: CMakeLists.txt

[Lldb-commits] [PATCH] D51999: build: add libedit to include paths

tatyana-krasnukha added a comment. Everything that includes Host/Editline.h (Host/Editline.cpp, Core/IOHandler.cpp, ...). Build fails with "fatal error: histedit.h: No such file or directory" Repository: rLLDB LLDB https://reviews.llvm.org/D51999 _

[Lldb-commits] [PATCH] D51999: build: add libedit to include paths

tatyana-krasnukha added a comment. TBC, I pass libedit_INCLUDE_DIRS and libedit_LIBRARIES manually to CMake. Repository: rLLDB LLDB https://reviews.llvm.org/D51999 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg

[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

tatyana-krasnukha added a comment. symbol-list-lines.test fails on Linux too, input is compiled with gcc. Comment at: lldb/trunk/lit/tools/lldb-mi/symbol/inputs/symbol-list-lines.c:6 + return 0; +} The check doesn't count this line Comment a

[Lldb-commits] [PATCH] D49739: Add new API to SBTarget class

tatyana-krasnukha added a comment. On CentOS this test hangs forever. If I manually kill lldb-mi and lldb-server subprocesses, the output is -- Exit Code: 1 Command Output (stderr): -- /lldb/lit/tools/lldb-mi/target/target-select-so-path.test:16:10: error: CHECK: expected string no

[Lldb-commits] [PATCH] D51999: build: add libedit to include paths

tatyana-krasnukha updated this revision to Diff 166258. tatyana-krasnukha added a comment. Unfortunately, doing this only on `lldbHost` is not enough, because CMake doesn't propagate include directories to dependent projects. I added these lines to every project that includes "Editline.h". Rep

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

tatyana-krasnukha accepted this revision. tatyana-krasnukha added a comment. This revision is now accepted and ready to land. These changes fixed the issue for me. https://reviews.llvm.org/D52139 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

tatyana-krasnukha requested changes to this revision. tatyana-krasnukha added a comment. This revision now requires changes to proceed. Alexander, please add a timeout to be sure that the test is not hanging even if something goes wrong. A possible solution for Python 2: F7266803: target-select-s

[Lldb-commits] [PATCH] D48623: Move architecture-specific address adjustment to architecture plugins.

tatyana-krasnukha updated this revision to Diff 166342. tatyana-krasnukha retitled this revision from "WIP: Move architecture-specific address adjustment to architecture plugins." to "Move architecture-specific address adjustment to architecture plugins.". tatyana-krasnukha added a comment. Heral

[Lldb-commits] [PATCH] D48623: Move architecture-specific address adjustment to architecture plugins.

tatyana-krasnukha updated this revision to Diff 166475. tatyana-krasnukha added a comment. Make overriding functions public. Repository: rLLDB LLDB https://reviews.llvm.org/D48623 Files: include/lldb/Core/Architecture.h include/lldb/Target/Target.h source/Core/Address.cpp source/Plug

[Lldb-commits] [PATCH] D51999: build: add libedit to include paths

tatyana-krasnukha updated this revision to Diff 166507. tatyana-krasnukha added a comment. LLDB's static libraries link each other as INTERFACE, that's why CMake doesn't propagate lldbHost's include directories to lldbCore and lldbInterpreter. For lldbHost itself, I had to use PUBLIC, because its

[Lldb-commits] [PATCH] D48623: Move architecture-specific address adjustment to architecture plugins.

tatyana-krasnukha updated this revision to Diff 166520. Repository: rLLDB LLDB https://reviews.llvm.org/D48623 Files: include/lldb/Core/Architecture.h source/Plugins/Architecture/Arm/ArchitectureArm.cpp source/Plugins/Architecture/Arm/ArchitectureArm.h source/Plugins/Architecture/CMake

[Lldb-commits] [PATCH] D48623: Move architecture-specific address adjustment to architecture plugins.

tatyana-krasnukha added a comment. Thanks for your patience;) Repository: rLLDB LLDB https://reviews.llvm.org/D48623 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D52376: [API][Swig] Overloaded functions for SBTarget

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: spyffe, clayborg, zturner. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: lldb-commits. Slightly refactored typemaps to combine overloading with default arguments. Repository: rLLDB LLDB https://r

[Lldb-commits] [PATCH] D52376: [Swig] Merge typemaps with same bodies

tatyana-krasnukha updated this revision to Diff 166719. tatyana-krasnukha retitled this revision from "[API][Swig] Overloaded functions for SBTarget" to "[Swig] Merge typemaps with same bodies". tatyana-krasnukha edited the summary of this revision. tatyana-krasnukha removed a reviewer: spyffe. ta

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

tatyana-krasnukha accepted this revision. tatyana-krasnukha added a comment. This revision is now accepted and ready to land. A lot of tests are failing with Python 3, at least on CentOS. So, I agree the problem doesn't block this review. https://reviews.llvm.org/D52139 _

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

tatyana-krasnukha added a comment. `pass_fds` parameter was added in Python 3.7. With version 3.6 the test fails with a `TypeError`. https://reviews.llvm.org/D52498 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

tatyana-krasnukha added a comment. It seems I ran into an unrelated issue like this . If the revision works for others, you may ignore this. https://reviews.llvm.org/D52498 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

tatyana-krasnukha added a comment. Forget that the test calls default python, not which was passed to cmake. So, it is enough to replace (3,0) pair with (3,2) to fix. Comment at: lit/tools/lldb-mi/target/inputs/target-select-so-path.py:11 +kwargs = {} +if sys.version_info >= (

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

tatyana-krasnukha added a comment. Now works with Python 3.1 too. LGTM. https://reviews.llvm.org/D52498 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49739: Add new API to SBTarget class

tatyana-krasnukha added inline comments. Comment at: lit/tools/lldb-mi/target/target-select-so-path.test:4 +# RUN: %cc -o %t %p/inputs/main.c -g +# RUN: python %p/inputs/target-select-so-path.py "%debugserver" "%lldbmi %t" %s + Could you run the same python that

[Lldb-commits] [PATCH] D52572: Replace pointer to C-array of PropertyDefinition with llvm::ArrayRef

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: clayborg, zturner, jingham. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, teemperor, JDevlieghere. As a follow-up to https://reviews.llvm.org/D49017. Repository: rLLDB LLDB https://r

[Lldb-commits] [PATCH] D52572: Replace pointer to C-array of PropertyDefinition with llvm::ArrayRef

tatyana-krasnukha added a comment. Hmm... There is no such logic left, isn't it? If you mean iterating OptionValueProperties::m_properties vector, I can replace cycles with range based for loop, but this doesn't seem to be related to these changes. Repository: rLLDB LLDB https://reviews.llv

[Lldb-commits] [PATCH] D52572: Replace pointer to C-array of PropertyDefinition with llvm::ArrayRef

tatyana-krasnukha added a comment. It seems you are speaking about OptionDefinition, not PropertyDefinition. I was going to create a separate revision for it. Should I add OptionDefinition related changes to here? Repository: rLLDB LLDB https://reviews.llvm.org/D52572 ___

[Lldb-commits] [PATCH] D52604: Clean-up usage of OptionDefinition arrays

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: clayborg, zturner. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: lldb-commits. Removed unused static arrays from headers, removed sentinel entry from OptionDefinition array in Driver.cpp. Repositor

[Lldb-commits] [PATCH] D52604: Clean-up usage of OptionDefinition arrays

tatyana-krasnukha added inline comments. Comment at: tools/driver/Driver.cpp:71 typedef struct { uint32_t usage_mask; // Used to mark options that can be used together. If (1 This type is duplicated here to not break the encapsulation of lldb's private t

[Lldb-commits] [PATCH] D52604: Clean-up usage of OptionDefinition arrays

tatyana-krasnukha updated this revision to Diff 167475. tatyana-krasnukha added a comment. Modifies Driver::ParseArgs checks Repository: rLLDB LLDB https://reviews.llvm.org/D52604 Files: include/lldb/Target/Platform.h source/Commands/CommandObjectDisassemble.h source/Commands/CommandOb

[Lldb-commits] [PATCH] D52604: Clean-up usage of OptionDefinition arrays

tatyana-krasnukha added inline comments. Comment at: tools/driver/Driver.cpp:581-585 + if (g_num_options == 0) { if (argc > 1) error.SetErrorStringWithFormat("invalid number of options"); return error; } clayborg wrote: > Do we even need this

[Lldb-commits] [PATCH] D54084: [LLDB] Fix FreeBSD build

tatyana-krasnukha added inline comments. Comment at: source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp:378 namespace fs = llvm::sys::fs; - if (working_dir && (!working_dir.ResolvePath() || - !fs::is_directory(working_dir.GetPath( { + if (working_dir

[Lldb-commits] [PATCH] D54084: [LLDB] Fix FreeBSD build

tatyana-krasnukha added a comment. Could you please make the same fix for NativeProcessDarwin (`NativeProcessProtocol::Launch`) as well? Repository: rLLDB LLDB https://reviews.llvm.org/D54084 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D54084: [LLDB] Fix FreeBSD/Darwin build

tatyana-krasnukha accepted this revision. tatyana-krasnukha added a comment. This revision is now accepted and ready to land. Thank you! LGTM, though I'm not able to test it under any of these systems. https://reviews.llvm.org/D54084 ___ lldb-commit

[Lldb-commits] [PATCH] D55472: Speadup memory regions handling and cleanup related code

tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: clayborg. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, abidh. - replace unnecessary shared pointers with unique pointers - reserve space before filling a vector with 'push_back' in a lo

[Lldb-commits] [PATCH] D55522: Cache memory regions in ProcessMinidump and use the linux maps as the source of the information if available.

tatyana-krasnukha added a comment. Without overriding Process::GetMemoryRegions still does a lot of unnecessary job (FindMemoryRegion for each element in the vector). With these changes, it may just return m_regions (if not empty), doesn't it? Comment at: source/Plugins/Proces

[Lldb-commits] [PATCH] D55522: Cache memory regions in ProcessMinidump and use the linux maps as the source of the information if available.

tatyana-krasnukha added a comment. Don't you mind to take overridden GetMemoryRegions in this patch so that I can remove all minidump-related changes from D55472 ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55522/new/ https://reviews.llvm.org/D55522

[Lldb-commits] [PATCH] D55472: Speadup memory regions handling and cleanup related code

tatyana-krasnukha added a comment. Thanks to all for comments! As I wrote in inline comments, 'non-const' -> 'const' changes don't seem to break anything, I'd like to leave it here. Correct me, if I'm wrong. The second question is whether it is allowed to change private member functions of SBX

[Lldb-commits] [PATCH] D55653: Check pointer results on nullptr before using them

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: ki.stfu, abidh. Herald added a subscriber: lldb-commits. Prevent crashing like llvm.org/pr37054 Repository: rLLDB LLDB https://reviews.llvm.org/D55653 Files: MICmdCmdData.cpp MICmdCmdGdbInfo.cpp MICmdCmdMiscell

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: clayborg, jasonmolenda. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, mgorny. Add ARC architecture (bare-metal) that can be debugged through an RSP-server. Repository: rLLDB LLDB htt

[Lldb-commits] [PATCH] D55724: [ARC] Add SystemV ABI

tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: clayborg. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, teemperor, mgorny. Repository: rLLDB LLDB https://reviews.llvm.org/D55724 Files: source/API/SystemInitializerFull.cpp sour

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha marked 2 inline comments as done. tatyana-krasnukha added a comment. My intent was to move ARC-specific code to the architecture plugin as much as possible, but it requires to add undesired dependencies to Architecture interface. So, you are right, it seems to be better to keep

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha updated this revision to Diff 178643. tatyana-krasnukha added a comment. Addressed review comments Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55718/new/ https://reviews.llvm.org/D55718 Files: include/lldb/Utility/ArchSpec.h source/Plug

  1   2   3   >