[Lldb-commits] [lldb] b141534 - Remove unused #include

2023-09-29 Thread Ted Woodward via lldb-commits
Author: Ted Woodward Date: 2023-09-29T11:07:38-05:00 New Revision: b14153490134e210c05bafae330a270cf60c0e2a URL: https://github.com/llvm/llvm-project/commit/b14153490134e210c05bafae330a270cf60c0e2a DIFF: https://github.com/llvm/llvm-project/commit/b14153490134e210c05bafae330a270cf60c0e2a.diff

[Lldb-commits] [lldb] 847de9c - [RISC-V] Add RISC-V ABI plugin

2023-09-29 Thread Ted Woodward via lldb-commits
Author: Ted Woodward Date: 2023-09-29T10:31:01-05:00 New Revision: 847de9c332775d1841fec9fea5cb5c41592a4c8f URL: https://github.com/llvm/llvm-project/commit/847de9c332775d1841fec9fea5cb5c41592a4c8f DIFF: https://github.com/llvm/llvm-project/commit/847de9c332775d1841fec9fea5cb5c41592a4c8f.diff

[Lldb-commits] [lldb] be88462 - Platform qemu-user: Build path to qemu automatically if not specified

2023-08-22 Thread Ted Woodward via lldb-commits
Author: Ted Woodward Date: 2023-08-22T14:20:18-05:00 New Revision: be88462cd6aa819c22185ff0916988d4f03b6ab0 URL: https://github.com/llvm/llvm-project/commit/be88462cd6aa819c22185ff0916988d4f03b6ab0 DIFF: https://github.com/llvm/llvm-project/commit/be88462cd6aa819c22185ff0916988d4f03b6ab0.diff

[Lldb-commits] [lldb] 523110d - Add support for llvm::MCInstPrinter::setPrintBranchImmAsAddress

2023-08-22 Thread Ted Woodward via lldb-commits
Author: Ted Woodward Date: 2023-08-22T14:16:14-05:00 New Revision: 523110d654a286607790e7637da6be312de3a7c7 URL: https://github.com/llvm/llvm-project/commit/523110d654a286607790e7637da6be312de3a7c7 DIFF: https://github.com/llvm/llvm-project/commit/523110d654a286607790e7637da6be312de3a7c7.diff

[Lldb-commits] [lldb] ded1bad - Fix mixed disassembly showing source lines for "line 0"

2023-07-12 Thread Ted Woodward via lldb-commits
Author: Ted Woodward Date: 2023-07-12T11:39:11-05:00 New Revision: ded1bad64af0acf312d2464fcc4e826f89a720d0 URL: https://github.com/llvm/llvm-project/commit/ded1bad64af0acf312d2464fcc4e826f89a720d0 DIFF: https://github.com/llvm/llvm-project/commit/ded1bad64af0acf312d2464fcc4e826f89a720d0.diff

[Lldb-commits] [lldb] 1c05c52 - [lldb-vscode] Fix coredump load source mapping for first file

2021-11-01 Thread Ted Woodward via lldb-commits
Author: Ted Woodward Date: 2021-11-01T10:47:42-05:00 New Revision: 1c05c52de2177a328b7d2d07b697af67eb9f8122 URL: https://github.com/llvm/llvm-project/commit/1c05c52de2177a328b7d2d07b697af67eb9f8122 DIFF: https://github.com/llvm/llvm-project/commit/1c05c52de2177a328b7d2d07b697af67eb9f8122.diff

[Lldb-commits] [lldb] 953ddde - [lldb] Handle malformed qfThreadInfo reply

2021-09-23 Thread Ted Woodward via lldb-commits
Author: Ted Woodward Date: 2021-09-23T17:03:47-05:00 New Revision: 953ddded1aa2b459a939e0f1649691c9086ba416 URL: https://github.com/llvm/llvm-project/commit/953ddded1aa2b459a939e0f1649691c9086ba416 DIFF: https://github.com/llvm/llvm-project/commit/953ddded1aa2b459a939e0f1649691c9086ba416.diff

[Lldb-commits] [lldb] 1758953 - [lldb-vscode] Fix focus thread when previous thread exits

2021-09-15 Thread Ted Woodward via lldb-commits
Author: Ted Woodward Date: 2021-09-15T18:09:32-05:00 New Revision: 17589538aaef2b5ae27a0bfeb4346aff433aa59d URL: https://github.com/llvm/llvm-project/commit/17589538aaef2b5ae27a0bfeb4346aff433aa59d DIFF: https://github.com/llvm/llvm-project/commit/17589538aaef2b5ae27a0bfeb4346aff433aa59d.diff

[Lldb-commits] [lldb] 3169d92 - Remove special Hexagon packet traversal code

2020-08-05 Thread Ted Woodward via lldb-commits
Author: Ted Woodward Date: 2020-08-05T12:05:42-05:00 New Revision: 3169d920ccd16ec3c3e1bf5d91595b70a5278045 URL: https://github.com/llvm/llvm-project/commit/3169d920ccd16ec3c3e1bf5d91595b70a5278045 DIFF: https://github.com/llvm/llvm-project/commit/3169d920ccd16ec3c3e1bf5d91595b70a5278045.diff

[Lldb-commits] [lldb] cecc185 - Add REQUIRES: x86 so this won't be run if x86 is not available.

2020-02-13 Thread Ted Woodward via lldb-commits
Author: Ted Woodward Date: 2020-02-13T11:17:27-06:00 New Revision: cecc185166c03945f1c06f8d3e1993720f3d3c1a URL: https://github.com/llvm/llvm-project/commit/cecc185166c03945f1c06f8d3e1993720f3d3c1a DIFF: https://github.com/llvm/llvm-project/commit/cecc185166c03945f1c06f8d3e1993720f3d3c1a.diff

[Lldb-commits] [lldb] 6fd818c - Don't fail step out if remote server doesn't implement qMemoryRegionInfo

2020-02-10 Thread Ted Woodward via lldb-commits
Author: Ted Woodward Date: 2020-02-10T13:40:44-06:00 New Revision: 6fd818c5a9c565b8aaeaf1ca85ad14735ee0eb0c URL: https://github.com/llvm/llvm-project/commit/6fd818c5a9c565b8aaeaf1ca85ad14735ee0eb0c DIFF: https://github.com/llvm/llvm-project/commit/6fd818c5a9c565b8aaeaf1ca85ad14735ee0eb0c.diff

[Lldb-commits] [lldb] 04488c4 - Don't fail step out if remote server doesn't implement qMemoryRegionInfo

2020-01-28 Thread Ted Woodward via lldb-commits
Author: Ted Woodward Date: 2020-01-28T13:36:06-06:00 New Revision: 04488c485a8875ba4bd6d2d004ac778276ae37e0 URL: https://github.com/llvm/llvm-project/commit/04488c485a8875ba4bd6d2d004ac778276ae37e0 DIFF: https://github.com/llvm/llvm-project/commit/04488c485a8875ba4bd6d2d004ac778276ae37e0.diff

[Lldb-commits] [lldb] r341849 - Fix raw address breakpoints not resolving

2018-09-10 Thread Ted Woodward via lldb-commits
Author: ted Date: Mon Sep 10 11:19:01 2018 New Revision: 341849 URL: http://llvm.org/viewvc/llvm-project?rev=341849=rev Log: Fix raw address breakpoints not resolving Summary: An address breakpoint of the form "b 0x1000" won't resolve if it's created while the process isn't running. This patch

[Lldb-commits] [lldb] r315524 - Add cases for new type DependentAddressSpace, added in r314649

2017-10-11 Thread Ted Woodward via lldb-commits
Author: ted Date: Wed Oct 11 15:42:21 2017 New Revision: 315524 URL: http://llvm.org/viewvc/llvm-project?rev=315524=rev Log: Add cases for new type DependentAddressSpace, added in r314649 Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified:

[Lldb-commits] [lldb] r313799 - Fix warning caused by new clang::BuiltinType::Float16 added in r312794

2017-09-20 Thread Ted Woodward via lldb-commits
Author: ted Date: Wed Sep 20 12:16:53 2017 New Revision: 313799 URL: http://llvm.org/viewvc/llvm-project?rev=313799=rev Log: Fix warning caused by new clang::BuiltinType::Float16 added in r312794 Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified:

[Lldb-commits] [lldb] r312726 - Fix lldb-mi test data_read_memory_bytes_global

2017-09-07 Thread Ted Woodward via lldb-commits
Author: ted Date: Thu Sep 7 09:24:39 2017 New Revision: 312726 URL: http://llvm.org/viewvc/llvm-project?rev=312726=rev Log: Fix lldb-mi test data_read_memory_bytes_global Summary: Test was skipped because -data-evaluate-expression was thought to not work on globals. This is not the case - the

[Lldb-commits] [lldb] r312270 - lldb-mi: -var-update can hang when traversing complex types with pointers

2017-08-31 Thread Ted Woodward via lldb-commits
Author: ted Date: Thu Aug 31 12:22:33 2017 New Revision: 312270 URL: http://llvm.org/viewvc/llvm-project?rev=312270=rev Log: lldb-mi: -var-update can hang when traversing complex types with pointers Summary: -var-update calls CMICmdCmdVarUpdate::ExamineSBValueForChange to check if a varObj has

[Lldb-commits] [lldb] r303278 - Fix error string set in AddName to take a StringRef.

2017-05-17 Thread Ted Woodward via lldb-commits
Author: ted Date: Wed May 17 12:48:55 2017 New Revision: 303278 URL: http://llvm.org/viewvc/llvm-project?rev=303278=rev Log: Fix error string set in AddName to take a StringRef. Modified: lldb/trunk/source/Breakpoint/Breakpoint.cpp Modified: lldb/trunk/source/Breakpoint/Breakpoint.cpp URL:

[Lldb-commits] [PATCH] D23802: gdb-remote: Make the sequence mutex non-recursive

2016-10-12 Thread Ted Woodward via lldb-commits
ted added a comment. I'm seeing the same issue as Nitesh, except in a different spot. The Hexagon Simulator doesn't support QSaveRegisterState, so lldb calls GDBRemoteRegisterContext::ReadAllRegisterValues. It gets a lock on the communication client, then calls ReadAllRegisters, which tries

[Lldb-commits] [PATCH] D25137: [lldbmi] Fix prompt which can get inserted in the middle of lldb-mi output

2016-09-30 Thread Ted Woodward via lldb-commits
ted accepted this revision. ted added a comment. This revision is now accepted and ready to land. The problem this scenario has is asynchronous output from 2 different sources. The original fix made Windows (or any lldb without libedit) much better, but I think most non-Windows builds will use

Re: [Lldb-commits] [PATCH] D21649: Don't create unnecessary remote platforms

2016-06-23 Thread Ted Woodward via lldb-commits
ted added a subscriber: ted. ted added a comment. The Hexagon platform (currently in-house only) acts like the ios simulator platform, in that it doesn't connect - it fixes up the command line, then launches the Hexagon simulator (based on the debugserver launch code in the gdb-remote process

[Lldb-commits] [PATCH] D20135: Keep original source path and mapped path in LineEntry

2016-05-10 Thread Ted Woodward via lldb-commits
ted created this revision. ted added reviewers: jingham, clayborg. ted added a subscriber: lldb-commits. The "file" variable in a LineEntry was mapped using target.source-map, except when stepping through inlined code. This patch adds a new variable to LineEntry, "original_file", that contains

Re: [Lldb-commits] [PATCH] D20035: Add source file mapping to inline frames' SymbolContext line_entry.file

2016-05-10 Thread Ted Woodward via lldb-commits
ted abandoned this revision. ted added a comment. Problem will be fixed in another way. http://reviews.llvm.org/D20035 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D20035: Add source file mapping to inline frames' SymbolContext line_entry.file

2016-05-06 Thread Ted Woodward via lldb-commits
ted created this revision. ted added a reviewer: jingham. ted added a subscriber: lldb-commits. new StackFrame objects created in StackFrameList::GetFramesUpTo are constructed with SymbolContext set to nullptr, except for inline frames. Calling the ctor with nullptr causes

Re: [Lldb-commits] [PATCH] D18531: Allow gdbremote process to read modules from memory

2016-03-30 Thread Ted Woodward via lldb-commits
ted added a comment. Thanks for adding me, Tamas. It looks like removing the code in the Hexagon Dynamic Loader plugin will have lldb drill down into ObjectFileElf, and end up doing the same thing - set the load address of each section of the ELF file. So it should behave the same as before

[Lldb-commits] [PATCH] D18484: Change windows cmake to require debug libraries for a debug build, otherwise release libraries

2016-03-25 Thread Ted Woodward via lldb-commits
ted created this revision. ted added a reviewer: zturner. ted added a subscriber: lldb-commits. On Windows we require both debug and release python executable/libraries; this change requires debug for a debug build and release for other builds. If CMAKE_BUILD_TYPE is not specified, the llvm

[Lldb-commits] [lldb] r264332 - Fix for missing prompt on Windows

2016-03-24 Thread Ted Woodward via lldb-commits
Author: ted Date: Thu Mar 24 15:35:03 2016 New Revision: 264332 URL: http://llvm.org/viewvc/llvm-project?rev=264332=rev Log: Fix for missing prompt on Windows Summary: On Windows (and possibly other hosts with LLDB_DISABLE_LIBEDIT defined), the (lldb) prompt won't print after async output, like

Re: [Lldb-commits] [PATCH] D18335: Fix for missing prompt on Windows

2016-03-23 Thread Ted Woodward via lldb-commits
ted added a comment. Adrian and I worked out what is going on: 1. Run starts the launch and writes a prompt 2. State change fires, prints out “launching” through async, overwriting the prompt from 1) and writing a new prompt 3. CommandObjectProcessLaunch::Execute appends “launch” to the result.

Re: [Lldb-commits] [PATCH] D18335: Fix for missing prompt on Windows

2016-03-23 Thread Ted Woodward via lldb-commits
ted updated this revision to Diff 51462. ted added a comment. Updated to change cursor position before async output so old prompt is overwritten. Adrian, please test with your setup and let me know if it solves the issues you see. http://reviews.llvm.org/D18335 Files:

Re: [Lldb-commits] [PATCH] D18335: Fix for missing prompt on Windows

2016-03-21 Thread Ted Woodward via lldb-commits
ted added a comment. Without the patch I'm seeing the original prompt printed after the command, in a line like this: (lldb) Process 1 stopped and no prompt after the async output from the stop. With the patch I see the above prompt, and a prompt after the async output. I think with the

[Lldb-commits] [PATCH] D18335: Fix for missing prompt on Windows

2016-03-21 Thread Ted Woodward via lldb-commits
ted created this revision. ted added reviewers: clayborg, zturner. ted added a subscriber: lldb-commits. On Windows (and possibly other hosts with LLDB_DISABLE_LIBEDIT defined), the (lldb) prompt won't print after async output, like from a breakpoint hit or a step. This patch forces the prompt

[Lldb-commits] [lldb] r263066 - Fix "ninja check-lldb" crash in IRExecutionUnit.cpp

2016-03-09 Thread Ted Woodward via lldb-commits
Author: ted Date: Wed Mar 9 16:05:17 2016 New Revision: 263066 URL: http://llvm.org/viewvc/llvm-project?rev=263066=rev Log: Fix "ninja check-lldb" crash in IRExecutionUnit.cpp Summary: From Adrian McCarthy: "Running ninja check-lldb now has one crash in a Python process, due to deferencing a

Re: [Lldb-commits] [PATCH] D17860: Fix "ninja check-lldb" crash in IRExecutionUnit.cpp

2016-03-09 Thread Ted Woodward via lldb-commits
ted updated this revision to Diff 50189. ted added a comment. Updated to address Jim's comments. http://reviews.llvm.org/D17860 Files: source/Expression/IRExecutionUnit.cpp Index: source/Expression/IRExecutionUnit.cpp === ---

Re: [Lldb-commits] [PATCH] D17860: Fix "ninja check-lldb" crash in IRExecutionUnit.cpp

2016-03-09 Thread Ted Woodward via lldb-commits
So you'd like to see this function get the address of a function that it finds in either symbols or debug info? Which should it prioritize when we have both? Ted -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation

Re: [Lldb-commits] [PATCH] D17860: Fix "ninja check-lldb" crash in IRExecutionUnit.cpp

2016-03-08 Thread Ted Woodward via lldb-commits
ted added a comment. The change is to guard against the case where candidate_sc.symbol is nullptr. candidate_sc.function is only used when load_address != LLDB_INVALID_ADDRESS, but load_address is set on line 802: load_address = candidate_sc.symbol->ResolveCallableAddress(*target); so

Re: [Lldb-commits] [PATCH] D17860: Fix "ninja check-lldb" crash in IRExecutionUnit.cpp

2016-03-08 Thread Ted Woodward via lldb-commits
ted updated this revision to Diff 50074. ted added a comment. Updated to use early-out as requested http://reviews.llvm.org/D17860 Files: source/Expression/IRExecutionUnit.cpp Index: source/Expression/IRExecutionUnit.cpp ===

[Lldb-commits] [PATCH] D17860: Fix "ninja check-lldb" crash in IRExecutionUnit.cpp

2016-03-03 Thread Ted Woodward via lldb-commits
ted created this revision. ted added reviewers: spyffe, zturner, amccarth. ted added a subscriber: lldb-commits. From Adrian McCarthy: "Running ninja check-lldb now has one crash in a Python process, due to deferencing a null pointer in IRExecutionUnit.cpp: candidate_sc.symbol is null, which

[Lldb-commits] [lldb] r262407 - Fix bug with function resolution when using IR Interpreter

2016-03-01 Thread Ted Woodward via lldb-commits
Author: ted Date: Tue Mar 1 15:53:26 2016 New Revision: 262407 URL: http://llvm.org/viewvc/llvm-project?rev=262407=rev Log: Fix bug with function resolution when using IR Interpreter Summary: Recent changes to the expression parser broke function name resolution when using the IR interpreter

Re: [Lldb-commits] [PATCH] D17745: Fix bug with function resolution when using IR Interpreter

2016-03-01 Thread Ted Woodward via lldb-commits
ted updated this revision to Diff 49542. ted added a comment. Updated to address Sean's comments http://reviews.llvm.org/D17745 Files: include/lldb/Expression/IRInterpreter.h source/Expression/IRExecutionUnit.cpp source/Expression/IRInterpreter.cpp

[Lldb-commits] [PATCH] D17745: Fix bug with function resolution when using IR Interpreter

2016-02-29 Thread Ted Woodward via lldb-commits
ted created this revision. ted added a reviewer: spyffe. ted added a subscriber: lldb-commits. Recent changes to the expression parser broke function name resolution when using the IR interpreter instead of JIT. This patch changes the IRMemoryMap ivar in InterpreterStackFrame to an

[Lldb-commits] [lldb] r255374 - Remove hardcoded registers from Hexagon ABI

2015-12-11 Thread Ted Woodward via lldb-commits
Author: ted Date: Fri Dec 11 15:52:47 2015 New Revision: 255374 URL: http://llvm.org/viewvc/llvm-project?rev=255374=rev Log: Remove hardcoded registers from Hexagon ABI Summary: The Hexagon ABI plugin uses hardcoded registers when setting up function calls. This is OK for the Hexagon simulator,

[Lldb-commits] [lldb] r255340 - Change finishSwigPythonLLDB.py to copy six.py instead of simlink it

2015-12-11 Thread Ted Woodward via lldb-commits
Author: ted Date: Fri Dec 11 09:43:36 2015 New Revision: 255340 URL: http://llvm.org/viewvc/llvm-project?rev=255340=rev Log: Change finishSwigPythonLLDB.py to copy six.py instead of simlink it Summary: If six.py is simlink'd, an installation won't be able to find it unless it has access to the

Re: [Lldb-commits] [PATCH] D15457: Remove hardcoded registers from Hexagon ABI

2015-12-11 Thread Ted Woodward via lldb-commits
ted updated this revision to Diff 42555. ted added a comment. Updated to check for invalid register numbers. http://reviews.llvm.org/D15457 Files: source/Plugins/ABI/SysV-hexagon/ABISysV_hexagon.cpp Index: source/Plugins/ABI/SysV-hexagon/ABISysV_hexagon.cpp

[Lldb-commits] [PATCH] D15457: Remove hardcoded registers from Hexagon ABI

2015-12-11 Thread Ted Woodward via lldb-commits
ted created this revision. ted added a reviewer: clayborg. ted added a subscriber: lldb-commits. The Hexagon ABI plugin uses hardcoded registers when setting up function calls. This is OK for the Hexagon simulator, but the register numbers are different on the gdbserver running on hardware.

[Lldb-commits] [lldb] r255268 - Add Hexagon ABI to System Initialization

2015-12-10 Thread Ted Woodward via lldb-commits
Author: ted Date: Thu Dec 10 11:53:07 2015 New Revision: 255268 URL: http://llvm.org/viewvc/llvm-project?rev=255268=rev Log: Add Hexagon ABI to System Initialization Summary: When the Hexagon ABI was added, it was inadvertently left out of initialization/termination. This patch adds it.

Re: [Lldb-commits] [PATCH] D15422: Change finishSwigPythonLLDB.py to copy six.py instead of simlink it

2015-12-10 Thread Ted Woodward via lldb-commits
ted added a comment. Oops! :-) - Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project http://reviews.llvm.org/D15422 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D15347: Add Hexagon ABI to System Initialization

2015-12-08 Thread Ted Woodward via lldb-commits
ted created this revision. ted added a reviewer: clayborg. ted added a subscriber: lldb-commits. When the Hexagon ABI was added, it was inadvertently left out of initialization/termination. This patch adds it. http://reviews.llvm.org/D15347 Files: source/API/SystemInitializerFull.cpp Index:

Re: [Lldb-commits] [PATCH] D10247: Fix crash when cu_comp_dir parameter to DWARFDebugLine::ParseSupportFiles() is an empty string

2015-11-23 Thread Ted Woodward via lldb-commits
ted abandoned this revision. ted added a comment. Handled by another patch http://reviews.llvm.org/D10247 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D14932: Fix watchpoint check to use watchpoint ranges

2015-11-23 Thread Ted Woodward via lldb-commits
ted created this revision. ted added a reviewer: clayborg. ted added a subscriber: lldb-commits. Watchpoints, unlike breakpoints, have an address range. This patch changes WatchpointList::FindByAddress() to match on any address in the watchpoint range, instead of only matching on the