[Lldb-commits] [PATCH] D139102: [AArch64] Inline AArch64TargetParser.def

tmatheson closed this revision. tmatheson added a comment. Landed as part of f4225d325c19ae0e5dbe39faa900d81e24559da0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139102/new/

[Lldb-commits] [PATCH] D138792: [AArch64] Improve TargetParser API

tmatheson added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:532 getTargetDefinesARMV81A(Opts, Builder); -break; - case llvm::AArch64::ArchKind::ARMV8_2A: + if (*ArchInfo == llvm::AArch64::ARMV8_2A) getTargetDefinesARMV82A(Opts, Builder);

[Lldb-commits] [PATCH] D138792: [AArch64] Improve TargetParser API

tmatheson added a comment. Worth noting that this had to be reworked because both D127812 and D137838 went in since this was reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D138792: [AArch64] Improve TargetParser API

tmatheson added a comment. The most recent versions of this patch contains squashed changes from these reviews: - D139278 "[AArch64] Use string comparison for ArchInfo equality." This fixes the test failures with shared libraries, which were caused by each

[Lldb-commits] [PATCH] D139102: [AArch64] Inline AArch64TargetParser.def

tmatheson added a comment. Herald added a subscriber: JDevlieghere. > And this is the file that was being generated: > https://github.com/ziglang/zig/blob/c86589a738e5053a26b2be7d156bcfee1565f00b/lib/std/target/aarch64.zig Thanks for the heads up. It looks like that file hasn't been updated for

[Lldb-commits] [PATCH] D139102: [AArch64] Inline AArch64TargetParser.def

tmatheson updated this revision to Diff 479598. tmatheson added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Update lldb test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139102/new/

[Lldb-commits] [PATCH] D137564: [ARM] Move Triple::getARMCPUForArch into ARMTargetParser

This revision was automatically updated to reflect the committed changes. Closed by commit rG103bbddde66f: [ARM] Move Triple::getARMCPUForArch into ARMTargetParser (authored by tmatheson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137564/new/

[Lldb-commits] [PATCH] D137564: [ARM] Move Triple::getARMCPUForArch into ARMTargetParser

tmatheson created this revision. tmatheson added reviewers: lenary, pratlucas, DavidSpickett. Herald added subscribers: hiraditya, kristof.beyls, dschuff. Herald added a project: All. tmatheson requested review of this revision. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits,

[Lldb-commits] [PATCH] D120593: [Support] Allow the ability to change WithColor's auto detection function

tmatheson added inline comments. Comment at: llvm/include/llvm/Support/WithColor.h:142 + /// Retrieve the default color auto detection function. + static AutoDetectFunctionType defaultAutoDetectFunction(); + This introduces a global constructor call into