tonkosi added a comment.
Thanks for the fix Will!
Just one question: cpp test file contains the expression `a[10].c` and the test
complains about the expression path `a->c`.
If I understand correctly, with the latest fix, that would become `a[10]->c`,
which is not the original expression (objec
tonkosi added a comment.
Hi, I fixed the issue causing macOS tests to fail, but I don't have a macOS
machine to verify it actually works. I'd be grateful if someone could check
that part.
I also decided to further reduce number of parenthesis in output (e.g.
`(*(ptr)).member` isn't ideal), but
tonkosi updated this revision to Diff 466043.
tonkosi edited the summary of this revision.
tonkosi added a comment.
Fixed the issue of printing unnecessary parenthesis, which broke API tests on
macOS.
Improved use of parenthesis to produce outputs such as `(*ptr).member` instead
of `(*(ptr)).me
tonkosi updated this revision to Diff 463158.
tonkosi added a comment.
Forgot to propagate "epformat" when calling GetExpressionPath
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132734/new/
https://reviews.llvm.org/D132734
Files:
lldb/source/Co
tonkosi created this revision.
tonkosi added reviewers: werat, Michael137.
Herald added a project: All.
tonkosi requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This change fixes two issues in ValueObject::GetExpressionPath method:
1. Acces
tonkosi added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3281-3282
if ((parent_tag == DW_TAG_compile_unit ||
- parent_tag == DW_TAG_partial_unit) &&
+ parent_tag == DW_TAG_partial_unit ||
+ parent_tag == DW_T
tonkosi updated this revision to Diff 388958.
tonkosi added a comment.
- Use scope context parent DIE instead of the direct parent
- Add tests for constants in anonymous namespace
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112147/new/
https://re
tonkosi added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3281-3282
if ((parent_tag == DW_TAG_compile_unit ||
- parent_tag == DW_TAG_partial_unit) &&
+ parent_tag == DW_TAG_partial_unit ||
+ parent_tag == DW_T
tonkosi created this revision.
tonkosi added reviewers: werat, teemperor.
tonkosi requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
LLDB uses mangled name to construct a fully qualified name for global
variables. Sometimes DW_TAG_linkage_name
