Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898

chris...@zoulas.com (Christos Zoulas) wrote on 30.05.2017 17:46:58: > I am sorry to say that this is my fault and this sucks. I accepted > some patches that broke binary compatibility in a way that it is not > user visible. Basically you seem to have version of libedit that is > between the

Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898

Kamil Rytarowski wrote on 29.05.2017 18:10:36: > Do you offer shell account? I don't have Linux and/or s390x to debug it. Sorry, this is on an internal IBM machine ... I don't have a publically accessible machine to reproduce this on at the moment. I managed to debug a bit

Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898

Hello, It appears this commit broke the EditlineTestFixture.EditlineReceivesSingleLineText unit test on s390x-linux. The test now simply hangs (hanging the whole test suite execution) ... Mit freundlichen Gruessen / Best Regards Ulrich Weigand -- Dr. Ulrich Weigand | Phone:

Re: [Lldb-commits] [PATCH] D18976: Handle lookup of names identifying both a variable and a type

uweigand added a reviewer: jingham. uweigand updated this revision to Diff 57617. uweigand added a comment. Ping? This fixes the last remaining test suite failure on s390x. I'd like to get a clean test suite ... Patch updated to current sources. Added jingham since you touched that code

Re: [Lldb-commits] [PATCH] D18975: Fix unwind failures when PC points beyond the end of a function

uweigand added a comment. Given Tamas' update, I've now checked in the original version, including comment. If you do want me to take out the comment after all, please let me know and I'll do so. Repository: rL LLVM http://reviews.llvm.org/D18975

Re: [Lldb-commits] [PATCH] D18975: Fix unwind failures when PC points beyond the end of a function

This revision was automatically updated to reflect the committed changes. Closed by commit rL267363: Fix unwind failures when PC points beyond the end of a function (authored by uweigand). Changed prior to commit: http://reviews.llvm.org/D18975?vs=53951=54813#toc Repository: rL LLVM

[Lldb-commits] [lldb] r267363 - Fix unwind failures when PC points beyond the end of a function

Author: uweigand Date: Sun Apr 24 15:49:56 2016 New Revision: 267363 URL: http://llvm.org/viewvc/llvm-project?rev=267363=rev Log: Fix unwind failures when PC points beyond the end of a function RegisterContextLLDB::InitializeNonZerothFrame already has code to attempt to detect and handle the

Re: [Lldb-commits] [PATCH] D18975: Fix unwind failures when PC points beyond the end of a function

uweigand added reviewers: clayborg, tberghammer. uweigand updated this revision to Diff 53951. uweigand added a comment. Add fix for a related problem that still caused unwind failures on SystemZ. The ResolveSymbolContextForAddress sometimes returns a "symbol" with empty name. This turns out to

[Lldb-commits] [lldb] r266422 - Fix usage of APInt.getRawData for big-endian systems

Author: uweigand Date: Fri Apr 15 04:55:52 2016 New Revision: 266422 URL: http://llvm.org/viewvc/llvm-project?rev=266422=rev Log: Fix usage of APInt.getRawData for big-endian systems Recommit modified version of r266311 including build bot regression fix. This differs from the original r266311

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

Pavel Labath wrote on 15.04.2016 11:19:35: > Thanks a lot for cleaning that up. I hope you'll be able to find the > cause of the 32-bit problems quickly. If you need help reproducing the > errors, I can send you some of the detailed logs from our buildbots. I did manage to

[Lldb-commits] [lldb] r266420 - Make Scalar::SChar return an explicit signed type

Author: uweigand Date: Fri Apr 15 04:15:47 2016 New Revision: 266420 URL: http://llvm.org/viewvc/llvm-project?rev=266420=rev Log: Make Scalar::SChar return an explicit signed type This is needed for platforms where the default "char" type is unsigned. Originally committed as part of (now

[Lldb-commits] [lldb] r266418 - Fix Scalar::SetValueFromData for 128- and 256-bit types

Author: uweigand Date: Fri Apr 15 04:14:59 2016 New Revision: 266418 URL: http://llvm.org/viewvc/llvm-project?rev=266418=rev Log: Fix Scalar::SetValueFromData for 128- and 256-bit types Obvious fix for incorrect use of GetU64 offset pointer. Originally committed as part of (now reverted)

[Lldb-commits] [lldb] r266419 - Fix Scalar::MakeSigned for 128- and 256-bit types.

Author: uweigand Date: Fri Apr 15 04:15:22 2016 New Revision: 266419 URL: http://llvm.org/viewvc/llvm-project?rev=266419=rev Log: Fix Scalar::MakeSigned for 128- and 256-bit types. Obvious fix for incorrect result types of the operation. Originally committed as part of (now reverted) r266311.

[Lldb-commits] [lldb] r266417 - Fix ABISysV_s390x::GetArgumentValues

Author: uweigand Date: Fri Apr 15 04:14:32 2016 New Revision: 266417 URL: http://llvm.org/viewvc/llvm-project?rev=266417=rev Log: Fix ABISysV_s390x::GetArgumentValues This routine contained a stray "return false;" making part of the code never executed. Also, the stack offset where to find

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

Ulrich Weigand/Germany/IBM wrote on 14.04.2016 18:20:20: > So there seem to be at least two different issues, looking at the build bot > logs. After the main SystemZ patch went it, there was just a single > failure, a timeout on the new s390x.core test. I guess we can just disable > that test

[Lldb-commits] [lldb] r266352 - Fix regression in gnu_libstdcpp.py introduced by r266313

Author: uweigand Date: Thu Apr 14 13:31:12 2016 New Revision: 266352 URL: http://llvm.org/viewvc/llvm-project?rev=266352=rev Log: Fix regression in gnu_libstdcpp.py introduced by r266313 CreateChildAtOffset needs a byte offset, not an element number. Modified:

[Lldb-commits] [lldb] r266343 - Disable LinuxCoreTestCase.test_s390x

Author: uweigand Date: Thu Apr 14 12:36:41 2016 New Revision: 266343 URL: http://llvm.org/viewvc/llvm-project?rev=266343=rev Log: Disable LinuxCoreTestCase.test_s390x This seems to hang on non-s390x hosts. Disable for now to get the build bots going again. Modified:

[Lldb-commits] [lldb] r266341 - Revert r266311 - Fix usage of APInt.getRawData for big-endian systems

Author: uweigand Date: Thu Apr 14 12:22:18 2016 New Revision: 266341 URL: http://llvm.org/viewvc/llvm-project?rev=266341=rev Log: Revert r266311 - Fix usage of APInt.getRawData for big-endian systems Try to get 32-bit build bots running again. Modified:

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

Pavel Labath wrote on 14.04.2016 17:36:40: > this has broken basically everything on 32-bit targets > >. > Will you be able to track down the problem quickly? I don't expect the > fix to be

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

Pavel Labath wrote on 14.04.2016 17:36:40: > this has broken basically everything on 32-bit targets > >. > Will you be able to track down the problem quickly? I don't expect the > fix to be

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

uweigand added a comment. In http://reviews.llvm.org/D18978#400787, @labath wrote: > That's perfect, thanks a lot. :) > > Do you have commit access? If not, let me know when you're ready to start > landing these things... I do have commit access, and have committed the 10 out of 12 patches

[Lldb-commits] [lldb] r266311 - Fix usage of APInt.getRawData for big-endian systems

Author: uweigand Date: Thu Apr 14 09:32:01 2016 New Revision: 266311 URL: http://llvm.org/viewvc/llvm-project?rev=266311=rev Log: Fix usage of APInt.getRawData for big-endian systems The Scalar implementation and a few other places in LLDB directly access the internal implementation of APInt

Re: [Lldb-commits] [PATCH] D18981: Fix usage of APInt.getRawData for big-endian systems

This revision was automatically updated to reflect the committed changes. Closed by commit rL266311: Fix usage of APInt.getRawData for big-endian systems (authored by uweigand). Changed prior to commit: http://reviews.llvm.org/D18981?vs=53622=53710#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D18973: Find .plt section in object files generated by recent ld

This revision was automatically updated to reflect the committed changes. Closed by commit rL266316: Find .plt section in object files generated by recent ld (authored by uweigand). Changed prior to commit: http://reviews.llvm.org/D18973?vs=53288=53715#toc Repository: rL LLVM

[Lldb-commits] [lldb] r266316 - Find .plt section in object files generated by recent ld

Author: uweigand Date: Thu Apr 14 09:36:29 2016 New Revision: 266316 URL: http://llvm.org/viewvc/llvm-project?rev=266316=rev Log: Find .plt section in object files generated by recent ld Code in ObjectFileELF::ParseTrampolineSymbols assumes that the sh_info field of the .rel(a).plt section

Re: [Lldb-commits] [PATCH] D18985: Fix test cases for big-endian systems

This revision was automatically updated to reflect the committed changes. Closed by commit rL266315: Fix test cases for big-endian systems (authored by uweigand). Changed prior to commit: http://reviews.llvm.org/D18985?vs=53501=53714#toc Repository: rL LLVM http://reviews.llvm.org/D18985

[Lldb-commits] [lldb] r266315 - Fix test cases for big-endian systems

Author: uweigand Date: Thu Apr 14 09:35:02 2016 New Revision: 266315 URL: http://llvm.org/viewvc/llvm-project?rev=266315=rev Log: Fix test cases for big-endian systems A number of test cases were failing on big-endian systems simply due to byte order assumptions in the tests themselves, and no

Re: [Lldb-commits] [PATCH] D18984: Fix ARM instruction emulation tests on big-endian systems

This revision was automatically updated to reflect the committed changes. Closed by commit rL266314: Fix ARM instruction emulation tests on big-endian systems (authored by uweigand). Changed prior to commit: http://reviews.llvm.org/D18984?vs=53500=53713#toc Repository: rL LLVM

[Lldb-commits] [lldb] r266314 - Fix ARM instruction emulation tests on big-endian systems

Author: uweigand Date: Thu Apr 14 09:34:19 2016 New Revision: 266314 URL: http://llvm.org/viewvc/llvm-project?rev=266314=rev Log: Fix ARM instruction emulation tests on big-endian systems Running the ARM instruction emulation test on a big-endian system would fail, since the code doesn't respect

Re: [Lldb-commits] [PATCH] D18983: Miscellaneous fixes for big-endian systems

This revision was automatically updated to reflect the committed changes. Closed by commit rL266313: Miscellaneous fixes for big-endian systems (authored by uweigand). Changed prior to commit: http://reviews.llvm.org/D18983?vs=53299=53712#toc Repository: rL LLVM

[Lldb-commits] [lldb] r266313 - Miscellaneous fixes for big-endian systems

Author: uweigand Date: Thu Apr 14 09:33:47 2016 New Revision: 266313 URL: http://llvm.org/viewvc/llvm-project?rev=266313=rev Log: Miscellaneous fixes for big-endian systems This patch fixes a bunch of issues that show up on big-endian systems: - The gnu_libstdcpp.py script doesn't follow the

Re: [Lldb-commits] [PATCH] D18982: Handle bit fields on big-endian systems correctly

This revision was automatically updated to reflect the committed changes. Closed by commit rL266312: Handle bit fields on big-endian systems correctly (authored by uweigand). Changed prior to commit: http://reviews.llvm.org/D18982?vs=53605=53711#toc Repository: rL LLVM

[Lldb-commits] [lldb] r266312 - Handle bit fields on big-endian systems correctly

Author: uweigand Date: Thu Apr 14 09:32:57 2016 New Revision: 266312 URL: http://llvm.org/viewvc/llvm-project?rev=266312=rev Log: Handle bit fields on big-endian systems correctly Currently, the DataExtractor::GetMaxU64Bitfield and GetMaxS64Bitfield routines assume the incoming

Re: [Lldb-commits] [PATCH] D18979: Fixes for platforms that default to unsigned char

This revision was automatically updated to reflect the committed changes. Closed by commit rL266309: Fixes for platforms that default to unsigned char (authored by uweigand). Changed prior to commit: http://reviews.llvm.org/D18979?vs=53294=53708#toc Repository: rL LLVM

[Lldb-commits] [lldb] r266309 - Fixes for platforms that default to unsigned char

Author: uweigand Date: Thu Apr 14 09:30:12 2016 New Revision: 266309 URL: http://llvm.org/viewvc/llvm-project?rev=266309=rev Log: Fixes for platforms that default to unsigned char This fixes several test case failure on s390x caused by the fact that on this platform, the default "char" type is

Re: [Lldb-commits] [PATCH] D18981: Fix usage of APInt.getRawData for big-endian systems

uweigand updated this revision to Diff 53622. uweigand added a comment. This adds some unit tests verifying correct operation of the GetBytes routine as well as the conversions (SChar, UChar, ...). Those tests actually exposed more problems in the original Scalar code: the SetValueFromData

Re: [Lldb-commits] [PATCH] D18982: Handle bit fields on big-endian systems correctly

uweigand updated this revision to Diff 53605. uweigand added a comment. Updated interface documentation in DataExtractor.h. Added unit test case for the DataExtractor::GetMaxU64Bitfield and GetMaxS64Bitfield routines. Retested on System z and Intel. http://reviews.llvm.org/D18982 Files:

Re: [Lldb-commits] [PATCH] D18977: Add new ABI callback to provide fallback unwind register locations

uweigand added a comment. In http://reviews.llvm.org/D18977#400047, @clayborg wrote: > Is the SystemZ ABI not in this patch? Looks good otherwise as long as Jason > Molenda is OK with the patch. The SystemZ ABI is in http://reviews.llvm.org/D18978, which I just re-uploaded.

Re: [Lldb-commits] [PATCH] D18976: Handle lookup of names identifying both a variable and a type

uweigand updated this revision to Diff 53553. uweigand added a comment. Add test case. http://reviews.llvm.org/D18976 Files: packages/Python/lldbsuite/test/lang/cpp/scope/TestCppScope.py packages/Python/lldbsuite/test/lang/cpp/scope/main.cpp

Re: [Lldb-commits] [PATCH] D18976: Handle lookup of names identifying both a variable and a type

uweigand added a comment. In http://reviews.llvm.org/D18976#399633, @labath wrote: > I think having a self-contained test for this issue (one which does not rely > on internals of some system library) would be extremely valuable. Could you > add one? Well, a simple way would be to just add

Re: [Lldb-commits] [PATCH] D18977: Add new ABI callback to provide fallback unwind register locations

uweigand added a comment. In http://reviews.llvm.org/D18977#399344, @jasonmolenda wrote: > Just to be clear, my concern is we get an register location which is > "undefined" (I've never seen it, I don't know what it means) and now > SavedLocationForRegister() will say "this register is

Re: [Lldb-commits] [PATCH] D18977: Add new ABI callback to provide fallback unwind register locations

uweigand added a comment. OK, here's an implementation of the new approach. In addition to the changes discussed, I had to add handling of undefined register locations -- this might now theoretically also trigger when CFI contains an explicit DW_CFA_undefined, but it should actually do the

Re: [Lldb-commits] [PATCH] D18977: Add new ABI callback to provide fallback unwind register locations

uweigand retitled this revision from "Add new ABI callback to return CFA offset" to "Add new ABI callback to provide fallback unwind register locations". uweigand updated the summary for this revision. uweigand updated this revision to Diff 53502. http://reviews.llvm.org/D18977 Files:

Re: [Lldb-commits] [PATCH] D18985: Fix test cases for big-endian systems

uweigand added a comment. In http://reviews.llvm.org/D18985#397674, @clayborg wrote: > So many tests above are going to accept either a little endian or big endian > value. This will make most of these tests useless since if a little endian > machine fails with a big endian number we won't

Re: [Lldb-commits] [PATCH] D18985: Fix test cases for big-endian systems

uweigand updated the summary for this revision. uweigand updated this revision to Diff 53501. http://reviews.llvm.org/D18985 Files: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-python-synth/TestDataFormatterPythonSynth.py

Re: [Lldb-commits] [PATCH] D18984: Fix ARM instruction emulation tests on big-endian systems

uweigand added a comment. In http://reviews.llvm.org/D18984#398486, @tberghammer wrote: > Generally looks good with 2 minor comment inline. I also run the test suite > on Android ARM (little endian) and everything looked fine Thanks for the review and test! Comment at:

Re: [Lldb-commits] [PATCH] D18984: Fix ARM instruction emulation tests on big-endian systems

uweigand updated this revision to Diff 53500. http://reviews.llvm.org/D18984 Files: source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp source/Plugins/Instruction/ARM/EmulationStateARM.cpp source/Plugins/Instruction/ARM/EmulationStateARM.h Index:

Re: [Lldb-commits] [PATCH] D18978: Support Linux on SystemZ as platform

uweigand added a comment. In http://reviews.llvm.org/D18978#398180, @labath wrote: > Could you also add a core file test to `TestLinuxCore`? It should be a matter > of running `make_core.sh`, saving the files and creating a new test function > in the file (I've tried to make it simple, if you

Re: [Lldb-commits] [PATCH] D18977: Add new ABI callback to return CFA offset

uweigand added a comment. In http://reviews.llvm.org/D18977#398557, @clayborg wrote: > In http://reviews.llvm.org/D18977#398157, @uweigand wrote: > > > In http://reviews.llvm.org/D18977#397626, @clayborg wrote: > > > > > I am not sure why this offset of 160 isn't represented in the unwind > > >

Re: [Lldb-commits] [PATCH] D18985: Fix test cases for big-endian systems

uweigand added a comment. In http://reviews.llvm.org/D18985#398171, @labath wrote: > Just because the tests test the console interface, it doesn't mean you can't > use the python interface to do auxiliary tasks, like computing the > expectations. It sounds like you should be able to to a >

Re: [Lldb-commits] [PATCH] D18985: Fix test cases for big-endian systems

uweigand added a comment. In http://reviews.llvm.org/D18985#397674, @clayborg wrote: > So many tests above are going to accept either a little endian or big endian > value. This will make most of these tests useless since if a little endian > machine fails with a big endian number we won't

Re: [Lldb-commits] [PATCH] D18977: Add new ABI callback to return CFA offset

uweigand added a comment. In http://reviews.llvm.org/D18977#397626, @clayborg wrote: > I am not sure why this offset of 160 isn't represented in the unwind info. I > guess the OS unwinder that uses the EH frame info just knows that it must > adjust the CFA? That seems like a hack. It seems

[Lldb-commits] [PATCH] D18985: Fix test cases for big-endian systems

uweigand created this revision. uweigand added reviewers: granata.enrico, clayborg. uweigand added a subscriber: lldb-commits. A number of test cases were failing on big-endian systems simply due to byte order assumptions in the tests themselves, and no underlying bug in LLDB. These two test

[Lldb-commits] [PATCH] D18984: Fix ARM instruction emulation tests on big-endian systems

uweigand created this revision. uweigand added a reviewer: clayborg. uweigand added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. Running the ARM instruction emulation test on a big-endian system would fail, since the code doesn't respect endianness properly. In

[Lldb-commits] [PATCH] D18983: Miscellaneous fixes for big-endian systems

uweigand created this revision. uweigand added reviewers: clayborg, granata.enrico, spyffe. uweigand added a subscriber: lldb-commits. This patch fixes a bunch of issues that show up on big-endian systems: - The gnu_libstdcpp.py script doesn't follow the way libstdc++ encodes bit vectors: it

[Lldb-commits] [PATCH] D18982: Handle bit fields on big-endian systems correctly

uweigand created this revision. uweigand added reviewers: granata.enrico, clayborg. uweigand added a subscriber: lldb-commits. Currently, the DataExtractor::GetMaxU64Bitfield and GetMaxS64Bitfield routines assume the incoming "bitfield_bit_offset" parameter uses little-endian bit numbering, i.e.

[Lldb-commits] [PATCH] D18981: Fix usage of APInt.getRawData for big-endian systems

uweigand created this revision. uweigand added reviewers: clayborg, jasonmolenda, spyffe, labath, tberghammer. uweigand added a subscriber: lldb-commits. The Scalar implementation and a few other places in LLDB directly access the internal implementation of APInt values using the getRawData

[Lldb-commits] [PATCH] D18980: Make Scalar::GetBytes and RegisterValue::GetBytes const

uweigand created this revision. uweigand added reviewers: clayborg, jasonmolenda, labath, tberghammer. uweigand added a subscriber: lldb-commits. Herald added a subscriber: dsanders. Scalar::GetBytes provides a non-const access to the underlying bytes of the scalar value, supposedly allowing for

[Lldb-commits] [PATCH] D18979: Fixes for platforms that default to unsigned char

uweigand created this revision. uweigand added reviewers: spyffe, clayborg. uweigand added a subscriber: lldb-commits. Herald added a subscriber: aemerson. This fixes several test case failure on s390x caused by the fact that on this platform, the default "char" type is unsigned. - In

[Lldb-commits] [PATCH] D18977: Add new ABI callback to return CFA offset

uweigand created this revision. uweigand added reviewers: jasonmolenda, clayborg. uweigand added a subscriber: lldb-commits. If the UnwindPlan did not identify how to unwind the stack pointer register, LLDB currently assumes it can determine to caller's SP from the current frame's CFA. This is

[Lldb-commits] [PATCH] D18975: Fix unwind failures when PC points beyond the end of a function

uweigand created this revision. uweigand added a reviewer: jasonmolenda. uweigand added a subscriber: lldb-commits. RegisterContextLLDB::InitializeNonZerothFrame already has code to attempt to detect and handle the case where the PC points beyond the end of a function, but there are certain cases